Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it possible to disable gRPC message spans #7642

Merged
merged 1 commit into from
Sep 19, 2024
Merged

make it possible to disable gRPC message spans #7642

merged 1 commit into from
Sep 19, 2024

Conversation

richardstartin
Copy link
Member

What Does This Do

Makes it possible to disable the gRPC message spans with -Ddd.integration.grpc-message.enabled=false

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@richardstartin richardstartin added the inst: grpc gRPC instrumentation label Sep 18, 2024
@richardstartin richardstartin requested a review from a team as a code owner September 18, 2024 17:29
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/disable-grpc-message
git_commit_date 1726677448 1726680512
git_commit_sha da9ecfb 287cb5f
release_version 1.40.0-SNAPSHOT~da9ecfbbcd 1.40.0-SNAPSHOT~287cb5f3f3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726682972 1726682972
ci_job_id 643922877 643922877
ci_pipeline_id 44614172 44614172
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~287cb5f3f3, baseline=1.40.0-SNAPSHOT~da9ecfbbcd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066512
Total [baseline] (8.535 s) : 0, 8535412
Agent [candidate] (1.06 s) : 0, 1060105
Total [candidate] (8.523 s) : 0, 8522985
section iast
Agent [baseline] (1.187 s) : 0, 1186715
Total [baseline] (8.995 s) : 0, 8994842
Agent [candidate] (1.205 s) : 0, 1204580
Total [candidate] (9.097 s) : 0, 9096928
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.187 s) : 0, 1186899
Total [baseline] (8.959 s) : 0, 8958872
Agent [candidate] (1.196 s) : 0, 1196267
Total [candidate] (9.022 s) : 0, 9022392
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1205479
Total [baseline] (9.063 s) : 0, 9063308
Agent [candidate] (1.184 s) : 0, 1183885
Total [candidate] (9.001 s) : 0, 9000503
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.187 s 120.203 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.187 s 120.387 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.205 s 138.967 ms (13.0%)
Total tracing 8.535 s -
Total iast 8.995 s 459.43 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.959 s 423.46 ms (5.0%)
Total iast_TELEMETRY_OFF 9.063 s 527.896 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.205 s 144.474 ms (13.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 136.162 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.184 s 123.78 ms (11.7%)
Total tracing 8.523 s -
Total iast 9.097 s 573.943 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.022 s 499.407 ms (5.9%)
Total iast_TELEMETRY_OFF 9.001 s 477.519 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~287cb5f3f3, baseline=1.40.0-SNAPSHOT~da9ecfbbcd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.199 ms) : 0, 681199
BytebuddyAgent [candidate] (677.132 ms) : 0, 677132
GlobalTracer [baseline] (311.109 ms) : 0, 311109
GlobalTracer [candidate] (309.163 ms) : 0, 309163
AppSec [baseline] (52.414 ms) : 0, 52414
AppSec [candidate] (52.076 ms) : 0, 52076
Remote Config [baseline] (660.853 µs) : 0, 661
Remote Config [candidate] (661.576 µs) : 0, 662
Telemetry [baseline] (7.492 ms) : 0, 7492
Telemetry [candidate] (7.452 ms) : 0, 7452
section iast
BytebuddyAgent [baseline] (789.771 ms) : 0, 789771
BytebuddyAgent [candidate] (802.473 ms) : 0, 802473
GlobalTracer [baseline] (298.355 ms) : 0, 298355
GlobalTracer [candidate] (302.304 ms) : 0, 302304
AppSec [baseline] (53.674 ms) : 0, 53674
AppSec [candidate] (51.61 ms) : 0, 51610
IAST [baseline] (23.371 ms) : 0, 23371
IAST [candidate] (26.301 ms) : 0, 26301
Remote Config [baseline] (607.092 µs) : 0, 607
Remote Config [candidate] (635.438 µs) : 0, 635
Telemetry [baseline] (7.272 ms) : 0, 7272
Telemetry [candidate] (7.442 ms) : 0, 7442
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.818 ms) : 0, 789818
BytebuddyAgent [candidate] (796.569 ms) : 0, 796569
GlobalTracer [baseline] (298.562 ms) : 0, 298562
GlobalTracer [candidate] (300.812 ms) : 0, 300812
AppSec [baseline] (52.759 ms) : 0, 52759
AppSec [candidate] (55.303 ms) : 0, 55303
IAST [baseline] (24.283 ms) : 0, 24283
IAST [candidate] (21.866 ms) : 0, 21866
Remote Config [baseline] (610.109 µs) : 0, 610
Remote Config [candidate] (627.214 µs) : 0, 627
Telemetry [baseline] (7.249 ms) : 0, 7249
Telemetry [candidate] (7.356 ms) : 0, 7356
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.087 ms) : 0, 802087
BytebuddyAgent [candidate] (786.533 ms) : 0, 786533
GlobalTracer [baseline] (303.813 ms) : 0, 303813
GlobalTracer [candidate] (298.985 ms) : 0, 298985
AppSec [baseline] (55.233 ms) : 0, 55233
AppSec [candidate] (54.719 ms) : 0, 54719
IAST [baseline] (20.91 ms) : 0, 20910
IAST [candidate] (21.413 ms) : 0, 21413
Remote Config [baseline] (595.64 µs) : 0, 596
Remote Config [candidate] (592.332 µs) : 0, 592
Telemetry [baseline] (8.999 ms) : 0, 8999
Telemetry [candidate] (8.007 ms) : 0, 8007
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~287cb5f3f3, baseline=1.40.0-SNAPSHOT~da9ecfbbcd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062751
Total [baseline] (10.339 s) : 0, 10338602
Agent [candidate] (1.07 s) : 0, 1070307
Total [candidate] (10.361 s) : 0, 10361111
section appsec
Agent [baseline] (1.2 s) : 0, 1199766
Total [baseline] (10.646 s) : 0, 10646214
Agent [candidate] (1.211 s) : 0, 1210695
Total [candidate] (10.657 s) : 0, 10656693
section iast
Agent [baseline] (1.19 s) : 0, 1189632
Total [baseline] (10.799 s) : 0, 10799271
Agent [candidate] (1.189 s) : 0, 1188529
Total [candidate] (10.763 s) : 0, 10763306
section profiling
Agent [baseline] (1.271 s) : 0, 1271061
Total [baseline] (10.651 s) : 0, 10650975
Agent [candidate] (1.263 s) : 0, 1262985
Total [candidate] (10.58 s) : 0, 10579888
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.2 s 137.015 ms (12.9%)
Agent iast 1.19 s 126.881 ms (11.9%)
Agent profiling 1.271 s 208.31 ms (19.6%)
Total tracing 10.339 s -
Total appsec 10.646 s 307.612 ms (3.0%)
Total iast 10.799 s 460.669 ms (4.5%)
Total profiling 10.651 s 312.373 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.211 s 140.388 ms (13.1%)
Agent iast 1.189 s 118.222 ms (11.0%)
Agent profiling 1.263 s 192.678 ms (18.0%)
Total tracing 10.361 s -
Total appsec 10.657 s 295.582 ms (2.9%)
Total iast 10.763 s 402.195 ms (3.9%)
Total profiling 10.58 s 218.776 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~287cb5f3f3, baseline=1.40.0-SNAPSHOT~da9ecfbbcd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.5 ms) : 0, 678500
BytebuddyAgent [candidate] (683.297 ms) : 0, 683297
GlobalTracer [baseline] (310.234 ms) : 0, 310234
GlobalTracer [candidate] (312.153 ms) : 0, 312153
AppSec [baseline] (52.316 ms) : 0, 52316
AppSec [candidate] (52.854 ms) : 0, 52854
Remote Config [baseline] (662.03 µs) : 0, 662
Remote Config [candidate] (671.271 µs) : 0, 671
Telemetry [baseline] (7.407 ms) : 0, 7407
Telemetry [candidate] (7.587 ms) : 0, 7587
section appsec
BytebuddyAgent [baseline] (700.339 ms) : 0, 700339
BytebuddyAgent [candidate] (708.371 ms) : 0, 708371
GlobalTracer [baseline] (303.976 ms) : 0, 303976
GlobalTracer [candidate] (306.223 ms) : 0, 306223
AppSec [baseline] (162.168 ms) : 0, 162168
AppSec [candidate] (162.946 ms) : 0, 162946
Remote Config [baseline] (637.934 µs) : 0, 638
Remote Config [candidate] (644.56 µs) : 0, 645
Telemetry [baseline] (8.02 ms) : 0, 8020
Telemetry [candidate] (8.452 ms) : 0, 8452
IAST [baseline] (22.022 ms) : 0, 22022
IAST [candidate] (20.584 ms) : 0, 20584
section iast
BytebuddyAgent [baseline] (791.705 ms) : 0, 791705
BytebuddyAgent [candidate] (791.044 ms) : 0, 791044
GlobalTracer [baseline] (298.915 ms) : 0, 298915
GlobalTracer [candidate] (298.846 ms) : 0, 298846
AppSec [baseline] (53.112 ms) : 0, 53112
AppSec [candidate] (54.457 ms) : 0, 54457
Remote Config [baseline] (609.565 µs) : 0, 610
Remote Config [candidate] (608.722 µs) : 0, 609
Telemetry [baseline] (7.259 ms) : 0, 7259
Telemetry [candidate] (7.305 ms) : 0, 7305
IAST [baseline] (24.385 ms) : 0, 24385
IAST [candidate] (22.623 ms) : 0, 22623
section profiling
ProfilingAgent [baseline] (97.532 ms) : 0, 97532
ProfilingAgent [candidate] (96.537 ms) : 0, 96537
BytebuddyAgent [baseline] (677.664 ms) : 0, 677664
BytebuddyAgent [candidate] (672.952 ms) : 0, 672952
GlobalTracer [baseline] (396.002 ms) : 0, 396002
GlobalTracer [candidate] (394.208 ms) : 0, 394208
AppSec [baseline] (53.423 ms) : 0, 53423
AppSec [candidate] (53.186 ms) : 0, 53186
Remote Config [baseline] (666.296 µs) : 0, 666
Remote Config [candidate] (658.103 µs) : 0, 658
Telemetry [baseline] (7.475 ms) : 0, 7475
Telemetry [candidate] (7.404 ms) : 0, 7404
Profiling [baseline] (97.555 ms) : 0, 97555
Profiling [candidate] (96.56 ms) : 0, 96560
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-18T17:41:42 2024-09-18T17:48:34
git_branch master rgs/disable-grpc-message
git_commit_date 1726677448 1726680512
git_commit_sha da9ecfb 287cb5f
release_version 1.40.0-SNAPSHOT~da9ecfbbcd 1.40.0-SNAPSHOT~287cb5f3f3
start_time 2024-09-18T17:41:28 2024-09-18T17:48:21
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726682064 1726682064
ci_job_id 643922878 643922878
ci_pipeline_id 44614172 44614172
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~287cb5f3f3, baseline=1.40.0-SNAPSHOT~da9ecfbbcd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1368
.   : milestone, 1349,
appsec (1.741 ms) : 1717, 1765
.   : milestone, 1741,
appsec_no_iast (1.743 ms) : 1719, 1767
.   : milestone, 1743,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.488 ms) : 1466, 1511
.   : milestone, 1488,
tracing (1.457 ms) : 1432, 1482
.   : milestone, 1457,
section candidate
no_agent (1.372 ms) : 1351, 1392
.   : milestone, 1372,
appsec (1.741 ms) : 1718, 1765
.   : milestone, 1741,
appsec_no_iast (1.726 ms) : 1701, 1750
.   : milestone, 1726,
iast (1.498 ms) : 1475, 1520
.   : milestone, 1498,
profiling (1.537 ms) : 1512, 1562
.   : milestone, 1537,
tracing (1.454 ms) : 1429, 1479
.   : milestone, 1454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.33 ms, 1.368 ms] -
appsec 1.741 ms [1.717 ms, 1.765 ms] 391.636 µs (29.0%)
appsec_no_iast 1.743 ms [1.719 ms, 1.767 ms] 393.587 µs (29.2%)
iast 1.489 ms [1.466 ms, 1.512 ms] 139.356 µs (10.3%)
profiling 1.488 ms [1.466 ms, 1.511 ms] 138.941 µs (10.3%)
tracing 1.457 ms [1.432 ms, 1.482 ms] 107.783 µs (8.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.372 ms [1.351 ms, 1.392 ms] -
appsec 1.741 ms [1.718 ms, 1.765 ms] 369.801 µs (27.0%)
appsec_no_iast 1.726 ms [1.701 ms, 1.75 ms] 354.211 µs (25.8%)
iast 1.498 ms [1.475 ms, 1.52 ms] 126.178 µs (9.2%)
profiling 1.537 ms [1.512 ms, 1.562 ms] 165.694 µs (12.1%)
tracing 1.454 ms [1.429 ms, 1.479 ms] 82.425 µs (6.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~287cb5f3f3, baseline=1.40.0-SNAPSHOT~da9ecfbbcd
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.931 µs) : 358, 400
.   : milestone, 379,
iast (487.534 µs) : 466, 509
.   : milestone, 488,
iast_FULL (557.298 µs) : 536, 579
.   : milestone, 557,
iast_GLOBAL (514.569 µs) : 493, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (488.558 µs) : 467, 510
.   : milestone, 489,
iast_INACTIVE (453.264 µs) : 433, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (482.662 µs) : 460, 505
.   : milestone, 483,
tracing (452.713 µs) : 432, 473
.   : milestone, 453,
section candidate
no_agent (381.337 µs) : 362, 401
.   : milestone, 381,
iast (491.833 µs) : 470, 513
.   : milestone, 492,
iast_FULL (560.82 µs) : 539, 582
.   : milestone, 561,
iast_GLOBAL (518.273 µs) : 496, 540
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (492.1 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (454.033 µs) : 433, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (485.491 µs) : 462, 509
.   : milestone, 485,
tracing (452.551 µs) : 431, 474
.   : milestone, 453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.931 µs [358.149 µs, 399.712 µs] -
iast 487.534 µs [466.39 µs, 508.678 µs] 108.604 µs (28.7%)
iast_FULL 557.298 µs [536.07 µs, 578.527 µs] 178.368 µs (47.1%)
iast_GLOBAL 514.569 µs [492.66 µs, 536.478 µs] 135.638 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 488.558 µs [466.775 µs, 510.341 µs] 109.627 µs (28.9%)
iast_INACTIVE 453.264 µs [432.52 µs, 474.009 µs] 74.334 µs (19.6%)
iast_TELEMETRY_OFF 482.662 µs [459.945 µs, 505.378 µs] 103.731 µs (27.4%)
tracing 452.713 µs [432.105 µs, 473.321 µs] 73.782 µs (19.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.337 µs [361.586 µs, 401.088 µs] -
iast 491.833 µs [470.246 µs, 513.421 µs] 110.497 µs (29.0%)
iast_FULL 560.82 µs [539.49 µs, 582.151 µs] 179.484 µs (47.1%)
iast_GLOBAL 518.273 µs [496.33 µs, 540.216 µs] 136.936 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 492.1 µs [471.056 µs, 513.145 µs] 110.763 µs (29.0%)
iast_INACTIVE 454.033 µs [432.56 µs, 475.505 µs] 72.696 µs (19.1%)
iast_TELEMETRY_OFF 485.491 µs [462.37 µs, 508.611 µs] 104.154 µs (27.3%)
tracing 452.551 µs [431.039 µs, 474.063 µs] 71.214 µs (18.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/disable-grpc-message
git_commit_date 1726677448 1726680512
git_commit_sha da9ecfb 287cb5f
release_version 1.40.0-SNAPSHOT~da9ecfbbcd 1.40.0-SNAPSHOT~287cb5f3f3
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726682623 1726682623
ci_job_id 643922879 643922879
ci_pipeline_id 44614172 44614172
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~287cb5f3f3, baseline=1.40.0-SNAPSHOT~da9ecfbbcd
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.446 s) : 15446000, 15446000
.   : milestone, 15446000,
appsec (14.972 s) : 14972000, 14972000
.   : milestone, 14972000,
iast (18.752 s) : 18752000, 18752000
.   : milestone, 18752000,
iast_GLOBAL (17.932 s) : 17932000, 17932000
.   : milestone, 17932000,
profiling (15.547 s) : 15547000, 15547000
.   : milestone, 15547000,
tracing (15.107 s) : 15107000, 15107000
.   : milestone, 15107000,
section candidate
no_agent (15.434 s) : 15434000, 15434000
.   : milestone, 15434000,
appsec (15.417 s) : 15417000, 15417000
.   : milestone, 15417000,
iast (18.809 s) : 18809000, 18809000
.   : milestone, 18809000,
iast_GLOBAL (18.174 s) : 18174000, 18174000
.   : milestone, 18174000,
profiling (15.368 s) : 15368000, 15368000
.   : milestone, 15368000,
tracing (15.334 s) : 15334000, 15334000
.   : milestone, 15334000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.446 s [15.446 s, 15.446 s] -
appsec 14.972 s [14.972 s, 14.972 s] -474.0 ms (-3.1%)
iast 18.752 s [18.752 s, 18.752 s] 3.306 s (21.4%)
iast_GLOBAL 17.932 s [17.932 s, 17.932 s] 2.486 s (16.1%)
profiling 15.547 s [15.547 s, 15.547 s] 101.0 ms (0.7%)
tracing 15.107 s [15.107 s, 15.107 s] -339.0 ms (-2.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.434 s [15.434 s, 15.434 s] -
appsec 15.417 s [15.417 s, 15.417 s] -17.0 ms (-0.1%)
iast 18.809 s [18.809 s, 18.809 s] 3.375 s (21.9%)
iast_GLOBAL 18.174 s [18.174 s, 18.174 s] 2.74 s (17.8%)
profiling 15.368 s [15.368 s, 15.368 s] -66.0 ms (-0.4%)
tracing 15.334 s [15.334 s, 15.334 s] -100.0 ms (-0.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~287cb5f3f3, baseline=1.40.0-SNAPSHOT~da9ecfbbcd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
.   : milestone, 1461,
appsec (2.289 ms) : 2248, 2329
.   : milestone, 2289,
iast (2.061 ms) : 2011, 2112
.   : milestone, 2061,
iast_GLOBAL (2.098 ms) : 2047, 2148
.   : milestone, 2098,
profiling (1.927 ms) : 1887, 1966
.   : milestone, 1927,
tracing (1.908 ms) : 1870, 1947
.   : milestone, 1908,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.302 ms) : 2261, 2343
.   : milestone, 2302,
iast (2.061 ms) : 2010, 2112
.   : milestone, 2061,
iast_GLOBAL (2.105 ms) : 2053, 2157
.   : milestone, 2105,
profiling (1.916 ms) : 1876, 1957
.   : milestone, 1916,
tracing (1.903 ms) : 1864, 1941
.   : milestone, 1903,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.45 ms, 1.473 ms] -
appsec 2.289 ms [2.248 ms, 2.329 ms] 827.412 µs (56.6%)
iast 2.061 ms [2.011 ms, 2.112 ms] 600.313 µs (41.1%)
iast_GLOBAL 2.098 ms [2.047 ms, 2.148 ms] 636.466 µs (43.6%)
profiling 1.927 ms [1.887 ms, 1.966 ms] 465.354 µs (31.8%)
tracing 1.908 ms [1.87 ms, 1.947 ms] 447.281 µs (30.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.302 ms [2.261 ms, 2.343 ms] 840.259 µs (57.5%)
iast 2.061 ms [2.01 ms, 2.112 ms] 599.533 µs (41.0%)
iast_GLOBAL 2.105 ms [2.053 ms, 2.157 ms] 643.349 µs (44.0%)
profiling 1.916 ms [1.876 ms, 1.957 ms] 454.375 µs (31.1%)
tracing 1.903 ms [1.864 ms, 1.941 ms] 440.792 µs (30.2%)

@richardstartin richardstartin merged commit a8ea730 into master Sep 19, 2024
104 checks passed
@richardstartin richardstartin deleted the rgs/disable-grpc-message branch September 19, 2024 10:51
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 19, 2024
jordan-wong pushed a commit that referenced this pull request Sep 23, 2024
@richardstartin @jordan-wong
make it possible to disable gRPC message spans (#7642)
dd17dea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@jbachorik jbachorik jbachorik approved these changes

Assignees
No one assigned
Labels
inst: grpc gRPC instrumentation
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richardstartin @jbachorik @amarziali