Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delay closing profiling state when scope reference count > 1 #7639

Merged
merged 1 commit into from
Sep 18, 2024
Merged

delay closing profiling state when scope reference count > 1 #7639

merged 1 commit into from
Sep 18, 2024

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented Sep 18, 2024 •
edited by jira bot
Loading

What Does This Do

Prevents from clearing the profiling context when a duplicate scope (reference count > 1) is closed, leaving all samples for the ancestor scopes unlabeled.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: PROF-10567

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/delay-closing-profiling-state
git_commit_date 1726653524 1726666729
git_commit_sha 5765052 39116d0
release_version 1.40.0-SNAPSHOT~5765052e34 1.40.0-SNAPSHOT~39116d085a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726669025 1726669025
ci_job_id 643490529 643490529
ci_pipeline_id 44586060 44586060
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~39116d085a, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069284
Total [baseline] (10.496 s) : 0, 10496273
Agent [candidate] (1.072 s) : 0, 1071885
Total [candidate] (10.424 s) : 0, 10424225
section appsec
Agent [baseline] (1.205 s) : 0, 1205225
Total [baseline] (10.626 s) : 0, 10626482
Agent [candidate] (1.206 s) : 0, 1205964
Total [candidate] (10.662 s) : 0, 10661838
section iast
Agent [baseline] (1.199 s) : 0, 1198707
Total [baseline] (10.873 s) : 0, 10872946
Agent [candidate] (1.2 s) : 0, 1200339
Total [candidate] (10.905 s) : 0, 10905219
section profiling
Agent [baseline] (1.263 s) : 0, 1262795
Total [baseline] (10.661 s) : 0, 10660926
Agent [candidate] (1.272 s) : 0, 1272301
Total [candidate] (10.722 s) : 0, 10721566
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.205 s 135.941 ms (12.7%)
Agent iast 1.199 s 129.423 ms (12.1%)
Agent profiling 1.263 s 193.51 ms (18.1%)
Total tracing 10.496 s -
Total appsec 10.626 s 130.209 ms (1.2%)
Total iast 10.873 s 376.673 ms (3.6%)
Total profiling 10.661 s 164.653 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.206 s 134.079 ms (12.5%)
Agent iast 1.2 s 128.454 ms (12.0%)
Agent profiling 1.272 s 200.416 ms (18.7%)
Total tracing 10.424 s -
Total appsec 10.662 s 237.613 ms (2.3%)
Total iast 10.905 s 480.994 ms (4.6%)
Total profiling 10.722 s 297.341 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~39116d085a, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.577 ms) : 0, 682577
BytebuddyAgent [candidate] (683.829 ms) : 0, 683829
GlobalTracer [baseline] (311.888 ms) : 0, 311888
GlobalTracer [candidate] (313.148 ms) : 0, 313148
AppSec [baseline] (52.892 ms) : 0, 52892
AppSec [candidate] (52.929 ms) : 0, 52929
Remote Config [baseline] (677.95 µs) : 0, 678
Remote Config [candidate] (671.109 µs) : 0, 671
Telemetry [baseline] (7.582 ms) : 0, 7582
Telemetry [candidate] (7.559 ms) : 0, 7559
section appsec
BytebuddyAgent [baseline] (705.801 ms) : 0, 705801
BytebuddyAgent [candidate] (706.177 ms) : 0, 706177
GlobalTracer [baseline] (305.715 ms) : 0, 305715
GlobalTracer [candidate] (304.936 ms) : 0, 304936
AppSec [baseline] (161.481 ms) : 0, 161481
AppSec [candidate] (161.628 ms) : 0, 161628
Remote Config [baseline] (624.279 µs) : 0, 624
Remote Config [candidate] (627.183 µs) : 0, 627
Telemetry [baseline] (8.396 ms) : 0, 8396
Telemetry [candidate] (8.701 ms) : 0, 8701
IAST [baseline] (19.079 ms) : 0, 19079
IAST [candidate] (20.382 ms) : 0, 20382
section iast
BytebuddyAgent [baseline] (797.703 ms) : 0, 797703
BytebuddyAgent [candidate] (798.479 ms) : 0, 798479
GlobalTracer [baseline] (301.28 ms) : 0, 301280
GlobalTracer [candidate] (302.218 ms) : 0, 302218
AppSec [baseline] (53.427 ms) : 0, 53427
AppSec [candidate] (53.276 ms) : 0, 53276
Remote Config [baseline] (663.768 µs) : 0, 664
Remote Config [candidate] (683.145 µs) : 0, 683
Telemetry [baseline] (7.371 ms) : 0, 7371
Telemetry [candidate] (7.394 ms) : 0, 7394
IAST [baseline] (24.531 ms) : 0, 24531
IAST [candidate] (24.514 ms) : 0, 24514
section profiling
BytebuddyAgent [baseline] (673.112 ms) : 0, 673112
BytebuddyAgent [candidate] (678.568 ms) : 0, 678568
GlobalTracer [baseline] (394.678 ms) : 0, 394678
GlobalTracer [candidate] (396.901 ms) : 0, 396901
AppSec [baseline] (53.039 ms) : 0, 53039
AppSec [candidate] (53.533 ms) : 0, 53533
Remote Config [baseline] (675.4 µs) : 0, 675
Remote Config [candidate] (670.861 µs) : 0, 671
Telemetry [baseline] (7.407 ms) : 0, 7407
Telemetry [candidate] (7.467 ms) : 0, 7467
ProfilingAgent [baseline] (95.868 ms) : 0, 95868
ProfilingAgent [candidate] (96.883 ms) : 0, 96883
Profiling [baseline] (95.891 ms) : 0, 95891
Profiling [candidate] (96.907 ms) : 0, 96907
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~39116d085a, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064066
Total [baseline] (8.577 s) : 0, 8576666
Agent [candidate] (1.077 s) : 0, 1076779
Total [candidate] (8.603 s) : 0, 8603279
section iast
Agent [baseline] (1.204 s) : 0, 1204363
Total [baseline] (9.072 s) : 0, 9071556
Agent [candidate] (1.19 s) : 0, 1190424
Total [candidate] (9.017 s) : 0, 9016990
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1190162
Total [baseline] (9.069 s) : 0, 9068699
Agent [candidate] (1.209 s) : 0, 1209396
Total [candidate] (9.068 s) : 0, 9067656
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1188371
Total [baseline] (9.002 s) : 0, 9002199
Agent [candidate] (1.187 s) : 0, 1187147
Total [candidate] (9.028 s) : 0, 9027799
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.204 s 140.297 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.19 s 126.096 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.188 s 124.305 ms (11.7%)
Total tracing 8.577 s -
Total iast 9.072 s 494.889 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.069 s 492.033 ms (5.7%)
Total iast_TELEMETRY_OFF 9.002 s 425.533 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.19 s 113.645 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 132.617 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.187 s 110.368 ms (10.2%)
Total tracing 8.603 s -
Total iast 9.017 s 413.711 ms (4.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.068 s 464.377 ms (5.4%)
Total iast_TELEMETRY_OFF 9.028 s 424.521 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~39116d085a, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.465 ms) : 0, 679465
BytebuddyAgent [candidate] (687.218 ms) : 0, 687218
GlobalTracer [baseline] (310.44 ms) : 0, 310440
GlobalTracer [candidate] (314.503 ms) : 0, 314503
AppSec [baseline] (52.355 ms) : 0, 52355
AppSec [candidate] (53.027 ms) : 0, 53027
Remote Config [baseline] (684.463 µs) : 0, 684
Remote Config [candidate] (662.191 µs) : 0, 662
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (7.532 ms) : 0, 7532
section iast
BytebuddyAgent [baseline] (802.297 ms) : 0, 802297
BytebuddyAgent [candidate] (791.531 ms) : 0, 791531
GlobalTracer [baseline] (302.888 ms) : 0, 302888
GlobalTracer [candidate] (299.707 ms) : 0, 299707
AppSec [baseline] (53.494 ms) : 0, 53494
AppSec [candidate] (51.656 ms) : 0, 51656
Remote Config [baseline] (635.137 µs) : 0, 635
Remote Config [candidate] (591.008 µs) : 0, 591
Telemetry [baseline] (7.443 ms) : 0, 7443
Telemetry [candidate] (7.274 ms) : 0, 7274
IAST [baseline] (23.783 ms) : 0, 23783
IAST [candidate] (25.97 ms) : 0, 25970
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (791.635 ms) : 0, 791635
BytebuddyAgent [candidate] (803.882 ms) : 0, 803882
GlobalTracer [baseline] (299.587 ms) : 0, 299587
GlobalTracer [candidate] (305.31 ms) : 0, 305310
AppSec [baseline] (53.667 ms) : 0, 53667
AppSec [candidate] (54.291 ms) : 0, 54291
Remote Config [baseline] (620.238 µs) : 0, 620
Remote Config [candidate] (627.475 µs) : 0, 627
Telemetry [baseline] (7.396 ms) : 0, 7396
Telemetry [candidate] (7.488 ms) : 0, 7488
IAST [baseline] (23.616 ms) : 0, 23616
IAST [candidate] (23.978 ms) : 0, 23978
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.879 ms) : 0, 789879
BytebuddyAgent [candidate] (788.957 ms) : 0, 788957
GlobalTracer [baseline] (300.106 ms) : 0, 300106
GlobalTracer [candidate] (300.423 ms) : 0, 300423
AppSec [baseline] (53.768 ms) : 0, 53768
AppSec [candidate] (52.999 ms) : 0, 52999
Remote Config [baseline] (600.766 µs) : 0, 601
Remote Config [candidate] (605.598 µs) : 0, 606
Telemetry [baseline] (7.241 ms) : 0, 7241
Telemetry [candidate] (8.076 ms) : 0, 8076
IAST [baseline] (23.129 ms) : 0, 23129
IAST [candidate] (22.42 ms) : 0, 22420
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-18T13:49:42 2024-09-18T13:56:33
git_branch master rgs/delay-closing-profiling-state
git_commit_date 1726653524 1726666729
git_commit_sha 5765052 39116d0
release_version 1.40.0-SNAPSHOT~5765052e34 1.40.0-SNAPSHOT~39116d085a
start_time 2024-09-18T13:49:29 2024-09-18T13:56:20
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726668139 1726668139
ci_job_id 643490530 643490530
ci_pipeline_id 44586060 44586060
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~39116d085a, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.065 µs) : 355, 393
.   : milestone, 374,
iast (485.185 µs) : 464, 507
.   : milestone, 485,
iast_FULL (551.432 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (511.241 µs) : 490, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (484.279 µs) : 463, 505
.   : milestone, 484,
iast_INACTIVE (450.016 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (479.673 µs) : 457, 502
.   : milestone, 480,
tracing (448.535 µs) : 428, 469
.   : milestone, 449,
section candidate
no_agent (374.484 µs) : 354, 395
.   : milestone, 374,
iast (487.55 µs) : 467, 508
.   : milestone, 488,
iast_FULL (550.613 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (504.051 µs) : 482, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (482.532 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (448.734 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (478.179 µs) : 456, 501
.   : milestone, 478,
tracing (442.679 µs) : 422, 463
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.065 µs [354.657 µs, 393.474 µs] -
iast 485.185 µs [463.687 µs, 506.682 µs] 111.119 µs (29.7%)
iast_FULL 551.432 µs [530.227 µs, 572.636 µs] 177.366 µs (47.4%)
iast_GLOBAL 511.241 µs [489.787 µs, 532.695 µs] 137.176 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 484.279 µs [463.182 µs, 505.376 µs] 110.214 µs (29.5%)
iast_INACTIVE 450.016 µs [428.653 µs, 471.379 µs] 75.951 µs (20.3%)
iast_TELEMETRY_OFF 479.673 µs [457.163 µs, 502.183 µs] 105.608 µs (28.2%)
tracing 448.535 µs [427.817 µs, 469.252 µs] 74.469 µs (19.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.484 µs [353.895 µs, 395.074 µs] -
iast 487.55 µs [466.638 µs, 508.462 µs] 113.065 µs (30.2%)
iast_FULL 550.613 µs [529.581 µs, 571.645 µs] 176.128 µs (47.0%)
iast_GLOBAL 504.051 µs [482.233 µs, 525.87 µs] 129.567 µs (34.6%)
iast_HARDCODED_SECRET_DISABLED 482.532 µs [461.393 µs, 503.671 µs] 108.048 µs (28.9%)
iast_INACTIVE 448.734 µs [427.929 µs, 469.538 µs] 74.249 µs (19.8%)
iast_TELEMETRY_OFF 478.179 µs [455.719 µs, 500.639 µs] 103.695 µs (27.7%)
tracing 442.679 µs [422.207 µs, 463.15 µs] 68.194 µs (18.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~39116d085a, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.363 ms) : 1344, 1382
.   : milestone, 1363,
appsec (1.708 ms) : 1685, 1731
.   : milestone, 1708,
appsec_no_iast (1.734 ms) : 1710, 1758
.   : milestone, 1734,
iast (1.489 ms) : 1466, 1511
.   : milestone, 1489,
profiling (1.521 ms) : 1495, 1546
.   : milestone, 1521,
tracing (1.457 ms) : 1434, 1481
.   : milestone, 1457,
section candidate
no_agent (1.355 ms) : 1335, 1375
.   : milestone, 1355,
appsec (1.704 ms) : 1680, 1729
.   : milestone, 1704,
appsec_no_iast (1.727 ms) : 1703, 1752
.   : milestone, 1727,
iast (1.477 ms) : 1454, 1500
.   : milestone, 1477,
profiling (1.492 ms) : 1469, 1515
.   : milestone, 1492,
tracing (1.467 ms) : 1443, 1492
.   : milestone, 1467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.382 ms] -
appsec 1.708 ms [1.685 ms, 1.731 ms] 345.172 µs (25.3%)
appsec_no_iast 1.734 ms [1.71 ms, 1.758 ms] 371.175 µs (27.2%)
iast 1.489 ms [1.466 ms, 1.511 ms] 125.946 µs (9.2%)
profiling 1.521 ms [1.495 ms, 1.546 ms] 157.952 µs (11.6%)
tracing 1.457 ms [1.434 ms, 1.481 ms] 94.646 µs (6.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.375 ms] -
appsec 1.704 ms [1.68 ms, 1.729 ms] 349.451 µs (25.8%)
appsec_no_iast 1.727 ms [1.703 ms, 1.752 ms] 372.317 µs (27.5%)
iast 1.477 ms [1.454 ms, 1.5 ms] 121.937 µs (9.0%)
profiling 1.492 ms [1.469 ms, 1.515 ms] 136.838 µs (10.1%)
tracing 1.467 ms [1.443 ms, 1.492 ms] 112.384 µs (8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/delay-closing-profiling-state
git_commit_date 1726653524 1726666729
git_commit_sha 5765052 39116d0
release_version 1.40.0-SNAPSHOT~5765052e34 1.40.0-SNAPSHOT~39116d085a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726668533 1726668533
ci_job_id 643490531 643490531
ci_pipeline_id 44586060 44586060
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~39116d085a, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.755 s) : 15755000, 15755000
.   : milestone, 15755000,
appsec (15.162 s) : 15162000, 15162000
.   : milestone, 15162000,
iast (18.781 s) : 18781000, 18781000
.   : milestone, 18781000,
iast_GLOBAL (18.24 s) : 18240000, 18240000
.   : milestone, 18240000,
profiling (15.357 s) : 15357000, 15357000
.   : milestone, 15357000,
tracing (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
section candidate
no_agent (15.291 s) : 15291000, 15291000
.   : milestone, 15291000,
appsec (15.307 s) : 15307000, 15307000
.   : milestone, 15307000,
iast (18.763 s) : 18763000, 18763000
.   : milestone, 18763000,
iast_GLOBAL (18.039 s) : 18039000, 18039000
.   : milestone, 18039000,
profiling (15.494 s) : 15494000, 15494000
.   : milestone, 15494000,
tracing (15.3 s) : 15300000, 15300000
.   : milestone, 15300000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.755 s [15.755 s, 15.755 s] -
appsec 15.162 s [15.162 s, 15.162 s] -593.0 ms (-3.8%)
iast 18.781 s [18.781 s, 18.781 s] 3.026 s (19.2%)
iast_GLOBAL 18.24 s [18.24 s, 18.24 s] 2.485 s (15.8%)
profiling 15.357 s [15.357 s, 15.357 s] -398.0 ms (-2.5%)
tracing 15.149 s [15.149 s, 15.149 s] -606.0 ms (-3.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.291 s [15.291 s, 15.291 s] -
appsec 15.307 s [15.307 s, 15.307 s] 16.0 ms (0.1%)
iast 18.763 s [18.763 s, 18.763 s] 3.472 s (22.7%)
iast_GLOBAL 18.039 s [18.039 s, 18.039 s] 2.748 s (18.0%)
profiling 15.494 s [15.494 s, 15.494 s] 203.0 ms (1.3%)
tracing 15.3 s [15.3 s, 15.3 s] 9.0 ms (0.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~39116d085a, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
.   : milestone, 1465,
appsec (2.29 ms) : 2249, 2330
.   : milestone, 2290,
iast (2.057 ms) : 2008, 2107
.   : milestone, 2057,
iast_GLOBAL (2.109 ms) : 2058, 2160
.   : milestone, 2109,
profiling (1.929 ms) : 1889, 1968
.   : milestone, 1929,
tracing (1.9 ms) : 1862, 1938
.   : milestone, 1900,
section candidate
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.298 ms) : 2257, 2339
.   : milestone, 2298,
iast (2.057 ms) : 2007, 2108
.   : milestone, 2057,
iast_GLOBAL (2.094 ms) : 2044, 2144
.   : milestone, 2094,
profiling (2.408 ms) : 2219, 2597
.   : milestone, 2408,
tracing (1.906 ms) : 1868, 1944
.   : milestone, 1906,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.453 ms, 1.476 ms] -
appsec 2.29 ms [2.249 ms, 2.33 ms] 825.011 µs (56.3%)
iast 2.057 ms [2.008 ms, 2.107 ms] 592.251 µs (40.4%)
iast_GLOBAL 2.109 ms [2.058 ms, 2.16 ms] 644.461 µs (44.0%)
profiling 1.929 ms [1.889 ms, 1.968 ms] 463.859 µs (31.7%)
tracing 1.9 ms [1.862 ms, 1.938 ms] 435.266 µs (29.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.298 ms [2.257 ms, 2.339 ms] 837.53 µs (57.4%)
iast 2.057 ms [2.007 ms, 2.108 ms] 596.909 µs (40.9%)
iast_GLOBAL 2.094 ms [2.044 ms, 2.144 ms] 633.365 µs (43.4%)
profiling 2.408 ms [2.219 ms, 2.597 ms] 947.485 µs (64.9%)
tracing 1.906 ms [1.868 ms, 1.944 ms] 445.487 µs (30.5%)

@richardstartin richardstartin marked this pull request as ready for review September 18, 2024 15:19
@richardstartin richardstartin requested a review from a team as a code owner September 18, 2024 15:19
@richardstartin richardstartin merged commit a04c89f into master Sep 18, 2024
102 checks passed
@richardstartin richardstartin deleted the rgs/delay-closing-profiling-state branch September 18, 2024 15:19
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richardstartin @jbachorik