Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of spring boot nested jar for SymDB #7635

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add support of spring boot nested jar for SymDB #7635

merged 1 commit into from
Sep 18, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 18, 2024 •
edited by jira bot
Loading

What Does This Do

Spring boot use a special jar organisation for nested ones. It uses a new jar protocol for URL: jar:nested:

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2852

@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Sep 18, 2024
@jpbempel jpbempel requested a review from a team as a code owner September 18, 2024 09:08
@jpbempel jpbempel requested review from shatzi and removed request for a team September 18, 2024 09:08
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1726664653 1726665035
end_time 2024-09-18T13:05:28 2024-09-18T13:11:51
git_branch master jpbempel/fix-nested-jars
git_commit_sha 5765052 4e04f54
start_time 2024-09-18T13:04:14 2024-09-18T13:10:36
See matching parameters
Baseline Candidate
ci_job_id 643421082 643421082
ci_pipeline_id 44582047 44582047
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1726664098 1726664098

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-465.881µs; -299.091µs] or [-4.416%; -2.835%]		 better
[-476.017µs; -298.885µs] or [-4.439%; -2.788%]		 better
[-465.043µs; -270.929µs] or [-4.310%; -2.511%]		 better
[-658.609µs; -216.481µs] or [-5.860%; -1.926%]		 better
[+1.214op/s; +4.077op/s] or [+1.311%; +4.403%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-17.868µs; +50.387µs] or [-6.816%; +19.221%]		 unstable
[-25.547µs; +70.070µs] or [-8.579%; +23.531%]		 unstable
[-34.869µs; +78.628µs] or [-11.205%; +25.266%]		 unstable
[-198.017µs; +500.707µs] or [-33.049%; +83.569%]		 same
scenario:basic same same same unstable
[-62.624µs; +50.134µs] or [-11.203%; +8.969%]		 unstable
[-256.684op/s; +128.479op/s] or [-10.011%; +5.011%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (297.775 µs) : 274, 322
.   : milestone, 298,
basic (303.091 µs) : 294, 312
.   : milestone, 303,
loop (10.722 ms) : 10611, 10834
.   : milestone, 10722,
section candidate
noprobe (320.037 µs) : 260, 380
.   : milestone, 320,
basic (309.252 µs) : 298, 321
.   : milestone, 309,
loop (10.335 ms) : 10302, 10368
.   : milestone, 10335,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 297.775 µs [273.552 µs, 321.999 µs]
basic 303.091 µs [293.97 µs, 312.211 µs]
loop 10.722 ms [10.611 ms, 10.834 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 320.037 µs [260.288 µs, 379.785 µs]
basic 309.252 µs [297.837 µs, 320.666 µs]
loop 10.335 ms [10.302 ms, 10.368 ms]

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-nested-jars
git_commit_date 1726653524 1726664098
git_commit_sha 5765052 4e04f54
release_version 1.40.0-SNAPSHOT~5765052e34 1.40.0-SNAPSHOT~4e04f547c5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726666492 1726666492
ci_job_id 643421076 643421076
ci_pipeline_id 44582047 44582047
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~4e04f547c5, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072636
Total [baseline] (10.462 s) : 0, 10462189
Agent [candidate] (1.08 s) : 0, 1080063
Total [candidate] (10.541 s) : 0, 10541041
section appsec
Agent [baseline] (1.211 s) : 0, 1211157
Total [baseline] (10.708 s) : 0, 10707753
Agent [candidate] (1.206 s) : 0, 1205756
Total [candidate] (10.658 s) : 0, 10658448
section iast
Agent [baseline] (1.197 s) : 0, 1197057
Total [baseline] (10.9 s) : 0, 10900012
Agent [candidate] (1.194 s) : 0, 1194124
Total [candidate] (10.928 s) : 0, 10927618
section profiling
Agent [baseline] (1.271 s) : 0, 1271114
Total [baseline] (10.756 s) : 0, 10756378
Agent [candidate] (1.269 s) : 0, 1268923
Total [candidate] (10.685 s) : 0, 10685348
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent appsec 1.211 s 138.521 ms (12.9%)
Agent iast 1.197 s 124.421 ms (11.6%)
Agent profiling 1.271 s 198.477 ms (18.5%)
Total tracing 10.462 s -
Total appsec 10.708 s 245.565 ms (2.3%)
Total iast 10.9 s 437.824 ms (4.2%)
Total profiling 10.756 s 294.189 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.206 s 125.692 ms (11.6%)
Agent iast 1.194 s 114.061 ms (10.6%)
Agent profiling 1.269 s 188.86 ms (17.5%)
Total tracing 10.541 s -
Total appsec 10.658 s 117.407 ms (1.1%)
Total iast 10.928 s 386.577 ms (3.7%)
Total profiling 10.685 s 144.308 ms (1.4%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~4e04f547c5, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.794 ms) : 0, 684794
BytebuddyAgent [candidate] (687.9 ms) : 0, 687900
GlobalTracer [baseline] (312.65 ms) : 0, 312650
GlobalTracer [candidate] (316.613 ms) : 0, 316613
AppSec [baseline] (53.069 ms) : 0, 53069
AppSec [candidate] (53.348 ms) : 0, 53348
Remote Config [baseline] (683.481 µs) : 0, 683
Remote Config [candidate] (684.267 µs) : 0, 684
Telemetry [baseline] (7.623 ms) : 0, 7623
Telemetry [candidate] (7.652 ms) : 0, 7652
section appsec
BytebuddyAgent [baseline] (707.175 ms) : 0, 707175
BytebuddyAgent [candidate] (704.209 ms) : 0, 704209
GlobalTracer [baseline] (307.261 ms) : 0, 307261
GlobalTracer [candidate] (304.726 ms) : 0, 304726
AppSec [baseline] (162.552 ms) : 0, 162552
AppSec [candidate] (161.571 ms) : 0, 161571
Remote Config [baseline] (639.704 µs) : 0, 640
Remote Config [candidate] (631.338 µs) : 0, 631
Telemetry [baseline] (9.089 ms) : 0, 9089
Telemetry [candidate] (10.524 ms) : 0, 10524
IAST [baseline] (21.265 ms) : 0, 21265
IAST [candidate] (20.674 ms) : 0, 20674
section iast
BytebuddyAgent [baseline] (796.126 ms) : 0, 796126
BytebuddyAgent [candidate] (794.161 ms) : 0, 794161
GlobalTracer [baseline] (300.891 ms) : 0, 300891
GlobalTracer [candidate] (300.109 ms) : 0, 300109
AppSec [baseline] (54.661 ms) : 0, 54661
AppSec [candidate] (55.137 ms) : 0, 55137
Remote Config [baseline] (612.423 µs) : 0, 612
Remote Config [candidate] (625.471 µs) : 0, 625
Telemetry [baseline] (7.34 ms) : 0, 7340
Telemetry [candidate] (7.332 ms) : 0, 7332
IAST [baseline] (23.641 ms) : 0, 23641
IAST [candidate] (22.952 ms) : 0, 22952
section profiling
ProfilingAgent [baseline] (96.99 ms) : 0, 96990
ProfilingAgent [candidate] (97.043 ms) : 0, 97043
BytebuddyAgent [baseline] (677.149 ms) : 0, 677149
BytebuddyAgent [candidate] (675.52 ms) : 0, 675520
GlobalTracer [baseline] (396.833 ms) : 0, 396833
GlobalTracer [candidate] (396.527 ms) : 0, 396527
AppSec [baseline] (53.521 ms) : 0, 53521
AppSec [candidate] (53.364 ms) : 0, 53364
Remote Config [baseline] (667.08 µs) : 0, 667
Remote Config [candidate] (657.351 µs) : 0, 657
Telemetry [baseline] (7.503 ms) : 0, 7503
Telemetry [candidate] (7.438 ms) : 0, 7438
Profiling [baseline] (97.014 ms) : 0, 97014
Profiling [candidate] (97.066 ms) : 0, 97066
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~4e04f547c5, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075405
Total [baseline] (8.602 s) : 0, 8601937
Agent [candidate] (1.069 s) : 0, 1068795
Total [candidate] (8.572 s) : 0, 8571570
section iast
Agent [baseline] (1.193 s) : 0, 1193413
Total [baseline] (9.075 s) : 0, 9074613
Agent [candidate] (1.204 s) : 0, 1203999
Total [candidate] (9.09 s) : 0, 9090002
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1191576
Total [baseline] (9.025 s) : 0, 9025130
Agent [candidate] (1.203 s) : 0, 1203249
Total [candidate] (9.024 s) : 0, 9024370
section iast_TELEMETRY_OFF
Agent [baseline] (1.197 s) : 0, 1197328
Total [baseline] (9.06 s) : 0, 9060453
Agent [candidate] (1.202 s) : 0, 1202436
Total [candidate] (9.065 s) : 0, 9065440
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.193 s 118.008 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 116.171 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.197 s 121.923 ms (11.3%)
Total tracing 8.602 s -
Total iast 9.075 s 472.676 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.025 s 423.193 ms (4.9%)
Total iast_TELEMETRY_OFF 9.06 s 458.516 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.204 s 135.204 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 134.454 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.202 s 133.641 ms (12.5%)
Total tracing 8.572 s -
Total iast 9.09 s 518.432 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.024 s 452.801 ms (5.3%)
Total iast_TELEMETRY_OFF 9.065 s 493.871 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~4e04f547c5, baseline=1.40.0-SNAPSHOT~5765052e34

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.352 ms) : 0, 687352
BytebuddyAgent [candidate] (681.791 ms) : 0, 681791
GlobalTracer [baseline] (312.982 ms) : 0, 312982
GlobalTracer [candidate] (312.197 ms) : 0, 312197
AppSec [baseline] (52.996 ms) : 0, 52996
AppSec [candidate] (52.733 ms) : 0, 52733
Remote Config [baseline] (676.392 µs) : 0, 676
Remote Config [candidate] (669.947 µs) : 0, 670
Telemetry [baseline] (7.527 ms) : 0, 7527
Telemetry [candidate] (7.585 ms) : 0, 7585
section iast
BytebuddyAgent [baseline] (794.035 ms) : 0, 794035
BytebuddyAgent [candidate] (800.714 ms) : 0, 800714
GlobalTracer [baseline] (300.246 ms) : 0, 300246
GlobalTracer [candidate] (302.855 ms) : 0, 302855
AppSec [baseline] (52.9 ms) : 0, 52900
AppSec [candidate] (54.508 ms) : 0, 54508
IAST [baseline] (24.53 ms) : 0, 24530
IAST [candidate] (23.925 ms) : 0, 23925
Remote Config [baseline] (605.994 µs) : 0, 606
Remote Config [candidate] (658.862 µs) : 0, 659
Telemetry [baseline] (7.317 ms) : 0, 7317
Telemetry [candidate] (7.434 ms) : 0, 7434
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.609 ms) : 0, 792609
BytebuddyAgent [candidate] (800.197 ms) : 0, 800197
GlobalTracer [baseline] (299.623 ms) : 0, 299623
GlobalTracer [candidate] (302.521 ms) : 0, 302521
AppSec [baseline] (53.819 ms) : 0, 53819
AppSec [candidate] (54.48 ms) : 0, 54480
IAST [baseline] (22.967 ms) : 0, 22967
IAST [candidate] (24.115 ms) : 0, 24115
Remote Config [baseline] (617.56 µs) : 0, 618
Remote Config [candidate] (614.23 µs) : 0, 614
Telemetry [baseline] (8.205 ms) : 0, 8205
Telemetry [candidate] (7.424 ms) : 0, 7424
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.614 ms) : 0, 795614
BytebuddyAgent [candidate] (798.875 ms) : 0, 798875
GlobalTracer [baseline] (302.428 ms) : 0, 302428
GlobalTracer [candidate] (303.368 ms) : 0, 303368
AppSec [baseline] (54.887 ms) : 0, 54887
AppSec [candidate] (53.843 ms) : 0, 53843
IAST [baseline] (22.612 ms) : 0, 22612
IAST [candidate] (24.463 ms) : 0, 24463
Remote Config [baseline] (586.921 µs) : 0, 587
Remote Config [candidate] (604.761 µs) : 0, 605
Telemetry [baseline] (7.315 ms) : 0, 7315
Telemetry [candidate] (7.354 ms) : 0, 7354
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-18T13:05:18 2024-09-18T13:12:09
git_branch master jpbempel/fix-nested-jars
git_commit_date 1726653524 1726664098
git_commit_sha 5765052 4e04f54
release_version 1.40.0-SNAPSHOT~5765052e34 1.40.0-SNAPSHOT~4e04f547c5
start_time 2024-09-18T13:05:04 2024-09-18T13:11:56
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726665478 1726665478
ci_job_id 643421077 643421077
ci_pipeline_id 44582047 44582047
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~4e04f547c5, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1374
.   : milestone, 1355,
appsec (1.73 ms) : 1706, 1753
.   : milestone, 1730,
appsec_no_iast (1.712 ms) : 1687, 1737
.   : milestone, 1712,
iast (1.461 ms) : 1439, 1484
.   : milestone, 1461,
profiling (1.521 ms) : 1497, 1545
.   : milestone, 1521,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,
section candidate
no_agent (1.338 ms) : 1319, 1358
.   : milestone, 1338,
appsec (1.747 ms) : 1722, 1771
.   : milestone, 1747,
appsec_no_iast (1.722 ms) : 1697, 1746
.   : milestone, 1722,
iast (1.48 ms) : 1457, 1503
.   : milestone, 1480,
profiling (1.552 ms) : 1527, 1577
.   : milestone, 1552,
tracing (1.488 ms) : 1464, 1512
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.374 ms] -
appsec 1.73 ms [1.706 ms, 1.753 ms] 374.879 µs (27.7%)
appsec_no_iast 1.712 ms [1.687 ms, 1.737 ms] 357.46 µs (26.4%)
iast 1.461 ms [1.439 ms, 1.484 ms] 106.78 µs (7.9%)
profiling 1.521 ms [1.497 ms, 1.545 ms] 166.573 µs (12.3%)
tracing 1.482 ms [1.458 ms, 1.506 ms] 127.167 µs (9.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.319 ms, 1.358 ms] -
appsec 1.747 ms [1.722 ms, 1.771 ms] 408.26 µs (30.5%)
appsec_no_iast 1.722 ms [1.697 ms, 1.746 ms] 383.47 µs (28.7%)
iast 1.48 ms [1.457 ms, 1.503 ms] 141.885 µs (10.6%)
profiling 1.552 ms [1.527 ms, 1.577 ms] 213.358 µs (15.9%)
tracing 1.488 ms [1.464 ms, 1.512 ms] 149.489 µs (11.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~4e04f547c5, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.529 µs) : 350, 391
.   : milestone, 371,
iast (483.355 µs) : 462, 505
.   : milestone, 483,
iast_FULL (554.402 µs) : 533, 576
.   : milestone, 554,
iast_GLOBAL (505.087 µs) : 484, 526
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (489.522 µs) : 468, 511
.   : milestone, 490,
iast_INACTIVE (451.381 µs) : 430, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (480.017 µs) : 457, 503
.   : milestone, 480,
tracing (448.488 µs) : 428, 469
.   : milestone, 448,
section candidate
no_agent (367.432 µs) : 348, 387
.   : milestone, 367,
iast (487.295 µs) : 466, 509
.   : milestone, 487,
iast_FULL (553.466 µs) : 532, 575
.   : milestone, 553,
iast_GLOBAL (520.01 µs) : 496, 544
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (480.772 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (445.068 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (478.332 µs) : 455, 502
.   : milestone, 478,
tracing (444.738 µs) : 424, 465
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.529 µs [350.33 µs, 390.729 µs] -
iast 483.355 µs [462.005 µs, 504.705 µs] 112.826 µs (30.4%)
iast_FULL 554.402 µs [533.257 µs, 575.548 µs] 183.873 µs (49.6%)
iast_GLOBAL 505.087 µs [484.256 µs, 525.917 µs] 134.558 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED 489.522 µs [467.85 µs, 511.193 µs] 118.993 µs (32.1%)
iast_INACTIVE 451.381 µs [430.114 µs, 472.648 µs] 80.852 µs (21.8%)
iast_TELEMETRY_OFF 480.017 µs [457.324 µs, 502.711 µs] 109.488 µs (29.5%)
tracing 448.488 µs [427.74 µs, 469.236 µs] 77.959 µs (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.432 µs [347.73 µs, 387.134 µs] -
iast 487.295 µs [465.678 µs, 508.912 µs] 119.863 µs (32.6%)
iast_FULL 553.466 µs [532.085 µs, 574.847 µs] 186.034 µs (50.6%)
iast_GLOBAL 520.01 µs [496.086 µs, 543.934 µs] 152.578 µs (41.5%)
iast_HARDCODED_SECRET_DISABLED 480.772 µs [459.869 µs, 501.675 µs] 113.34 µs (30.8%)
iast_INACTIVE 445.068 µs [424.286 µs, 465.85 µs] 77.636 µs (21.1%)
iast_TELEMETRY_OFF 478.332 µs [454.984 µs, 501.681 µs] 110.9 µs (30.2%)
tracing 444.738 µs [424.47 µs, 465.006 µs] 77.306 µs (21.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-nested-jars
git_commit_date 1726653524 1726664098
git_commit_sha 5765052 4e04f54
release_version 1.40.0-SNAPSHOT~5765052e34 1.40.0-SNAPSHOT~4e04f547c5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726665995 1726665995
ci_job_id 643421078 643421078
ci_pipeline_id 44582047 44582047
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~4e04f547c5, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.136 s) : 15136000, 15136000
.   : milestone, 15136000,
appsec (15.343 s) : 15343000, 15343000
.   : milestone, 15343000,
iast (19.012 s) : 19012000, 19012000
.   : milestone, 19012000,
iast_GLOBAL (18.158 s) : 18158000, 18158000
.   : milestone, 18158000,
profiling (15.537 s) : 15537000, 15537000
.   : milestone, 15537000,
tracing (14.82 s) : 14820000, 14820000
.   : milestone, 14820000,
section candidate
no_agent (14.882 s) : 14882000, 14882000
.   : milestone, 14882000,
appsec (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
iast (19.07 s) : 19070000, 19070000
.   : milestone, 19070000,
iast_GLOBAL (18.094 s) : 18094000, 18094000
.   : milestone, 18094000,
profiling (15.339 s) : 15339000, 15339000
.   : milestone, 15339000,
tracing (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.136 s [15.136 s, 15.136 s] -
appsec 15.343 s [15.343 s, 15.343 s] 207.0 ms (1.4%)
iast 19.012 s [19.012 s, 19.012 s] 3.876 s (25.6%)
iast_GLOBAL 18.158 s [18.158 s, 18.158 s] 3.022 s (20.0%)
profiling 15.537 s [15.537 s, 15.537 s] 401.0 ms (2.6%)
tracing 14.82 s [14.82 s, 14.82 s] -316.0 ms (-2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.882 s [14.882 s, 14.882 s] -
appsec 15.037 s [15.037 s, 15.037 s] 155.0 ms (1.0%)
iast 19.07 s [19.07 s, 19.07 s] 4.188 s (28.1%)
iast_GLOBAL 18.094 s [18.094 s, 18.094 s] 3.212 s (21.6%)
profiling 15.339 s [15.339 s, 15.339 s] 457.0 ms (3.1%)
tracing 15.187 s [15.187 s, 15.187 s] 305.0 ms (2.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~4e04f547c5, baseline=1.40.0-SNAPSHOT~5765052e34
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.281 ms) : 2241, 2322
.   : milestone, 2281,
iast (2.041 ms) : 1993, 2090
.   : milestone, 2041,
iast_GLOBAL (2.104 ms) : 2053, 2155
.   : milestone, 2104,
profiling (2.367 ms) : 2182, 2552
.   : milestone, 2367,
tracing (1.9 ms) : 1862, 1938
.   : milestone, 1900,
section candidate
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.291 ms) : 2250, 2331
.   : milestone, 2291,
iast (2.052 ms) : 2002, 2103
.   : milestone, 2052,
iast_GLOBAL (2.091 ms) : 2041, 2141
.   : milestone, 2091,
profiling (1.922 ms) : 1882, 1961
.   : milestone, 1922,
tracing (1.9 ms) : 1861, 1938
.   : milestone, 1900,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.281 ms [2.241 ms, 2.322 ms] 818.071 µs (55.9%)
iast 2.041 ms [1.993 ms, 2.09 ms] 577.869 µs (39.5%)
iast_GLOBAL 2.104 ms [2.053 ms, 2.155 ms] 640.409 µs (43.8%)
profiling 2.367 ms [2.182 ms, 2.552 ms] 903.92 µs (61.8%)
tracing 1.9 ms [1.862 ms, 1.938 ms] 437.037 µs (29.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.291 ms [2.25 ms, 2.331 ms] 825.741 µs (56.4%)
iast 2.052 ms [2.002 ms, 2.103 ms] 587.148 µs (40.1%)
iast_GLOBAL 2.091 ms [2.041 ms, 2.141 ms] 626.333 µs (42.8%)
profiling 1.922 ms [1.882 ms, 1.961 ms] 456.556 µs (31.2%)
tracing 1.9 ms [1.861 ms, 1.938 ms] 434.662 µs (29.7%)

@jpbempel
Add support of spring boot nested jar for SymDB
4e04f54 
Spring boot use a special jar organisation for nested ones. It uses a
new jar protocol for URL: jar:nested:
@jpbempel jpbempel force-pushed the jpbempel/fix-nested-jars branch from 4f97c4c to 4e04f54 Compare September 18, 2024 12:55
ojung
ojung approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you know if there are other custom jar path prefixes?

@jpbempel jpbempel merged commit da9ecfb into master Sep 18, 2024
101 of 102 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-nested-jars branch September 18, 2024 16:37
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 18, 2024
@jpbempel
Copy link
Member Author

Thanks! Do you know if there are other custom jar path prefixes?

Not I am aware of. this one is specific to Spring boot: https://docs.spring.io/spring-boot/specification/executable-jar/nested-jars.html

jpbempel added a commit that referenced this pull request Sep 24, 2024
@jpbempel
Add support of spring boot nested jar for SymDB (#7635)
546c0cc 
Spring boot use a special jar organisation for nested ones. It uses a
new jar protocol for URL: jar:nested:
@jpbempel jpbempel mentioned this pull request Sep 24, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojung ojung ojung approved these changes

@shatzi shatzi Awaiting requested review from shatzi shatzi is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @ojung