Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jackson json parser propagation for field names #7606

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Fix jackson json parser propagation for field names #7606

merged 13 commits into from
Sep 30, 2024

Conversation

Mariovido
Copy link
Contributor

@Mariovido Mariovido commented Sep 12, 2024 •
edited
Loading

What Does This Do

This fix the unwanted tainting of field names that are being interned by the parser. This is making us report vulnerabilities that we don't want to report. One example could be SQL Injection, where we are reporting an SQL Injection in the eBean framework due to the fact that we are tainting the name of a field in the request, and this name is interned, so when eBean look for it is tainted.

Motivation

It is motivated by the report of a client using eBean.

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-54675

@Mariovido Mariovido added type: bug comp: asm iast Application Security Management (IAST) labels Sep 12, 2024
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 bot reviewed Sep 12, 2024
View reviewed changes
.../src/main/java/datadog/trace/instrumentation/jackson/core/Json2_16ParserInstrumentation.java Outdated Show resolved Hide resolved
...6/src/main/java/datadog/trace/instrumentation/jackson/core/Json2_6ParserInstrumentation.java Outdated Show resolved Hide resolved
...re/jackson-core-2.16/src/main/java/com/fasterxml/jackson/core/json/Json2_16ParserHelper.java Outdated Show resolved Hide resolved
...core-2.16/src/main/java/com/fasterxml/jackson/core/sym/ByteQuadsCanonicalizer2_16Helper.java Outdated Show resolved Hide resolved
...core/jackson-core-2.6/src/main/java/com/fasterxml/jackson/core/json/Json2_6ParserHelper.java Outdated Show resolved Hide resolved
...n-core-2.6/src/main/java/com/fasterxml/jackson/core/sym/ByteQuadsCanonicalizer2_6Helper.java Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/json_parser_propagation
git_commit_date 1727682967 1727684368
git_commit_sha efa3824 367dec7
release_version 1.40.0-SNAPSHOT~efa3824d5d 1.40.0-SNAPSHOT~367dec7ac7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727687243 1727687243
ci_job_id 655142770 655142770
ci_pipeline_id 45393038 45393038
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~367dec7ac7, baseline=1.40.0-SNAPSHOT~efa3824d5d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070211
Total [baseline] (8.555 s) : 0, 8555470
Agent [candidate] (1.077 s) : 0, 1076805
Total [candidate] (8.598 s) : 0, 8598458
section iast
Agent [baseline] (1.195 s) : 0, 1195109
Total [baseline] (9.028 s) : 0, 9027690
Agent [candidate] (1.209 s) : 0, 1209019
Total [candidate] (9.114 s) : 0, 9113947
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.213 s) : 0, 1212687
Total [baseline] (9.067 s) : 0, 9067370
Agent [candidate] (1.198 s) : 0, 1197962
Total [candidate] (9.081 s) : 0, 9080758
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1201549
Total [baseline] (9.088 s) : 0, 9088304
Agent [candidate] (1.194 s) : 0, 1194470
Total [candidate] (9.076 s) : 0, 9075531
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent iast 1.195 s 124.898 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.213 s 142.476 ms (13.3%)
Agent iast_TELEMETRY_OFF 1.202 s 131.338 ms (12.3%)
Total tracing 8.555 s -
Total iast 9.028 s 472.22 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.067 s 511.9 ms (6.0%)
Total iast_TELEMETRY_OFF 9.088 s 532.834 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.209 s 132.214 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 121.157 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.194 s 117.665 ms (10.9%)
Total tracing 8.598 s -
Total iast 9.114 s 515.489 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.081 s 482.3 ms (5.6%)
Total iast_TELEMETRY_OFF 9.076 s 477.074 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~367dec7ac7, baseline=1.40.0-SNAPSHOT~efa3824d5d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.713 ms) : 0, 682713
BytebuddyAgent [candidate] (686.959 ms) : 0, 686959
GlobalTracer [baseline] (311.517 ms) : 0, 311517
GlobalTracer [candidate] (313.539 ms) : 0, 313539
AppSec [baseline] (53.873 ms) : 0, 53873
AppSec [candidate] (54.028 ms) : 0, 54028
Remote Config [baseline] (667.334 µs) : 0, 667
Remote Config [candidate] (665.934 µs) : 0, 666
Telemetry [baseline] (7.638 ms) : 0, 7638
Telemetry [candidate] (7.734 ms) : 0, 7734
section iast
BytebuddyAgent [baseline] (794.34 ms) : 0, 794340
BytebuddyAgent [candidate] (805.978 ms) : 0, 805978
GlobalTracer [baseline] (300.41 ms) : 0, 300410
GlobalTracer [candidate] (302.433 ms) : 0, 302433
AppSec [baseline] (53.964 ms) : 0, 53964
AppSec [candidate] (55.845 ms) : 0, 55845
IAST [baseline] (24.821 ms) : 0, 24821
IAST [candidate] (22.962 ms) : 0, 22962
Remote Config [baseline] (630.772 µs) : 0, 631
Remote Config [candidate] (637.856 µs) : 0, 638
Telemetry [baseline] (7.104 ms) : 0, 7104
Telemetry [candidate] (7.152 ms) : 0, 7152
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.001 ms) : 0, 807001
BytebuddyAgent [candidate] (796.771 ms) : 0, 796771
GlobalTracer [baseline] (304.65 ms) : 0, 304650
GlobalTracer [candidate] (300.905 ms) : 0, 300905
AppSec [baseline] (58.725 ms) : 0, 58725
AppSec [candidate] (55.468 ms) : 0, 55468
IAST [baseline] (20.452 ms) : 0, 20452
IAST [candidate] (23.133 ms) : 0, 23133
Remote Config [baseline] (613.577 µs) : 0, 614
Remote Config [candidate] (636.468 µs) : 0, 636
Telemetry [baseline] (7.178 ms) : 0, 7178
Telemetry [candidate] (7.143 ms) : 0, 7143
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.737 ms) : 0, 797737
BytebuddyAgent [candidate] (793.231 ms) : 0, 793231
GlobalTracer [baseline] (303.063 ms) : 0, 303063
GlobalTracer [candidate] (301.28 ms) : 0, 301280
AppSec [baseline] (57.429 ms) : 0, 57429
AppSec [candidate] (55.96 ms) : 0, 55960
IAST [baseline] (21.813 ms) : 0, 21813
IAST [candidate] (22.531 ms) : 0, 22531
Remote Config [baseline] (638.583 µs) : 0, 639
Remote Config [candidate] (649.611 µs) : 0, 650
Telemetry [baseline] (6.899 ms) : 0, 6899
Telemetry [candidate] (6.928 ms) : 0, 6928
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~367dec7ac7, baseline=1.40.0-SNAPSHOT~efa3824d5d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077187
Total [baseline] (10.38 s) : 0, 10380154
Agent [candidate] (1.078 s) : 0, 1078246
Total [candidate] (10.383 s) : 0, 10382751
section appsec
Agent [baseline] (1.212 s) : 0, 1212122
Total [baseline] (10.666 s) : 0, 10666209
Agent [candidate] (1.212 s) : 0, 1211910
Total [candidate] (10.662 s) : 0, 10661895
section iast
Agent [baseline] (1.203 s) : 0, 1203227
Total [baseline] (10.899 s) : 0, 10898882
Agent [candidate] (1.199 s) : 0, 1198556
Total [candidate] (10.956 s) : 0, 10956253
section profiling
Agent [baseline] (1.266 s) : 0, 1265658
Total [baseline] (10.591 s) : 0, 10591185
Agent [candidate] (1.268 s) : 0, 1268375
Total [candidate] (10.675 s) : 0, 10674534
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.212 s 134.935 ms (12.5%)
Agent iast 1.203 s 126.04 ms (11.7%)
Agent profiling 1.266 s 188.471 ms (17.5%)
Total tracing 10.38 s -
Total appsec 10.666 s 286.055 ms (2.8%)
Total iast 10.899 s 518.728 ms (5.0%)
Total profiling 10.591 s 211.031 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.212 s 133.664 ms (12.4%)
Agent iast 1.199 s 120.31 ms (11.2%)
Agent profiling 1.268 s 190.129 ms (17.6%)
Total tracing 10.383 s -
Total appsec 10.662 s 279.144 ms (2.7%)
Total iast 10.956 s 573.503 ms (5.5%)
Total profiling 10.675 s 291.784 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~367dec7ac7, baseline=1.40.0-SNAPSHOT~efa3824d5d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.536 ms) : 0, 686536
BytebuddyAgent [candidate] (687.781 ms) : 0, 687781
GlobalTracer [baseline] (314.178 ms) : 0, 314178
GlobalTracer [candidate] (313.798 ms) : 0, 313798
AppSec [baseline] (54.187 ms) : 0, 54187
AppSec [candidate] (54.403 ms) : 0, 54403
Remote Config [baseline] (667.151 µs) : 0, 667
Remote Config [candidate] (668.278 µs) : 0, 668
Telemetry [baseline] (7.775 ms) : 0, 7775
Telemetry [candidate] (7.748 ms) : 0, 7748
section appsec
BytebuddyAgent [baseline] (703.949 ms) : 0, 703949
BytebuddyAgent [candidate] (702.986 ms) : 0, 702986
GlobalTracer [baseline] (310.715 ms) : 0, 310715
GlobalTracer [candidate] (310.075 ms) : 0, 310075
AppSec [baseline] (163.268 ms) : 0, 163268
AppSec [candidate] (163.873 ms) : 0, 163873
Remote Config [baseline] (652.315 µs) : 0, 652
Remote Config [candidate] (647.501 µs) : 0, 648
Telemetry [baseline] (8.601 ms) : 0, 8601
Telemetry [candidate] (9.282 ms) : 0, 9282
IAST [baseline] (22.29 ms) : 0, 22290
IAST [candidate] (22.433 ms) : 0, 22433
section iast
BytebuddyAgent [baseline] (800.075 ms) : 0, 800075
BytebuddyAgent [candidate] (797.889 ms) : 0, 797889
GlobalTracer [baseline] (302.412 ms) : 0, 302412
GlobalTracer [candidate] (301.054 ms) : 0, 301054
AppSec [baseline] (55.36 ms) : 0, 55360
AppSec [candidate] (55.808 ms) : 0, 55808
Remote Config [baseline] (641.221 µs) : 0, 641
Remote Config [candidate] (638.886 µs) : 0, 639
Telemetry [baseline] (7.031 ms) : 0, 7031
Telemetry [candidate] (7.109 ms) : 0, 7109
IAST [baseline] (23.826 ms) : 0, 23826
IAST [candidate] (22.216 ms) : 0, 22216
section profiling
ProfilingAgent [baseline] (96.179 ms) : 0, 96179
ProfilingAgent [candidate] (96.934 ms) : 0, 96934
BytebuddyAgent [baseline] (674.072 ms) : 0, 674072
BytebuddyAgent [candidate] (675.193 ms) : 0, 675193
GlobalTracer [baseline] (393.789 ms) : 0, 393789
GlobalTracer [candidate] (394.304 ms) : 0, 394304
AppSec [baseline] (54.672 ms) : 0, 54672
AppSec [candidate] (54.879 ms) : 0, 54879
Remote Config [baseline] (654.062 µs) : 0, 654
Remote Config [candidate] (658.622 µs) : 0, 659
Telemetry [baseline] (7.54 ms) : 0, 7540
Telemetry [candidate] (7.562 ms) : 0, 7562
Profiling [baseline] (96.202 ms) : 0, 96202
Profiling [candidate] (96.958 ms) : 0, 96958
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-30T08:40:04 2024-09-30T08:46:56
git_branch master mario.vidal/json_parser_propagation
git_commit_date 1727682967 1727684368
git_commit_sha efa3824 367dec7
release_version 1.40.0-SNAPSHOT~efa3824d5d 1.40.0-SNAPSHOT~367dec7ac7
start_time 2024-09-30T08:39:50 2024-09-30T08:46:42
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727686365 1727686365
ci_job_id 655142771 655142771
ci_pipeline_id 45393038 45393038
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~367dec7ac7, baseline=1.40.0-SNAPSHOT~efa3824d5d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1365
.   : milestone, 1345,
appsec (1.732 ms) : 1707, 1757
.   : milestone, 1732,
appsec_no_iast (1.733 ms) : 1708, 1757
.   : milestone, 1733,
iast (1.475 ms) : 1453, 1498
.   : milestone, 1475,
profiling (1.496 ms) : 1474, 1518
.   : milestone, 1496,
tracing (1.471 ms) : 1446, 1495
.   : milestone, 1471,
section candidate
no_agent (1.36 ms) : 1340, 1380
.   : milestone, 1360,
appsec (1.732 ms) : 1709, 1756
.   : milestone, 1732,
appsec_no_iast (1.749 ms) : 1725, 1773
.   : milestone, 1749,
iast (1.479 ms) : 1456, 1502
.   : milestone, 1479,
profiling (1.531 ms) : 1507, 1555
.   : milestone, 1531,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.365 ms] -
appsec 1.732 ms [1.707 ms, 1.757 ms] 386.558 µs (28.7%)
appsec_no_iast 1.733 ms [1.708 ms, 1.757 ms] 387.185 µs (28.8%)
iast 1.475 ms [1.453 ms, 1.498 ms] 129.781 µs (9.6%)
profiling 1.496 ms [1.474 ms, 1.518 ms] 150.686 µs (11.2%)
tracing 1.471 ms [1.446 ms, 1.495 ms] 125.334 µs (9.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.38 ms] -
appsec 1.732 ms [1.709 ms, 1.756 ms] 372.294 µs (27.4%)
appsec_no_iast 1.749 ms [1.725 ms, 1.773 ms] 389.042 µs (28.6%)
iast 1.479 ms [1.456 ms, 1.502 ms] 118.888 µs (8.7%)
profiling 1.531 ms [1.507 ms, 1.555 ms] 171.343 µs (12.6%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 111.382 µs (8.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~367dec7ac7, baseline=1.40.0-SNAPSHOT~efa3824d5d
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.954 µs) : 358, 398
.   : milestone, 378,
iast (492.017 µs) : 471, 513
.   : milestone, 492,
iast_FULL (559.242 µs) : 538, 580
.   : milestone, 559,
iast_GLOBAL (517.454 µs) : 496, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (491.666 µs) : 470, 513
.   : milestone, 492,
iast_INACTIVE (453.506 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (478.994 µs) : 457, 501
.   : milestone, 479,
tracing (444.966 µs) : 424, 465
.   : milestone, 445,
section candidate
no_agent (374.626 µs) : 355, 394
.   : milestone, 375,
iast (491.559 µs) : 470, 513
.   : milestone, 492,
iast_FULL (557.605 µs) : 536, 579
.   : milestone, 558,
iast_GLOBAL (509.608 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (491.09 µs) : 470, 512
.   : milestone, 491,
iast_INACTIVE (449.609 µs) : 429, 470
.   : milestone, 450,
iast_TELEMETRY_OFF (484.653 µs) : 463, 506
.   : milestone, 485,
tracing (450.844 µs) : 430, 472
.   : milestone, 451,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.954 µs [358.335 µs, 397.574 µs] -
iast 492.017 µs [470.914 µs, 513.121 µs] 114.063 µs (30.2%)
iast_FULL 559.242 µs [538.075 µs, 580.409 µs] 181.288 µs (48.0%)
iast_GLOBAL 517.454 µs [495.825 µs, 539.084 µs] 139.5 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 491.666 µs [470.251 µs, 513.082 µs] 113.712 µs (30.1%)
iast_INACTIVE 453.506 µs [432.031 µs, 474.982 µs] 75.552 µs (20.0%)
iast_TELEMETRY_OFF 478.994 µs [456.787 µs, 501.201 µs] 101.04 µs (26.7%)
tracing 444.966 µs [424.44 µs, 465.491 µs] 67.011 µs (17.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.626 µs [354.933 µs, 394.318 µs] -
iast 491.559 µs [469.971 µs, 513.147 µs] 116.933 µs (31.2%)
iast_FULL 557.605 µs [536.397 µs, 578.813 µs] 182.979 µs (48.8%)
iast_GLOBAL 509.608 µs [488.525 µs, 530.69 µs] 134.982 µs (36.0%)
iast_HARDCODED_SECRET_DISABLED 491.09 µs [469.984 µs, 512.195 µs] 116.464 µs (31.1%)
iast_INACTIVE 449.609 µs [428.985 µs, 470.232 µs] 74.983 µs (20.0%)
iast_TELEMETRY_OFF 484.653 µs [463.341 µs, 505.965 µs] 110.027 µs (29.4%)
tracing 450.844 µs [429.73 µs, 471.959 µs] 76.218 µs (20.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/json_parser_propagation
git_commit_date 1727682967 1727684368
git_commit_sha efa3824 367dec7
release_version 1.40.0-SNAPSHOT~efa3824d5d 1.40.0-SNAPSHOT~367dec7ac7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727686924 1727686924
ci_job_id 655142772 655142772
ci_pipeline_id 45393038 45393038
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~367dec7ac7, baseline=1.40.0-SNAPSHOT~efa3824d5d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.279 ms) : 2240, 2319
.   : milestone, 2279,
iast (2.057 ms) : 2008, 2107
.   : milestone, 2057,
iast_GLOBAL (2.093 ms) : 2043, 2144
.   : milestone, 2093,
profiling (1.921 ms) : 1881, 1962
.   : milestone, 1921,
tracing (1.903 ms) : 1865, 1942
.   : milestone, 1903,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.304 ms) : 2264, 2344
.   : milestone, 2304,
iast (2.057 ms) : 2007, 2108
.   : milestone, 2057,
iast_GLOBAL (2.111 ms) : 2060, 2163
.   : milestone, 2111,
profiling (2.437 ms) : 2245, 2628
.   : milestone, 2437,
tracing (1.915 ms) : 1876, 1954
.   : milestone, 1915,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.279 ms [2.24 ms, 2.319 ms] 816.036 µs (55.8%)
iast 2.057 ms [2.008 ms, 2.107 ms] 594.0 µs (40.6%)
iast_GLOBAL 2.093 ms [2.043 ms, 2.144 ms] 629.857 µs (43.0%)
profiling 1.921 ms [1.881 ms, 1.962 ms] 457.747 µs (31.3%)
tracing 1.903 ms [1.865 ms, 1.942 ms] 439.703 µs (30.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.304 ms [2.264 ms, 2.344 ms] 837.81 µs (57.1%)
iast 2.057 ms [2.007 ms, 2.108 ms] 591.065 µs (40.3%)
iast_GLOBAL 2.111 ms [2.06 ms, 2.163 ms] 645.047 µs (44.0%)
profiling 2.437 ms [2.245 ms, 2.628 ms] 970.265 µs (66.2%)
tracing 1.915 ms [1.876 ms, 1.954 ms] 448.629 µs (30.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~367dec7ac7, baseline=1.40.0-SNAPSHOT~efa3824d5d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.128 s) : 15128000, 15128000
.   : milestone, 15128000,
appsec (15.322 s) : 15322000, 15322000
.   : milestone, 15322000,
iast (18.915 s) : 18915000, 18915000
.   : milestone, 18915000,
iast_GLOBAL (18.047 s) : 18047000, 18047000
.   : milestone, 18047000,
profiling (15.076 s) : 15076000, 15076000
.   : milestone, 15076000,
tracing (15.369 s) : 15369000, 15369000
.   : milestone, 15369000,
section candidate
no_agent (15.321 s) : 15321000, 15321000
.   : milestone, 15321000,
appsec (15.121 s) : 15121000, 15121000
.   : milestone, 15121000,
iast (18.727 s) : 18727000, 18727000
.   : milestone, 18727000,
iast_GLOBAL (18.115 s) : 18115000, 18115000
.   : milestone, 18115000,
profiling (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
tracing (15.258 s) : 15258000, 15258000
.   : milestone, 15258000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.128 s [15.128 s, 15.128 s] -
appsec 15.322 s [15.322 s, 15.322 s] 194.0 ms (1.3%)
iast 18.915 s [18.915 s, 18.915 s] 3.787 s (25.0%)
iast_GLOBAL 18.047 s [18.047 s, 18.047 s] 2.919 s (19.3%)
profiling 15.076 s [15.076 s, 15.076 s] -52.0 ms (-0.3%)
tracing 15.369 s [15.369 s, 15.369 s] 241.0 ms (1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.321 s [15.321 s, 15.321 s] -
appsec 15.121 s [15.121 s, 15.121 s] -200.0 ms (-1.3%)
iast 18.727 s [18.727 s, 18.727 s] 3.406 s (22.2%)
iast_GLOBAL 18.115 s [18.115 s, 18.115 s] 2.794 s (18.2%)
profiling 15.001 s [15.001 s, 15.001 s] -320.0 ms (-2.1%)
tracing 15.258 s [15.258 s, 15.258 s] -63.0 ms (-0.4%)

@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2024 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/json_parser_propagation
git_commit_date 1727682967 1727684368
git_commit_sha efa3824 367dec7
See matching parameters
Baseline Candidate
ci_job_date 1727689236 1727689236
ci_job_id 655229537 655229537
ci_pipeline_id 45393038 45393038
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce unsure
[-6837.004op/s; -365.655op/s] or [-3.902%; -0.209%]
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2024 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/json_parser_propagation
git_commit_date 1727682967 1727684368
git_commit_sha efa3824 367dec7
See matching parameters
Baseline Candidate
ci_job_date 1727689275 1727689275
ci_job_id 655229553 655229553
ci_pipeline_id 45393038 45393038
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 bot reviewed Sep 12, 2024
View reviewed changes
...8/src/main/java/datadog/trace/instrumentation/jackson/core/Json2_8ParserInstrumentation.java Outdated Show resolved Hide resolved
...n-core-2.8/src/main/java/com/fasterxml/jackson/core/sym/ByteQuadsCanonicalizer2_8Helper.java Outdated Show resolved Hide resolved
...core-2.12/src/main/java/com/fasterxml/jackson/core/sym/ByteQuadsCanonicalizer2_12Helper.java Outdated Show resolved Hide resolved
...re/jackson-core-2.12/src/main/java/com/fasterxml/jackson/core/json/Json2_12ParserHelper.java Outdated Show resolved Hide resolved
...core/jackson-core-2.8/src/main/java/com/fasterxml/jackson/core/json/Json2_8ParserHelper.java Outdated Show resolved Hide resolved
.../src/main/java/datadog/trace/instrumentation/jackson/core/Json2_12ParserInstrumentation.java Outdated Show resolved Hide resolved
@Mariovido Mariovido marked this pull request as ready for review September 13, 2024 12:20
@Mariovido Mariovido requested review from a team as code owners September 13, 2024 12:20
manuel-alvarez-alvarez
manuel-alvarez-alvarez approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mariovido Mariovido merged commit 70ac474 into master Sep 30, 2024
105 checks passed
@Mariovido Mariovido deleted the mario.vidal/json_parser_propagation branch September 30, 2024 10:13
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mariovido @manuel-alvarez-alvarez