-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pull_request extra tags for GitHub Actions #7604
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/gha-pr-extra-tags
Sep 13, 2024
Merged
Add pull_request extra tags for GitHub Actions #7604
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/gha-pr-extra-tags
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
the
comp: ci visibility
Continuous Integration Visibility
label
Sep 11, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~66be571623, baseline=1.40.0-SNAPSHOT~4abf841368
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068588
Total [baseline] (10.503 s) : 0, 10503236
Agent [candidate] (1.072 s) : 0, 1071615
Total [candidate] (10.484 s) : 0, 10483846
section appsec
Agent [baseline] (1.197 s) : 0, 1197006
Total [baseline] (10.628 s) : 0, 10628249
Agent [candidate] (1.205 s) : 0, 1204871
Total [candidate] (10.681 s) : 0, 10681423
section iast
Agent [baseline] (1.196 s) : 0, 1196275
Total [baseline] (10.894 s) : 0, 10894117
Agent [candidate] (1.197 s) : 0, 1197261
Total [candidate] (10.923 s) : 0, 10923318
section profiling
Agent [baseline] (1.282 s) : 0, 1282109
Total [baseline] (10.717 s) : 0, 10717471
Agent [candidate] (1.274 s) : 0, 1274282
Total [candidate] (10.718 s) : 0, 10717701
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~66be571623, baseline=1.40.0-SNAPSHOT~4abf841368
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.897 ms) : 0, 681897
BytebuddyAgent [candidate] (682.579 ms) : 0, 682579
GlobalTracer [baseline] (312.199 ms) : 0, 312199
GlobalTracer [candidate] (314.276 ms) : 0, 314276
AppSec [baseline] (52.332 ms) : 0, 52332
AppSec [candidate] (52.582 ms) : 0, 52582
Remote Config [baseline] (738.313 µs) : 0, 738
Remote Config [candidate] (733.544 µs) : 0, 734
Telemetry [baseline] (7.686 ms) : 0, 7686
Telemetry [candidate] (7.701 ms) : 0, 7701
section appsec
BytebuddyAgent [baseline] (699.328 ms) : 0, 699328
BytebuddyAgent [candidate] (702.689 ms) : 0, 702689
GlobalTracer [baseline] (303.74 ms) : 0, 303740
GlobalTracer [candidate] (305.199 ms) : 0, 305199
AppSec [baseline] (162.002 ms) : 0, 162002
AppSec [candidate] (161.996 ms) : 0, 161996
IAST [baseline] (18.496 ms) : 0, 18496
IAST [candidate] (23.149 ms) : 0, 23149
Remote Config [baseline] (645.09 µs) : 0, 645
Remote Config [candidate] (650.1 µs) : 0, 650
Telemetry [baseline] (8.36 ms) : 0, 8360
Telemetry [candidate] (9.035 ms) : 0, 9035
section iast
BytebuddyAgent [baseline] (794.528 ms) : 0, 794528
BytebuddyAgent [candidate] (794.667 ms) : 0, 794667
GlobalTracer [baseline] (301.867 ms) : 0, 301867
GlobalTracer [candidate] (302.811 ms) : 0, 302811
AppSec [baseline] (54.148 ms) : 0, 54148
AppSec [candidate] (53.898 ms) : 0, 53898
IAST [baseline] (23.102 ms) : 0, 23102
IAST [candidate] (21.543 ms) : 0, 21543
Remote Config [baseline] (1.389 ms) : 0, 1389
Remote Config [candidate] (2.981 ms) : 0, 2981
Telemetry [baseline] (7.492 ms) : 0, 7492
Telemetry [candidate] (7.604 ms) : 0, 7604
section profiling
BytebuddyAgent [baseline] (684.5 ms) : 0, 684500
BytebuddyAgent [candidate] (680.365 ms) : 0, 680365
GlobalTracer [baseline] (399.867 ms) : 0, 399867
GlobalTracer [candidate] (397.258 ms) : 0, 397258
AppSec [baseline] (53.145 ms) : 0, 53145
AppSec [candidate] (52.858 ms) : 0, 52858
Remote Config [baseline] (714.216 µs) : 0, 714
Remote Config [candidate] (717.55 µs) : 0, 718
Telemetry [baseline] (7.571 ms) : 0, 7571
Telemetry [candidate] (7.505 ms) : 0, 7505
ProfilingAgent [baseline] (97.56 ms) : 0, 97560
ProfilingAgent [candidate] (97.083 ms) : 0, 97083
Profiling [baseline] (97.584 ms) : 0, 97584
Profiling [candidate] (97.107 ms) : 0, 97107
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~66be571623, baseline=1.40.0-SNAPSHOT~4abf841368
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068385
Total [baseline] (8.555 s) : 0, 8554863
Agent [candidate] (1.068 s) : 0, 1067705
Total [candidate] (8.544 s) : 0, 8544435
section iast
Agent [baseline] (1.216 s) : 0, 1216423
Total [baseline] (9.029 s) : 0, 9028569
Agent [candidate] (1.198 s) : 0, 1198165
Total [candidate] (9.032 s) : 0, 9031792
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.193 s) : 0, 1193274
Total [baseline] (9.008 s) : 0, 9008389
Agent [candidate] (1.197 s) : 0, 1196559
Total [candidate] (9.004 s) : 0, 9004071
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1196058
Total [baseline] (9.011 s) : 0, 9011367
Agent [candidate] (1.2 s) : 0, 1200168
Total [candidate] (9.025 s) : 0, 9025035
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~66be571623, baseline=1.40.0-SNAPSHOT~4abf841368
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.605 ms) : 0, 681605
BytebuddyAgent [candidate] (681.703 ms) : 0, 681703
GlobalTracer [baseline] (312.736 ms) : 0, 312736
GlobalTracer [candidate] (311.934 ms) : 0, 311934
AppSec [baseline] (51.967 ms) : 0, 51967
AppSec [candidate] (51.943 ms) : 0, 51943
Remote Config [baseline] (719.441 µs) : 0, 719
Remote Config [candidate] (720.605 µs) : 0, 721
Telemetry [baseline] (7.64 ms) : 0, 7640
Telemetry [candidate] (7.685 ms) : 0, 7685
section iast
BytebuddyAgent [baseline] (810.974 ms) : 0, 810974
BytebuddyAgent [candidate] (797.278 ms) : 0, 797278
GlobalTracer [baseline] (306.193 ms) : 0, 306193
GlobalTracer [candidate] (302.086 ms) : 0, 302086
AppSec [baseline] (55.334 ms) : 0, 55334
AppSec [candidate] (53.17 ms) : 0, 53170
IAST [baseline] (21.69 ms) : 0, 21690
IAST [candidate] (23.768 ms) : 0, 23768
Remote Config [baseline] (624.361 µs) : 0, 624
Remote Config [candidate] (632.968 µs) : 0, 633
Telemetry [baseline] (7.566 ms) : 0, 7566
Telemetry [candidate] (7.418 ms) : 0, 7418
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.44 ms) : 0, 793440
BytebuddyAgent [candidate] (792.274 ms) : 0, 792274
GlobalTracer [baseline] (300.486 ms) : 0, 300486
GlobalTracer [candidate] (306.089 ms) : 0, 306089
AppSec [baseline] (56.061 ms) : 0, 56061
AppSec [candidate] (55.138 ms) : 0, 55138
IAST [baseline] (21.385 ms) : 0, 21385
IAST [candidate] (20.483 ms) : 0, 20483
Remote Config [baseline] (616.239 µs) : 0, 616
Remote Config [candidate] (622.517 µs) : 0, 623
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (8.199 ms) : 0, 8199
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.812 ms) : 0, 794812
BytebuddyAgent [candidate] (797.928 ms) : 0, 797928
GlobalTracer [baseline] (301.994 ms) : 0, 301994
GlobalTracer [candidate] (303.259 ms) : 0, 303259
AppSec [baseline] (53.248 ms) : 0, 53248
AppSec [candidate] (56.086 ms) : 0, 56086
IAST [baseline] (24.23 ms) : 0, 24230
IAST [candidate] (21.069 ms) : 0, 21069
Remote Config [baseline] (607.313 µs) : 0, 607
Remote Config [candidate] (609.146 µs) : 0, 609
Telemetry [baseline] (7.303 ms) : 0, 7303
Telemetry [candidate] (7.357 ms) : 0, 7357
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~66be571623, baseline=1.40.0-SNAPSHOT~4abf841368
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1365
. : milestone, 1346,
appsec (1.72 ms) : 1695, 1746
. : milestone, 1720,
appsec_no_iast (1.734 ms) : 1710, 1758
. : milestone, 1734,
iast (1.484 ms) : 1461, 1506
. : milestone, 1484,
profiling (1.483 ms) : 1460, 1505
. : milestone, 1483,
tracing (1.465 ms) : 1441, 1489
. : milestone, 1465,
section candidate
no_agent (1.35 ms) : 1331, 1369
. : milestone, 1350,
appsec (1.712 ms) : 1687, 1737
. : milestone, 1712,
appsec_no_iast (1.711 ms) : 1687, 1736
. : milestone, 1711,
iast (1.484 ms) : 1461, 1507
. : milestone, 1484,
profiling (1.501 ms) : 1478, 1524
. : milestone, 1501,
tracing (1.458 ms) : 1433, 1483
. : milestone, 1458,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~66be571623, baseline=1.40.0-SNAPSHOT~4abf841368
dateFormat X
axisFormat %s
section baseline
no_agent (373.028 µs) : 353, 393
. : milestone, 373,
iast (498.994 µs) : 477, 521
. : milestone, 499,
iast_FULL (554.48 µs) : 533, 576
. : milestone, 554,
iast_GLOBAL (508.961 µs) : 488, 530
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (487.401 µs) : 466, 509
. : milestone, 487,
iast_INACTIVE (445.676 µs) : 425, 466
. : milestone, 446,
iast_TELEMETRY_OFF (478.865 µs) : 457, 501
. : milestone, 479,
tracing (444.78 µs) : 425, 465
. : milestone, 445,
section candidate
no_agent (378.543 µs) : 359, 398
. : milestone, 379,
iast (487.294 µs) : 466, 509
. : milestone, 487,
iast_FULL (558.569 µs) : 537, 580
. : milestone, 559,
iast_GLOBAL (517.217 µs) : 495, 540
. : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (498.482 µs) : 476, 521
. : milestone, 498,
iast_INACTIVE (450.231 µs) : 430, 471
. : milestone, 450,
iast_TELEMETRY_OFF (481.699 µs) : 459, 504
. : milestone, 482,
tracing (445.867 µs) : 425, 466
. : milestone, 446,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~66be571623, baseline=1.40.0-SNAPSHOT~4abf841368
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.301 ms) : 2261, 2342
. : milestone, 2301,
iast (2.05 ms) : 2002, 2098
. : milestone, 2050,
iast_GLOBAL (2.103 ms) : 2052, 2154
. : milestone, 2103,
profiling (1.925 ms) : 1885, 1965
. : milestone, 1925,
tracing (1.911 ms) : 1872, 1950
. : milestone, 1911,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.312 ms) : 2271, 2352
. : milestone, 2312,
iast (2.058 ms) : 2007, 2108
. : milestone, 2058,
iast_GLOBAL (2.094 ms) : 2044, 2144
. : milestone, 2094,
profiling (1.92 ms) : 1879, 1961
. : milestone, 1920,
tracing (1.91 ms) : 1872, 1949
. : milestone, 1910,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~66be571623, baseline=1.40.0-SNAPSHOT~4abf841368
dateFormat X
axisFormat %s
section baseline
no_agent (15.566 s) : 15566000, 15566000
. : milestone, 15566000,
appsec (15.083 s) : 15083000, 15083000
. : milestone, 15083000,
iast (18.863 s) : 18863000, 18863000
. : milestone, 18863000,
iast_GLOBAL (18.265 s) : 18265000, 18265000
. : milestone, 18265000,
profiling (15.282 s) : 15282000, 15282000
. : milestone, 15282000,
tracing (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
section candidate
no_agent (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
appsec (15.215 s) : 15215000, 15215000
. : milestone, 15215000,
iast (18.897 s) : 18897000, 18897000
. : milestone, 18897000,
iast_GLOBAL (18.212 s) : 18212000, 18212000
. : milestone, 18212000,
profiling (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
tracing (15.083 s) : 15083000, 15083000
. : milestone, 15083000,
|
anmarchenko
approved these changes
Sep 13, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/gha-pr-extra-tags
branch
September 13, 2024 08:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds extra tags with Git metadata for Github Actions workflows that are triggered with
pull_request
event.Motivation
These tags are needed by the backend.
In GHA
pull_request
workflows HEAD does not point to the last commit in the PR, but to a commit that is the result of merging PR branch with the target branch.Additional Notes
The extra tags are:
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-527