Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set test session name on test/suite/module/session events #7603

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Set test session name on test/suite/module/session events #7603

merged 6 commits into from
Sep 16, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Sep 11, 2024 •
edited by smola
Loading

What Does This Do

Sets test_session.name tag on every Test Visibility event.

Motivation

Test session names are being introduced in Test Visibility as a replacement for test services.

Additional Notes

This PR also updates CI Test Cycle protocol mapping logic.
Some tags that are the same for every span (namely JVM and OS details) are moved to message header to avoid repeating them.

Contributor Checklist

Jira ticket: SDTEST-784

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Sep 11, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 11, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/test-session-name
git_commit_date 1726154176 1726154025
git_commit_sha a472c9d c8f1363
release_version 1.40.0-SNAPSHOT~a472c9dc91 1.40.0-SNAPSHOT~c8f1363a33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726156309 1726156309
ci_job_id 637299826 637299826
ci_pipeline_id 44185222 44185222
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~c8f1363a33, baseline=1.40.0-SNAPSHOT~a472c9dc91

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072054
Total [baseline] (10.385 s) : 0, 10384762
Agent [candidate] (1.067 s) : 0, 1067216
Total [candidate] (10.469 s) : 0, 10468585
section appsec
Agent [baseline] (1.202 s) : 0, 1202155
Total [baseline] (10.591 s) : 0, 10590805
Agent [candidate] (1.205 s) : 0, 1205020
Total [candidate] (10.621 s) : 0, 10621247
section iast
Agent [baseline] (1.199 s) : 0, 1198600
Total [baseline] (10.854 s) : 0, 10854170
Agent [candidate] (1.194 s) : 0, 1193556
Total [candidate] (10.869 s) : 0, 10869380
section profiling
Agent [baseline] (1.264 s) : 0, 1263658
Total [baseline] (10.611 s) : 0, 10610757
Agent [candidate] (1.275 s) : 0, 1274662
Total [candidate] (10.704 s) : 0, 10704029
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.202 s 130.101 ms (12.1%)
Agent iast 1.199 s 126.546 ms (11.8%)
Agent profiling 1.264 s 191.604 ms (17.9%)
Total tracing 10.385 s -
Total appsec 10.591 s 206.043 ms (2.0%)
Total iast 10.854 s 469.408 ms (4.5%)
Total profiling 10.611 s 225.995 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.205 s 137.804 ms (12.9%)
Agent iast 1.194 s 126.34 ms (11.8%)
Agent profiling 1.275 s 207.446 ms (19.4%)
Total tracing 10.469 s -
Total appsec 10.621 s 152.662 ms (1.5%)
Total iast 10.869 s 400.795 ms (3.8%)
Total profiling 10.704 s 235.444 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~c8f1363a33, baseline=1.40.0-SNAPSHOT~a472c9dc91

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.993 ms) : 0, 684993
BytebuddyAgent [candidate] (681.388 ms) : 0, 681388
GlobalTracer [baseline] (312.829 ms) : 0, 312829
GlobalTracer [candidate] (311.788 ms) : 0, 311788
AppSec [baseline] (52.115 ms) : 0, 52115
AppSec [candidate] (51.997 ms) : 0, 51997
Remote Config [baseline] (720.664 µs) : 0, 721
Remote Config [candidate] (700.817 µs) : 0, 701
Telemetry [baseline] (7.595 ms) : 0, 7595
Telemetry [candidate] (7.604 ms) : 0, 7604
section appsec
BytebuddyAgent [baseline] (702.141 ms) : 0, 702141
BytebuddyAgent [candidate] (705.003 ms) : 0, 705003
GlobalTracer [baseline] (304.854 ms) : 0, 304854
GlobalTracer [candidate] (305.09 ms) : 0, 305090
AppSec [baseline] (163.336 ms) : 0, 163336
AppSec [candidate] (162.313 ms) : 0, 162313
Remote Config [baseline] (651.327 µs) : 0, 651
Remote Config [candidate] (649.879 µs) : 0, 650
Telemetry [baseline] (8.043 ms) : 0, 8043
Telemetry [candidate] (8.43 ms) : 0, 8430
IAST [baseline] (18.744 ms) : 0, 18744
IAST [candidate] (19.418 ms) : 0, 19418
section iast
BytebuddyAgent [baseline] (798.007 ms) : 0, 798007
BytebuddyAgent [candidate] (794.194 ms) : 0, 794194
GlobalTracer [baseline] (301.274 ms) : 0, 301274
GlobalTracer [candidate] (300.306 ms) : 0, 300306
AppSec [baseline] (56.158 ms) : 0, 56158
AppSec [candidate] (54.911 ms) : 0, 54911
Remote Config [baseline] (609.868 µs) : 0, 610
Remote Config [candidate] (614.75 µs) : 0, 615
Telemetry [baseline] (7.444 ms) : 0, 7444
Telemetry [candidate] (7.47 ms) : 0, 7470
IAST [baseline] (21.303 ms) : 0, 21303
IAST [candidate] (22.29 ms) : 0, 22290
section profiling
BytebuddyAgent [baseline] (674.322 ms) : 0, 674322
BytebuddyAgent [candidate] (680.417 ms) : 0, 680417
GlobalTracer [baseline] (394.443 ms) : 0, 394443
GlobalTracer [candidate] (397.899 ms) : 0, 397899
AppSec [baseline] (52.373 ms) : 0, 52373
AppSec [candidate] (52.761 ms) : 0, 52761
Remote Config [baseline] (706.215 µs) : 0, 706
Remote Config [candidate] (699.863 µs) : 0, 700
Telemetry [baseline] (7.462 ms) : 0, 7462
Telemetry [candidate] (7.46 ms) : 0, 7460
ProfilingAgent [baseline] (96.194 ms) : 0, 96194
ProfilingAgent [candidate] (96.825 ms) : 0, 96825
Profiling [baseline] (96.219 ms) : 0, 96219
Profiling [candidate] (96.849 ms) : 0, 96849
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~c8f1363a33, baseline=1.40.0-SNAPSHOT~a472c9dc91

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066333
Total [baseline] (8.546 s) : 0, 8545791
Agent [candidate] (1.066 s) : 0, 1065662
Total [candidate] (8.542 s) : 0, 8542308
section iast
Agent [baseline] (1.207 s) : 0, 1207142
Total [baseline] (9.016 s) : 0, 9016272
Agent [candidate] (1.199 s) : 0, 1198937
Total [candidate] (9.057 s) : 0, 9056998
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.193 s) : 0, 1192560
Total [baseline] (8.971 s) : 0, 8970830
Agent [candidate] (1.191 s) : 0, 1191080
Total [candidate] (8.967 s) : 0, 8966784
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1188090
Total [baseline] (8.994 s) : 0, 8993882
Agent [candidate] (1.198 s) : 0, 1197537
Total [candidate] (8.996 s) : 0, 8995593
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.207 s 140.81 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.193 s 126.227 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.188 s 121.758 ms (11.4%)
Total tracing 8.546 s -
Total iast 9.016 s 470.481 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.971 s 425.039 ms (5.0%)
Total iast_TELEMETRY_OFF 8.994 s 448.091 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.199 s 133.275 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 125.419 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.198 s 131.876 ms (12.4%)
Total tracing 8.542 s -
Total iast 9.057 s 514.69 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.967 s 424.476 ms (5.0%)
Total iast_TELEMETRY_OFF 8.996 s 453.284 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~c8f1363a33, baseline=1.40.0-SNAPSHOT~a472c9dc91

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.9 ms) : 0, 680900
BytebuddyAgent [candidate] (680.266 ms) : 0, 680266
GlobalTracer [baseline] (311.291 ms) : 0, 311291
GlobalTracer [candidate] (311.459 ms) : 0, 311459
AppSec [baseline] (52.071 ms) : 0, 52071
AppSec [candidate] (51.81 ms) : 0, 51810
Remote Config [baseline] (724.07 µs) : 0, 724
Remote Config [candidate] (730.083 µs) : 0, 730
Telemetry [baseline] (7.637 ms) : 0, 7637
Telemetry [candidate] (7.647 ms) : 0, 7647
section iast
BytebuddyAgent [baseline] (804.148 ms) : 0, 804148
BytebuddyAgent [candidate] (798.758 ms) : 0, 798758
GlobalTracer [baseline] (302.989 ms) : 0, 302989
GlobalTracer [candidate] (301.496 ms) : 0, 301496
AppSec [baseline] (53.055 ms) : 0, 53055
AppSec [candidate] (51.735 ms) : 0, 51735
Remote Config [baseline] (1.401 ms) : 0, 1401
Remote Config [candidate] (632.77 µs) : 0, 633
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.555 ms) : 0, 7555
IAST [baseline] (24.074 ms) : 0, 24074
IAST [candidate] (24.887 ms) : 0, 24887
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.139 ms) : 0, 793139
BytebuddyAgent [candidate] (792.162 ms) : 0, 792162
GlobalTracer [baseline] (300.132 ms) : 0, 300132
GlobalTracer [candidate] (299.859 ms) : 0, 299859
AppSec [baseline] (53.515 ms) : 0, 53515
AppSec [candidate] (52.781 ms) : 0, 52781
Remote Config [baseline] (629.726 µs) : 0, 630
Remote Config [candidate] (601.3 µs) : 0, 601
Telemetry [baseline] (8.241 ms) : 0, 8241
Telemetry [candidate] (7.361 ms) : 0, 7361
IAST [baseline] (23.117 ms) : 0, 23117
IAST [candidate] (24.563 ms) : 0, 24563
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.704 ms) : 0, 789704
BytebuddyAgent [candidate] (795.774 ms) : 0, 795774
GlobalTracer [baseline] (300.173 ms) : 0, 300173
GlobalTracer [candidate] (302.286 ms) : 0, 302286
AppSec [baseline] (53.277 ms) : 0, 53277
AppSec [candidate] (54.082 ms) : 0, 54082
Remote Config [baseline] (593.933 µs) : 0, 594
Remote Config [candidate] (607.783 µs) : 0, 608
Telemetry [baseline] (8.863 ms) : 0, 8863
Telemetry [candidate] (8.173 ms) : 0, 8173
IAST [baseline] (21.683 ms) : 0, 21683
IAST [candidate] (22.679 ms) : 0, 22679
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-12T15:24:30 2024-09-12T15:31:23
git_branch master nikita-tkachenko/test-session-name
git_commit_date 1726154176 1726154025
git_commit_sha a472c9d c8f1363
release_version 1.40.0-SNAPSHOT~a472c9dc91 1.40.0-SNAPSHOT~c8f1363a33
start_time 2024-09-12T15:24:17 2024-09-12T15:31:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726155431 1726155431
ci_job_id 637299830 637299830
ci_pipeline_id 44185222 44185222
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~c8f1363a33, baseline=1.40.0-SNAPSHOT~a472c9dc91
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1325, 1364
.   : milestone, 1345,
appsec (1.716 ms) : 1692, 1740
.   : milestone, 1716,
appsec_no_iast (1.727 ms) : 1702, 1751
.   : milestone, 1727,
iast (1.47 ms) : 1447, 1493
.   : milestone, 1470,
profiling (1.561 ms) : 1536, 1586
.   : milestone, 1561,
tracing (1.486 ms) : 1463, 1510
.   : milestone, 1486,
section candidate
no_agent (1.355 ms) : 1335, 1375
.   : milestone, 1355,
appsec (1.729 ms) : 1702, 1756
.   : milestone, 1729,
appsec_no_iast (1.729 ms) : 1705, 1752
.   : milestone, 1729,
iast (1.482 ms) : 1459, 1506
.   : milestone, 1482,
profiling (1.515 ms) : 1491, 1540
.   : milestone, 1515,
tracing (1.472 ms) : 1449, 1496
.   : milestone, 1472,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.325 ms, 1.364 ms] -
appsec 1.716 ms [1.692 ms, 1.74 ms] 370.892 µs (27.6%)
appsec_no_iast 1.727 ms [1.702 ms, 1.751 ms] 381.887 µs (28.4%)
iast 1.47 ms [1.447 ms, 1.493 ms] 125.218 µs (9.3%)
profiling 1.561 ms [1.536 ms, 1.586 ms] 215.955 µs (16.1%)
tracing 1.486 ms [1.463 ms, 1.51 ms] 141.653 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.375 ms] -
appsec 1.729 ms [1.702 ms, 1.756 ms] 374.547 µs (27.6%)
appsec_no_iast 1.729 ms [1.705 ms, 1.752 ms] 373.804 µs (27.6%)
iast 1.482 ms [1.459 ms, 1.506 ms] 127.754 µs (9.4%)
profiling 1.515 ms [1.491 ms, 1.54 ms] 160.555 µs (11.9%)
tracing 1.472 ms [1.449 ms, 1.496 ms] 117.713 µs (8.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~c8f1363a33, baseline=1.40.0-SNAPSHOT~a472c9dc91
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.793 µs) : 357, 397
.   : milestone, 377,
iast (490.061 µs) : 468, 512
.   : milestone, 490,
iast_FULL (558.195 µs) : 537, 579
.   : milestone, 558,
iast_GLOBAL (509.603 µs) : 488, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (489.381 µs) : 467, 511
.   : milestone, 489,
iast_INACTIVE (454.397 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (489.399 µs) : 466, 512
.   : milestone, 489,
tracing (447.257 µs) : 427, 468
.   : milestone, 447,
section candidate
no_agent (379.335 µs) : 358, 401
.   : milestone, 379,
iast (485.18 µs) : 464, 506
.   : milestone, 485,
iast_FULL (553.942 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (510.135 µs) : 488, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (486.109 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (446.021 µs) : 426, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (486.179 µs) : 463, 509
.   : milestone, 486,
tracing (447.517 µs) : 427, 468
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.793 µs [356.757 µs, 396.829 µs] -
iast 490.061 µs [467.725 µs, 512.396 µs] 113.268 µs (30.1%)
iast_FULL 558.195 µs [536.991 µs, 579.398 µs] 181.402 µs (48.1%)
iast_GLOBAL 509.603 µs [488.459 µs, 530.747 µs] 132.81 µs (35.2%)
iast_HARDCODED_SECRET_DISABLED 489.381 µs [467.415 µs, 511.348 µs] 112.588 µs (29.9%)
iast_INACTIVE 454.397 µs [433.344 µs, 475.451 µs] 77.604 µs (20.6%)
iast_TELEMETRY_OFF 489.399 µs [466.407 µs, 512.391 µs] 112.606 µs (29.9%)
tracing 447.257 µs [426.999 µs, 467.514 µs] 70.464 µs (18.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.335 µs [357.503 µs, 401.167 µs] -
iast 485.18 µs [464.128 µs, 506.232 µs] 105.845 µs (27.9%)
iast_FULL 553.942 µs [532.812 µs, 575.071 µs] 174.607 µs (46.0%)
iast_GLOBAL 510.135 µs [488.419 µs, 531.851 µs] 130.8 µs (34.5%)
iast_HARDCODED_SECRET_DISABLED 486.109 µs [465.128 µs, 507.091 µs] 106.774 µs (28.1%)
iast_INACTIVE 446.021 µs [425.696 µs, 466.346 µs] 66.686 µs (17.6%)
iast_TELEMETRY_OFF 486.179 µs [463.152 µs, 509.207 µs] 106.844 µs (28.2%)
tracing 447.517 µs [426.711 µs, 468.324 µs] 68.182 µs (18.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/test-session-name
git_commit_date 1726154176 1726154025
git_commit_sha a472c9d c8f1363
release_version 1.40.0-SNAPSHOT~a472c9dc91 1.40.0-SNAPSHOT~c8f1363a33
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726155956 1726155956
ci_job_id 637299833 637299833
ci_pipeline_id 44185222 44185222
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~c8f1363a33, baseline=1.40.0-SNAPSHOT~a472c9dc91
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.301 ms) : 2261, 2341
.   : milestone, 2301,
iast (2.064 ms) : 2016, 2113
.   : milestone, 2064,
iast_GLOBAL (2.12 ms) : 2070, 2171
.   : milestone, 2120,
profiling (2.374 ms) : 2198, 2551
.   : milestone, 2374,
tracing (1.904 ms) : 1866, 1941
.   : milestone, 1904,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.305 ms) : 2265, 2345
.   : milestone, 2305,
iast (2.059 ms) : 2009, 2109
.   : milestone, 2059,
iast_GLOBAL (2.103 ms) : 2053, 2154
.   : milestone, 2103,
profiling (2.361 ms) : 2122, 2600
.   : milestone, 2361,
tracing (1.919 ms) : 1881, 1958
.   : milestone, 1919,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.301 ms [2.261 ms, 2.341 ms] 826.995 µs (56.1%)
iast 2.064 ms [2.016 ms, 2.113 ms] 590.31 µs (40.0%)
iast_GLOBAL 2.12 ms [2.07 ms, 2.171 ms] 646.214 µs (43.8%)
profiling 2.374 ms [2.198 ms, 2.551 ms] 900.235 µs (61.1%)
tracing 1.904 ms [1.866 ms, 1.941 ms] 429.494 µs (29.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.305 ms [2.265 ms, 2.345 ms] 836.483 µs (57.0%)
iast 2.059 ms [2.009 ms, 2.109 ms] 590.194 µs (40.2%)
iast_GLOBAL 2.103 ms [2.053 ms, 2.154 ms] 634.823 µs (43.2%)
profiling 2.361 ms [2.122 ms, 2.6 ms] 892.668 µs (60.8%)
tracing 1.919 ms [1.881 ms, 1.958 ms] 450.495 µs (30.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~c8f1363a33, baseline=1.40.0-SNAPSHOT~a472c9dc91
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.707 s) : 15707000, 15707000
.   : milestone, 15707000,
appsec (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
iast (19.319 s) : 19319000, 19319000
.   : milestone, 19319000,
iast_GLOBAL (18.246 s) : 18246000, 18246000
.   : milestone, 18246000,
profiling (15.261 s) : 15261000, 15261000
.   : milestone, 15261000,
tracing (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
section candidate
no_agent (14.941 s) : 14941000, 14941000
.   : milestone, 14941000,
appsec (15.168 s) : 15168000, 15168000
.   : milestone, 15168000,
iast (19.097 s) : 19097000, 19097000
.   : milestone, 19097000,
iast_GLOBAL (18.212 s) : 18212000, 18212000
.   : milestone, 18212000,
profiling (15.303 s) : 15303000, 15303000
.   : milestone, 15303000,
tracing (15.035 s) : 15035000, 15035000
.   : milestone, 15035000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.707 s [15.707 s, 15.707 s] -
appsec 15.026 s [15.026 s, 15.026 s] -681.0 ms (-4.3%)
iast 19.319 s [19.319 s, 19.319 s] 3.612 s (23.0%)
iast_GLOBAL 18.246 s [18.246 s, 18.246 s] 2.539 s (16.2%)
profiling 15.261 s [15.261 s, 15.261 s] -446.0 ms (-2.8%)
tracing 15.016 s [15.016 s, 15.016 s] -691.0 ms (-4.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.941 s [14.941 s, 14.941 s] -
appsec 15.168 s [15.168 s, 15.168 s] 227.0 ms (1.5%)
iast 19.097 s [19.097 s, 19.097 s] 4.156 s (27.8%)
iast_GLOBAL 18.212 s [18.212 s, 18.212 s] 3.271 s (21.9%)
profiling 15.303 s [15.303 s, 15.303 s] 362.0 ms (2.4%)
tracing 15.035 s [15.035 s, 15.035 s] 94.0 ms (0.6%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review September 13, 2024 08:22
smola
smola approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@smola smola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: complained about missing info in description but it was actually there, enough reviews for today 😂

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 7108ba0 into master Sep 16, 2024
97 of 98 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/test-session-name branch September 16, 2024 08:50
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyredondo tonyredondo Awaiting requested review from tonyredondo tonyredondo is a code owner automatically assigned from DataDog/ci-app-libraries-java

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @smola