Implement the DebuggerProbe #7588

evanchooly · 2024-09-09T21:16:20Z

What Does This Do

Implement the DebuggerProbe as defined in the RFC as well as some related changes from the Code Origin for Spans RFC

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-2719

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/DebuggerProbe.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/Configuration.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/DebuggerProbe.java

.../agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerProductChangesListener.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/DebuggerProbe.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/Configuration.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/DebuggerProbe.java

.../agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerProductChangesListener.java

evanchooly · 2024-09-09T21:40:02Z

I don't know where that submodule came or how to get rid of it if anyone has any advice. do I just delete that folder locally and repush to my branch?

...ent/agent-debugger/src/main/java/com/datadog/debugger/codeorigin/CodeOriginProbeManager.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/CodeOriginProbe.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/DebuggerProbe.java

dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java

...gger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/spanorigin/CodeOriginInfo.java

...ent/agent-debugger/src/main/java/com/datadog/debugger/codeorigin/CodeOriginProbeManager.java

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/CodeOriginProbe.java

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/probe/DebuggerProbeTest.java

pr-commenter · 2024-09-10T14:52:05Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1726014898	1726015278
end_time	2024-09-11T00:36:13	2024-09-11T00:42:34
git_branch	master	evanchooly/DEBUG-2719
git_commit_sha	`04db2f0`	`de6b0c4`
start_time	2024-09-11T00:34:59	2024-09-11T00:41:19

See matching parameters

	Baseline	Candidate
ci_job_id	634792883	634792883
ci_pipeline_id	44038369	44038369
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1726014231	1726014231

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 9 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	better [-285.821µs; -197.610µs] or [-2.753%; -1.903%]	better [-305.984µs; -187.815µs] or [-2.897%; -1.778%]	better [-315.595µs; -170.699µs] or [-2.961%; -1.602%]	unsure [-504.804µs; -86.523µs] or [-4.561%; -0.782%]	unsure [+0.916op/s; +3.556op/s] or [+0.980%; +3.805%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-55.351µs; +61.770µs] or [-19.969%; +22.285%]	unstable [-67.065µs; +73.658µs] or [-21.142%; +23.221%]	unstable [-80.538µs; +86.537µs] or [-24.170%; +25.971%]	unstable [-877.158µs; +868.657µs] or [-97.490%; +96.545%]	unstable [-177.217op/s; +107.041op/s] or [-6.646%; +4.014%]
scenario:basic	same	unstable [-12.986µs; +23.870µs] or [-4.350%; +7.996%]	unstable [-20.813µs; +28.942µs] or [-6.680%; +9.289%]	unstable [-89.413µs; +71.270µs] or [-15.958%; +12.720%]	unstable [-268.350op/s; +133.397op/s] or [-10.197%; +5.069%]

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (317.208 µs) : 251, 384
.   : milestone, 317,
basic (298.518 µs) : 280, 317
.   : milestone, 299,
loop (10.562 ms) : 10498, 10627
.   : milestone, 10562,
section candidate
noprobe (320.504 µs) : 253, 388
.   : milestone, 321,
basic (303.96 µs) : 287, 321
.   : milestone, 304,
loop (10.315 ms) : 10272, 10358
.   : milestone, 10315,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	317.208 µs [250.834 µs, 383.582 µs]
basic	298.518 µs [279.628 µs, 317.408 µs]
loop	10.562 ms [10.498 ms, 10.627 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	320.504 µs [252.68 µs, 388.329 µs]
basic	303.96 µs [286.81 µs, 321.11 µs]
loop	10.315 ms [10.272 ms, 10.358 ms]

pr-commenter · 2024-09-10T15:08:55Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-2719
git_commit_date	1725979768	1726014231
git_commit_sha	`04db2f0`	`de6b0c4`
release_version	1.40.0-SNAPSHOT~04db2f0bfb	1.40.0-SNAPSHOT~de6b0c4d70

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1726016729	1726016729
ci_job_id	634792877	634792877
ci_pipeline_id	44038369	44038369
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~de6b0c4d70, baseline=1.40.0-SNAPSHOT~04db2f0bfb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064240
Total [baseline] (8.514 s) : 0, 8514326
Agent [candidate] (1.071 s) : 0, 1070610
Total [candidate] (8.524 s) : 0, 8523868
section iast
Agent [baseline] (1.186 s) : 0, 1185801
Total [baseline] (8.964 s) : 0, 8963995
Agent [candidate] (1.189 s) : 0, 1188604
Total [candidate] (8.973 s) : 0, 8972966
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.195 s) : 0, 1195360
Total [baseline] (8.943 s) : 0, 8943393
Agent [candidate] (1.186 s) : 0, 1185792
Total [candidate] (8.946 s) : 0, 8945860
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1184184
Total [baseline] (8.954 s) : 0, 8954332
Agent [candidate] (1.186 s) : 0, 1185502
Total [candidate] (8.961 s) : 0, 8961044

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	iast	1.186 s	121.561 ms (11.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.195 s	131.12 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.184 s	119.944 ms (11.3%)
Total	tracing	8.514 s	-
Total	iast	8.964 s	449.669 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.943 s	429.066 ms (5.0%)
Total	iast_TELEMETRY_OFF	8.954 s	440.005 ms (5.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.071 s	-
Agent	iast	1.189 s	117.994 ms (11.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.186 s	115.183 ms (10.8%)
Agent	iast_TELEMETRY_OFF	1.186 s	114.892 ms (10.7%)
Total	tracing	8.524 s	-
Total	iast	8.973 s	449.097 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.946 s	421.992 ms (5.0%)
Total	iast_TELEMETRY_OFF	8.961 s	437.175 ms (5.1%)

gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~de6b0c4d70, baseline=1.40.0-SNAPSHOT~04db2f0bfb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.567 ms) : 0, 679567
BytebuddyAgent [candidate] (684.061 ms) : 0, 684061
GlobalTracer [baseline] (311.122 ms) : 0, 311122
GlobalTracer [candidate] (312.352 ms) : 0, 312352
AppSec [baseline] (51.633 ms) : 0, 51633
AppSec [candidate] (52.099 ms) : 0, 52099
Remote Config [baseline] (715.966 µs) : 0, 716
Remote Config [candidate] (728.01 µs) : 0, 728
Telemetry [baseline] (7.519 ms) : 0, 7519
Telemetry [candidate] (7.596 ms) : 0, 7596
section iast
BytebuddyAgent [baseline] (789.488 ms) : 0, 789488
BytebuddyAgent [candidate] (790.922 ms) : 0, 790922
GlobalTracer [baseline] (298.347 ms) : 0, 298347
GlobalTracer [candidate] (299.192 ms) : 0, 299192
AppSec [baseline] (53.538 ms) : 0, 53538
AppSec [candidate] (52.343 ms) : 0, 52343
IAST [baseline] (21.985 ms) : 0, 21985
IAST [candidate] (24.433 ms) : 0, 24433
Remote Config [baseline] (1.383 ms) : 0, 1383
Remote Config [candidate] (667.719 µs) : 0, 668
Telemetry [baseline] (7.433 ms) : 0, 7433
Telemetry [candidate] (7.355 ms) : 0, 7355
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.899 ms) : 0, 795899
BytebuddyAgent [candidate] (789.31 ms) : 0, 789310
GlobalTracer [baseline] (300.338 ms) : 0, 300338
GlobalTracer [candidate] (298.686 ms) : 0, 298686
AppSec [baseline] (51.136 ms) : 0, 51136
AppSec [candidate] (53.298 ms) : 0, 53298
IAST [baseline] (24.686 ms) : 0, 24686
IAST [candidate] (22.054 ms) : 0, 22054
Remote Config [baseline] (614.042 µs) : 0, 614
Remote Config [candidate] (614.034 µs) : 0, 614
Telemetry [baseline] (8.94 ms) : 0, 8940
Telemetry [candidate] (8.186 ms) : 0, 8186
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.153 ms) : 0, 787153
BytebuddyAgent [candidate] (787.944 ms) : 0, 787944
GlobalTracer [baseline] (299.255 ms) : 0, 299255
GlobalTracer [candidate] (299.319 ms) : 0, 299319
AppSec [baseline] (52.243 ms) : 0, 52243
AppSec [candidate] (53.294 ms) : 0, 53294
IAST [baseline] (22.417 ms) : 0, 22417
IAST [candidate] (22.51 ms) : 0, 22510
Remote Config [baseline] (609.336 µs) : 0, 609
Remote Config [candidate] (677.656 µs) : 0, 678
Telemetry [baseline] (8.834 ms) : 0, 8834
Telemetry [candidate] (8.04 ms) : 0, 8040

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~de6b0c4d70, baseline=1.40.0-SNAPSHOT~04db2f0bfb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062442
Total [baseline] (10.388 s) : 0, 10387813
Agent [candidate] (1.064 s) : 0, 1064072
Total [candidate] (10.42 s) : 0, 10419818
section appsec
Agent [baseline] (1.2 s) : 0, 1199759
Total [baseline] (10.622 s) : 0, 10621865
Agent [candidate] (1.198 s) : 0, 1197531
Total [candidate] (10.565 s) : 0, 10565299
section iast
Agent [baseline] (1.187 s) : 0, 1187035
Total [baseline] (10.85 s) : 0, 10850052
Agent [candidate] (1.2 s) : 0, 1200326
Total [candidate] (10.797 s) : 0, 10796713
section profiling
Agent [baseline] (1.257 s) : 0, 1256822
Total [baseline] (10.563 s) : 0, 10563072
Agent [candidate] (1.263 s) : 0, 1262585
Total [candidate] (10.623 s) : 0, 10622697

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	appsec	1.2 s	137.317 ms (12.9%)
Agent	iast	1.187 s	124.593 ms (11.7%)
Agent	profiling	1.257 s	194.38 ms (18.3%)
Total	tracing	10.388 s	-
Total	appsec	10.622 s	234.052 ms (2.3%)
Total	iast	10.85 s	462.239 ms (4.4%)
Total	profiling	10.563 s	175.259 ms (1.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	appsec	1.198 s	133.459 ms (12.5%)
Agent	iast	1.2 s	136.254 ms (12.8%)
Agent	profiling	1.263 s	198.512 ms (18.7%)
Total	tracing	10.42 s	-
Total	appsec	10.565 s	145.481 ms (1.4%)
Total	iast	10.797 s	376.895 ms (3.6%)
Total	profiling	10.623 s	202.878 ms (1.9%)

gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~de6b0c4d70, baseline=1.40.0-SNAPSHOT~04db2f0bfb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.583 ms) : 0, 678583
BytebuddyAgent [candidate] (679.526 ms) : 0, 679526
GlobalTracer [baseline] (310.257 ms) : 0, 310257
GlobalTracer [candidate] (310.768 ms) : 0, 310768
AppSec [baseline] (51.795 ms) : 0, 51795
AppSec [candidate] (51.808 ms) : 0, 51808
Remote Config [baseline] (719.99 µs) : 0, 720
Remote Config [candidate] (727.022 µs) : 0, 727
Telemetry [baseline] (7.491 ms) : 0, 7491
Telemetry [candidate] (7.565 ms) : 0, 7565
section appsec
BytebuddyAgent [baseline] (701.586 ms) : 0, 701586
BytebuddyAgent [candidate] (699.942 ms) : 0, 699942
GlobalTracer [baseline] (304.305 ms) : 0, 304305
GlobalTracer [candidate] (303.843 ms) : 0, 303843
AppSec [baseline] (161.131 ms) : 0, 161131
AppSec [candidate] (161.94 ms) : 0, 161940
IAST [baseline] (19.531 ms) : 0, 19531
IAST [candidate] (19.732 ms) : 0, 19732
Remote Config [baseline] (643.564 µs) : 0, 644
Remote Config [candidate] (646.803 µs) : 0, 647
Telemetry [baseline] (8.661 ms) : 0, 8661
Telemetry [candidate] (7.598 ms) : 0, 7598
section iast
BytebuddyAgent [baseline] (789.941 ms) : 0, 789941
BytebuddyAgent [candidate] (800.186 ms) : 0, 800186
GlobalTracer [baseline] (298.836 ms) : 0, 298836
GlobalTracer [candidate] (301.235 ms) : 0, 301235
AppSec [baseline] (53.131 ms) : 0, 53131
AppSec [candidate] (54.042 ms) : 0, 54042
IAST [baseline] (22.667 ms) : 0, 22667
IAST [candidate] (23.013 ms) : 0, 23013
Remote Config [baseline] (1.421 ms) : 0, 1421
Remote Config [candidate] (616.787 µs) : 0, 617
Telemetry [baseline] (7.4 ms) : 0, 7400
Telemetry [candidate] (7.42 ms) : 0, 7420
section profiling
BytebuddyAgent [baseline] (670.758 ms) : 0, 670758
BytebuddyAgent [candidate] (673.859 ms) : 0, 673859
GlobalTracer [baseline] (391.796 ms) : 0, 391796
GlobalTracer [candidate] (394.002 ms) : 0, 394002
AppSec [baseline] (52.366 ms) : 0, 52366
AppSec [candidate] (52.285 ms) : 0, 52285
Remote Config [baseline] (708.435 µs) : 0, 708
Remote Config [candidate] (713.55 µs) : 0, 714
Telemetry [baseline] (7.444 ms) : 0, 7444
Telemetry [candidate] (7.445 ms) : 0, 7445
ProfilingAgent [baseline] (95.859 ms) : 0, 95859
ProfilingAgent [candidate] (96.073 ms) : 0, 96073
Profiling [baseline] (95.883 ms) : 0, 95883
Profiling [candidate] (96.097 ms) : 0, 96097

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-09-11T00:36:11	2024-09-11T00:43:04
git_branch	master	evanchooly/DEBUG-2719
git_commit_date	1725979768	1726014231
git_commit_sha	`04db2f0`	`de6b0c4`
release_version	1.40.0-SNAPSHOT~04db2f0bfb	1.40.0-SNAPSHOT~de6b0c4d70
start_time	2024-09-11T00:35:57	2024-09-11T00:42:50

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1726015732	1726015732
ci_job_id	634792878	634792878
ci_pipeline_id	44038369	44038369
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~de6b0c4d70, baseline=1.40.0-SNAPSHOT~04db2f0bfb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1371
.   : milestone, 1351,
appsec (1.726 ms) : 1703, 1749
.   : milestone, 1726,
appsec_no_iast (1.733 ms) : 1707, 1758
.   : milestone, 1733,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.533 ms) : 1508, 1558
.   : milestone, 1533,
tracing (1.481 ms) : 1457, 1504
.   : milestone, 1481,
section candidate
no_agent (1.35 ms) : 1330, 1370
.   : milestone, 1350,
appsec (1.712 ms) : 1688, 1737
.   : milestone, 1712,
appsec_no_iast (1.756 ms) : 1732, 1779
.   : milestone, 1756,
iast (1.494 ms) : 1471, 1517
.   : milestone, 1494,
profiling (1.536 ms) : 1511, 1560
.   : milestone, 1536,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.332 ms, 1.371 ms]	-
appsec	1.726 ms [1.703 ms, 1.749 ms]	374.726 µs (27.7%)
appsec_no_iast	1.733 ms [1.707 ms, 1.758 ms]	381.499 µs (28.2%)
iast	1.478 ms [1.455 ms, 1.501 ms]	126.522 µs (9.4%)
profiling	1.533 ms [1.508 ms, 1.558 ms]	181.908 µs (13.5%)
tracing	1.481 ms [1.457 ms, 1.504 ms]	129.457 µs (9.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.33 ms, 1.37 ms]	-
appsec	1.712 ms [1.688 ms, 1.737 ms]	362.787 µs (26.9%)
appsec_no_iast	1.756 ms [1.732 ms, 1.779 ms]	406.147 µs (30.1%)
iast	1.494 ms [1.471 ms, 1.517 ms]	144.71 µs (10.7%)
profiling	1.536 ms [1.511 ms, 1.56 ms]	185.881 µs (13.8%)
tracing	1.482 ms [1.458 ms, 1.506 ms]	132.558 µs (9.8%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~de6b0c4d70, baseline=1.40.0-SNAPSHOT~04db2f0bfb
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.4 µs) : 359, 398
.   : milestone, 378,
iast (496.806 µs) : 475, 518
.   : milestone, 497,
iast_FULL (553.354 µs) : 532, 575
.   : milestone, 553,
iast_GLOBAL (512.814 µs) : 491, 534
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (487.66 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (448.533 µs) : 428, 469
.   : milestone, 449,
iast_TELEMETRY_OFF (475.815 µs) : 453, 499
.   : milestone, 476,
tracing (443.821 µs) : 423, 464
.   : milestone, 444,
section candidate
no_agent (372.545 µs) : 353, 392
.   : milestone, 373,
iast (496.7 µs) : 474, 519
.   : milestone, 497,
iast_FULL (554.299 µs) : 533, 576
.   : milestone, 554,
iast_GLOBAL (510.746 µs) : 489, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (493.262 µs) : 471, 515
.   : milestone, 493,
iast_INACTIVE (453.921 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (480.804 µs) : 458, 504
.   : milestone, 481,
tracing (441.981 µs) : 422, 462
.   : milestone, 442,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.4 µs [358.875 µs, 397.924 µs]	-
iast	496.806 µs [475.454 µs, 518.158 µs]	118.406 µs (31.3%)
iast_FULL	553.354 µs [532.125 µs, 574.584 µs]	174.954 µs (46.2%)
iast_GLOBAL	512.814 µs [491.251 µs, 534.376 µs]	134.414 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED	487.66 µs [466.003 µs, 509.318 µs]	109.261 µs (28.9%)
iast_INACTIVE	448.533 µs [427.576 µs, 469.491 µs]	70.134 µs (18.5%)
iast_TELEMETRY_OFF	475.815 µs [452.931 µs, 498.699 µs]	97.415 µs (25.7%)
tracing	443.821 µs [423.24 µs, 464.403 µs]	65.422 µs (17.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.545 µs [352.748 µs, 392.343 µs]	-
iast	496.7 µs [474.444 µs, 518.956 µs]	124.155 µs (33.3%)
iast_FULL	554.299 µs [532.966 µs, 575.633 µs]	181.754 µs (48.8%)
iast_GLOBAL	510.746 µs [489.013 µs, 532.48 µs]	138.201 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED	493.262 µs [471.453 µs, 515.071 µs]	120.717 µs (32.4%)
iast_INACTIVE	453.921 µs [432.503 µs, 475.338 µs]	81.376 µs (21.8%)
iast_TELEMETRY_OFF	480.804 µs [457.873 µs, 503.734 µs]	108.258 µs (29.1%)
tracing	441.981 µs [421.806 µs, 462.157 µs]	69.436 µs (18.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-2719
git_commit_date	1725979768	1726014231
git_commit_sha	`04db2f0`	`de6b0c4`
release_version	1.40.0-SNAPSHOT~04db2f0bfb	1.40.0-SNAPSHOT~de6b0c4d70

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1726016282	1726016282
ci_job_id	634792879	634792879
ci_pipeline_id	44038369	44038369
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~de6b0c4d70, baseline=1.40.0-SNAPSHOT~04db2f0bfb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.299 ms) : 2258, 2339
.   : milestone, 2299,
iast (2.062 ms) : 2013, 2112
.   : milestone, 2062,
iast_GLOBAL (2.112 ms) : 2061, 2163
.   : milestone, 2112,
profiling (2.194 ms) : 2046, 2342
.   : milestone, 2194,
tracing (1.906 ms) : 1868, 1945
.   : milestone, 1906,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.3 ms) : 2260, 2341
.   : milestone, 2300,
iast (2.036 ms) : 1988, 2084
.   : milestone, 2036,
iast_GLOBAL (2.106 ms) : 2056, 2155
.   : milestone, 2106,
profiling (1.922 ms) : 1881, 1963
.   : milestone, 1922,
tracing (1.909 ms) : 1871, 1948
.   : milestone, 1909,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.466 ms [1.454 ms, 1.477 ms]	-
appsec	2.299 ms [2.258 ms, 2.339 ms]	833.213 µs (56.9%)
iast	2.062 ms [2.013 ms, 2.112 ms]	596.835 µs (40.7%)
iast_GLOBAL	2.112 ms [2.061 ms, 2.163 ms]	646.273 µs (44.1%)
profiling	2.194 ms [2.046 ms, 2.342 ms]	728.547 µs (49.7%)
tracing	1.906 ms [1.868 ms, 1.945 ms]	440.73 µs (30.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.3 ms [2.26 ms, 2.341 ms]	828.319 µs (56.3%)
iast	2.036 ms [1.988 ms, 2.084 ms]	563.771 µs (38.3%)
iast_GLOBAL	2.106 ms [2.056 ms, 2.155 ms]	633.615 µs (43.0%)
profiling	1.922 ms [1.881 ms, 1.963 ms]	450.014 µs (30.6%)
tracing	1.909 ms [1.871 ms, 1.948 ms]	437.076 µs (29.7%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~de6b0c4d70, baseline=1.40.0-SNAPSHOT~04db2f0bfb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
appsec (15.617 s) : 15617000, 15617000
.   : milestone, 15617000,
iast (18.878 s) : 18878000, 18878000
.   : milestone, 18878000,
iast_GLOBAL (17.881 s) : 17881000, 17881000
.   : milestone, 17881000,
profiling (16.177 s) : 16177000, 16177000
.   : milestone, 16177000,
tracing (14.779 s) : 14779000, 14779000
.   : milestone, 14779000,
section candidate
no_agent (15.217 s) : 15217000, 15217000
.   : milestone, 15217000,
appsec (15.325 s) : 15325000, 15325000
.   : milestone, 15325000,
iast (18.982 s) : 18982000, 18982000
.   : milestone, 18982000,
iast_GLOBAL (18.204 s) : 18204000, 18204000
.   : milestone, 18204000,
profiling (15.444 s) : 15444000, 15444000
.   : milestone, 15444000,
tracing (15.316 s) : 15316000, 15316000
.   : milestone, 15316000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.075 s [15.075 s, 15.075 s]	-
appsec	15.617 s [15.617 s, 15.617 s]	542.0 ms (3.6%)
iast	18.878 s [18.878 s, 18.878 s]	3.803 s (25.2%)
iast_GLOBAL	17.881 s [17.881 s, 17.881 s]	2.806 s (18.6%)
profiling	16.177 s [16.177 s, 16.177 s]	1.102 s (7.3%)
tracing	14.779 s [14.779 s, 14.779 s]	-296.0 ms (-2.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.217 s [15.217 s, 15.217 s]	-
appsec	15.325 s [15.325 s, 15.325 s]	108.0 ms (0.7%)
iast	18.982 s [18.982 s, 18.982 s]	3.765 s (24.7%)
iast_GLOBAL	18.204 s [18.204 s, 18.204 s]	2.987 s (19.6%)
profiling	15.444 s [15.444 s, 15.444 s]	227.0 ms (1.5%)
tracing	15.316 s [15.316 s, 15.316 s]	99.0 ms (0.7%)

add some tests some clean up

stop walking the stack at the first hit since that's all we use anyway.

jpbempel · 2024-09-11T07:57:14Z

.../agent-debugger/src/main/java/com/datadog/debugger/codeorigin/DefaultCodeOriginRecorder.java

+
+import datadog.trace.bootstrap.debugger.DebuggerContext.CodeOriginRecorder;
+
+public class DefaultCodeOriginRecorder implements CodeOriginRecorder {


Honestly, I think this class is useless: we could implement CodeOriginRecorder in CodeOriginPRobeManager there is no added value here.
Could be done in a next PR

i 100% agree. this is all an outgrowth of mimicking the exception probe stuff but has felt overly convoluted for a while now. I'd really love to clean it up but have been waiting to get it working first. it's high on my list to clean up post-PR.

jpbempel · 2024-09-11T08:06:28Z

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/CodeOriginProbe.java

+    if (localRootSpan.getTag(getId()) != null) {
+      span = (AgentSpan) localRootSpan.getTag(getId());
+    }


Object probeTag = localRootSpan.getTag(getId()); if (probeTag != null) { span = (AgentSpan) probeTag; }

Can be done later

jpbempel · 2024-09-11T08:23:11Z

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/DebuggerProbe.java

+  @Override
+  public InstrumentationResult.Status instrument(
+      MethodInfo methodInfo, List<DiagnosticMessage> diagnostics, List<ProbeId> probeIds) {
+    return new CapturedContextInstrumentor(this, methodInfo, diagnostics, probeIds, false, null)


This is not the best way to do it. It's overkill for just a callback on evaluate.
If we add condition that requires to evaluate the context then yes it makes sense. otherwise I think we need a dedicated instrumentor that avoid capturing for nothing

i was just pondering this issue, actually. we should talk this one through and aim for a future iteration to streamline that.

jpbempel

LGTM , my last major concern is about instrumentor

evanchooly added 4 commits September 6, 2024 16:59

Implement the DebuggerProbe

9b6cc13

WIP

8cd4b40

some tidying, fixing of json structures

87d0a4b

exit spans should not be tagged

0026f35

evanchooly requested review from a team as code owners September 9, 2024 21:16

evanchooly requested review from jpbempel and nayeem-kamal and removed request for a team September 9, 2024 21:16

datadog-datadog-prod-us1 bot reviewed Sep 9, 2024

View reviewed changes

Merge branch 'master' into evanchooly/DEBUG-2719

2de3ffb

shatzi approved these changes Sep 10, 2024

View reviewed changes

jpbempel reviewed Sep 10, 2024

View reviewed changes

PR cleanups

13c8c9f

evanchooly added 3 commits September 10, 2024 14:19

fix the location of exit span stack traces

4024d8a

add some tests some clean up

fixes for exit spans

fa4af98

rename a constant

de6b0c4

stop walking the stack at the first hit since that's all we use anyway.

jpbempel reviewed Sep 11, 2024

View reviewed changes

jpbempel approved these changes Sep 11, 2024

View reviewed changes

evanchooly merged commit 4abf841 into master Sep 11, 2024
99 of 100 checks passed

evanchooly deleted the evanchooly/DEBUG-2719 branch September 11, 2024 13:56

github-actions bot added this to the 1.40.0 milestone Sep 11, 2024

PerfectSlayer added a commit that referenced this pull request Sep 12, 2024

fix: Restore jmx-fetch integration-core from #7588

e69a859

PerfectSlayer mentioned this pull request Sep 12, 2024

Restore jmx-fetch integration-core from #7588 #7611

Merged

5 tasks

PerfectSlayer added a commit that referenced this pull request Sep 12, 2024

fix: Restore jmx-fetch integration-core from #7588 (#7611)

435a1d2

smola added the comp: debugger Dynamic Instrumentation label Sep 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement the DebuggerProbe #7588

Implement the DebuggerProbe #7588

evanchooly commented Sep 9, 2024

evanchooly commented Sep 9, 2024

pr-commenter bot commented Sep 10, 2024 •

edited

Loading

pr-commenter bot commented Sep 10, 2024 •

edited

Loading

jpbempel Sep 11, 2024

evanchooly Sep 11, 2024

jpbempel Sep 11, 2024

jpbempel Sep 11, 2024

evanchooly Sep 11, 2024

jpbempel left a comment


		import datadog.trace.bootstrap.debugger.DebuggerContext.CodeOriginRecorder;

		public class DefaultCodeOriginRecorder implements CodeOriginRecorder {

Implement the DebuggerProbe #7588

Implement the DebuggerProbe #7588

Conversation

evanchooly commented Sep 9, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

evanchooly commented Sep 9, 2024

pr-commenter bot commented Sep 10, 2024 • edited Loading

Debugger benchmarks

Parameters

Summary

pr-commenter bot commented Sep 10, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

jpbempel Sep 11, 2024

Choose a reason for hiding this comment

evanchooly Sep 11, 2024

Choose a reason for hiding this comment

jpbempel Sep 11, 2024

Choose a reason for hiding this comment

jpbempel Sep 11, 2024

Choose a reason for hiding this comment

evanchooly Sep 11, 2024

Choose a reason for hiding this comment

jpbempel left a comment

Choose a reason for hiding this comment

pr-commenter bot commented Sep 10, 2024 •

edited

Loading

pr-commenter bot commented Sep 10, 2024 •

edited

Loading