Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring scheduling: ensure spans have no parent #7583

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Spring scheduling: ensure spans have no parent #7583

merged 3 commits into from
Sep 10, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

According to our tests the spring scheduling spans should have no parent. This PR ensure that the spans are created with a noop parent scope. Temporary, I also added a way to restore the old behaviour (that's nondeterministic anyway) by

  • the sys prop -Ddd.spring-scheduling.legacy.tracing.enabled=true
  • the env DD_SPRING_SCHEDULING_LEGACY_TRACING_ENABLED=true

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner September 9, 2024 13:30
@amarziali amarziali requested a review from mcculls September 9, 2024 13:51
@amarziali amarziali enabled auto-merge (squash) September 9, 2024 13:51
@amarziali amarziali added type: bug inst: spring Spring instrumentation labels Sep 9, 2024
mcculls
mcculls approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 can we add a test to confirm the new behaviour?

@amarziali amarziali disabled auto-merge September 9, 2024 13:56
@pr-commenter
Copy link

pr-commenter bot commented Sep 9, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/apms-13074
git_commit_date 1725890539 1725895265
git_commit_sha 1d59e61 2a32bc0
release_version 1.40.0-SNAPSHOT~1d59e612a6 1.40.0-SNAPSHOT~2a32bc0279
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725897634 1725897634
ci_job_id 632193713 632193713
ci_pipeline_id 43871954 43871954
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~2a32bc0279, baseline=1.40.0-SNAPSHOT~1d59e612a6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051321
Total [baseline] (8.493 s) : 0, 8492707
Agent [candidate] (1.052 s) : 0, 1051912
Total [candidate] (8.503 s) : 0, 8503078
section iast
Agent [baseline] (1.175 s) : 0, 1175076
Total [baseline] (8.987 s) : 0, 8987353
Agent [candidate] (1.175 s) : 0, 1174554
Total [candidate] (8.948 s) : 0, 8947689
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1175172
Total [baseline] (8.947 s) : 0, 8946550
Agent [candidate] (1.184 s) : 0, 1183903
Total [candidate] (8.98 s) : 0, 8980345
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1171100
Total [baseline] (8.95 s) : 0, 8950306
Agent [candidate] (1.177 s) : 0, 1177158
Total [candidate] (8.992 s) : 0, 8991707
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.175 s 123.755 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 123.851 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.171 s 119.779 ms (11.4%)
Total tracing 8.493 s -
Total iast 8.987 s 494.646 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.947 s 453.843 ms (5.3%)
Total iast_TELEMETRY_OFF 8.95 s 457.599 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.175 s 122.641 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 131.99 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.177 s 125.246 ms (11.9%)
Total tracing 8.503 s -
Total iast 8.948 s 444.611 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.98 s 477.267 ms (5.6%)
Total iast_TELEMETRY_OFF 8.992 s 488.629 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~2a32bc0279, baseline=1.40.0-SNAPSHOT~1d59e612a6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.635 ms) : 0, 670635
BytebuddyAgent [candidate] (670.968 ms) : 0, 670968
GlobalTracer [baseline] (307.572 ms) : 0, 307572
GlobalTracer [candidate] (307.743 ms) : 0, 307743
AppSec [baseline] (51.358 ms) : 0, 51358
AppSec [candidate] (51.362 ms) : 0, 51362
Remote Config [baseline] (687.511 µs) : 0, 688
Remote Config [candidate] (690.432 µs) : 0, 690
Telemetry [baseline] (7.506 ms) : 0, 7506
Telemetry [candidate] (7.526 ms) : 0, 7526
section iast
BytebuddyAgent [baseline] (781.701 ms) : 0, 781701
BytebuddyAgent [candidate] (781.054 ms) : 0, 781054
GlobalTracer [baseline] (295.984 ms) : 0, 295984
GlobalTracer [candidate] (296.211 ms) : 0, 296211
AppSec [baseline] (54.877 ms) : 0, 54877
AppSec [candidate] (51.512 ms) : 0, 51512
IAST [baseline] (20.974 ms) : 0, 20974
IAST [candidate] (24.358 ms) : 0, 24358
Remote Config [baseline] (597.819 µs) : 0, 598
Remote Config [candidate] (580.72 µs) : 0, 581
Telemetry [baseline] (7.323 ms) : 0, 7323
Telemetry [candidate] (7.197 ms) : 0, 7197
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.435 ms) : 0, 781435
BytebuddyAgent [candidate] (787.027 ms) : 0, 787027
GlobalTracer [baseline] (296.058 ms) : 0, 296058
GlobalTracer [candidate] (298.255 ms) : 0, 298255
AppSec [baseline] (54.265 ms) : 0, 54265
AppSec [candidate] (52.302 ms) : 0, 52302
IAST [baseline] (21.006 ms) : 0, 21006
IAST [candidate] (24.557 ms) : 0, 24557
Remote Config [baseline] (587.649 µs) : 0, 588
Remote Config [candidate] (606.675 µs) : 0, 607
Telemetry [baseline] (8.205 ms) : 0, 8205
Telemetry [candidate] (7.436 ms) : 0, 7436
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.176 ms) : 0, 778176
BytebuddyAgent [candidate] (783.72 ms) : 0, 783720
GlobalTracer [baseline] (295.476 ms) : 0, 295476
GlobalTracer [candidate] (295.765 ms) : 0, 295765
AppSec [baseline] (52.837 ms) : 0, 52837
AppSec [candidate] (55.034 ms) : 0, 55034
IAST [baseline] (22.393 ms) : 0, 22393
IAST [candidate] (20.99 ms) : 0, 20990
Remote Config [baseline] (592.727 µs) : 0, 593
Remote Config [candidate] (587.467 µs) : 0, 587
Telemetry [baseline] (8.003 ms) : 0, 8003
Telemetry [candidate] (7.324 ms) : 0, 7324
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~2a32bc0279, baseline=1.40.0-SNAPSHOT~1d59e612a6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066224
Total [baseline] (10.479 s) : 0, 10478798
Agent [candidate] (1.05 s) : 0, 1050346
Total [candidate] (10.335 s) : 0, 10335154
section appsec
Agent [baseline] (1.188 s) : 0, 1188251
Total [baseline] (10.55 s) : 0, 10550499
Agent [candidate] (1.183 s) : 0, 1183211
Total [candidate] (10.562 s) : 0, 10561683
section iast
Agent [baseline] (1.177 s) : 0, 1177186
Total [baseline] (10.793 s) : 0, 10792562
Agent [candidate] (1.176 s) : 0, 1175828
Total [candidate] (10.787 s) : 0, 10787004
section profiling
Agent [baseline] (1.254 s) : 0, 1254443
Total [baseline] (10.547 s) : 0, 10547164
Agent [candidate] (1.247 s) : 0, 1247023
Total [candidate] (10.591 s) : 0, 10590594
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.188 s 122.027 ms (11.4%)
Agent iast 1.177 s 110.962 ms (10.4%)
Agent profiling 1.254 s 188.218 ms (17.7%)
Total tracing 10.479 s -
Total appsec 10.55 s 71.702 ms (0.7%)
Total iast 10.793 s 313.764 ms (3.0%)
Total profiling 10.547 s 68.366 ms (0.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.183 s 132.865 ms (12.6%)
Agent iast 1.176 s 125.483 ms (11.9%)
Agent profiling 1.247 s 196.677 ms (18.7%)
Total tracing 10.335 s -
Total appsec 10.562 s 226.529 ms (2.2%)
Total iast 10.787 s 451.85 ms (4.4%)
Total profiling 10.591 s 255.44 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~2a32bc0279, baseline=1.40.0-SNAPSHOT~1d59e612a6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.786 ms) : 0, 680786
BytebuddyAgent [candidate] (669.903 ms) : 0, 669903
GlobalTracer [baseline] (311.442 ms) : 0, 311442
GlobalTracer [candidate] (307.533 ms) : 0, 307533
AppSec [baseline] (51.947 ms) : 0, 51947
AppSec [candidate] (51.211 ms) : 0, 51211
Remote Config [baseline] (685.596 µs) : 0, 686
Remote Config [candidate] (682.551 µs) : 0, 683
Telemetry [baseline] (7.609 ms) : 0, 7609
Telemetry [candidate] (7.41 ms) : 0, 7410
section appsec
BytebuddyAgent [baseline] (693.188 ms) : 0, 693188
BytebuddyAgent [candidate] (691.33 ms) : 0, 691330
GlobalTracer [baseline] (301.811 ms) : 0, 301811
GlobalTracer [candidate] (300.842 ms) : 0, 300842
AppSec [baseline] (160.709 ms) : 0, 160709
AppSec [candidate] (158.923 ms) : 0, 158923
Remote Config [baseline] (626.311 µs) : 0, 626
Remote Config [candidate] (629.182 µs) : 0, 629
Telemetry [baseline] (8.142 ms) : 0, 8142
Telemetry [candidate] (8.279 ms) : 0, 8279
IAST [baseline] (20.294 ms) : 0, 20294
IAST [candidate] (19.175 ms) : 0, 19175
section iast
BytebuddyAgent [baseline] (783.504 ms) : 0, 783504
BytebuddyAgent [candidate] (781.817 ms) : 0, 781817
GlobalTracer [baseline] (296.251 ms) : 0, 296251
GlobalTracer [candidate] (296.285 ms) : 0, 296285
AppSec [baseline] (53.463 ms) : 0, 53463
AppSec [candidate] (51.074 ms) : 0, 51074
Remote Config [baseline] (584.467 µs) : 0, 584
Remote Config [candidate] (591.586 µs) : 0, 592
Telemetry [baseline] (7.257 ms) : 0, 7257
Telemetry [candidate] (7.269 ms) : 0, 7269
IAST [baseline] (22.521 ms) : 0, 22521
IAST [candidate] (25.143 ms) : 0, 25143
section profiling
BytebuddyAgent [baseline] (670.12 ms) : 0, 670120
BytebuddyAgent [candidate] (664.533 ms) : 0, 664533
GlobalTracer [baseline] (390.517 ms) : 0, 390517
GlobalTracer [candidate] (388.662 ms) : 0, 388662
AppSec [baseline] (52.366 ms) : 0, 52366
AppSec [candidate] (52.008 ms) : 0, 52008
Remote Config [baseline] (683.083 µs) : 0, 683
Remote Config [candidate] (681.63 µs) : 0, 682
Telemetry [baseline] (7.398 ms) : 0, 7398
Telemetry [candidate] (7.398 ms) : 0, 7398
ProfilingAgent [baseline] (95.306 ms) : 0, 95306
ProfilingAgent [candidate] (95.905 ms) : 0, 95905
Profiling [baseline] (95.33 ms) : 0, 95330
Profiling [candidate] (95.928 ms) : 0, 95928
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-09T15:31:17 2024-09-09T15:38:07
git_branch master andrea.marziali/apms-13074
git_commit_date 1725890539 1725895265
git_commit_sha 1d59e61 2a32bc0
release_version 1.40.0-SNAPSHOT~1d59e612a6 1.40.0-SNAPSHOT~2a32bc0279
start_time 2024-09-09T15:31:04 2024-09-09T15:37:54
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725896632 1725896632
ci_job_id 632193715 632193715
ci_pipeline_id 43871954 43871954
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~2a32bc0279, baseline=1.40.0-SNAPSHOT~1d59e612a6
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.397 µs) : 349, 390
.   : milestone, 369,
iast (472.487 µs) : 451, 494
.   : milestone, 472,
iast_FULL (553.096 µs) : 532, 574
.   : milestone, 553,
iast_GLOBAL (500.015 µs) : 479, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (487.809 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (443.957 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (474.98 µs) : 452, 498
.   : milestone, 475,
tracing (441.545 µs) : 421, 462
.   : milestone, 442,
section candidate
no_agent (368.907 µs) : 349, 389
.   : milestone, 369,
iast (483.694 µs) : 463, 505
.   : milestone, 484,
iast_FULL (551.581 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (515.91 µs) : 493, 539
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (488.596 µs) : 466, 511
.   : milestone, 489,
iast_INACTIVE (443.653 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (471.328 µs) : 448, 494
.   : milestone, 471,
tracing (437.348 µs) : 417, 457
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.397 µs [349.238 µs, 389.555 µs] -
iast 472.487 µs [451.054 µs, 493.92 µs] 103.09 µs (27.9%)
iast_FULL 553.096 µs [531.992 µs, 574.2 µs] 183.699 µs (49.7%)
iast_GLOBAL 500.015 µs [478.931 µs, 521.1 µs] 130.619 µs (35.4%)
iast_HARDCODED_SECRET_DISABLED 487.809 µs [466.264 µs, 509.353 µs] 118.412 µs (32.1%)
iast_INACTIVE 443.957 µs [423.291 µs, 464.624 µs] 74.56 µs (20.2%)
iast_TELEMETRY_OFF 474.98 µs [452.132 µs, 497.827 µs] 105.583 µs (28.6%)
tracing 441.545 µs [421.089 µs, 462.002 µs] 72.149 µs (19.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.907 µs [349.037 µs, 388.776 µs] -
iast 483.694 µs [462.543 µs, 504.844 µs] 114.787 µs (31.1%)
iast_FULL 551.581 µs [530.658 µs, 572.504 µs] 182.674 µs (49.5%)
iast_GLOBAL 515.91 µs [493.022 µs, 538.797 µs] 147.003 µs (39.8%)
iast_HARDCODED_SECRET_DISABLED 488.596 µs [465.986 µs, 511.206 µs] 119.689 µs (32.4%)
iast_INACTIVE 443.653 µs [422.642 µs, 464.663 µs] 74.746 µs (20.3%)
iast_TELEMETRY_OFF 471.328 µs [448.325 µs, 494.331 µs] 102.422 µs (27.8%)
tracing 437.348 µs [417.426 µs, 457.27 µs] 68.441 µs (18.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~2a32bc0279, baseline=1.40.0-SNAPSHOT~1d59e612a6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.736 ms) : 1711, 1761
.   : milestone, 1736,
appsec_no_iast (1.728 ms) : 1703, 1753
.   : milestone, 1728,
iast (1.481 ms) : 1458, 1503
.   : milestone, 1481,
profiling (1.469 ms) : 1446, 1492
.   : milestone, 1469,
tracing (1.492 ms) : 1468, 1515
.   : milestone, 1492,
section candidate
no_agent (1.338 ms) : 1318, 1359
.   : milestone, 1338,
appsec (1.714 ms) : 1691, 1737
.   : milestone, 1714,
appsec_no_iast (1.753 ms) : 1729, 1777
.   : milestone, 1753,
iast (1.458 ms) : 1436, 1481
.   : milestone, 1458,
profiling (1.507 ms) : 1483, 1532
.   : milestone, 1507,
tracing (1.469 ms) : 1445, 1494
.   : milestone, 1469,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.332 ms, 1.37 ms] -
appsec 1.736 ms [1.711 ms, 1.761 ms] 385.099 µs (28.5%)
appsec_no_iast 1.728 ms [1.703 ms, 1.753 ms] 376.754 µs (27.9%)
iast 1.481 ms [1.458 ms, 1.503 ms] 129.758 µs (9.6%)
profiling 1.469 ms [1.446 ms, 1.492 ms] 117.832 µs (8.7%)
tracing 1.492 ms [1.468 ms, 1.515 ms] 140.721 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.318 ms, 1.359 ms] -
appsec 1.714 ms [1.691 ms, 1.737 ms] 375.373 µs (28.0%)
appsec_no_iast 1.753 ms [1.729 ms, 1.777 ms] 414.299 µs (31.0%)
iast 1.458 ms [1.436 ms, 1.481 ms] 120.029 µs (9.0%)
profiling 1.507 ms [1.483 ms, 1.532 ms] 168.943 µs (12.6%)
tracing 1.469 ms [1.445 ms, 1.494 ms] 130.786 µs (9.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/apms-13074
git_commit_date 1725890539 1725895265
git_commit_sha 1d59e61 2a32bc0
release_version 1.40.0-SNAPSHOT~1d59e612a6 1.40.0-SNAPSHOT~2a32bc0279
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725897154 1725897154
ci_job_id 632193718 632193718
ci_pipeline_id 43871954 43871954
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~2a32bc0279, baseline=1.40.0-SNAPSHOT~1d59e612a6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.553 s) : 15553000, 15553000
.   : milestone, 15553000,
appsec (15.086 s) : 15086000, 15086000
.   : milestone, 15086000,
iast (18.852 s) : 18852000, 18852000
.   : milestone, 18852000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
.   : milestone, 17897000,
profiling (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
tracing (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
section candidate
no_agent (15.366 s) : 15366000, 15366000
.   : milestone, 15366000,
appsec (15.218 s) : 15218000, 15218000
.   : milestone, 15218000,
iast (18.793 s) : 18793000, 18793000
.   : milestone, 18793000,
iast_GLOBAL (17.817 s) : 17817000, 17817000
.   : milestone, 17817000,
profiling (15.27 s) : 15270000, 15270000
.   : milestone, 15270000,
tracing (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.553 s [15.553 s, 15.553 s] -
appsec 15.086 s [15.086 s, 15.086 s] -467.0 ms (-3.0%)
iast 18.852 s [18.852 s, 18.852 s] 3.299 s (21.2%)
iast_GLOBAL 17.897 s [17.897 s, 17.897 s] 2.344 s (15.1%)
profiling 15.138 s [15.138 s, 15.138 s] -415.0 ms (-2.7%)
tracing 15.037 s [15.037 s, 15.037 s] -516.0 ms (-3.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.366 s [15.366 s, 15.366 s] -
appsec 15.218 s [15.218 s, 15.218 s] -148.0 ms (-1.0%)
iast 18.793 s [18.793 s, 18.793 s] 3.427 s (22.3%)
iast_GLOBAL 17.817 s [17.817 s, 17.817 s] 2.451 s (16.0%)
profiling 15.27 s [15.27 s, 15.27 s] -96.0 ms (-0.6%)
tracing 15.117 s [15.117 s, 15.117 s] -249.0 ms (-1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~2a32bc0279, baseline=1.40.0-SNAPSHOT~1d59e612a6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.25 ms) : 2214, 2286
.   : milestone, 2250,
iast (1.995 ms) : 1950, 2040
.   : milestone, 1995,
iast_GLOBAL (2.037 ms) : 1992, 2081
.   : milestone, 2037,
profiling (1.864 ms) : 1829, 1898
.   : milestone, 1864,
tracing (1.839 ms) : 1806, 1872
.   : milestone, 1839,
section candidate
no_agent (1.467 ms) : 1455, 1479
.   : milestone, 1467,
appsec (2.252 ms) : 2216, 2287
.   : milestone, 2252,
iast (2.001 ms) : 1957, 2046
.   : milestone, 2001,
iast_GLOBAL (2.027 ms) : 1984, 2071
.   : milestone, 2027,
profiling (1.876 ms) : 1842, 1911
.   : milestone, 1876,
tracing (1.849 ms) : 1816, 1882
.   : milestone, 1849,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.25 ms [2.214 ms, 2.286 ms] 789.91 µs (54.1%)
iast 1.995 ms [1.95 ms, 2.04 ms] 535.142 µs (36.7%)
iast_GLOBAL 2.037 ms [1.992 ms, 2.081 ms] 576.703 µs (39.5%)
profiling 1.864 ms [1.829 ms, 1.898 ms] 403.778 µs (27.7%)
tracing 1.839 ms [1.806 ms, 1.872 ms] 379.058 µs (26.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.479 ms] -
appsec 2.252 ms [2.216 ms, 2.287 ms] 784.596 µs (53.5%)
iast 2.001 ms [1.957 ms, 2.046 ms] 534.179 µs (36.4%)
iast_GLOBAL 2.027 ms [1.984 ms, 2.071 ms] 560.065 µs (38.2%)
profiling 1.876 ms [1.842 ms, 1.911 ms] 409.254 µs (27.9%)
tracing 1.849 ms [1.816 ms, 1.882 ms] 381.792 µs (26.0%)

@amarziali amarziali enabled auto-merge (squash) September 10, 2024 08:42
@amarziali amarziali merged commit 97ed58b into master Sep 10, 2024
98 checks passed
@amarziali amarziali deleted the andrea.marziali/apms-13074 branch September 10, 2024 08:49
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

Assignees
No one assigned
Labels
inst: spring Spring instrumentation type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @mcculls