Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Optional(Int|Double|Long) #7581

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add support for Optional(Int|Double|Long) #7581

merged 1 commit into from
Sep 10, 2024
+56 −2

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 9, 2024 •
edited by jira bot
Loading

What Does This Do

We added special field access for Optional but forgot about specialized version for primitives: Int, Double and Long

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2777

@jpbempel
Add support for Optional(Int|Double|Long)
1891175 
We added special field access for Optional but forgot about
specialized version for primitives: Int, Double and Long
@jpbempel jpbempel added type: enhancement comp: debugger Dynamic Instrumentation labels Sep 9, 2024
@jpbempel jpbempel requested a review from a team as a code owner September 9, 2024 12:21
@jpbempel jpbempel requested review from ojung and removed request for a team September 9, 2024 12:21
@pr-commenter
Copy link

pr-commenter bot commented Sep 9, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1725885110 1725885484
end_time 2024-09-09T12:33:04 2024-09-09T12:39:19
git_branch master jpbempel/add-optional-prims
git_commit_sha 5ddb19d 1891175
start_time 2024-09-09T12:31:51 2024-09-09T12:38:05
See matching parameters
Baseline Candidate
ci_job_id 631799511 631799511
ci_pipeline_id 43844886 43844886
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1725884405 1725884405

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 3 metrics, 7 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+221.775µs; +375.545µs] or [+2.193%; +3.713%]		 worse
[+218.358µs; +383.849µs] or [+2.124%; +3.734%]		 worse
[+228.088µs; +413.460µs] or [+2.200%; +3.988%]		 worse
[+219.276µs; +655.571µs] or [+2.061%; +6.162%]		 worse
[-3.905op/s; -1.487op/s] or [-4.061%; -1.546%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-28.326µs; +37.875µs] or [-10.894%; +14.566%]		 unstable
[-40.810µs; +53.143µs] or [-13.733%; +17.883%]		 unstable
[-54.139µs; +66.091µs] or [-17.347%; +21.176%]		 unstable
[-93.323µs; +124.842µs] or [-14.651%; +19.599%]		 unstable
[-179.687op/s; +107.723op/s] or [-6.649%; +3.986%]
scenario:basic same same same unstable
[-5.550µs; +67.812µs] or [-0.976%; +11.922%]		 unstable
[-248.030op/s; +113.077op/s] or [-9.425%; +4.297%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (297.165 µs) : 255, 339
.   : milestone, 297,
basic (296.157 µs) : 287, 305
.   : milestone, 296,
loop (10.28 ms) : 10243, 10316
.   : milestone, 10280,
section candidate
noprobe (303.331 µs) : 256, 351
.   : milestone, 303,
basic (298.819 µs) : 289, 309
.   : milestone, 299,
loop (10.581 ms) : 10479, 10683
.   : milestone, 10581,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 297.165 µs [255.208 µs, 339.122 µs]
basic 296.157 µs [287.396 µs, 304.917 µs]
loop 10.28 ms [10.243 ms, 10.316 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 303.331 µs [255.828 µs, 350.835 µs]
basic 298.819 µs [288.628 µs, 309.01 µs]
loop 10.581 ms [10.479 ms, 10.683 ms]

@pr-commenter
Copy link

pr-commenter bot commented Sep 9, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/add-optional-prims
git_commit_date 1725881796 1725884405
git_commit_sha c4dfa36 1891175
release_version 1.40.0-SNAPSHOT~c4dfa36730 1.40.0-SNAPSHOT~1891175ec9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725886737 1725886737
ci_job_id 631799502 631799502
ci_pipeline_id 43844886 43844886
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~1891175ec9, baseline=1.40.0-SNAPSHOT~c4dfa36730

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053145
Total [baseline] (8.525 s) : 0, 8524815
Agent [candidate] (1.05 s) : 0, 1049968
Total [candidate] (8.502 s) : 0, 8501934
section iast
Agent [baseline] (1.176 s) : 0, 1176420
Total [baseline] (8.978 s) : 0, 8978232
Agent [candidate] (1.177 s) : 0, 1176817
Total [candidate] (8.988 s) : 0, 8988327
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174837
Total [baseline] (8.955 s) : 0, 8954716
Agent [candidate] (1.176 s) : 0, 1175508
Total [candidate] (9.011 s) : 0, 9010785
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173094
Total [baseline] (8.963 s) : 0, 8962748
Agent [candidate] (1.172 s) : 0, 1172495
Total [candidate] (8.951 s) : 0, 8951216
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.176 s 123.274 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 121.692 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.173 s 119.949 ms (11.4%)
Total tracing 8.525 s -
Total iast 8.978 s 453.417 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.955 s 429.901 ms (5.0%)
Total iast_TELEMETRY_OFF 8.963 s 437.933 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent iast 1.177 s 126.849 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 125.54 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.172 s 122.528 ms (11.7%)
Total tracing 8.502 s -
Total iast 8.988 s 486.393 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.011 s 508.851 ms (6.0%)
Total iast_TELEMETRY_OFF 8.951 s 449.282 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~1891175ec9, baseline=1.40.0-SNAPSHOT~c4dfa36730

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.254 ms) : 0, 672254
BytebuddyAgent [candidate] (670.305 ms) : 0, 670305
GlobalTracer [baseline] (307.793 ms) : 0, 307793
GlobalTracer [candidate] (306.948 ms) : 0, 306948
AppSec [baseline] (51.369 ms) : 0, 51369
AppSec [candidate] (51.048 ms) : 0, 51048
Remote Config [baseline] (686.369 µs) : 0, 686
Remote Config [candidate] (684.757 µs) : 0, 685
Telemetry [baseline] (7.447 ms) : 0, 7447
Telemetry [candidate] (7.422 ms) : 0, 7422
section iast
BytebuddyAgent [baseline] (783.112 ms) : 0, 783112
BytebuddyAgent [candidate] (782.394 ms) : 0, 782394
GlobalTracer [baseline] (296.354 ms) : 0, 296354
GlobalTracer [candidate] (296.437 ms) : 0, 296437
AppSec [baseline] (54.584 ms) : 0, 54584
AppSec [candidate] (53.858 ms) : 0, 53858
IAST [baseline] (20.884 ms) : 0, 20884
IAST [candidate] (22.554 ms) : 0, 22554
Remote Config [baseline] (586.792 µs) : 0, 587
Remote Config [candidate] (593.265 µs) : 0, 593
Telemetry [baseline] (7.301 ms) : 0, 7301
Telemetry [candidate] (7.344 ms) : 0, 7344
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.189 ms) : 0, 781189
BytebuddyAgent [candidate] (781.397 ms) : 0, 781397
GlobalTracer [baseline] (296.152 ms) : 0, 296152
GlobalTracer [candidate] (296.244 ms) : 0, 296244
AppSec [baseline] (50.838 ms) : 0, 50838
AppSec [candidate] (52.6 ms) : 0, 52600
IAST [baseline] (24.359 ms) : 0, 24359
IAST [candidate] (21.297 ms) : 0, 21297
Remote Config [baseline] (598.835 µs) : 0, 599
Remote Config [candidate] (611.909 µs) : 0, 612
Telemetry [baseline] (8.072 ms) : 0, 8072
Telemetry [candidate] (9.713 ms) : 0, 9713
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.831 ms) : 0, 779831
BytebuddyAgent [candidate] (779.118 ms) : 0, 779118
GlobalTracer [baseline] (296.728 ms) : 0, 296728
GlobalTracer [candidate] (296.045 ms) : 0, 296045
AppSec [baseline] (53.668 ms) : 0, 53668
AppSec [candidate] (52.56 ms) : 0, 52560
IAST [baseline] (20.695 ms) : 0, 20695
IAST [candidate] (23.292 ms) : 0, 23292
Remote Config [baseline] (577.341 µs) : 0, 577
Remote Config [candidate] (598.096 µs) : 0, 598
Telemetry [baseline] (7.97 ms) : 0, 7970
Telemetry [candidate] (7.235 ms) : 0, 7235
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~1891175ec9, baseline=1.40.0-SNAPSHOT~c4dfa36730

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052177
Total [baseline] (10.471 s) : 0, 10471424
Agent [candidate] (1.066 s) : 0, 1066302
Total [candidate] (10.415 s) : 0, 10414927
section appsec
Agent [baseline] (1.18 s) : 0, 1180028
Total [baseline] (10.579 s) : 0, 10578888
Agent [candidate] (1.183 s) : 0, 1183413
Total [candidate] (10.603 s) : 0, 10603348
section iast
Agent [baseline] (1.176 s) : 0, 1176222
Total [baseline] (10.856 s) : 0, 10855727
Agent [candidate] (1.176 s) : 0, 1175915
Total [candidate] (10.851 s) : 0, 10851298
section profiling
Agent [baseline] (1.257 s) : 0, 1256589
Total [baseline] (10.596 s) : 0, 10595812
Agent [candidate] (1.248 s) : 0, 1247602
Total [candidate] (10.61 s) : 0, 10610179
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.18 s 127.851 ms (12.2%)
Agent iast 1.176 s 124.045 ms (11.8%)
Agent profiling 1.257 s 204.412 ms (19.4%)
Total tracing 10.471 s -
Total appsec 10.579 s 107.463 ms (1.0%)
Total iast 10.856 s 384.302 ms (3.7%)
Total profiling 10.596 s 124.387 ms (1.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.183 s 117.11 ms (11.0%)
Agent iast 1.176 s 109.612 ms (10.3%)
Agent profiling 1.248 s 181.3 ms (17.0%)
Total tracing 10.415 s -
Total appsec 10.603 s 188.421 ms (1.8%)
Total iast 10.851 s 436.371 ms (4.2%)
Total profiling 10.61 s 195.252 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~1891175ec9, baseline=1.40.0-SNAPSHOT~c4dfa36730

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.526 ms) : 0, 671526
BytebuddyAgent [candidate] (680.631 ms) : 0, 680631
GlobalTracer [baseline] (307.377 ms) : 0, 307377
GlobalTracer [candidate] (311.606 ms) : 0, 311606
AppSec [baseline] (51.509 ms) : 0, 51509
AppSec [candidate] (52.013 ms) : 0, 52013
Remote Config [baseline] (684.766 µs) : 0, 685
Remote Config [candidate] (691.041 µs) : 0, 691
Telemetry [baseline] (7.473 ms) : 0, 7473
Telemetry [candidate] (7.589 ms) : 0, 7589
section appsec
BytebuddyAgent [baseline] (688.784 ms) : 0, 688784
BytebuddyAgent [candidate] (690.498 ms) : 0, 690498
GlobalTracer [baseline] (299.629 ms) : 0, 299629
GlobalTracer [candidate] (300.619 ms) : 0, 300619
AppSec [baseline] (157.62 ms) : 0, 157620
AppSec [candidate] (160.288 ms) : 0, 160288
Remote Config [baseline] (625.445 µs) : 0, 625
Remote Config [candidate] (622.357 µs) : 0, 622
Telemetry [baseline] (8.878 ms) : 0, 8878
Telemetry [candidate] (7.536 ms) : 0, 7536
IAST [baseline] (21.947 ms) : 0, 21947
IAST [candidate] (20.523 ms) : 0, 20523
section iast
BytebuddyAgent [baseline] (782.622 ms) : 0, 782622
BytebuddyAgent [candidate] (782.664 ms) : 0, 782664
GlobalTracer [baseline] (296.524 ms) : 0, 296524
GlobalTracer [candidate] (296.794 ms) : 0, 296794
AppSec [baseline] (53.71 ms) : 0, 53710
AppSec [candidate] (52.953 ms) : 0, 52953
Remote Config [baseline] (582.961 µs) : 0, 583
Remote Config [candidate] (597.221 µs) : 0, 597
Telemetry [baseline] (7.326 ms) : 0, 7326
Telemetry [candidate] (7.351 ms) : 0, 7351
IAST [baseline] (21.868 ms) : 0, 21868
IAST [candidate] (21.948 ms) : 0, 21948
section profiling
BytebuddyAgent [baseline] (669.557 ms) : 0, 669557
BytebuddyAgent [candidate] (664.841 ms) : 0, 664841
GlobalTracer [baseline] (390.993 ms) : 0, 390993
GlobalTracer [candidate] (389.165 ms) : 0, 389165
AppSec [baseline] (52.629 ms) : 0, 52629
AppSec [candidate] (51.961 ms) : 0, 51961
Remote Config [baseline] (704.366 µs) : 0, 704
Remote Config [candidate] (679.831 µs) : 0, 680
Telemetry [baseline] (7.455 ms) : 0, 7455
Telemetry [candidate] (7.369 ms) : 0, 7369
ProfilingAgent [baseline] (97.203 ms) : 0, 97203
ProfilingAgent [candidate] (95.765 ms) : 0, 95765
Profiling [baseline] (97.227 ms) : 0, 97227
Profiling [candidate] (95.788 ms) : 0, 95788
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-09T12:29:52 2024-09-09T12:36:38
git_branch master jpbempel/add-optional-prims
git_commit_date 1725881796 1725884405
git_commit_sha c4dfa36 1891175
release_version 1.40.0-SNAPSHOT~c4dfa36730 1.40.0-SNAPSHOT~1891175ec9
start_time 2024-09-09T12:29:39 2024-09-09T12:36:25
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725885741 1725885741
ci_job_id 631799503 631799503
ci_pipeline_id 43844886 43844886
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 20 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~1891175ec9, baseline=1.40.0-SNAPSHOT~c4dfa36730
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.716 ms) : 1692, 1741
.   : milestone, 1716,
appsec_no_iast (1.724 ms) : 1700, 1748
.   : milestone, 1724,
iast (1.461 ms) : 1438, 1484
.   : milestone, 1461,
profiling (1.484 ms) : 1460, 1508
.   : milestone, 1484,
tracing (1.462 ms) : 1438, 1485
.   : milestone, 1462,
section candidate
no_agent (1.341 ms) : 1322, 1360
.   : milestone, 1341,
appsec (1.717 ms) : 1693, 1740
.   : milestone, 1717,
appsec_no_iast (1.698 ms) : 1673, 1724
.   : milestone, 1698,
iast (1.456 ms) : 1434, 1479
.   : milestone, 1456,
profiling (1.486 ms) : 1463, 1509
.   : milestone, 1486,
tracing (1.455 ms) : 1430, 1480
.   : milestone, 1455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.716 ms [1.692 ms, 1.741 ms] 373.453 µs (27.8%)
appsec_no_iast 1.724 ms [1.7 ms, 1.748 ms] 380.879 µs (28.4%)
iast 1.461 ms [1.438 ms, 1.484 ms] 118.204 µs (8.8%)
profiling 1.484 ms [1.46 ms, 1.508 ms] 141.227 µs (10.5%)
tracing 1.462 ms [1.438 ms, 1.485 ms] 118.839 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.36 ms] -
appsec 1.717 ms [1.693 ms, 1.74 ms] 375.51 µs (28.0%)
appsec_no_iast 1.698 ms [1.673 ms, 1.724 ms] 357.485 µs (26.7%)
iast 1.456 ms [1.434 ms, 1.479 ms] 115.372 µs (8.6%)
profiling 1.486 ms [1.463 ms, 1.509 ms] 144.958 µs (10.8%)
tracing 1.455 ms [1.43 ms, 1.48 ms] 114.022 µs (8.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~1891175ec9, baseline=1.40.0-SNAPSHOT~c4dfa36730
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.843 µs) : 341, 381
.   : milestone, 361,
iast (477.335 µs) : 455, 500
.   : milestone, 477,
iast_FULL (547.253 µs) : 526, 569
.   : milestone, 547,
iast_GLOBAL (496.114 µs) : 475, 517
.   : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (470.14 µs) : 448, 492
.   : milestone, 470,
iast_INACTIVE (433.741 µs) : 413, 454
.   : milestone, 434,
iast_TELEMETRY_OFF (463.792 µs) : 442, 486
.   : milestone, 464,
tracing (432.616 µs) : 412, 453
.   : milestone, 433,
section candidate
no_agent (358.459 µs) : 339, 378
.   : milestone, 358,
iast (481.734 µs) : 459, 504
.   : milestone, 482,
iast_FULL (543.871 µs) : 523, 565
.   : milestone, 544,
iast_GLOBAL (496.38 µs) : 475, 518
.   : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (474.175 µs) : 452, 496
.   : milestone, 474,
iast_INACTIVE (435.29 µs) : 414, 456
.   : milestone, 435,
iast_TELEMETRY_OFF (472.908 µs) : 450, 496
.   : milestone, 473,
tracing (439.835 µs) : 419, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.843 µs [341.032 µs, 380.655 µs] -
iast 477.335 µs [454.782 µs, 499.888 µs] 116.491 µs (32.3%)
iast_FULL 547.253 µs [525.784 µs, 568.722 µs] 186.409 µs (51.7%)
iast_GLOBAL 496.114 µs [475.253 µs, 516.976 µs] 135.271 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 470.14 µs [448.168 µs, 492.111 µs] 109.296 µs (30.3%)
iast_INACTIVE 433.741 µs [413.376 µs, 454.107 µs] 72.898 µs (20.2%)
iast_TELEMETRY_OFF 463.792 µs [441.672 µs, 485.913 µs] 102.949 µs (28.5%)
tracing 432.616 µs [412.482 µs, 452.75 µs] 71.773 µs (19.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.459 µs [338.992 µs, 377.926 µs] -
iast 481.734 µs [459.353 µs, 504.115 µs] 123.275 µs (34.4%)
iast_FULL 543.871 µs [522.931 µs, 564.81 µs] 185.412 µs (51.7%)
iast_GLOBAL 496.38 µs [475.224 µs, 517.536 µs] 137.921 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 474.175 µs [452.159 µs, 496.192 µs] 115.716 µs (32.3%)
iast_INACTIVE 435.29 µs [414.345 µs, 456.236 µs] 76.832 µs (21.4%)
iast_TELEMETRY_OFF 472.908 µs [449.783 µs, 496.033 µs] 114.449 µs (31.9%)
tracing 439.835 µs [419.26 µs, 460.411 µs] 81.377 µs (22.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/add-optional-prims
git_commit_date 1725884741 1725884405
git_commit_sha 5ddb19d 1891175
release_version 1.40.0-SNAPSHOT~5ddb19db3a 1.40.0-SNAPSHOT~1891175ec9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725886455 1725886455
ci_job_id 631799504 631799504
ci_pipeline_id 43844886 43844886
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~1891175ec9, baseline=1.40.0-SNAPSHOT~5ddb19db3a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.226 ms) : 2190, 2261
.   : milestone, 2226,
iast (1.972 ms) : 1928, 2016
.   : milestone, 1972,
iast_GLOBAL (2.01 ms) : 1966, 2054
.   : milestone, 2010,
profiling (1.861 ms) : 1826, 1895
.   : milestone, 1861,
tracing (1.842 ms) : 1809, 1875
.   : milestone, 1842,
section candidate
no_agent (1.453 ms) : 1442, 1464
.   : milestone, 1453,
appsec (2.227 ms) : 2191, 2263
.   : milestone, 2227,
iast (1.982 ms) : 1938, 2026
.   : milestone, 1982,
iast_GLOBAL (2.023 ms) : 1978, 2067
.   : milestone, 2023,
profiling (1.868 ms) : 1831, 1904
.   : milestone, 1868,
tracing (1.842 ms) : 1808, 1875
.   : milestone, 1842,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.226 ms [2.19 ms, 2.261 ms] 769.283 µs (52.8%)
iast 1.972 ms [1.928 ms, 2.016 ms] 515.557 µs (35.4%)
iast_GLOBAL 2.01 ms [1.966 ms, 2.054 ms] 553.369 µs (38.0%)
profiling 1.861 ms [1.826 ms, 1.895 ms] 404.602 µs (27.8%)
tracing 1.842 ms [1.809 ms, 1.875 ms] 385.364 µs (26.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.453 ms [1.442 ms, 1.464 ms] -
appsec 2.227 ms [2.191 ms, 2.263 ms] 773.712 µs (53.2%)
iast 1.982 ms [1.938 ms, 2.026 ms] 528.696 µs (36.4%)
iast_GLOBAL 2.023 ms [1.978 ms, 2.067 ms] 569.443 µs (39.2%)
profiling 1.868 ms [1.831 ms, 1.904 ms] 414.407 µs (28.5%)
tracing 1.842 ms [1.808 ms, 1.875 ms] 388.609 µs (26.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~1891175ec9, baseline=1.40.0-SNAPSHOT~5ddb19db3a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
appsec (15.216 s) : 15216000, 15216000
.   : milestone, 15216000,
iast (18.949 s) : 18949000, 18949000
.   : milestone, 18949000,
iast_GLOBAL (17.826 s) : 17826000, 17826000
.   : milestone, 17826000,
profiling (15.215 s) : 15215000, 15215000
.   : milestone, 15215000,
tracing (15.144 s) : 15144000, 15144000
.   : milestone, 15144000,
section candidate
no_agent (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
appsec (15.264 s) : 15264000, 15264000
.   : milestone, 15264000,
iast (18.735 s) : 18735000, 18735000
.   : milestone, 18735000,
iast_GLOBAL (17.799 s) : 17799000, 17799000
.   : milestone, 17799000,
profiling (15.339 s) : 15339000, 15339000
.   : milestone, 15339000,
tracing (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.033 s [15.033 s, 15.033 s] -
appsec 15.216 s [15.216 s, 15.216 s] 183.0 ms (1.2%)
iast 18.949 s [18.949 s, 18.949 s] 3.916 s (26.0%)
iast_GLOBAL 17.826 s [17.826 s, 17.826 s] 2.793 s (18.6%)
profiling 15.215 s [15.215 s, 15.215 s] 182.0 ms (1.2%)
tracing 15.144 s [15.144 s, 15.144 s] 111.0 ms (0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.026 s [15.026 s, 15.026 s] -
appsec 15.264 s [15.264 s, 15.264 s] 238.0 ms (1.6%)
iast 18.735 s [18.735 s, 18.735 s] 3.709 s (24.7%)
iast_GLOBAL 17.799 s [17.799 s, 17.799 s] 2.773 s (18.5%)
profiling 15.339 s [15.339 s, 15.339 s] 313.0 ms (2.1%)
tracing 14.958 s [14.958 s, 14.958 s] -68.0 ms (-0.5%)

shatzi
shatzi approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

What about OptionalFloat/Byte/Char/Boolean?
Maybe there are more primitives we need to support or we can generate a generic solution for all of those...

@jpbempel
Copy link
Member Author

nice.

What about OptionalFloat/Byte/Char/Boolean? Maybe there are more primitives we need to support or we can generate a generic solution for all of those...

no only those, because for other primitives they are widen into int or double version

@jpbempel jpbempel merged commit d1d0aa8 into master Sep 10, 2024
99 checks passed
@jpbempel jpbempel deleted the jpbempel/add-optional-prims branch September 10, 2024 05:40
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi