Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception_hash tag for span #7574

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add exception_hash tag for span #7574

merged 1 commit into from
Sep 9, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 6, 2024 •
edited by jira bot
Loading

What Does This Do

For Exception Replay we add also the _dd.debug.error.exception_hash
tag along with exception_id and snapshot ids

Motivation

fix system tests

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2787

@jpbempel
Add exception_hash tag for span
1ea0314 
For Exception Replay we add also the `_dd.debug.error.exception_hash`
 tag along with exception_id and snapshot ids
@pr-commenter
Copy link

pr-commenter bot commented Sep 6, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1725630138 1725630527
end_time 2024-09-06T13:43:31 2024-09-06T13:50:01
git_branch master jpbempel/fix-exception-hash
git_commit_sha fb9b96a 1ea0314
start_time 2024-09-06T13:42:19 2024-09-06T13:48:48
See matching parameters
Baseline Candidate
ci_job_id 630250400 630250400
ci_pipeline_id 43731117 43731117
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1725627485 1725627485

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-11.455µs; +25.624µs] or [-4.563%; +10.208%]		 unstable
[-21.034µs; +41.609µs] or [-7.377%; +14.592%]		 unstable
[-32.730µs; +53.203µs] or [-10.965%; +17.824%]		 unstable
[-83.492µs; +113.430µs] or [-13.077%; +17.766%]		 same
scenario:basic unsure
[+0.493µs; +9.451µs] or [+0.186%; +3.561%]		 same same unstable
[-9.865µs; +72.422µs] or [-1.712%; +12.567%]		 unstable
[-257.102op/s; +122.149op/s] or [-9.770%; +4.642%]
scenario:loop unsure
[-45.069µs; -35.767µs] or [-0.416%; -0.330%]		 unsure
[-74.510µs; -18.544µs] or [-0.677%; -0.168%]		 unsure
[-124.546µs; -13.879µs] or [-1.120%; -0.125%]		 same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (285.151 µs) : 261, 309
.   : milestone, 285,
basic (291.88 µs) : 284, 300
.   : milestone, 292,
loop (11.014 ms) : 10989, 11039
.   : milestone, 11014,
section candidate
noprobe (295.438 µs) : 261, 330
.   : milestone, 295,
basic (297.079 µs) : 290, 304
.   : milestone, 297,
loop (10.967 ms) : 10940, 10994
.   : milestone, 10967,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 285.151 µs [260.921 µs, 309.38 µs]
basic 291.88 µs [283.563 µs, 300.197 µs]
loop 11.014 ms [10.989 ms, 11.039 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 295.438 µs [260.799 µs, 330.077 µs]
basic 297.079 µs [290.011 µs, 304.147 µs]
loop 10.967 ms [10.94 ms, 10.994 ms]

@jpbempel jpbempel marked this pull request as ready for review September 6, 2024 14:03
@jpbempel jpbempel requested a review from a team as a code owner September 6, 2024 14:03
@jpbempel jpbempel requested review from cimi and removed request for a team September 6, 2024 14:03
@pr-commenter
Copy link

pr-commenter bot commented Sep 6, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-exception-hash
git_commit_date 1725622627 1725627485
git_commit_sha fb9b96a 1ea0314
release_version 1.40.0-SNAPSHOT~fb9b96a2fa 1.40.0-SNAPSHOT~1ea0314923
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725631843 1725631843
ci_job_id 630250387 630250387
ci_pipeline_id 43731117 43731117
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 49 metrics, 13 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:AppSec worse
[+2.514ms; +7.464ms] or [+4.948%; +14.689%]		 55.801ms 50.812ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~1ea0314923, baseline=1.40.0-SNAPSHOT~fb9b96a2fa

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060820
Total [baseline] (10.403 s) : 0, 10402682
Agent [candidate] (1.066 s) : 0, 1066224
Total [candidate] (10.372 s) : 0, 10372162
section appsec
Agent [baseline] (1.184 s) : 0, 1183908
Total [baseline] (10.621 s) : 0, 10621424
Agent [candidate] (1.188 s) : 0, 1187821
Total [candidate] (10.617 s) : 0, 10617286
section iast
Agent [baseline] (1.184 s) : 0, 1184332
Total [baseline] (10.906 s) : 0, 10906182
Agent [candidate] (1.177 s) : 0, 1177270
Total [candidate] (10.848 s) : 0, 10848136
section profiling
Agent [baseline] (1.259 s) : 0, 1259200
Total [baseline] (10.671 s) : 0, 10670864
Agent [candidate] (1.251 s) : 0, 1251065
Total [candidate] (10.627 s) : 0, 10626999
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.184 s 123.088 ms (11.6%)
Agent iast 1.184 s 123.512 ms (11.6%)
Agent profiling 1.259 s 198.38 ms (18.7%)
Total tracing 10.403 s -
Total appsec 10.621 s 218.742 ms (2.1%)
Total iast 10.906 s 503.5 ms (4.8%)
Total profiling 10.671 s 268.182 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.188 s 121.597 ms (11.4%)
Agent iast 1.177 s 111.046 ms (10.4%)
Agent profiling 1.251 s 184.841 ms (17.3%)
Total tracing 10.372 s -
Total appsec 10.617 s 245.125 ms (2.4%)
Total iast 10.848 s 475.974 ms (4.6%)
Total profiling 10.627 s 254.837 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~1ea0314923, baseline=1.40.0-SNAPSHOT~fb9b96a2fa

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.761 ms) : 0, 675761
BytebuddyAgent [candidate] (681.883 ms) : 0, 681883
GlobalTracer [baseline] (310.929 ms) : 0, 310929
GlobalTracer [candidate] (310.323 ms) : 0, 310323
AppSec [baseline] (52.164 ms) : 0, 52164
AppSec [candidate] (51.924 ms) : 0, 51924
Remote Config [baseline] (690.314 µs) : 0, 690
Remote Config [candidate] (703.565 µs) : 0, 704
Telemetry [baseline] (7.621 ms) : 0, 7621
Telemetry [candidate] (7.588 ms) : 0, 7588
section appsec
BytebuddyAgent [baseline] (690.344 ms) : 0, 690344
BytebuddyAgent [candidate] (693.07 ms) : 0, 693070
GlobalTracer [baseline] (301.123 ms) : 0, 301123
GlobalTracer [candidate] (302.105 ms) : 0, 302105
AppSec [baseline] (159.14 ms) : 0, 159140
AppSec [candidate] (159.203 ms) : 0, 159203
Remote Config [baseline] (624.473 µs) : 0, 624
Remote Config [candidate] (630.833 µs) : 0, 631
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.97 ms) : 0, 8970
IAST [baseline] (21.141 ms) : 0, 21141
IAST [candidate] (20.428 ms) : 0, 20428
section iast
BytebuddyAgent [baseline] (786.886 ms) : 0, 786886
BytebuddyAgent [candidate] (782.852 ms) : 0, 782852
GlobalTracer [baseline] (299.538 ms) : 0, 299538
GlobalTracer [candidate] (297.0 ms) : 0, 297000
AppSec [baseline] (54.354 ms) : 0, 54354
AppSec [candidate] (51.465 ms) : 0, 51465
Remote Config [baseline] (589.266 µs) : 0, 589
Remote Config [candidate] (595.969 µs) : 0, 596
Telemetry [baseline] (7.42 ms) : 0, 7420
Telemetry [candidate] (7.288 ms) : 0, 7288
IAST [baseline] (21.907 ms) : 0, 21907
IAST [candidate] (24.465 ms) : 0, 24465
section profiling
BytebuddyAgent [baseline] (669.463 ms) : 0, 669463
BytebuddyAgent [candidate] (666.249 ms) : 0, 666249
GlobalTracer [baseline] (393.638 ms) : 0, 393638
GlobalTracer [candidate] (390.764 ms) : 0, 390764
AppSec [baseline] (52.697 ms) : 0, 52697
AppSec [candidate] (52.453 ms) : 0, 52453
Remote Config [baseline] (693.801 µs) : 0, 694
Remote Config [candidate] (687.783 µs) : 0, 688
Telemetry [baseline] (7.447 ms) : 0, 7447
Telemetry [candidate] (7.379 ms) : 0, 7379
ProfilingAgent [baseline] (97.222 ms) : 0, 97222
ProfilingAgent [candidate] (95.624 ms) : 0, 95624
Profiling [baseline] (97.246 ms) : 0, 97246
Profiling [candidate] (95.647 ms) : 0, 95647
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~1ea0314923, baseline=1.40.0-SNAPSHOT~fb9b96a2fa

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060814
Total [baseline] (8.534 s) : 0, 8533520
Agent [candidate] (1.053 s) : 0, 1053016
Total [candidate] (8.508 s) : 0, 8508323
section iast
Agent [baseline] (1.19 s) : 0, 1189858
Total [baseline] (9.071 s) : 0, 9070803
Agent [candidate] (1.176 s) : 0, 1176057
Total [candidate] (8.98 s) : 0, 8980439
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1177466
Total [baseline] (8.94 s) : 0, 8940132
Agent [candidate] (1.177 s) : 0, 1176897
Total [candidate] (8.936 s) : 0, 8936440
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172614
Total [baseline] (8.989 s) : 0, 8988986
Agent [candidate] (1.176 s) : 0, 1175782
Total [candidate] (8.98 s) : 0, 8979544
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.19 s 129.043 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 116.652 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.173 s 111.8 ms (10.5%)
Total tracing 8.534 s -
Total iast 9.071 s 537.283 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.94 s 406.612 ms (4.8%)
Total iast_TELEMETRY_OFF 8.989 s 455.466 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.176 s 123.041 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 123.881 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.176 s 122.767 ms (11.7%)
Total tracing 8.508 s -
Total iast 8.98 s 472.116 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.936 s 428.117 ms (5.0%)
Total iast_TELEMETRY_OFF 8.98 s 471.221 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~1ea0314923, baseline=1.40.0-SNAPSHOT~fb9b96a2fa

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.863 ms) : 0, 676863
BytebuddyAgent [candidate] (671.766 ms) : 0, 671766
GlobalTracer [baseline] (310.052 ms) : 0, 310052
GlobalTracer [candidate] (308.239 ms) : 0, 308239
AppSec [baseline] (51.907 ms) : 0, 51907
AppSec [candidate] (51.214 ms) : 0, 51214
Remote Config [baseline] (705.818 µs) : 0, 706
Remote Config [candidate] (677.752 µs) : 0, 678
Telemetry [baseline] (7.561 ms) : 0, 7561
Telemetry [candidate] (7.509 ms) : 0, 7509
section iast
BytebuddyAgent [baseline] (791.296 ms) : 0, 791296
BytebuddyAgent [candidate] (781.837 ms) : 0, 781837
GlobalTracer [baseline] (299.98 ms) : 0, 299980
GlobalTracer [candidate] (296.783 ms) : 0, 296783
AppSec [baseline] (53.878 ms) : 0, 53878
AppSec [candidate] (51.658 ms) : 0, 51658
Remote Config [baseline] (1.372 ms) : 0, 1372
Remote Config [candidate] (1.374 ms) : 0, 1374
Telemetry [baseline] (7.48 ms) : 0, 7480
Telemetry [candidate] (7.361 ms) : 0, 7361
IAST [baseline] (22.078 ms) : 0, 22078
IAST [candidate] (23.442 ms) : 0, 23442
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.801 ms) : 0, 782801
BytebuddyAgent [candidate] (782.198 ms) : 0, 782198
GlobalTracer [baseline] (297.176 ms) : 0, 297176
GlobalTracer [candidate] (297.124 ms) : 0, 297124
AppSec [baseline] (50.812 ms) : 0, 50812
AppSec [candidate] (55.801 ms) : 0, 55801
Remote Config [baseline] (604.651 µs) : 0, 605
Remote Config [candidate] (585.181 µs) : 0, 585
Telemetry [baseline] (8.053 ms) : 0, 8053
Telemetry [candidate] (7.324 ms) : 0, 7324
IAST [baseline] (24.39 ms) : 0, 24390
IAST [candidate] (20.209 ms) : 0, 20209
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.072 ms) : 0, 779072
BytebuddyAgent [candidate] (781.598 ms) : 0, 781598
GlobalTracer [baseline] (296.709 ms) : 0, 296709
GlobalTracer [candidate] (297.542 ms) : 0, 297542
AppSec [baseline] (53.938 ms) : 0, 53938
AppSec [candidate] (52.591 ms) : 0, 52591
Remote Config [baseline] (576.09 µs) : 0, 576
Remote Config [candidate] (586.074 µs) : 0, 586
Telemetry [baseline] (7.963 ms) : 0, 7963
Telemetry [candidate] (8.016 ms) : 0, 8016
IAST [baseline] (20.751 ms) : 0, 20751
IAST [candidate] (21.765 ms) : 0, 21765
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-06T13:43:22 2024-09-06T13:50:10
git_branch master jpbempel/fix-exception-hash
git_commit_date 1725622627 1725627485
git_commit_sha fb9b96a 1ea0314
release_version 1.40.0-SNAPSHOT~fb9b96a2fa 1.40.0-SNAPSHOT~1ea0314923
start_time 2024-09-06T13:43:09 2024-09-06T13:49:57
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725630955 1725630955
ci_job_id 630250389 630250389
ci_pipeline_id 43731117 43731117
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~1ea0314923, baseline=1.40.0-SNAPSHOT~fb9b96a2fa
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.713 ms) : 1689, 1738
.   : milestone, 1713,
appsec_no_iast (1.73 ms) : 1706, 1754
.   : milestone, 1730,
iast (1.468 ms) : 1446, 1490
.   : milestone, 1468,
profiling (1.483 ms) : 1461, 1506
.   : milestone, 1483,
tracing (1.469 ms) : 1445, 1493
.   : milestone, 1469,
section candidate
no_agent (1.347 ms) : 1327, 1367
.   : milestone, 1347,
appsec (1.697 ms) : 1672, 1722
.   : milestone, 1697,
appsec_no_iast (1.73 ms) : 1706, 1753
.   : milestone, 1730,
iast (1.519 ms) : 1495, 1542
.   : milestone, 1519,
profiling (1.485 ms) : 1462, 1508
.   : milestone, 1485,
tracing (1.467 ms) : 1444, 1491
.   : milestone, 1467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.713 ms [1.689 ms, 1.738 ms] 363.116 µs (26.9%)
appsec_no_iast 1.73 ms [1.706 ms, 1.754 ms] 379.762 µs (28.1%)
iast 1.468 ms [1.446 ms, 1.49 ms] 117.509 µs (8.7%)
profiling 1.483 ms [1.461 ms, 1.506 ms] 132.976 µs (9.8%)
tracing 1.469 ms [1.445 ms, 1.493 ms] 119.0 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.367 ms] -
appsec 1.697 ms [1.672 ms, 1.722 ms] 350.122 µs (26.0%)
appsec_no_iast 1.73 ms [1.706 ms, 1.753 ms] 382.829 µs (28.4%)
iast 1.519 ms [1.495 ms, 1.542 ms] 171.636 µs (12.7%)
profiling 1.485 ms [1.462 ms, 1.508 ms] 138.453 µs (10.3%)
tracing 1.467 ms [1.444 ms, 1.491 ms] 120.491 µs (8.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~1ea0314923, baseline=1.40.0-SNAPSHOT~fb9b96a2fa
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.721 µs) : 349, 388
.   : milestone, 369,
iast (485.943 µs) : 465, 507
.   : milestone, 486,
iast_FULL (557.332 µs) : 536, 579
.   : milestone, 557,
iast_GLOBAL (503.675 µs) : 483, 524
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (483.729 µs) : 462, 506
.   : milestone, 484,
iast_INACTIVE (445.669 µs) : 424, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (463.636 µs) : 442, 486
.   : milestone, 464,
tracing (432.923 µs) : 413, 453
.   : milestone, 433,
section candidate
no_agent (369.447 µs) : 350, 389
.   : milestone, 369,
iast (484.717 µs) : 463, 506
.   : milestone, 485,
iast_FULL (545.487 µs) : 524, 567
.   : milestone, 545,
iast_GLOBAL (508.28 µs) : 487, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (479.361 µs) : 459, 500
.   : milestone, 479,
iast_INACTIVE (443.123 µs) : 422, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (468.556 µs) : 446, 491
.   : milestone, 469,
tracing (440.816 µs) : 420, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.721 µs [349.401 µs, 388.042 µs] -
iast 485.943 µs [464.56 µs, 507.326 µs] 117.222 µs (31.8%)
iast_FULL 557.332 µs [535.974 µs, 578.69 µs] 188.611 µs (51.2%)
iast_GLOBAL 503.675 µs [482.89 µs, 524.46 µs] 134.954 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED 483.729 µs [461.93 µs, 505.529 µs] 115.008 µs (31.2%)
iast_INACTIVE 445.669 µs [424.115 µs, 467.223 µs] 76.948 µs (20.9%)
iast_TELEMETRY_OFF 463.636 µs [441.642 µs, 485.631 µs] 94.915 µs (25.7%)
tracing 432.923 µs [412.941 µs, 452.906 µs] 64.202 µs (17.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.447 µs [350.07 µs, 388.824 µs] -
iast 484.717 µs [463.039 µs, 506.395 µs] 115.27 µs (31.2%)
iast_FULL 545.487 µs [524.339 µs, 566.634 µs] 176.04 µs (47.6%)
iast_GLOBAL 508.28 µs [486.896 µs, 529.664 µs] 138.834 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED 479.361 µs [458.568 µs, 500.154 µs] 109.914 µs (29.8%)
iast_INACTIVE 443.123 µs [422.015 µs, 464.23 µs] 73.676 µs (19.9%)
iast_TELEMETRY_OFF 468.556 µs [446.273 µs, 490.839 µs] 99.109 µs (26.8%)
tracing 440.816 µs [420.181 µs, 461.452 µs] 71.37 µs (19.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-exception-hash
git_commit_date 1725622627 1725627485
git_commit_sha fb9b96a 1ea0314
release_version 1.40.0-SNAPSHOT~fb9b96a2fa 1.40.0-SNAPSHOT~1ea0314923
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725631456 1725631456
ci_job_id 630250391 630250391
ci_pipeline_id 43731117 43731117
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~1ea0314923, baseline=1.40.0-SNAPSHOT~fb9b96a2fa
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.221 ms) : 2186, 2257
.   : milestone, 2221,
iast (1.97 ms) : 1928, 2013
.   : milestone, 1970,
iast_GLOBAL (2.012 ms) : 1969, 2056
.   : milestone, 2012,
profiling (1.842 ms) : 1809, 1876
.   : milestone, 1842,
tracing (1.843 ms) : 1809, 1877
.   : milestone, 1843,
section candidate
no_agent (1.45 ms) : 1439, 1462
.   : milestone, 1450,
appsec (2.22 ms) : 2185, 2255
.   : milestone, 2220,
iast (1.972 ms) : 1929, 2015
.   : milestone, 1972,
iast_GLOBAL (2.023 ms) : 1979, 2066
.   : milestone, 2023,
profiling (1.862 ms) : 1827, 1896
.   : milestone, 1862,
tracing (1.837 ms) : 1804, 1870
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.221 ms [2.186 ms, 2.257 ms] 762.139 µs (52.2%)
iast 1.97 ms [1.928 ms, 2.013 ms] 511.176 µs (35.0%)
iast_GLOBAL 2.012 ms [1.969 ms, 2.056 ms] 553.267 µs (37.9%)
profiling 1.842 ms [1.809 ms, 1.876 ms] 383.358 µs (26.3%)
tracing 1.843 ms [1.809 ms, 1.877 ms] 384.071 µs (26.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.45 ms [1.439 ms, 1.462 ms] -
appsec 2.22 ms [2.185 ms, 2.255 ms] 769.791 µs (53.1%)
iast 1.972 ms [1.929 ms, 2.015 ms] 521.905 µs (36.0%)
iast_GLOBAL 2.023 ms [1.979 ms, 2.066 ms] 572.425 µs (39.5%)
profiling 1.862 ms [1.827 ms, 1.896 ms] 411.469 µs (28.4%)
tracing 1.837 ms [1.804 ms, 1.87 ms] 386.945 µs (26.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~1ea0314923, baseline=1.40.0-SNAPSHOT~fb9b96a2fa
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.926 s) : 14926000, 14926000
.   : milestone, 14926000,
appsec (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
iast (18.62 s) : 18620000, 18620000
.   : milestone, 18620000,
iast_GLOBAL (17.857 s) : 17857000, 17857000
.   : milestone, 17857000,
profiling (15.689 s) : 15689000, 15689000
.   : milestone, 15689000,
tracing (14.923 s) : 14923000, 14923000
.   : milestone, 14923000,
section candidate
no_agent (14.97 s) : 14970000, 14970000
.   : milestone, 14970000,
appsec (15.318 s) : 15318000, 15318000
.   : milestone, 15318000,
iast (19.08 s) : 19080000, 19080000
.   : milestone, 19080000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
.   : milestone, 17905000,
profiling (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
tracing (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.926 s [14.926 s, 14.926 s] -
appsec 15.418 s [15.418 s, 15.418 s] 492.0 ms (3.3%)
iast 18.62 s [18.62 s, 18.62 s] 3.694 s (24.7%)
iast_GLOBAL 17.857 s [17.857 s, 17.857 s] 2.931 s (19.6%)
profiling 15.689 s [15.689 s, 15.689 s] 763.0 ms (5.1%)
tracing 14.923 s [14.923 s, 14.923 s] -3.0 ms (-0.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.97 s [14.97 s, 14.97 s] -
appsec 15.318 s [15.318 s, 15.318 s] 348.0 ms (2.3%)
iast 19.08 s [19.08 s, 19.08 s] 4.11 s (27.5%)
iast_GLOBAL 17.905 s [17.905 s, 17.905 s] 2.935 s (19.6%)
profiling 15.089 s [15.089 s, 15.089 s] 119.0 ms (0.8%)
tracing 15.049 s [15.049 s, 15.049 s] 79.0 ms (0.5%)

@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Sep 9, 2024
@jpbempel jpbempel merged commit 5ddb19d into master Sep 9, 2024
101 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-exception-hash branch September 9, 2024 12:25
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@cimi cimi Awaiting requested review from cimi cimi is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @PerfectSlayer