Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make redisson tracing the full request #7571

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Make redisson tracing the full request #7571

merged 2 commits into from
Sep 6, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

When tracing redisson redis request, we're only tracing the synchronous part (see #7510 )

Now we're instead capturing a continuation and finish when the command actually finishes. The tricky part here is to follow the changes on interfaces and method signature of the redisson codebase.
In details:

  • 2.0 to 2.3 uses RPromise with netty future listeners
  • 2.3 to 3.10.2 uses RFuture with future listeners
  • 3.10.3 + uses generally speaking CompletionStage but needs a method handle trick to get the promise since the RPromise class has been removed somewhere on the 3.x and would have muzzle blocking the instrumentation on recent versions.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested review from a team as code owners September 5, 2024 15:46
@amarziali amarziali requested a review from ygree September 5, 2024 15:46
@amarziali amarziali added type: bug inst: redis Redis instrumentation labels Sep 5, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/redisson
git_commit_date 1725556786 1725608709
git_commit_sha 0a583fe ee3c323
release_version 1.40.0-SNAPSHOT~0a583fed33 1.40.0-SNAPSHOT~ee3c323b60
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725611067 1725611067
ci_job_id 629844982 629844982
ci_pipeline_id 43705790 43705790
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~ee3c323b60, baseline=1.40.0-SNAPSHOT~0a583fed33

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052093
Total [baseline] (8.489 s) : 0, 8489065
Agent [candidate] (1.051 s) : 0, 1050920
Total [candidate] (8.551 s) : 0, 8550610
section iast
Agent [baseline] (1.174 s) : 0, 1174332
Total [baseline] (8.963 s) : 0, 8962612
Agent [candidate] (1.178 s) : 0, 1178280
Total [candidate] (8.963 s) : 0, 8963284
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1182806
Total [baseline] (8.961 s) : 0, 8960531
Agent [candidate] (1.174 s) : 0, 1174420
Total [candidate] (8.993 s) : 0, 8992712
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1179806
Total [baseline] (8.994 s) : 0, 8993527
Agent [candidate] (1.169 s) : 0, 1169353
Total [candidate] (8.947 s) : 0, 8947245
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.174 s 122.24 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 130.713 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.18 s 127.713 ms (12.1%)
Total tracing 8.489 s -
Total iast 8.963 s 473.547 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.961 s 471.466 ms (5.6%)
Total iast_TELEMETRY_OFF 8.994 s 504.462 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.178 s 127.36 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 123.5 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.169 s 118.433 ms (11.3%)
Total tracing 8.551 s -
Total iast 8.963 s 412.674 ms (4.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.993 s 442.102 ms (5.2%)
Total iast_TELEMETRY_OFF 8.947 s 396.635 ms (4.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~ee3c323b60, baseline=1.40.0-SNAPSHOT~0a583fed33

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.345 ms) : 0, 671345
BytebuddyAgent [candidate] (670.629 ms) : 0, 670629
GlobalTracer [baseline] (307.474 ms) : 0, 307474
GlobalTracer [candidate] (307.408 ms) : 0, 307408
AppSec [baseline] (51.447 ms) : 0, 51447
AppSec [candidate] (51.175 ms) : 0, 51175
Remote Config [baseline] (694.484 µs) : 0, 694
Remote Config [candidate] (671.424 µs) : 0, 671
Telemetry [baseline] (7.52 ms) : 0, 7520
Telemetry [candidate] (7.436 ms) : 0, 7436
section iast
BytebuddyAgent [baseline] (781.265 ms) : 0, 781265
BytebuddyAgent [candidate] (784.763 ms) : 0, 784763
GlobalTracer [baseline] (296.107 ms) : 0, 296107
GlobalTracer [candidate] (296.633 ms) : 0, 296633
AppSec [baseline] (52.502 ms) : 0, 52502
AppSec [candidate] (52.044 ms) : 0, 52044
IAST [baseline] (22.119 ms) : 0, 22119
IAST [candidate] (23.318 ms) : 0, 23318
Remote Config [baseline] (603.359 µs) : 0, 603
Remote Config [candidate] (580.019 µs) : 0, 580
Telemetry [baseline] (8.127 ms) : 0, 8127
Telemetry [candidate] (7.285 ms) : 0, 7285
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (786.595 ms) : 0, 786595
BytebuddyAgent [candidate] (780.746 ms) : 0, 780746
GlobalTracer [baseline] (297.632 ms) : 0, 297632
GlobalTracer [candidate] (296.169 ms) : 0, 296169
AppSec [baseline] (53.32 ms) : 0, 53320
AppSec [candidate] (52.301 ms) : 0, 52301
IAST [baseline] (23.585 ms) : 0, 23585
IAST [candidate] (22.804 ms) : 0, 22804
Remote Config [baseline] (603.245 µs) : 0, 603
Remote Config [candidate] (595.014 µs) : 0, 595
Telemetry [baseline] (7.337 ms) : 0, 7337
Telemetry [candidate] (8.147 ms) : 0, 8147
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.034 ms) : 0, 784034
BytebuddyAgent [candidate] (777.369 ms) : 0, 777369
GlobalTracer [baseline] (297.935 ms) : 0, 297935
GlobalTracer [candidate] (295.956 ms) : 0, 295956
AppSec [baseline] (52.76 ms) : 0, 52760
AppSec [candidate] (53.017 ms) : 0, 53017
IAST [baseline] (22.011 ms) : 0, 22011
IAST [candidate] (20.78 ms) : 0, 20780
Remote Config [baseline] (593.816 µs) : 0, 594
Remote Config [candidate] (589.393 µs) : 0, 589
Telemetry [baseline] (8.745 ms) : 0, 8745
Telemetry [candidate] (7.991 ms) : 0, 7991
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~ee3c323b60, baseline=1.40.0-SNAPSHOT~0a583fed33

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058922
Total [baseline] (10.395 s) : 0, 10395190
Agent [candidate] (1.053 s) : 0, 1053482
Total [candidate] (10.365 s) : 0, 10365249
section appsec
Agent [baseline] (1.187 s) : 0, 1187194
Total [baseline] (10.598 s) : 0, 10598385
Agent [candidate] (1.186 s) : 0, 1185597
Total [candidate] (10.533 s) : 0, 10532532
section iast
Agent [baseline] (1.185 s) : 0, 1185320
Total [baseline] (10.861 s) : 0, 10860733
Agent [candidate] (1.174 s) : 0, 1173853
Total [candidate] (10.795 s) : 0, 10795012
section profiling
Agent [baseline] (1.265 s) : 0, 1265389
Total [baseline] (10.679 s) : 0, 10679172
Agent [candidate] (1.254 s) : 0, 1253643
Total [candidate] (10.675 s) : 0, 10674595
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent appsec 1.187 s 128.272 ms (12.1%)
Agent iast 1.185 s 126.398 ms (11.9%)
Agent profiling 1.265 s 206.467 ms (19.5%)
Total tracing 10.395 s -
Total appsec 10.598 s 203.195 ms (2.0%)
Total iast 10.861 s 465.542 ms (4.5%)
Total profiling 10.679 s 283.982 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent appsec 1.186 s 132.115 ms (12.5%)
Agent iast 1.174 s 120.372 ms (11.4%)
Agent profiling 1.254 s 200.161 ms (19.0%)
Total tracing 10.365 s -
Total appsec 10.533 s 167.283 ms (1.6%)
Total iast 10.795 s 429.764 ms (4.1%)
Total profiling 10.675 s 309.346 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~ee3c323b60, baseline=1.40.0-SNAPSHOT~0a583fed33

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.183 ms) : 0, 676183
BytebuddyAgent [candidate] (674.055 ms) : 0, 674055
GlobalTracer [baseline] (309.183 ms) : 0, 309183
GlobalTracer [candidate] (306.044 ms) : 0, 306044
AppSec [baseline] (51.67 ms) : 0, 51670
AppSec [candidate] (51.537 ms) : 0, 51537
Remote Config [baseline] (682.424 µs) : 0, 682
Remote Config [candidate] (694.362 µs) : 0, 694
Telemetry [baseline] (7.486 ms) : 0, 7486
Telemetry [candidate] (7.479 ms) : 0, 7479
section appsec
BytebuddyAgent [baseline] (692.247 ms) : 0, 692247
BytebuddyAgent [candidate] (691.4 ms) : 0, 691400
GlobalTracer [baseline] (301.902 ms) : 0, 301902
GlobalTracer [candidate] (301.009 ms) : 0, 301009
AppSec [baseline] (158.879 ms) : 0, 158879
AppSec [candidate] (160.449 ms) : 0, 160449
Remote Config [baseline] (631.276 µs) : 0, 631
Remote Config [candidate] (627.672 µs) : 0, 628
Telemetry [baseline] (9.255 ms) : 0, 9255
Telemetry [candidate] (8.577 ms) : 0, 8577
IAST [baseline] (21.333 ms) : 0, 21333
IAST [candidate] (19.829 ms) : 0, 19829
section iast
BytebuddyAgent [baseline] (790.225 ms) : 0, 790225
BytebuddyAgent [candidate] (780.697 ms) : 0, 780697
GlobalTracer [baseline] (298.194 ms) : 0, 298194
GlobalTracer [candidate] (296.141 ms) : 0, 296141
AppSec [baseline] (52.321 ms) : 0, 52321
AppSec [candidate] (54.556 ms) : 0, 54556
Remote Config [baseline] (1.323 ms) : 0, 1323
Remote Config [candidate] (577.812 µs) : 0, 578
Telemetry [baseline] (7.38 ms) : 0, 7380
Telemetry [candidate] (7.323 ms) : 0, 7323
IAST [baseline] (22.112 ms) : 0, 22112
IAST [candidate] (20.903 ms) : 0, 20903
section profiling
BytebuddyAgent [baseline] (675.594 ms) : 0, 675594
BytebuddyAgent [candidate] (667.875 ms) : 0, 667875
GlobalTracer [baseline] (393.001 ms) : 0, 393001
GlobalTracer [candidate] (390.423 ms) : 0, 390423
AppSec [baseline] (52.72 ms) : 0, 52720
AppSec [candidate] (52.38 ms) : 0, 52380
Remote Config [baseline] (705.826 µs) : 0, 706
Remote Config [candidate] (696.237 µs) : 0, 696
Telemetry [baseline] (7.526 ms) : 0, 7526
Telemetry [candidate] (7.399 ms) : 0, 7399
ProfilingAgent [baseline] (97.395 ms) : 0, 97395
ProfilingAgent [candidate] (96.8 ms) : 0, 96800
Profiling [baseline] (97.419 ms) : 0, 97419
Profiling [candidate] (96.824 ms) : 0, 96824
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-06T07:57:26 2024-09-06T08:04:13
git_branch master andrea.marziali/redisson
git_commit_date 1725556786 1725608709
git_commit_sha 0a583fe ee3c323
release_version 1.40.0-SNAPSHOT~0a583fed33 1.40.0-SNAPSHOT~ee3c323b60
start_time 2024-09-06T07:57:13 2024-09-06T08:04:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725610197 1725610197
ci_job_id 629844983 629844983
ci_pipeline_id 43705790 43705790
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~ee3c323b60, baseline=1.40.0-SNAPSHOT~0a583fed33
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1317, 1357
.   : milestone, 1337,
appsec (1.721 ms) : 1697, 1745
.   : milestone, 1721,
appsec_no_iast (1.723 ms) : 1699, 1747
.   : milestone, 1723,
iast (1.467 ms) : 1445, 1489
.   : milestone, 1467,
profiling (1.484 ms) : 1460, 1507
.   : milestone, 1484,
tracing (1.463 ms) : 1439, 1486
.   : milestone, 1463,
section candidate
no_agent (1.336 ms) : 1317, 1355
.   : milestone, 1336,
appsec (1.698 ms) : 1674, 1723
.   : milestone, 1698,
appsec_no_iast (1.698 ms) : 1674, 1722
.   : milestone, 1698,
iast (1.48 ms) : 1458, 1502
.   : milestone, 1480,
profiling (1.498 ms) : 1474, 1523
.   : milestone, 1498,
tracing (1.467 ms) : 1443, 1492
.   : milestone, 1467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.317 ms, 1.357 ms] -
appsec 1.721 ms [1.697 ms, 1.745 ms] 384.275 µs (28.7%)
appsec_no_iast 1.723 ms [1.699 ms, 1.747 ms] 386.03 µs (28.9%)
iast 1.467 ms [1.445 ms, 1.489 ms] 130.124 µs (9.7%)
profiling 1.484 ms [1.46 ms, 1.507 ms] 146.71 µs (11.0%)
tracing 1.463 ms [1.439 ms, 1.486 ms] 125.488 µs (9.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.317 ms, 1.355 ms] -
appsec 1.698 ms [1.674 ms, 1.723 ms] 362.654 µs (27.1%)
appsec_no_iast 1.698 ms [1.674 ms, 1.722 ms] 362.228 µs (27.1%)
iast 1.48 ms [1.458 ms, 1.502 ms] 144.0 µs (10.8%)
profiling 1.498 ms [1.474 ms, 1.523 ms] 162.696 µs (12.2%)
tracing 1.467 ms [1.443 ms, 1.492 ms] 131.693 µs (9.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~ee3c323b60, baseline=1.40.0-SNAPSHOT~0a583fed33
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.33 µs) : 348, 387
.   : milestone, 367,
iast (478.811 µs) : 456, 501
.   : milestone, 479,
iast_FULL (551.945 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (506.969 µs) : 486, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (483.288 µs) : 462, 505
.   : milestone, 483,
iast_INACTIVE (442.732 µs) : 422, 463
.   : milestone, 443,
iast_TELEMETRY_OFF (466.769 µs) : 444, 489
.   : milestone, 467,
tracing (436.869 µs) : 417, 457
.   : milestone, 437,
section candidate
no_agent (366.085 µs) : 345, 387
.   : milestone, 366,
iast (482.509 µs) : 460, 505
.   : milestone, 483,
iast_FULL (559.276 µs) : 537, 581
.   : milestone, 559,
iast_GLOBAL (503.798 µs) : 481, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (478.274 µs) : 456, 500
.   : milestone, 478,
iast_INACTIVE (439.041 µs) : 419, 459
.   : milestone, 439,
iast_TELEMETRY_OFF (473.539 µs) : 451, 496
.   : milestone, 474,
tracing (439.663 µs) : 419, 461
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.33 µs [348.142 µs, 386.518 µs] -
iast 478.811 µs [456.34 µs, 501.282 µs] 111.482 µs (30.3%)
iast_FULL 551.945 µs [530.575 µs, 573.316 µs] 184.616 µs (50.3%)
iast_GLOBAL 506.969 µs [485.875 µs, 528.063 µs] 139.639 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED 483.288 µs [461.583 µs, 504.994 µs] 115.959 µs (31.6%)
iast_INACTIVE 442.732 µs [422.091 µs, 463.373 µs] 75.402 µs (20.5%)
iast_TELEMETRY_OFF 466.769 µs [444.204 µs, 489.335 µs] 99.44 µs (27.1%)
tracing 436.869 µs [416.669 µs, 457.069 µs] 69.539 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.085 µs [345.376 µs, 386.794 µs] -
iast 482.509 µs [459.825 µs, 505.194 µs] 116.424 µs (31.8%)
iast_FULL 559.276 µs [537.485 µs, 581.068 µs] 193.191 µs (52.8%)
iast_GLOBAL 503.798 µs [481.431 µs, 526.164 µs] 137.713 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED 478.274 µs [456.234 µs, 500.313 µs] 112.189 µs (30.6%)
iast_INACTIVE 439.041 µs [418.794 µs, 459.287 µs] 72.956 µs (19.9%)
iast_TELEMETRY_OFF 473.539 µs [451.068 µs, 496.009 µs] 107.454 µs (29.4%)
tracing 439.663 µs [418.577 µs, 460.749 µs] 73.578 µs (20.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/redisson
git_commit_date 1725556786 1725608709
git_commit_sha 0a583fe ee3c323
release_version 1.40.0-SNAPSHOT~0a583fed33 1.40.0-SNAPSHOT~ee3c323b60
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725610703 1725610703
ci_job_id 629844984 629844984
ci_pipeline_id 43705790 43705790
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~ee3c323b60, baseline=1.40.0-SNAPSHOT~0a583fed33
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.042 s) : 15042000, 15042000
.   : milestone, 15042000,
appsec (15.231 s) : 15231000, 15231000
.   : milestone, 15231000,
iast (18.963 s) : 18963000, 18963000
.   : milestone, 18963000,
iast_GLOBAL (17.791 s) : 17791000, 17791000
.   : milestone, 17791000,
profiling (15.397 s) : 15397000, 15397000
.   : milestone, 15397000,
tracing (14.987 s) : 14987000, 14987000
.   : milestone, 14987000,
section candidate
no_agent (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
appsec (15.024 s) : 15024000, 15024000
.   : milestone, 15024000,
iast (18.831 s) : 18831000, 18831000
.   : milestone, 18831000,
iast_GLOBAL (17.927 s) : 17927000, 17927000
.   : milestone, 17927000,
profiling (15.369 s) : 15369000, 15369000
.   : milestone, 15369000,
tracing (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.042 s [15.042 s, 15.042 s] -
appsec 15.231 s [15.231 s, 15.231 s] 189.0 ms (1.3%)
iast 18.963 s [18.963 s, 18.963 s] 3.921 s (26.1%)
iast_GLOBAL 17.791 s [17.791 s, 17.791 s] 2.749 s (18.3%)
profiling 15.397 s [15.397 s, 15.397 s] 355.0 ms (2.4%)
tracing 14.987 s [14.987 s, 14.987 s] -55.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.997 s [14.997 s, 14.997 s] -
appsec 15.024 s [15.024 s, 15.024 s] 27.0 ms (0.2%)
iast 18.831 s [18.831 s, 18.831 s] 3.834 s (25.6%)
iast_GLOBAL 17.927 s [17.927 s, 17.927 s] 2.93 s (19.5%)
profiling 15.369 s [15.369 s, 15.369 s] 372.0 ms (2.5%)
tracing 15.114 s [15.114 s, 15.114 s] 117.0 ms (0.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~ee3c323b60, baseline=1.40.0-SNAPSHOT~0a583fed33
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.452 ms) : 1440, 1463
.   : milestone, 1452,
appsec (2.206 ms) : 2171, 2241
.   : milestone, 2206,
iast (1.968 ms) : 1925, 2011
.   : milestone, 1968,
iast_GLOBAL (2.034 ms) : 1988, 2079
.   : milestone, 2034,
profiling (1.855 ms) : 1820, 1889
.   : milestone, 1855,
tracing (1.831 ms) : 1797, 1864
.   : milestone, 1831,
section candidate
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.212 ms) : 2177, 2247
.   : milestone, 2212,
iast (1.952 ms) : 1909, 1994
.   : milestone, 1952,
iast_GLOBAL (2.011 ms) : 1967, 2055
.   : milestone, 2011,
profiling (2.334 ms) : 2146, 2521
.   : milestone, 2334,
tracing (1.83 ms) : 1797, 1863
.   : milestone, 1830,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.452 ms [1.44 ms, 1.463 ms] -
appsec 2.206 ms [2.171 ms, 2.241 ms] 754.778 µs (52.0%)
iast 1.968 ms [1.925 ms, 2.011 ms] 516.386 µs (35.6%)
iast_GLOBAL 2.034 ms [1.988 ms, 2.079 ms] 582.196 µs (40.1%)
profiling 1.855 ms [1.82 ms, 1.889 ms] 402.903 µs (27.8%)
tracing 1.831 ms [1.797 ms, 1.864 ms] 378.952 µs (26.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.212 ms [2.177 ms, 2.247 ms] 755.904 µs (51.9%)
iast 1.952 ms [1.909 ms, 1.994 ms] 495.534 µs (34.0%)
iast_GLOBAL 2.011 ms [1.967 ms, 2.055 ms] 554.523 µs (38.1%)
profiling 2.334 ms [2.146 ms, 2.521 ms] 877.637 µs (60.3%)
tracing 1.83 ms [1.797 ms, 1.863 ms] 374.153 µs (25.7%)

PerfectSlayer
PerfectSlayer reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Can you move all three redisson instrumentation under a redisson folder to follow conventions?
(yeah, I know not all our instrumentations follow them, but fixing this one is better than nothing)

@amarziali amarziali merged commit 70e0c21 into master Sep 6, 2024
98 checks passed
@amarziali amarziali deleted the andrea.marziali/redisson branch September 6, 2024 10:46
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: redis Redis instrumentation type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @PerfectSlayer