Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix span decoration probe EMITTING status #7569

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix span decoration probe EMITTING status #7569

merged 1 commit into from
Sep 10, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 5, 2024 •
edited by jira bot
Loading

What Does This Do

Don't emit the status when no tag are set for the span

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2825

@jpbempel
Fix span decoration probe EMITTING status
cce93a5 
Don't emit the status when no tag are set for the span
@jpbempel jpbempel added type: bug comp: debugger Dynamic Instrumentation labels Sep 5, 2024
@jpbempel jpbempel requested a review from a team as a code owner September 5, 2024 14:34
@jpbempel jpbempel requested review from evanchooly and removed request for a team September 5, 2024 14:34
@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1725547200 1725547580
end_time 2024-09-05T14:41:14 2024-09-05T14:47:33
git_branch master jpbempel/fix-emitting-span-deco
git_commit_sha 123a2c8 cce93a5
start_time 2024-09-05T14:40:01 2024-09-05T14:46:20
See matching parameters
Baseline Candidate
ci_job_id 628851888 628851888
ci_pipeline_id 43623168 43623168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1725546638 1725546638

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-40.005µs; +59.620µs] or [-15.161%; +22.595%]		 unstable
[-50.371µs; +69.428µs] or [-16.740%; +23.073%]		 unstable
[-62.461µs; +89.294µs] or [-19.821%; +28.336%]		 unstable
[-394.043µs; +1074.197µs] or [-59.899%; +163.291%]		 same
scenario:basic same same unstable
[-22.990µs; +9.349µs] or [-7.318%; +2.976%]		 unstable
[-50.250µs; +68.062µs] or [-8.184%; +11.085%]		 unstable
[-204.166op/s; +204.166op/s] or [-7.962%; +7.962%]
scenario:loop same same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (300.905 µs) : 255, 346
.   : milestone, 301,
basic (304.457 µs) : 294, 315
.   : milestone, 304,
loop (10.53 ms) : 10490, 10570
.   : milestone, 10530,
section candidate
noprobe (310.434 µs) : 244, 377
.   : milestone, 310,
basic (297.982 µs) : 284, 312
.   : milestone, 298,
loop (10.515 ms) : 10485, 10545
.   : milestone, 10515,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 300.905 µs [255.405 µs, 346.406 µs]
basic 304.457 µs [294.242 µs, 314.672 µs]
loop 10.53 ms [10.49 ms, 10.57 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 310.434 µs [243.625 µs, 377.243 µs]
basic 297.982 µs [283.648 µs, 312.315 µs]
loop 10.515 ms [10.485 ms, 10.545 ms]

@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-emitting-span-deco
git_commit_date 1725545464 1725546638
git_commit_sha 123a2c8 cce93a5
release_version 1.40.0-SNAPSHOT~123a2c8614 1.40.0-SNAPSHOT~cce93a551f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725548907 1725548907
ci_job_id 628851879 628851879
ci_pipeline_id 43623168 43623168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~cce93a551f, baseline=1.40.0-SNAPSHOT~123a2c8614

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058315
Total [baseline] (10.424 s) : 0, 10423651
Agent [candidate] (1.05 s) : 0, 1049682
Total [candidate] (10.35 s) : 0, 10350187
section appsec
Agent [baseline] (1.183 s) : 0, 1182560
Total [baseline] (10.639 s) : 0, 10639472
Agent [candidate] (1.189 s) : 0, 1188719
Total [candidate] (10.633 s) : 0, 10632558
section iast
Agent [baseline] (1.173 s) : 0, 1172561
Total [baseline] (10.816 s) : 0, 10815847
Agent [candidate] (1.183 s) : 0, 1183475
Total [candidate] (10.794 s) : 0, 10793507
section profiling
Agent [baseline] (1.243 s) : 0, 1243486
Total [baseline] (10.608 s) : 0, 10607542
Agent [candidate] (1.261 s) : 0, 1260630
Total [candidate] (10.587 s) : 0, 10587088
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.183 s 124.245 ms (11.7%)
Agent iast 1.173 s 114.246 ms (10.8%)
Agent profiling 1.243 s 185.171 ms (17.5%)
Total tracing 10.424 s -
Total appsec 10.639 s 215.821 ms (2.1%)
Total iast 10.816 s 392.196 ms (3.8%)
Total profiling 10.608 s 183.891 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.189 s 139.037 ms (13.2%)
Agent iast 1.183 s 133.793 ms (12.7%)
Agent profiling 1.261 s 210.949 ms (20.1%)
Total tracing 10.35 s -
Total appsec 10.633 s 282.371 ms (2.7%)
Total iast 10.794 s 443.32 ms (4.3%)
Total profiling 10.587 s 236.901 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~cce93a551f, baseline=1.40.0-SNAPSHOT~123a2c8614

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.195 ms) : 0, 676195
BytebuddyAgent [candidate] (669.06 ms) : 0, 669060
GlobalTracer [baseline] (308.542 ms) : 0, 308542
GlobalTracer [candidate] (307.464 ms) : 0, 307464
AppSec [baseline] (51.632 ms) : 0, 51632
AppSec [candidate] (51.452 ms) : 0, 51452
Remote Config [baseline] (681.825 µs) : 0, 682
Remote Config [candidate] (676.692 µs) : 0, 677
Telemetry [baseline] (7.519 ms) : 0, 7519
Telemetry [candidate] (7.467 ms) : 0, 7467
section appsec
BytebuddyAgent [baseline] (690.376 ms) : 0, 690376
BytebuddyAgent [candidate] (692.937 ms) : 0, 692937
GlobalTracer [baseline] (300.309 ms) : 0, 300309
GlobalTracer [candidate] (302.031 ms) : 0, 302031
AppSec [baseline] (158.194 ms) : 0, 158194
AppSec [candidate] (160.411 ms) : 0, 160411
Remote Config [baseline] (623.415 µs) : 0, 623
Remote Config [candidate] (622.926 µs) : 0, 623
Telemetry [baseline] (9.633 ms) : 0, 9633
Telemetry [candidate] (8.833 ms) : 0, 8833
IAST [baseline] (19.718 ms) : 0, 19718
IAST [candidate] (20.491 ms) : 0, 20491
section iast
BytebuddyAgent [baseline] (780.528 ms) : 0, 780528
BytebuddyAgent [candidate] (787.212 ms) : 0, 787212
GlobalTracer [baseline] (296.105 ms) : 0, 296105
GlobalTracer [candidate] (298.18 ms) : 0, 298180
AppSec [baseline] (50.951 ms) : 0, 50951
AppSec [candidate] (52.758 ms) : 0, 52758
Remote Config [baseline] (583.803 µs) : 0, 584
Remote Config [candidate] (587.821 µs) : 0, 588
Telemetry [baseline] (7.301 ms) : 0, 7301
Telemetry [candidate] (7.322 ms) : 0, 7322
IAST [baseline] (23.534 ms) : 0, 23534
IAST [candidate] (23.711 ms) : 0, 23711
section profiling
BytebuddyAgent [baseline] (662.929 ms) : 0, 662929
BytebuddyAgent [candidate] (672.71 ms) : 0, 672710
GlobalTracer [baseline] (387.923 ms) : 0, 387923
GlobalTracer [candidate] (393.379 ms) : 0, 393379
AppSec [baseline] (51.882 ms) : 0, 51882
AppSec [candidate] (52.289 ms) : 0, 52289
Remote Config [baseline] (668.361 µs) : 0, 668
Remote Config [candidate] (687.655 µs) : 0, 688
Telemetry [baseline] (7.352 ms) : 0, 7352
Telemetry [candidate] (7.359 ms) : 0, 7359
ProfilingAgent [baseline] (94.958 ms) : 0, 94958
ProfilingAgent [candidate] (95.89 ms) : 0, 95890
Profiling [baseline] (94.982 ms) : 0, 94982
Profiling [candidate] (95.914 ms) : 0, 95914
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~cce93a551f, baseline=1.40.0-SNAPSHOT~123a2c8614

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057838
Total [baseline] (8.501 s) : 0, 8500562
Agent [candidate] (1.05 s) : 0, 1050331
Total [candidate] (8.493 s) : 0, 8493006
section iast
Agent [baseline] (1.172 s) : 0, 1172428
Total [baseline] (8.946 s) : 0, 8946006
Agent [candidate] (1.182 s) : 0, 1181831
Total [candidate] (8.996 s) : 0, 8996196
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174363
Total [baseline] (8.952 s) : 0, 8951502
Agent [candidate] (1.182 s) : 0, 1182312
Total [candidate] (8.974 s) : 0, 8973632
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172852
Total [baseline] (8.982 s) : 0, 8982006
Agent [candidate] (1.172 s) : 0, 1171729
Total [candidate] (8.935 s) : 0, 8935374
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.172 s 114.59 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 116.525 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.173 s 115.014 ms (10.9%)
Total tracing 8.501 s -
Total iast 8.946 s 445.444 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.952 s 450.94 ms (5.3%)
Total iast_TELEMETRY_OFF 8.982 s 481.445 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent iast 1.182 s 131.5 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.182 s 131.981 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.172 s 121.398 ms (11.6%)
Total tracing 8.493 s -
Total iast 8.996 s 503.19 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.974 s 480.626 ms (5.7%)
Total iast_TELEMETRY_OFF 8.935 s 442.368 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~cce93a551f, baseline=1.40.0-SNAPSHOT~123a2c8614

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.206 ms) : 0, 675206
BytebuddyAgent [candidate] (670.188 ms) : 0, 670188
GlobalTracer [baseline] (309.056 ms) : 0, 309056
GlobalTracer [candidate] (307.431 ms) : 0, 307431
AppSec [baseline] (51.672 ms) : 0, 51672
AppSec [candidate] (51.055 ms) : 0, 51055
Remote Config [baseline] (676.488 µs) : 0, 676
Remote Config [candidate] (656.48 µs) : 0, 656
Telemetry [baseline] (7.526 ms) : 0, 7526
Telemetry [candidate] (7.426 ms) : 0, 7426
section iast
BytebuddyAgent [baseline] (780.118 ms) : 0, 780118
BytebuddyAgent [candidate] (786.331 ms) : 0, 786331
GlobalTracer [baseline] (295.591 ms) : 0, 295591
GlobalTracer [candidate] (297.816 ms) : 0, 297816
AppSec [baseline] (51.6 ms) : 0, 51600
AppSec [candidate] (51.87 ms) : 0, 51870
IAST [baseline] (22.891 ms) : 0, 22891
IAST [candidate] (24.247 ms) : 0, 24247
Remote Config [baseline] (592.734 µs) : 0, 593
Remote Config [candidate] (608.047 µs) : 0, 608
Telemetry [baseline] (8.045 ms) : 0, 8045
Telemetry [candidate] (7.274 ms) : 0, 7274
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.809 ms) : 0, 780809
BytebuddyAgent [candidate] (785.894 ms) : 0, 785894
GlobalTracer [baseline] (296.282 ms) : 0, 296282
GlobalTracer [candidate] (298.389 ms) : 0, 298389
AppSec [baseline] (53.998 ms) : 0, 53998
AppSec [candidate] (53.623 ms) : 0, 53623
IAST [baseline] (21.823 ms) : 0, 21823
IAST [candidate] (22.692 ms) : 0, 22692
Remote Config [baseline] (581.682 µs) : 0, 582
Remote Config [candidate] (597.642 µs) : 0, 598
Telemetry [baseline] (7.278 ms) : 0, 7278
Telemetry [candidate] (7.391 ms) : 0, 7391
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.729 ms) : 0, 779729
BytebuddyAgent [candidate] (778.426 ms) : 0, 778426
GlobalTracer [baseline] (296.511 ms) : 0, 296511
GlobalTracer [candidate] (296.479 ms) : 0, 296479
AppSec [baseline] (52.064 ms) : 0, 52064
AppSec [candidate] (52.307 ms) : 0, 52307
IAST [baseline] (22.276 ms) : 0, 22276
IAST [candidate] (22.36 ms) : 0, 22360
Remote Config [baseline] (576.804 µs) : 0, 577
Remote Config [candidate] (570.383 µs) : 0, 570
Telemetry [baseline] (8.047 ms) : 0, 8047
Telemetry [candidate] (7.969 ms) : 0, 7969
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-05T14:41:10 2024-09-05T14:47:59
git_branch master jpbempel/fix-emitting-span-deco
git_commit_date 1725545464 1725546638
git_commit_sha 123a2c8 cce93a5
release_version 1.40.0-SNAPSHOT~123a2c8614 1.40.0-SNAPSHOT~cce93a551f
start_time 2024-09-05T14:40:57 2024-09-05T14:47:46
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725548025 1725548025
ci_job_id 628851881 628851881
ci_pipeline_id 43623168 43623168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~cce93a551f, baseline=1.40.0-SNAPSHOT~123a2c8614
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.353 µs) : 363, 404
.   : milestone, 383,
iast (488.151 µs) : 466, 510
.   : milestone, 488,
iast_FULL (553.99 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (514.634 µs) : 492, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (481.701 µs) : 460, 503
.   : milestone, 482,
iast_INACTIVE (448.199 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (472.986 µs) : 451, 495
.   : milestone, 473,
tracing (444.727 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (370.794 µs) : 350, 392
.   : milestone, 371,
iast (485.81 µs) : 463, 509
.   : milestone, 486,
iast_FULL (551.143 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (527.719 µs) : 505, 550
.   : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (482.426 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (444.758 µs) : 424, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (471.841 µs) : 449, 494
.   : milestone, 472,
tracing (438.193 µs) : 418, 458
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.353 µs [362.689 µs, 404.016 µs] -
iast 488.151 µs [465.909 µs, 510.393 µs] 104.799 µs (27.3%)
iast_FULL 553.99 µs [532.681 µs, 575.298 µs] 170.637 µs (44.5%)
iast_GLOBAL 514.634 µs [492.113 µs, 537.156 µs] 131.282 µs (34.2%)
iast_HARDCODED_SECRET_DISABLED 481.701 µs [460.23 µs, 503.172 µs] 98.348 µs (25.7%)
iast_INACTIVE 448.199 µs [427.33 µs, 469.069 µs] 64.847 µs (16.9%)
iast_TELEMETRY_OFF 472.986 µs [450.66 µs, 495.313 µs] 89.634 µs (23.4%)
tracing 444.727 µs [423.52 µs, 465.935 µs] 61.375 µs (16.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.794 µs [349.873 µs, 391.715 µs] -
iast 485.81 µs [462.523 µs, 509.097 µs] 115.016 µs (31.0%)
iast_FULL 551.143 µs [529.663 µs, 572.623 µs] 180.349 µs (48.6%)
iast_GLOBAL 527.719 µs [505.125 µs, 550.313 µs] 156.925 µs (42.3%)
iast_HARDCODED_SECRET_DISABLED 482.426 µs [460.835 µs, 504.017 µs] 111.633 µs (30.1%)
iast_INACTIVE 444.758 µs [424.334 µs, 465.182 µs] 73.965 µs (19.9%)
iast_TELEMETRY_OFF 471.841 µs [449.378 µs, 494.303 µs] 101.047 µs (27.3%)
tracing 438.193 µs [417.933 µs, 458.453 µs] 67.399 µs (18.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~cce93a551f, baseline=1.40.0-SNAPSHOT~123a2c8614
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1312, 1351
.   : milestone, 1332,
appsec (1.725 ms) : 1701, 1749
.   : milestone, 1725,
appsec_no_iast (1.709 ms) : 1685, 1732
.   : milestone, 1709,
iast (1.493 ms) : 1470, 1515
.   : milestone, 1493,
profiling (1.502 ms) : 1478, 1527
.   : milestone, 1502,
tracing (1.471 ms) : 1447, 1496
.   : milestone, 1471,
section candidate
no_agent (1.353 ms) : 1333, 1373
.   : milestone, 1353,
appsec (1.712 ms) : 1689, 1736
.   : milestone, 1712,
appsec_no_iast (1.723 ms) : 1699, 1747
.   : milestone, 1723,
iast (1.478 ms) : 1456, 1500
.   : milestone, 1478,
profiling (1.493 ms) : 1468, 1517
.   : milestone, 1493,
tracing (1.483 ms) : 1459, 1507
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.312 ms, 1.351 ms] -
appsec 1.725 ms [1.701 ms, 1.749 ms] 393.238 µs (29.5%)
appsec_no_iast 1.709 ms [1.685 ms, 1.732 ms] 376.754 µs (28.3%)
iast 1.493 ms [1.47 ms, 1.515 ms] 160.898 µs (12.1%)
profiling 1.502 ms [1.478 ms, 1.527 ms] 170.667 µs (12.8%)
tracing 1.471 ms [1.447 ms, 1.496 ms] 139.628 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.333 ms, 1.373 ms] -
appsec 1.712 ms [1.689 ms, 1.736 ms] 359.323 µs (26.6%)
appsec_no_iast 1.723 ms [1.699 ms, 1.747 ms] 369.996 µs (27.3%)
iast 1.478 ms [1.456 ms, 1.5 ms] 124.955 µs (9.2%)
profiling 1.493 ms [1.468 ms, 1.517 ms] 139.562 µs (10.3%)
tracing 1.483 ms [1.459 ms, 1.507 ms] 130.045 µs (9.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-emitting-span-deco
git_commit_date 1725545464 1725546638
git_commit_sha 123a2c8 cce93a5
release_version 1.40.0-SNAPSHOT~123a2c8614 1.40.0-SNAPSHOT~cce93a551f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725548532 1725548532
ci_job_id 628851883 628851883
ci_pipeline_id 43623168 43623168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~cce93a551f, baseline=1.40.0-SNAPSHOT~123a2c8614
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1469
.   : milestone, 1458,
appsec (2.22 ms) : 2185, 2254
.   : milestone, 2220,
iast (1.999 ms) : 1954, 2043
.   : milestone, 1999,
iast_GLOBAL (2.03 ms) : 1986, 2073
.   : milestone, 2030,
profiling (1.87 ms) : 1836, 1905
.   : milestone, 1870,
tracing (1.849 ms) : 1816, 1883
.   : milestone, 1849,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.243 ms) : 2207, 2278
.   : milestone, 2243,
iast (1.97 ms) : 1928, 2012
.   : milestone, 1970,
iast_GLOBAL (2.036 ms) : 1991, 2081
.   : milestone, 2036,
profiling (2.36 ms) : 2174, 2546
.   : milestone, 2360,
tracing (1.847 ms) : 1813, 1880
.   : milestone, 1847,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.469 ms] -
appsec 2.22 ms [2.185 ms, 2.254 ms] 761.561 µs (52.2%)
iast 1.999 ms [1.954 ms, 2.043 ms] 540.378 µs (37.1%)
iast_GLOBAL 2.03 ms [1.986 ms, 2.073 ms] 571.696 µs (39.2%)
profiling 1.87 ms [1.836 ms, 1.905 ms] 412.308 µs (28.3%)
tracing 1.849 ms [1.816 ms, 1.883 ms] 390.982 µs (26.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.243 ms [2.207 ms, 2.278 ms] 782.964 µs (53.6%)
iast 1.97 ms [1.928 ms, 2.012 ms] 510.166 µs (34.9%)
iast_GLOBAL 2.036 ms [1.991 ms, 2.081 ms] 576.113 µs (39.5%)
profiling 2.36 ms [2.174 ms, 2.546 ms] 900.238 µs (61.7%)
tracing 1.847 ms [1.813 ms, 1.88 ms] 386.711 µs (26.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~cce93a551f, baseline=1.40.0-SNAPSHOT~123a2c8614
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,
appsec (15.417 s) : 15417000, 15417000
.   : milestone, 15417000,
iast (18.818 s) : 18818000, 18818000
.   : milestone, 18818000,
iast_GLOBAL (17.93 s) : 17930000, 17930000
.   : milestone, 17930000,
profiling (15.264 s) : 15264000, 15264000
.   : milestone, 15264000,
tracing (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
section candidate
no_agent (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
appsec (15.229 s) : 15229000, 15229000
.   : milestone, 15229000,
iast (18.814 s) : 18814000, 18814000
.   : milestone, 18814000,
iast_GLOBAL (17.946 s) : 17946000, 17946000
.   : milestone, 17946000,
profiling (15.314 s) : 15314000, 15314000
.   : milestone, 15314000,
tracing (15.186 s) : 15186000, 15186000
.   : milestone, 15186000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.0 s [15.0 s, 15.0 s] -
appsec 15.417 s [15.417 s, 15.417 s] 417.0 ms (2.8%)
iast 18.818 s [18.818 s, 18.818 s] 3.818 s (25.5%)
iast_GLOBAL 17.93 s [17.93 s, 17.93 s] 2.93 s (19.5%)
profiling 15.264 s [15.264 s, 15.264 s] 264.0 ms (1.8%)
tracing 15.026 s [15.026 s, 15.026 s] 26.0 ms (0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.947 s [14.947 s, 14.947 s] -
appsec 15.229 s [15.229 s, 15.229 s] 282.0 ms (1.9%)
iast 18.814 s [18.814 s, 18.814 s] 3.867 s (25.9%)
iast_GLOBAL 17.946 s [17.946 s, 17.946 s] 2.999 s (20.1%)
profiling 15.314 s [15.314 s, 15.314 s] 367.0 ms (2.5%)
tracing 15.186 s [15.186 s, 15.186 s] 239.0 ms (1.6%)

shatzi
shatzi approved these changes Sep 9, 2024
View reviewed changes
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/SpanDecorationProbe.java
@@ -232,7 +232,10 @@ private void decorateTags(SpanDecorationStatus status) {
for (Pair<String, String> tag : tagsToDecorate) {
agentSpan.setTag(tag.getLeft(), tag.getRight());
}
DebuggerAgent.getSink().getProbeStatusSink().addEmitting(probeId);
if (!tagsToDecorate.isEmpty()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

Do we specify this on the RFC? better to be explicit about this edge case.
Do we have system-test to check this happens?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a system tests will be added for that

@jpbempel jpbempel merged commit 5ca22e4 into master Sep 10, 2024
101 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-emitting-span-deco branch September 10, 2024 05:37
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

@evanchooly evanchooly Awaiting requested review from evanchooly evanchooly is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi