Google PubSub: implement switchable legacy tracing mode #7564

amarziali · 2024-09-04T14:48:51Z

What Does This Do

Google pubsub was lacking of the possibility to turn off the legacy tracing mode. When off, the consumer will use the value of DD_SERVICE instead that google-pubsub as a service name.

The feature can be activated by:

A system property -Ddd.google-pubsub.legacy.tracing.enabled=false
An environment variable DD_GOOGLE_PUBSUB_LEGACY_TRACING_ENABLED=false

Motivation

see #7209

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-09-04T15:28:29Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/pubsub-no-legacy
git_commit_date	1725455874	1725461168
git_commit_sha	`86d01e6`	`4cb14e9`
release_version	1.40.0-SNAPSHOT~86d01e6f14	1.40.0-SNAPSHOT~4cb14e94e8

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1725463541	1725463541
ci_job_id	627316233	627316233
ci_pipeline_id	43521364	43521364
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~4cb14e94e8, baseline=1.40.0-SNAPSHOT~86d01e6f14

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053401
Total [baseline] (8.531 s) : 0, 8530689
Agent [candidate] (1.053 s) : 0, 1052922
Total [candidate] (8.474 s) : 0, 8473764
section iast
Agent [baseline] (1.186 s) : 0, 1185934
Total [baseline] (8.989 s) : 0, 8989380
Agent [candidate] (1.176 s) : 0, 1176450
Total [candidate] (8.983 s) : 0, 8983489
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175698
Total [baseline] (8.917 s) : 0, 8917084
Agent [candidate] (1.176 s) : 0, 1175757
Total [candidate] (8.964 s) : 0, 8964468
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1171077
Total [baseline] (8.959 s) : 0, 8958705
Agent [candidate] (1.171 s) : 0, 1171304
Total [candidate] (8.962 s) : 0, 8961840

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.186 s	132.534 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.176 s	122.297 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.171 s	117.676 ms (11.2%)
Total	tracing	8.531 s	-
Total	iast	8.989 s	458.691 ms (5.4%)
Total	iast_HARDCODED_SECRET_DISABLED	8.917 s	386.395 ms (4.5%)
Total	iast_TELEMETRY_OFF	8.959 s	428.016 ms (5.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.176 s	123.528 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.176 s	122.835 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.171 s	118.382 ms (11.2%)
Total	tracing	8.474 s	-
Total	iast	8.983 s	509.725 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	8.964 s	490.704 ms (5.8%)
Total	iast_TELEMETRY_OFF	8.962 s	488.076 ms (5.8%)

gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~4cb14e94e8, baseline=1.40.0-SNAPSHOT~86d01e6f14

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.035 ms) : 0, 672035
BytebuddyAgent [candidate] (671.687 ms) : 0, 671687
GlobalTracer [baseline] (308.187 ms) : 0, 308187
GlobalTracer [candidate] (307.809 ms) : 0, 307809
AppSec [baseline] (51.39 ms) : 0, 51390
AppSec [candidate] (51.651 ms) : 0, 51651
Remote Config [baseline] (676.359 µs) : 0, 676
Remote Config [candidate] (663.803 µs) : 0, 664
Telemetry [baseline] (7.505 ms) : 0, 7505
Telemetry [candidate] (7.521 ms) : 0, 7521
section iast
BytebuddyAgent [baseline] (787.238 ms) : 0, 787238
BytebuddyAgent [candidate] (782.708 ms) : 0, 782708
GlobalTracer [baseline] (300.466 ms) : 0, 300466
GlobalTracer [candidate] (297.033 ms) : 0, 297033
AppSec [baseline] (52.615 ms) : 0, 52615
AppSec [candidate] (51.522 ms) : 0, 51522
IAST [baseline] (23.205 ms) : 0, 23205
IAST [candidate] (23.627 ms) : 0, 23627
Remote Config [baseline] (605.659 µs) : 0, 606
Remote Config [candidate] (579.008 µs) : 0, 579
Telemetry [baseline] (8.119 ms) : 0, 8119
Telemetry [candidate] (7.354 ms) : 0, 7354
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.815 ms) : 0, 781815
BytebuddyAgent [candidate] (781.617 ms) : 0, 781617
GlobalTracer [baseline] (296.366 ms) : 0, 296366
GlobalTracer [candidate] (296.565 ms) : 0, 296565
AppSec [baseline] (51.643 ms) : 0, 51643
AppSec [candidate] (53.385 ms) : 0, 53385
IAST [baseline] (24.421 ms) : 0, 24421
IAST [candidate] (22.698 ms) : 0, 22698
Remote Config [baseline] (580.738 µs) : 0, 581
Remote Config [candidate] (584.52 µs) : 0, 585
Telemetry [baseline] (7.274 ms) : 0, 7274
Telemetry [candidate] (7.276 ms) : 0, 7276
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.129 ms) : 0, 778129
BytebuddyAgent [candidate] (778.662 ms) : 0, 778662
GlobalTracer [baseline] (296.291 ms) : 0, 296291
GlobalTracer [candidate] (296.063 ms) : 0, 296063
AppSec [baseline] (52.907 ms) : 0, 52907
AppSec [candidate] (51.374 ms) : 0, 51374
IAST [baseline] (22.303 ms) : 0, 22303
IAST [candidate] (22.285 ms) : 0, 22285
Remote Config [baseline] (581.058 µs) : 0, 581
Remote Config [candidate] (572.203 µs) : 0, 572
Telemetry [baseline] (7.234 ms) : 0, 7234
Telemetry [candidate] (8.709 ms) : 0, 8709

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~4cb14e94e8, baseline=1.40.0-SNAPSHOT~86d01e6f14

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058746
Total [baseline] (10.383 s) : 0, 10382878
Agent [candidate] (1.052 s) : 0, 1052244
Total [candidate] (10.362 s) : 0, 10361538
section appsec
Agent [baseline] (1.184 s) : 0, 1183741
Total [baseline] (10.618 s) : 0, 10618069
Agent [candidate] (1.19 s) : 0, 1190250
Total [candidate] (10.671 s) : 0, 10670595
section iast
Agent [baseline] (1.186 s) : 0, 1186066
Total [baseline] (10.842 s) : 0, 10841576
Agent [candidate] (1.177 s) : 0, 1177172
Total [candidate] (10.782 s) : 0, 10781597
section profiling
Agent [baseline] (1.245 s) : 0, 1245483
Total [baseline] (10.581 s) : 0, 10581266
Agent [candidate] (1.251 s) : 0, 1250540
Total [candidate] (10.568 s) : 0, 10567889

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.059 s	-
Agent	appsec	1.184 s	124.995 ms (11.8%)
Agent	iast	1.186 s	127.32 ms (12.0%)
Agent	profiling	1.245 s	186.737 ms (17.6%)
Total	tracing	10.383 s	-
Total	appsec	10.618 s	235.191 ms (2.3%)
Total	iast	10.842 s	458.698 ms (4.4%)
Total	profiling	10.581 s	198.388 ms (1.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.052 s	-
Agent	appsec	1.19 s	138.005 ms (13.1%)
Agent	iast	1.177 s	124.927 ms (11.9%)
Agent	profiling	1.251 s	198.296 ms (18.8%)
Total	tracing	10.362 s	-
Total	appsec	10.671 s	309.058 ms (3.0%)
Total	iast	10.782 s	420.059 ms (4.1%)
Total	profiling	10.568 s	206.351 ms (2.0%)

gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~4cb14e94e8, baseline=1.40.0-SNAPSHOT~86d01e6f14

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.912 ms) : 0, 675912
BytebuddyAgent [candidate] (671.299 ms) : 0, 671299
GlobalTracer [baseline] (309.194 ms) : 0, 309194
GlobalTracer [candidate] (307.851 ms) : 0, 307851
AppSec [baseline] (51.729 ms) : 0, 51729
AppSec [candidate] (51.347 ms) : 0, 51347
Remote Config [baseline] (679.092 µs) : 0, 679
Remote Config [candidate] (657.098 µs) : 0, 657
Telemetry [baseline] (7.56 ms) : 0, 7560
Telemetry [candidate] (7.474 ms) : 0, 7474
section appsec
BytebuddyAgent [baseline] (691.452 ms) : 0, 691452
BytebuddyAgent [candidate] (695.219 ms) : 0, 695219
GlobalTracer [baseline] (300.592 ms) : 0, 300592
GlobalTracer [candidate] (302.017 ms) : 0, 302017
AppSec [baseline] (159.776 ms) : 0, 159776
AppSec [candidate] (159.897 ms) : 0, 159897
IAST [baseline] (19.682 ms) : 0, 19682
IAST [candidate] (22.429 ms) : 0, 22429
Remote Config [baseline] (619.822 µs) : 0, 620
Remote Config [candidate] (626.601 µs) : 0, 627
Telemetry [baseline] (7.878 ms) : 0, 7878
Telemetry [candidate] (7.607 ms) : 0, 7607
section iast
BytebuddyAgent [baseline] (789.232 ms) : 0, 789232
BytebuddyAgent [candidate] (783.273 ms) : 0, 783273
GlobalTracer [baseline] (298.648 ms) : 0, 298648
GlobalTracer [candidate] (296.511 ms) : 0, 296511
AppSec [baseline] (51.236 ms) : 0, 51236
AppSec [candidate] (53.251 ms) : 0, 53251
IAST [baseline] (23.039 ms) : 0, 23039
IAST [candidate] (22.699 ms) : 0, 22699
Remote Config [baseline] (605.121 µs) : 0, 605
Remote Config [candidate] (584.113 µs) : 0, 584
Telemetry [baseline] (9.6 ms) : 0, 9600
Telemetry [candidate] (7.246 ms) : 0, 7246
section profiling
BytebuddyAgent [baseline] (664.144 ms) : 0, 664144
BytebuddyAgent [candidate] (666.571 ms) : 0, 666571
GlobalTracer [baseline] (388.656 ms) : 0, 388656
GlobalTracer [candidate] (390.083 ms) : 0, 390083
AppSec [baseline] (51.851 ms) : 0, 51851
AppSec [candidate] (52.274 ms) : 0, 52274
Remote Config [baseline] (689.953 µs) : 0, 690
Remote Config [candidate] (684.627 µs) : 0, 685
Telemetry [baseline] (7.367 ms) : 0, 7367
Telemetry [candidate] (7.42 ms) : 0, 7420
ProfilingAgent [baseline] (95.008 ms) : 0, 95008
ProfilingAgent [candidate] (95.617 ms) : 0, 95617
Profiling [baseline] (95.031 ms) : 0, 95031
Profiling [candidate] (95.641 ms) : 0, 95641

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-09-04T14:56:21	2024-09-04T15:03:08
git_branch	master	andrea.marziali/pubsub-no-legacy
git_commit_date	1725455874	1725461168
git_commit_sha	`86d01e6`	`4cb14e9`
release_version	1.40.0-SNAPSHOT~86d01e6f14	1.40.0-SNAPSHOT~4cb14e94e8
start_time	2024-09-04T14:56:08	2024-09-04T15:02:55

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1725462531	1725462531
ci_job_id	627316234	627316234
ci_pipeline_id	43521364	43521364
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 19 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~4cb14e94e8, baseline=1.40.0-SNAPSHOT~86d01e6f14
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.967 µs) : 342, 380
.   : milestone, 361,
iast (476.145 µs) : 455, 498
.   : milestone, 476,
iast_FULL (549.058 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (492.299 µs) : 471, 513
.   : milestone, 492,
iast_HARDCODED_SECRET_DISABLED (469.035 µs) : 447, 491
.   : milestone, 469,
iast_INACTIVE (432.545 µs) : 412, 453
.   : milestone, 433,
iast_TELEMETRY_OFF (474.284 µs) : 452, 496
.   : milestone, 474,
tracing (441.829 µs) : 421, 463
.   : milestone, 442,
section candidate
no_agent (367.423 µs) : 347, 388
.   : milestone, 367,
iast (476.527 µs) : 455, 498
.   : milestone, 477,
iast_FULL (549.19 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (501.411 µs) : 480, 523
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (478.035 µs) : 456, 500
.   : milestone, 478,
iast_INACTIVE (437.091 µs) : 416, 458
.   : milestone, 437,
iast_TELEMETRY_OFF (467.352 µs) : 445, 490
.   : milestone, 467,
tracing (433.397 µs) : 412, 455
.   : milestone, 433,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	360.967 µs [341.544 µs, 380.39 µs]	-
iast	476.145 µs [454.548 µs, 497.742 µs]	115.178 µs (31.9%)
iast_FULL	549.058 µs [528.059 µs, 570.058 µs]	188.091 µs (52.1%)
iast_GLOBAL	492.299 µs [471.237 µs, 513.36 µs]	131.332 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED	469.035 µs [447.19 µs, 490.881 µs]	108.068 µs (29.9%)
iast_INACTIVE	432.545 µs [412.297 µs, 452.793 µs]	71.578 µs (19.8%)
iast_TELEMETRY_OFF	474.284 µs [452.134 µs, 496.434 µs]	113.317 µs (31.4%)
tracing	441.829 µs [420.914 µs, 462.745 µs]	80.862 µs (22.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.423 µs [347.091 µs, 387.756 µs]	-
iast	476.527 µs [455.244 µs, 497.811 µs]	109.104 µs (29.7%)
iast_FULL	549.19 µs [528.019 µs, 570.361 µs]	181.767 µs (49.5%)
iast_GLOBAL	501.411 µs [479.941 µs, 522.882 µs]	133.988 µs (36.5%)
iast_HARDCODED_SECRET_DISABLED	478.035 µs [455.913 µs, 500.157 µs]	110.612 µs (30.1%)
iast_INACTIVE	437.091 µs [416.445 µs, 457.737 µs]	69.668 µs (19.0%)
iast_TELEMETRY_OFF	467.352 µs [444.898 µs, 489.806 µs]	99.929 µs (27.2%)
tracing	433.397 µs [412.13 µs, 454.664 µs]	65.974 µs (18.0%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~4cb14e94e8, baseline=1.40.0-SNAPSHOT~86d01e6f14
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.335 ms) : 1317, 1354
.   : milestone, 1335,
appsec (1.727 ms) : 1704, 1750
.   : milestone, 1727,
appsec_no_iast (1.749 ms) : 1723, 1776
.   : milestone, 1749,
iast (1.463 ms) : 1440, 1486
.   : milestone, 1463,
profiling (1.467 ms) : 1443, 1490
.   : milestone, 1467,
tracing (1.473 ms) : 1449, 1497
.   : milestone, 1473,
section candidate
no_agent (1.346 ms) : 1327, 1366
.   : milestone, 1346,
appsec (1.718 ms) : 1694, 1742
.   : milestone, 1718,
appsec_no_iast (1.728 ms) : 1704, 1752
.   : milestone, 1728,
iast (1.466 ms) : 1443, 1488
.   : milestone, 1466,
profiling (1.482 ms) : 1459, 1505
.   : milestone, 1482,
tracing (1.472 ms) : 1448, 1496
.   : milestone, 1472,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.335 ms [1.317 ms, 1.354 ms]	-
appsec	1.727 ms [1.704 ms, 1.75 ms]	391.731 µs (29.3%)
appsec_no_iast	1.749 ms [1.723 ms, 1.776 ms]	413.905 µs (31.0%)
iast	1.463 ms [1.44 ms, 1.486 ms]	127.85 µs (9.6%)
profiling	1.467 ms [1.443 ms, 1.49 ms]	131.324 µs (9.8%)
tracing	1.473 ms [1.449 ms, 1.497 ms]	138.009 µs (10.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.327 ms, 1.366 ms]	-
appsec	1.718 ms [1.694 ms, 1.742 ms]	372.316 µs (27.7%)
appsec_no_iast	1.728 ms [1.704 ms, 1.752 ms]	381.705 µs (28.4%)
iast	1.466 ms [1.443 ms, 1.488 ms]	119.43 µs (8.9%)
profiling	1.482 ms [1.459 ms, 1.505 ms]	135.586 µs (10.1%)
tracing	1.472 ms [1.448 ms, 1.496 ms]	125.778 µs (9.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/pubsub-no-legacy
git_commit_date	1725455874	1725461168
git_commit_sha	`86d01e6`	`4cb14e9`
release_version	1.40.0-SNAPSHOT~86d01e6f14	1.40.0-SNAPSHOT~4cb14e94e8

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1725463036	1725463036
ci_job_id	627316236	627316236
ci_pipeline_id	43521364	43521364
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~4cb14e94e8, baseline=1.40.0-SNAPSHOT~86d01e6f14
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.273 s) : 15273000, 15273000
.   : milestone, 15273000,
appsec (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
iast (18.81 s) : 18810000, 18810000
.   : milestone, 18810000,
iast_GLOBAL (17.652 s) : 17652000, 17652000
.   : milestone, 17652000,
profiling (15.382 s) : 15382000, 15382000
.   : milestone, 15382000,
tracing (14.826 s) : 14826000, 14826000
.   : milestone, 14826000,
section candidate
no_agent (15.065 s) : 15065000, 15065000
.   : milestone, 15065000,
appsec (15.092 s) : 15092000, 15092000
.   : milestone, 15092000,
iast (18.671 s) : 18671000, 18671000
.   : milestone, 18671000,
iast_GLOBAL (18.228 s) : 18228000, 18228000
.   : milestone, 18228000,
profiling (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
tracing (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.273 s [15.273 s, 15.273 s]	-
appsec	15.047 s [15.047 s, 15.047 s]	-226.0 ms (-1.5%)
iast	18.81 s [18.81 s, 18.81 s]	3.537 s (23.2%)
iast_GLOBAL	17.652 s [17.652 s, 17.652 s]	2.379 s (15.6%)
profiling	15.382 s [15.382 s, 15.382 s]	109.0 ms (0.7%)
tracing	14.826 s [14.826 s, 14.826 s]	-447.0 ms (-2.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.065 s [15.065 s, 15.065 s]	-
appsec	15.092 s [15.092 s, 15.092 s]	27.0 ms (0.2%)
iast	18.671 s [18.671 s, 18.671 s]	3.606 s (23.9%)
iast_GLOBAL	18.228 s [18.228 s, 18.228 s]	3.163 s (21.0%)
profiling	15.138 s [15.138 s, 15.138 s]	73.0 ms (0.5%)
tracing	15.067 s [15.067 s, 15.067 s]	2.0 ms (0.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~4cb14e94e8, baseline=1.40.0-SNAPSHOT~86d01e6f14
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1468
.   : milestone, 1457,
appsec (2.218 ms) : 2183, 2253
.   : milestone, 2218,
iast (1.993 ms) : 1950, 2037
.   : milestone, 1993,
iast_GLOBAL (2.021 ms) : 1977, 2064
.   : milestone, 2021,
profiling (1.86 ms) : 1826, 1895
.   : milestone, 1860,
tracing (1.841 ms) : 1808, 1875
.   : milestone, 1841,
section candidate
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.223 ms) : 2188, 2258
.   : milestone, 2223,
iast (1.961 ms) : 1919, 2004
.   : milestone, 1961,
iast_GLOBAL (2.027 ms) : 1983, 2071
.   : milestone, 2027,
profiling (2.348 ms) : 2160, 2537
.   : milestone, 2348,
tracing (1.832 ms) : 1799, 1864
.   : milestone, 1832,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.457 ms [1.446 ms, 1.468 ms]	-
appsec	2.218 ms [2.183 ms, 2.253 ms]	761.077 µs (52.2%)
iast	1.993 ms [1.95 ms, 2.037 ms]	535.942 µs (36.8%)
iast_GLOBAL	2.021 ms [1.977 ms, 2.064 ms]	563.463 µs (38.7%)
profiling	1.86 ms [1.826 ms, 1.895 ms]	403.055 µs (27.7%)
tracing	1.841 ms [1.808 ms, 1.875 ms]	384.24 µs (26.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.452 ms, 1.475 ms]	-
appsec	2.223 ms [2.188 ms, 2.258 ms]	759.753 µs (51.9%)
iast	1.961 ms [1.919 ms, 2.004 ms]	498.338 µs (34.1%)
iast_GLOBAL	2.027 ms [1.983 ms, 2.071 ms]	563.603 µs (38.5%)
profiling	2.348 ms [2.16 ms, 2.537 ms]	885.156 µs (60.5%)
tracing	1.832 ms [1.799 ms, 1.864 ms]	368.496 µs (25.2%)

nayeem-kamal

LGTM

Google PubSub: implement switchable legacy tracing mode

4cb14e9

amarziali requested review from a team as code owners September 4, 2024 14:48

amarziali requested a review from smola September 4, 2024 14:48

amarziali added type: enhancement inst: others All other instrumentations labels Sep 4, 2024

nayeem-kamal approved these changes Sep 4, 2024

View reviewed changes

PerfectSlayer approved these changes Sep 5, 2024

View reviewed changes

amarziali merged commit cca7d95 into master Sep 5, 2024
100 checks passed

amarziali deleted the andrea.marziali/pubsub-no-legacy branch September 5, 2024 05:34

github-actions bot added this to the 1.40.0 milestone Sep 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Google PubSub: implement switchable legacy tracing mode #7564

Google PubSub: implement switchable legacy tracing mode #7564

amarziali commented Sep 4, 2024 •

edited

Loading

pr-commenter bot commented Sep 4, 2024

nayeem-kamal left a comment

Google PubSub: implement switchable legacy tracing mode #7564

Google PubSub: implement switchable legacy tracing mode #7564

Conversation

amarziali commented Sep 4, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Sep 4, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

nayeem-kamal left a comment

Choose a reason for hiding this comment

amarziali commented Sep 4, 2024 •

edited

Loading