Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertx: wrap internal routes to let the context propagate for blocking handlers #7563

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Vertx: wrap internal routes to let the context propagate for blocking handlers #7563

merged 2 commits into from
Sep 4, 2024

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented Sep 4, 2024 •
edited
Loading

What Does This Do

When doing blockingHandler vertx create a inner route that we do not wrap. because of this the context is not propagated hence the span generated while executing this handler are attached to the wrong trace/parent

This PR makes sure that all the handlers can activate the right scope by using the one created for the route stored in the routing context

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner September 4, 2024 13:49
@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/vertx-sticky
git_commit_date 1725455874 1725459967
git_commit_sha 86d01e6 4332760
release_version 1.40.0-SNAPSHOT~86d01e6f14 1.40.0-SNAPSHOT~43327605c7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725462263 1725462263
ci_job_id 627256951 627256951
ci_pipeline_id 43519254 43519254
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~43327605c7, baseline=1.40.0-SNAPSHOT~86d01e6f14

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050638
Total [baseline] (10.352 s) : 0, 10352188
Agent [candidate] (1.051 s) : 0, 1050614
Total [candidate] (10.384 s) : 0, 10384461
section appsec
Agent [baseline] (1.183 s) : 0, 1183402
Total [baseline] (10.539 s) : 0, 10539085
Agent [candidate] (1.182 s) : 0, 1182153
Total [candidate] (10.599 s) : 0, 10599000
section iast
Agent [baseline] (1.171 s) : 0, 1170964
Total [baseline] (10.84 s) : 0, 10840263
Agent [candidate] (1.189 s) : 0, 1189275
Total [candidate] (10.942 s) : 0, 10941671
section profiling
Agent [baseline] (1.246 s) : 0, 1246489
Total [baseline] (10.609 s) : 0, 10608729
Agent [candidate] (1.252 s) : 0, 1251513
Total [candidate] (10.609 s) : 0, 10608571
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent appsec 1.183 s 132.763 ms (12.6%)
Agent iast 1.171 s 120.326 ms (11.5%)
Agent profiling 1.246 s 195.851 ms (18.6%)
Total tracing 10.352 s -
Total appsec 10.539 s 186.897 ms (1.8%)
Total iast 10.84 s 488.075 ms (4.7%)
Total profiling 10.609 s 256.541 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent appsec 1.182 s 131.539 ms (12.5%)
Agent iast 1.189 s 138.661 ms (13.2%)
Agent profiling 1.252 s 200.898 ms (19.1%)
Total tracing 10.384 s -
Total appsec 10.599 s 214.539 ms (2.1%)
Total iast 10.942 s 557.21 ms (5.4%)
Total profiling 10.609 s 224.11 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~43327605c7, baseline=1.40.0-SNAPSHOT~86d01e6f14

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.441 ms) : 0, 670441
BytebuddyAgent [candidate] (670.169 ms) : 0, 670169
GlobalTracer [baseline] (307.23 ms) : 0, 307230
GlobalTracer [candidate] (307.282 ms) : 0, 307282
AppSec [baseline] (51.187 ms) : 0, 51187
AppSec [candidate] (51.388 ms) : 0, 51388
Remote Config [baseline] (678.458 µs) : 0, 678
Remote Config [candidate] (674.489 µs) : 0, 674
Telemetry [baseline] (7.522 ms) : 0, 7522
Telemetry [candidate] (7.522 ms) : 0, 7522
section appsec
BytebuddyAgent [baseline] (690.659 ms) : 0, 690659
BytebuddyAgent [candidate] (690.06 ms) : 0, 690060
GlobalTracer [baseline] (300.863 ms) : 0, 300863
GlobalTracer [candidate] (300.211 ms) : 0, 300211
AppSec [baseline] (160.435 ms) : 0, 160435
AppSec [candidate] (158.576 ms) : 0, 158576
IAST [baseline] (19.451 ms) : 0, 19451
IAST [candidate] (19.779 ms) : 0, 19779
Remote Config [baseline] (618.657 µs) : 0, 619
Remote Config [candidate] (621.241 µs) : 0, 621
Telemetry [baseline] (7.522 ms) : 0, 7522
Telemetry [candidate] (9.197 ms) : 0, 9197
section iast
BytebuddyAgent [baseline] (779.3 ms) : 0, 779300
BytebuddyAgent [candidate] (790.901 ms) : 0, 790901
GlobalTracer [baseline] (294.943 ms) : 0, 294943
GlobalTracer [candidate] (299.495 ms) : 0, 299495
AppSec [baseline] (51.928 ms) : 0, 51928
AppSec [candidate] (54.075 ms) : 0, 54075
IAST [baseline] (22.612 ms) : 0, 22612
IAST [candidate] (23.093 ms) : 0, 23093
Remote Config [baseline] (578.758 µs) : 0, 579
Remote Config [candidate] (603.54 µs) : 0, 604
Telemetry [baseline] (8.037 ms) : 0, 8037
Telemetry [candidate] (7.437 ms) : 0, 7437
section profiling
BytebuddyAgent [baseline] (664.521 ms) : 0, 664521
BytebuddyAgent [candidate] (668.746 ms) : 0, 668746
GlobalTracer [baseline] (388.311 ms) : 0, 388311
GlobalTracer [candidate] (389.101 ms) : 0, 389101
AppSec [baseline] (52.337 ms) : 0, 52337
AppSec [candidate] (51.751 ms) : 0, 51751
Remote Config [baseline] (687.693 µs) : 0, 688
Remote Config [candidate] (683.569 µs) : 0, 684
Telemetry [baseline] (7.439 ms) : 0, 7439
Telemetry [candidate] (7.354 ms) : 0, 7354
ProfilingAgent [baseline] (95.369 ms) : 0, 95369
ProfilingAgent [candidate] (95.775 ms) : 0, 95775
Profiling [baseline] (95.392 ms) : 0, 95392
Profiling [candidate] (95.799 ms) : 0, 95799
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~43327605c7, baseline=1.40.0-SNAPSHOT~86d01e6f14

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051369
Total [baseline] (8.48 s) : 0, 8480237
Agent [candidate] (1.049 s) : 0, 1048885
Total [candidate] (8.474 s) : 0, 8473932
section iast
Agent [baseline] (1.175 s) : 0, 1175008
Total [baseline] (9.014 s) : 0, 9013853
Agent [candidate] (1.172 s) : 0, 1172051
Total [candidate] (8.952 s) : 0, 8952262
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1172752
Total [baseline] (8.98 s) : 0, 8979842
Agent [candidate] (1.175 s) : 0, 1175058
Total [candidate] (8.938 s) : 0, 8937738
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1169311
Total [baseline] (8.968 s) : 0, 8968250
Agent [candidate] (1.183 s) : 0, 1182537
Total [candidate] (8.98 s) : 0, 8980058
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.175 s 123.639 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.173 s 121.383 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.169 s 117.942 ms (11.2%)
Total tracing 8.48 s -
Total iast 9.014 s 533.615 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.98 s 499.604 ms (5.9%)
Total iast_TELEMETRY_OFF 8.968 s 488.012 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.172 s 123.166 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 126.173 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.183 s 133.652 ms (12.7%)
Total tracing 8.474 s -
Total iast 8.952 s 478.33 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.938 s 463.806 ms (5.5%)
Total iast_TELEMETRY_OFF 8.98 s 506.126 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~43327605c7, baseline=1.40.0-SNAPSHOT~86d01e6f14

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.086 ms) : 0, 671086
BytebuddyAgent [candidate] (668.974 ms) : 0, 668974
GlobalTracer [baseline] (307.404 ms) : 0, 307404
GlobalTracer [candidate] (307.008 ms) : 0, 307008
AppSec [baseline] (51.156 ms) : 0, 51156
AppSec [candidate] (51.198 ms) : 0, 51198
Remote Config [baseline] (667.395 µs) : 0, 667
Remote Config [candidate] (659.458 µs) : 0, 659
Telemetry [baseline] (7.461 ms) : 0, 7461
Telemetry [candidate] (7.471 ms) : 0, 7471
section iast
BytebuddyAgent [baseline] (781.463 ms) : 0, 781463
BytebuddyAgent [candidate] (779.151 ms) : 0, 779151
GlobalTracer [baseline] (296.12 ms) : 0, 296120
GlobalTracer [candidate] (295.406 ms) : 0, 295406
AppSec [baseline] (52.336 ms) : 0, 52336
AppSec [candidate] (52.527 ms) : 0, 52527
IAST [baseline] (23.575 ms) : 0, 23575
IAST [candidate] (23.484 ms) : 0, 23484
Remote Config [baseline] (589.455 µs) : 0, 589
Remote Config [candidate] (600.287 µs) : 0, 600
Telemetry [baseline] (7.342 ms) : 0, 7342
Telemetry [candidate] (7.309 ms) : 0, 7309
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.052 ms) : 0, 780052
BytebuddyAgent [candidate] (781.457 ms) : 0, 781457
GlobalTracer [baseline] (295.664 ms) : 0, 295664
GlobalTracer [candidate] (296.096 ms) : 0, 296096
AppSec [baseline] (53.718 ms) : 0, 53718
AppSec [candidate] (52.456 ms) : 0, 52456
IAST [baseline] (21.833 ms) : 0, 21833
IAST [candidate] (22.747 ms) : 0, 22747
Remote Config [baseline] (594.41 µs) : 0, 594
Remote Config [candidate] (613.322 µs) : 0, 613
Telemetry [baseline] (7.297 ms) : 0, 7297
Telemetry [candidate] (8.042 ms) : 0, 8042
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.004 ms) : 0, 777004
BytebuddyAgent [candidate] (786.273 ms) : 0, 786273
GlobalTracer [baseline] (295.921 ms) : 0, 295921
GlobalTracer [candidate] (298.888 ms) : 0, 298888
AppSec [baseline] (51.295 ms) : 0, 51295
AppSec [candidate] (53.342 ms) : 0, 53342
IAST [baseline] (22.22 ms) : 0, 22220
IAST [candidate] (22.499 ms) : 0, 22499
Remote Config [baseline] (574.817 µs) : 0, 575
Remote Config [candidate] (574.66 µs) : 0, 575
Telemetry [baseline] (8.685 ms) : 0, 8685
Telemetry [candidate] (7.207 ms) : 0, 7207
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-04T14:35:03 2024-09-04T14:41:54
git_branch master andrea.marziali/vertx-sticky
git_commit_date 1725455874 1725459967
git_commit_sha 86d01e6 4332760
release_version 1.40.0-SNAPSHOT~86d01e6f14 1.40.0-SNAPSHOT~43327605c7
start_time 2024-09-04T14:34:49 2024-09-04T14:41:40
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725461262 1725461262
ci_job_id 627256952 627256952
ci_pipeline_id 43519254 43519254
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+39.888µs; +91.796µs] or [+2.667%; +6.137%]		 unstable
[-687.055op/s; +459.135op/s] or [-22.329%; +14.922%]		 1.562ms 2962.963op/s 1.496ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~43327605c7, baseline=1.40.0-SNAPSHOT~86d01e6f14
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.828 µs) : 357, 396
.   : milestone, 377,
iast (487.754 µs) : 465, 510
.   : milestone, 488,
iast_FULL (560.59 µs) : 539, 582
.   : milestone, 561,
iast_GLOBAL (522.185 µs) : 499, 545
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (493.238 µs) : 472, 515
.   : milestone, 493,
iast_INACTIVE (452.445 µs) : 432, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (480.727 µs) : 458, 503
.   : milestone, 481,
tracing (443.672 µs) : 424, 464
.   : milestone, 444,
section candidate
no_agent (377.118 µs) : 356, 398
.   : milestone, 377,
iast (490.569 µs) : 469, 512
.   : milestone, 491,
iast_FULL (557.638 µs) : 536, 579
.   : milestone, 558,
iast_GLOBAL (520.826 µs) : 499, 543
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (493.155 µs) : 472, 514
.   : milestone, 493,
iast_INACTIVE (453.946 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (482.07 µs) : 460, 505
.   : milestone, 482,
tracing (441.673 µs) : 421, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.828 µs [357.411 µs, 396.246 µs] -
iast 487.754 µs [465.02 µs, 510.487 µs] 110.925 µs (29.4%)
iast_FULL 560.59 µs [539.297 µs, 581.884 µs] 183.762 µs (48.8%)
iast_GLOBAL 522.185 µs [499.051 µs, 545.319 µs] 145.357 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 493.238 µs [471.761 µs, 514.716 µs] 116.41 µs (30.9%)
iast_INACTIVE 452.445 µs [431.739 µs, 473.151 µs] 75.617 µs (20.1%)
iast_TELEMETRY_OFF 480.727 µs [457.995 µs, 503.458 µs] 103.898 µs (27.6%)
tracing 443.672 µs [423.611 µs, 463.733 µs] 66.844 µs (17.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.118 µs [356.299 µs, 397.938 µs] -
iast 490.569 µs [468.806 µs, 512.331 µs] 113.45 µs (30.1%)
iast_FULL 557.638 µs [536.293 µs, 578.983 µs] 180.519 µs (47.9%)
iast_GLOBAL 520.826 µs [498.608 µs, 543.045 µs] 143.708 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 493.155 µs [472.02 µs, 514.29 µs] 116.037 µs (30.8%)
iast_INACTIVE 453.946 µs [432.654 µs, 475.238 µs] 76.828 µs (20.4%)
iast_TELEMETRY_OFF 482.07 µs [459.639 µs, 504.501 µs] 104.952 µs (27.8%)
tracing 441.673 µs [421.451 µs, 461.895 µs] 64.555 µs (17.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~43327605c7, baseline=1.40.0-SNAPSHOT~86d01e6f14
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.336 ms) : 1317, 1356
.   : milestone, 1336,
appsec (1.743 ms) : 1719, 1766
.   : milestone, 1743,
appsec_no_iast (1.739 ms) : 1714, 1764
.   : milestone, 1739,
iast (1.48 ms) : 1458, 1503
.   : milestone, 1480,
profiling (1.496 ms) : 1473, 1519
.   : milestone, 1496,
tracing (1.483 ms) : 1459, 1507
.   : milestone, 1483,
section candidate
no_agent (1.36 ms) : 1341, 1379
.   : milestone, 1360,
appsec (1.734 ms) : 1709, 1759
.   : milestone, 1734,
appsec_no_iast (1.734 ms) : 1710, 1758
.   : milestone, 1734,
iast (1.485 ms) : 1462, 1507
.   : milestone, 1485,
profiling (1.562 ms) : 1537, 1587
.   : milestone, 1562,
tracing (1.484 ms) : 1459, 1508
.   : milestone, 1484,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.317 ms, 1.356 ms] -
appsec 1.743 ms [1.719 ms, 1.766 ms] 406.214 µs (30.4%)
appsec_no_iast 1.739 ms [1.714 ms, 1.764 ms] 402.427 µs (30.1%)
iast 1.48 ms [1.458 ms, 1.503 ms] 143.869 µs (10.8%)
profiling 1.496 ms [1.473 ms, 1.519 ms] 159.299 µs (11.9%)
tracing 1.483 ms [1.459 ms, 1.507 ms] 146.482 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.341 ms, 1.379 ms] -
appsec 1.734 ms [1.709 ms, 1.759 ms] 374.097 µs (27.5%)
appsec_no_iast 1.734 ms [1.71 ms, 1.758 ms] 374.163 µs (27.5%)
iast 1.485 ms [1.462 ms, 1.507 ms] 124.685 µs (9.2%)
profiling 1.562 ms [1.537 ms, 1.587 ms] 201.678 µs (14.8%)
tracing 1.484 ms [1.459 ms, 1.508 ms] 123.6 µs (9.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/vertx-sticky
git_commit_date 1725455874 1725459967
git_commit_sha 86d01e6 4332760
release_version 1.40.0-SNAPSHOT~86d01e6f14 1.40.0-SNAPSHOT~43327605c7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725461892 1725461892
ci_job_id 627256953 627256953
ci_pipeline_id 43519254 43519254
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~43327605c7, baseline=1.40.0-SNAPSHOT~86d01e6f14
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.236 ms) : 2201, 2271
.   : milestone, 2236,
iast (1.978 ms) : 1936, 2021
.   : milestone, 1978,
iast_GLOBAL (2.017 ms) : 1974, 2060
.   : milestone, 2017,
profiling (1.875 ms) : 1840, 1911
.   : milestone, 1875,
tracing (1.85 ms) : 1817, 1884
.   : milestone, 1850,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.228 ms) : 2193, 2264
.   : milestone, 2228,
iast (1.972 ms) : 1929, 2014
.   : milestone, 1972,
iast_GLOBAL (2.032 ms) : 1987, 2076
.   : milestone, 2032,
profiling (1.856 ms) : 1822, 1889
.   : milestone, 1856,
tracing (1.854 ms) : 1820, 1888
.   : milestone, 1854,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.236 ms [2.201 ms, 2.271 ms] 777.403 µs (53.3%)
iast 1.978 ms [1.936 ms, 2.021 ms] 519.737 µs (35.6%)
iast_GLOBAL 2.017 ms [1.974 ms, 2.06 ms] 558.548 µs (38.3%)
profiling 1.875 ms [1.84 ms, 1.911 ms] 416.98 µs (28.6%)
tracing 1.85 ms [1.817 ms, 1.884 ms] 392.038 µs (26.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.228 ms [2.193 ms, 2.264 ms] 768.486 µs (52.6%)
iast 1.972 ms [1.929 ms, 2.014 ms] 511.726 µs (35.1%)
iast_GLOBAL 2.032 ms [1.987 ms, 2.076 ms] 571.875 µs (39.2%)
profiling 1.856 ms [1.822 ms, 1.889 ms] 395.836 µs (27.1%)
tracing 1.854 ms [1.82 ms, 1.888 ms] 394.136 µs (27.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~43327605c7, baseline=1.40.0-SNAPSHOT~86d01e6f14
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.556 s) : 15556000, 15556000
.   : milestone, 15556000,
appsec (15.152 s) : 15152000, 15152000
.   : milestone, 15152000,
iast (18.852 s) : 18852000, 18852000
.   : milestone, 18852000,
iast_GLOBAL (17.837 s) : 17837000, 17837000
.   : milestone, 17837000,
profiling (15.538 s) : 15538000, 15538000
.   : milestone, 15538000,
tracing (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
section candidate
no_agent (15.397 s) : 15397000, 15397000
.   : milestone, 15397000,
appsec (14.86 s) : 14860000, 14860000
.   : milestone, 14860000,
iast (18.605 s) : 18605000, 18605000
.   : milestone, 18605000,
iast_GLOBAL (17.774 s) : 17774000, 17774000
.   : milestone, 17774000,
profiling (15.354 s) : 15354000, 15354000
.   : milestone, 15354000,
tracing (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.556 s [15.556 s, 15.556 s] -
appsec 15.152 s [15.152 s, 15.152 s] -404.0 ms (-2.6%)
iast 18.852 s [18.852 s, 18.852 s] 3.296 s (21.2%)
iast_GLOBAL 17.837 s [17.837 s, 17.837 s] 2.281 s (14.7%)
profiling 15.538 s [15.538 s, 15.538 s] -18.0 ms (-0.1%)
tracing 15.137 s [15.137 s, 15.137 s] -419.0 ms (-2.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.397 s [15.397 s, 15.397 s] -
appsec 14.86 s [14.86 s, 14.86 s] -537.0 ms (-3.5%)
iast 18.605 s [18.605 s, 18.605 s] 3.208 s (20.8%)
iast_GLOBAL 17.774 s [17.774 s, 17.774 s] 2.377 s (15.4%)
profiling 15.354 s [15.354 s, 15.354 s] -43.0 ms (-0.3%)
tracing 15.049 s [15.049 s, 15.049 s] -348.0 ms (-2.3%)

@amarziali amarziali added type: bug inst: vertx Eclipse Vert.x instrumentation labels Sep 4, 2024
@amarziali amarziali enabled auto-merge (squash) September 4, 2024 16:09
@amarziali amarziali merged commit 235737f into master Sep 4, 2024
94 of 96 checks passed
@amarziali amarziali deleted the andrea.marziali/vertx-sticky branch September 4, 2024 16:13
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

Assignees
No one assigned
Labels
inst: vertx Eclipse Vert.x instrumentation type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @ValentinZakharov