Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent errors when dealing with MinimalStage in graphql #7560

Merged
merged 4 commits into from
Sep 9, 2024
Merged

prevent errors when dealing with MinimalStage in graphql #7560

merged 4 commits into from
Sep 9, 2024

Conversation

vandonr
Copy link
Contributor

@vandonr vandonr commented Sep 4, 2024 •
edited by ygree
Loading

What Does This Do

solves #6284

Additional Notes

I'd like to have a test on the behavior that was fixed

Contributor Checklist

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vandonr/minimalstage
git_commit_date 1725622627 1725658311
git_commit_sha fb9b96a 9c17bb9
release_version 1.40.0-SNAPSHOT~fb9b96a2fa 1.40.0-SNAPSHOT~9c17bb943d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725660888 1725660888
ci_job_id 631011227 631011227
ci_pipeline_id 43780650 43780650
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~9c17bb943d, baseline=1.40.0-SNAPSHOT~fb9b96a2fa

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062708
Total [baseline] (8.553 s) : 0, 8553152
Agent [candidate] (1.051 s) : 0, 1050611
Total [candidate] (8.506 s) : 0, 8505866
section iast
Agent [baseline] (1.172 s) : 0, 1172345
Total [baseline] (9.016 s) : 0, 9015897
Agent [candidate] (1.17 s) : 0, 1170143
Total [candidate] (8.957 s) : 0, 8957443
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177770
Total [baseline] (8.931 s) : 0, 8930791
Agent [candidate] (1.173 s) : 0, 1172955
Total [candidate] (8.959 s) : 0, 8958925
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168988
Total [baseline] (8.938 s) : 0, 8937964
Agent [candidate] (1.17 s) : 0, 1170347
Total [candidate] (8.989 s) : 0, 8989441
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.172 s 109.636 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 115.062 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.169 s 106.28 ms (10.0%)
Total tracing 8.553 s -
Total iast 9.016 s 462.745 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.931 s 377.64 ms (4.4%)
Total iast_TELEMETRY_OFF 8.938 s 384.813 ms (4.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.17 s 119.532 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.173 s 122.345 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.17 s 119.736 ms (11.4%)
Total tracing 8.506 s -
Total iast 8.957 s 451.577 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.959 s 453.059 ms (5.3%)
Total iast_TELEMETRY_OFF 8.989 s 483.574 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~9c17bb943d, baseline=1.40.0-SNAPSHOT~fb9b96a2fa

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.936 ms) : 0, 678936
BytebuddyAgent [candidate] (670.338 ms) : 0, 670338
GlobalTracer [baseline] (309.809 ms) : 0, 309809
GlobalTracer [candidate] (307.362 ms) : 0, 307362
AppSec [baseline] (51.999 ms) : 0, 51999
AppSec [candidate] (51.215 ms) : 0, 51215
Remote Config [baseline] (692.914 µs) : 0, 693
Remote Config [candidate] (670.948 µs) : 0, 671
Telemetry [baseline] (7.555 ms) : 0, 7555
Telemetry [candidate] (7.445 ms) : 0, 7445
section iast
BytebuddyAgent [baseline] (780.679 ms) : 0, 780679
BytebuddyAgent [candidate] (777.687 ms) : 0, 777687
GlobalTracer [baseline] (295.453 ms) : 0, 295453
GlobalTracer [candidate] (295.132 ms) : 0, 295132
AppSec [baseline] (49.84 ms) : 0, 49840
AppSec [candidate] (53.945 ms) : 0, 53945
IAST [baseline] (24.94 ms) : 0, 24940
IAST [candidate] (21.93 ms) : 0, 21930
Remote Config [baseline] (654.758 µs) : 0, 655
Remote Config [candidate] (585.322 µs) : 0, 585
Telemetry [baseline] (7.218 ms) : 0, 7218
Telemetry [candidate] (7.304 ms) : 0, 7304
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.732 ms) : 0, 784732
BytebuddyAgent [candidate] (779.581 ms) : 0, 779581
GlobalTracer [baseline] (295.768 ms) : 0, 295768
GlobalTracer [candidate] (296.11 ms) : 0, 296110
AppSec [baseline] (52.386 ms) : 0, 52386
AppSec [candidate] (53.993 ms) : 0, 53993
IAST [baseline] (23.335 ms) : 0, 23335
IAST [candidate] (21.801 ms) : 0, 21801
Remote Config [baseline] (585.215 µs) : 0, 585
Remote Config [candidate] (577.555 µs) : 0, 578
Telemetry [baseline] (7.277 ms) : 0, 7277
Telemetry [candidate] (7.274 ms) : 0, 7274
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.478 ms) : 0, 777478
BytebuddyAgent [candidate] (777.362 ms) : 0, 777362
GlobalTracer [baseline] (295.76 ms) : 0, 295760
GlobalTracer [candidate] (296.295 ms) : 0, 296295
AppSec [baseline] (53.003 ms) : 0, 53003
AppSec [candidate] (52.328 ms) : 0, 52328
IAST [baseline] (21.411 ms) : 0, 21411
IAST [candidate] (23.019 ms) : 0, 23019
Remote Config [baseline] (577.666 µs) : 0, 578
Remote Config [candidate] (568.171 µs) : 0, 568
Telemetry [baseline] (7.162 ms) : 0, 7162
Telemetry [candidate] (7.155 ms) : 0, 7155
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~9c17bb943d, baseline=1.40.0-SNAPSHOT~fb9b96a2fa

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050635
Total [baseline] (10.375 s) : 0, 10375040
Agent [candidate] (1.066 s) : 0, 1065846
Total [candidate] (10.424 s) : 0, 10423657
section appsec
Agent [baseline] (1.179 s) : 0, 1179283
Total [baseline] (10.566 s) : 0, 10566250
Agent [candidate] (1.179 s) : 0, 1179089
Total [candidate] (10.6 s) : 0, 10599640
section iast
Agent [baseline] (1.172 s) : 0, 1172142
Total [baseline] (10.756 s) : 0, 10755753
Agent [candidate] (1.175 s) : 0, 1174835
Total [candidate] (10.806 s) : 0, 10806057
section profiling
Agent [baseline] (1.246 s) : 0, 1245935
Total [baseline] (10.623 s) : 0, 10623304
Agent [candidate] (1.248 s) : 0, 1247779
Total [candidate] (10.594 s) : 0, 10594393
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent appsec 1.179 s 128.648 ms (12.2%)
Agent iast 1.172 s 121.506 ms (11.6%)
Agent profiling 1.246 s 195.299 ms (18.6%)
Total tracing 10.375 s -
Total appsec 10.566 s 191.21 ms (1.8%)
Total iast 10.756 s 380.713 ms (3.7%)
Total profiling 10.623 s 248.264 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.179 s 113.243 ms (10.6%)
Agent iast 1.175 s 108.988 ms (10.2%)
Agent profiling 1.248 s 181.933 ms (17.1%)
Total tracing 10.424 s -
Total appsec 10.6 s 175.982 ms (1.7%)
Total iast 10.806 s 382.4 ms (3.7%)
Total profiling 10.594 s 170.736 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~9c17bb943d, baseline=1.40.0-SNAPSHOT~fb9b96a2fa

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.344 ms) : 0, 670344
BytebuddyAgent [candidate] (679.973 ms) : 0, 679973
GlobalTracer [baseline] (307.155 ms) : 0, 307155
GlobalTracer [candidate] (311.349 ms) : 0, 311349
AppSec [baseline] (51.427 ms) : 0, 51427
AppSec [candidate] (52.407 ms) : 0, 52407
Remote Config [baseline] (674.692 µs) : 0, 675
Remote Config [candidate] (687.572 µs) : 0, 688
Telemetry [baseline] (7.466 ms) : 0, 7466
Telemetry [candidate] (7.652 ms) : 0, 7652
section appsec
BytebuddyAgent [baseline] (688.114 ms) : 0, 688114
BytebuddyAgent [candidate] (687.736 ms) : 0, 687736
GlobalTracer [baseline] (299.131 ms) : 0, 299131
GlobalTracer [candidate] (299.695 ms) : 0, 299695
AppSec [baseline] (159.871 ms) : 0, 159871
AppSec [candidate] (158.777 ms) : 0, 158777
Remote Config [baseline] (623.726 µs) : 0, 624
Remote Config [candidate] (626.162 µs) : 0, 626
Telemetry [baseline] (8.19 ms) : 0, 8190
Telemetry [candidate] (8.536 ms) : 0, 8536
IAST [baseline] (19.693 ms) : 0, 19693
IAST [candidate] (20.386 ms) : 0, 20386
section iast
BytebuddyAgent [baseline] (779.947 ms) : 0, 779947
BytebuddyAgent [candidate] (781.549 ms) : 0, 781549
GlobalTracer [baseline] (295.375 ms) : 0, 295375
GlobalTracer [candidate] (296.288 ms) : 0, 296288
AppSec [baseline] (51.315 ms) : 0, 51315
AppSec [candidate] (49.727 ms) : 0, 49727
Remote Config [baseline] (2.046 ms) : 0, 2046
Remote Config [candidate] (585.817 µs) : 0, 586
Telemetry [baseline] (8.065 ms) : 0, 8065
Telemetry [candidate] (9.479 ms) : 0, 9479
IAST [baseline] (21.8 ms) : 0, 21800
IAST [candidate] (23.605 ms) : 0, 23605
section profiling
BytebuddyAgent [baseline] (664.227 ms) : 0, 664227
BytebuddyAgent [candidate] (664.116 ms) : 0, 664116
GlobalTracer [baseline] (388.047 ms) : 0, 388047
GlobalTracer [candidate] (389.335 ms) : 0, 389335
AppSec [baseline] (52.16 ms) : 0, 52160
AppSec [candidate] (52.284 ms) : 0, 52284
Remote Config [baseline] (677.852 µs) : 0, 678
Remote Config [candidate] (704.856 µs) : 0, 705
Telemetry [baseline] (7.365 ms) : 0, 7365
Telemetry [candidate] (7.364 ms) : 0, 7364
ProfilingAgent [baseline] (95.71 ms) : 0, 95710
ProfilingAgent [candidate] (96.235 ms) : 0, 96235
Profiling [baseline] (95.733 ms) : 0, 95733
Profiling [candidate] (96.258 ms) : 0, 96258
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-06T21:45:36 2024-09-06T21:52:25
git_branch master vandonr/minimalstage
git_commit_date 1725622627 1725658311
git_commit_sha fb9b96a 9c17bb9
release_version 1.40.0-SNAPSHOT~fb9b96a2fa 1.40.0-SNAPSHOT~9c17bb943d
start_time 2024-09-06T21:45:23 2024-09-06T21:52:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725659893 1725659893
ci_job_id 631011228 631011228
ci_pipeline_id 43780650 43780650
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~9c17bb943d, baseline=1.40.0-SNAPSHOT~fb9b96a2fa
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.567 µs) : 349, 388
.   : milestone, 369,
iast (482.809 µs) : 461, 505
.   : milestone, 483,
iast_FULL (551.882 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (504.155 µs) : 482, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (481.144 µs) : 460, 503
.   : milestone, 481,
iast_INACTIVE (446.749 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (471.68 µs) : 449, 495
.   : milestone, 472,
tracing (435.335 µs) : 415, 455
.   : milestone, 435,
section candidate
no_agent (423.11 µs) : 404, 443
.   : milestone, 423,
iast (481.498 µs) : 460, 503
.   : milestone, 481,
iast_FULL (551.963 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (507.231 µs) : 486, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (486.221 µs) : 464, 508
.   : milestone, 486,
iast_INACTIVE (445.768 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (472.849 µs) : 451, 495
.   : milestone, 473,
tracing (438.979 µs) : 418, 460
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.567 µs [348.915 µs, 388.219 µs] -
iast 482.809 µs [460.763 µs, 504.854 µs] 114.242 µs (31.0%)
iast_FULL 551.882 µs [530.85 µs, 572.915 µs] 183.315 µs (49.7%)
iast_GLOBAL 504.155 µs [482.329 µs, 525.981 µs] 135.588 µs (36.8%)
iast_HARDCODED_SECRET_DISABLED 481.144 µs [459.655 µs, 502.633 µs] 112.577 µs (30.5%)
iast_INACTIVE 446.749 µs [425.57 µs, 467.927 µs] 78.182 µs (21.2%)
iast_TELEMETRY_OFF 471.68 µs [448.619 µs, 494.741 µs] 103.113 µs (28.0%)
tracing 435.335 µs [415.338 µs, 455.332 µs] 66.768 µs (18.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 423.11 µs [403.605 µs, 442.614 µs] -
iast 481.498 µs [459.589 µs, 503.406 µs] 58.388 µs (13.8%)
iast_FULL 551.963 µs [530.862 µs, 573.065 µs] 128.853 µs (30.5%)
iast_GLOBAL 507.231 µs [485.793 µs, 528.668 µs] 84.121 µs (19.9%)
iast_HARDCODED_SECRET_DISABLED 486.221 µs [464.141 µs, 508.301 µs] 63.111 µs (14.9%)
iast_INACTIVE 445.768 µs [424.743 µs, 466.792 µs] 22.658 µs (5.4%)
iast_TELEMETRY_OFF 472.849 µs [450.876 µs, 494.822 µs] 49.739 µs (11.8%)
tracing 438.979 µs [418.26 µs, 459.698 µs] 15.869 µs (3.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~9c17bb943d, baseline=1.40.0-SNAPSHOT~fb9b96a2fa
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1318, 1356
.   : milestone, 1337,
appsec (1.705 ms) : 1680, 1729
.   : milestone, 1705,
appsec_no_iast (1.72 ms) : 1696, 1744
.   : milestone, 1720,
iast (1.471 ms) : 1448, 1493
.   : milestone, 1471,
profiling (1.494 ms) : 1470, 1519
.   : milestone, 1494,
tracing (1.462 ms) : 1438, 1486
.   : milestone, 1462,
section candidate
no_agent (1.356 ms) : 1336, 1376
.   : milestone, 1356,
appsec (1.728 ms) : 1704, 1751
.   : milestone, 1728,
appsec_no_iast (1.736 ms) : 1712, 1759
.   : milestone, 1736,
iast (1.492 ms) : 1470, 1514
.   : milestone, 1492,
profiling (1.527 ms) : 1502, 1551
.   : milestone, 1527,
tracing (1.473 ms) : 1449, 1497
.   : milestone, 1473,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.318 ms, 1.356 ms] -
appsec 1.705 ms [1.68 ms, 1.729 ms] 367.894 µs (27.5%)
appsec_no_iast 1.72 ms [1.696 ms, 1.744 ms] 383.461 µs (28.7%)
iast 1.471 ms [1.448 ms, 1.493 ms] 133.587 µs (10.0%)
profiling 1.494 ms [1.47 ms, 1.519 ms] 157.508 µs (11.8%)
tracing 1.462 ms [1.438 ms, 1.486 ms] 124.596 µs (9.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.336 ms, 1.376 ms] -
appsec 1.728 ms [1.704 ms, 1.751 ms] 371.879 µs (27.4%)
appsec_no_iast 1.736 ms [1.712 ms, 1.759 ms] 379.526 µs (28.0%)
iast 1.492 ms [1.47 ms, 1.514 ms] 136.255 µs (10.0%)
profiling 1.527 ms [1.502 ms, 1.551 ms] 170.743 µs (12.6%)
tracing 1.473 ms [1.449 ms, 1.497 ms] 116.783 µs (8.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vandonr/minimalstage
git_commit_date 1725622627 1725658311
git_commit_sha fb9b96a 9c17bb9
release_version 1.40.0-SNAPSHOT~fb9b96a2fa 1.40.0-SNAPSHOT~9c17bb943d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725660426 1725660426
ci_job_id 631011229 631011229
ci_pipeline_id 43780650 43780650
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~9c17bb943d, baseline=1.40.0-SNAPSHOT~fb9b96a2fa
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.454 ms) : 1443, 1466
.   : milestone, 1454,
appsec (2.221 ms) : 2186, 2256
.   : milestone, 2221,
iast (1.946 ms) : 1904, 1988
.   : milestone, 1946,
iast_GLOBAL (2.016 ms) : 1972, 2060
.   : milestone, 2016,
profiling (1.857 ms) : 1822, 1893
.   : milestone, 1857,
tracing (1.831 ms) : 1798, 1864
.   : milestone, 1831,
section candidate
no_agent (1.457 ms) : 1445, 1468
.   : milestone, 1457,
appsec (2.208 ms) : 2173, 2243
.   : milestone, 2208,
iast (1.968 ms) : 1925, 2010
.   : milestone, 1968,
iast_GLOBAL (2.013 ms) : 1969, 2057
.   : milestone, 2013,
profiling (1.847 ms) : 1812, 1881
.   : milestone, 1847,
tracing (1.823 ms) : 1790, 1856
.   : milestone, 1823,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.454 ms [1.443 ms, 1.466 ms] -
appsec 2.221 ms [2.186 ms, 2.256 ms] 766.789 µs (52.7%)
iast 1.946 ms [1.904 ms, 1.988 ms] 491.856 µs (33.8%)
iast_GLOBAL 2.016 ms [1.972 ms, 2.06 ms] 562.118 µs (38.7%)
profiling 1.857 ms [1.822 ms, 1.893 ms] 403.164 µs (27.7%)
tracing 1.831 ms [1.798 ms, 1.864 ms] 376.633 µs (25.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.445 ms, 1.468 ms] -
appsec 2.208 ms [2.173 ms, 2.243 ms] 751.19 µs (51.6%)
iast 1.968 ms [1.925 ms, 2.01 ms] 510.913 µs (35.1%)
iast_GLOBAL 2.013 ms [1.969 ms, 2.057 ms] 556.508 µs (38.2%)
profiling 1.847 ms [1.812 ms, 1.881 ms] 389.908 µs (26.8%)
tracing 1.823 ms [1.79 ms, 1.856 ms] 366.413 µs (25.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~9c17bb943d, baseline=1.40.0-SNAPSHOT~fb9b96a2fa
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
appsec (15.168 s) : 15168000, 15168000
.   : milestone, 15168000,
iast (18.502 s) : 18502000, 18502000
.   : milestone, 18502000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
.   : milestone, 17985000,
profiling (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
tracing (15.169 s) : 15169000, 15169000
.   : milestone, 15169000,
section candidate
no_agent (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
appsec (14.965 s) : 14965000, 14965000
.   : milestone, 14965000,
iast (19.029 s) : 19029000, 19029000
.   : milestone, 19029000,
iast_GLOBAL (17.959 s) : 17959000, 17959000
.   : milestone, 17959000,
profiling (15.316 s) : 15316000, 15316000
.   : milestone, 15316000,
tracing (14.815 s) : 14815000, 14815000
.   : milestone, 14815000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.953 s [14.953 s, 14.953 s] -
appsec 15.168 s [15.168 s, 15.168 s] 215.0 ms (1.4%)
iast 18.502 s [18.502 s, 18.502 s] 3.549 s (23.7%)
iast_GLOBAL 17.985 s [17.985 s, 17.985 s] 3.032 s (20.3%)
profiling 15.047 s [15.047 s, 15.047 s] 94.0 ms (0.6%)
tracing 15.169 s [15.169 s, 15.169 s] 216.0 ms (1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.969 s [14.969 s, 14.969 s] -
appsec 14.965 s [14.965 s, 14.965 s] -4.0 ms (-0.0%)
iast 19.029 s [19.029 s, 19.029 s] 4.06 s (27.1%)
iast_GLOBAL 17.959 s [17.959 s, 17.959 s] 2.99 s (20.0%)
profiling 15.316 s [15.316 s, 15.316 s] 347.0 ms (2.3%)
tracing 14.815 s [14.815 s, 14.815 s] -154.0 ms (-1.0%)

@ygree ygree added type: bug inst: graphql GraphQL instrumentation labels Sep 6, 2024
@ygree ygree self-assigned this Sep 6, 2024
@ygree ygree marked this pull request as ready for review September 6, 2024 21:31
@ygree ygree requested a review from a team as a code owner September 6, 2024 21:31
@ygree ygree requested a review from amarziali September 9, 2024 16:09
@ygree ygree merged commit 5699a18 into master Sep 9, 2024
94 of 96 checks passed
@ygree ygree deleted the vandonr/minimalstage branch September 9, 2024 18:33
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree left review comments

@amarziali amarziali amarziali approved these changes

Assignees

@ygree ygree

Labels
inst: graphql GraphQL instrumentation type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vandonr @ygree @amarziali