Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send telemetry log when Probe status queue is full #7557

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Send telemetry log when Probe status queue is full #7557

merged 1 commit into from
Sep 10, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 4, 2024 •
edited by jira bot
Loading

What Does This Do

Use a rate limited logger to warn the queue for probe status is full and send it explicitly to telemetry

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2700

@jpbempel jpbempel added type: enhancement comp: debugger Dynamic Instrumentation labels Sep 4, 2024
@jpbempel jpbempel requested review from a team as code owners September 4, 2024 08:43
@jpbempel jpbempel requested review from shatzi and mcculls and removed request for a team September 4, 2024 08:43
@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1725530194 1725530573
end_time 2024-09-05T09:57:48 2024-09-05T10:04:07
git_branch master jpbempel/log-probestatussink-full-q
git_commit_sha 7497a93 36afbf0
start_time 2024-09-05T09:56:35 2024-09-05T10:02:54
See matching parameters
Baseline Candidate
ci_job_id 628438745 628438745
ci_pipeline_id 43598748 43598748
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1725529626 1725529626

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-19461.499ns; +17674.851ns] or [-7.576%; +6.880%]		 unstable
[-28.789µs; +31.932µs] or [-9.872%; +10.950%]		 unstable
[-39.058µs; +44.217µs] or [-12.853%; +14.551%]		 unstable
[-86.864µs; +90.485µs] or [-13.663%; +14.233%]		 same
scenario:basic same same same unstable
[-60.394µs; +80.213µs] or [-9.704%; +12.889%]		 unstable
[-178.130op/s; +178.130op/s] or [-6.947%; +6.947%]
scenario:loop unsure
[+13.273µs; +25.713µs] or [+0.128%; +0.249%]		 same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (291.609 µs) : 268, 315
.   : milestone, 292,
basic (301.055 µs) : 294, 308
.   : milestone, 301,
loop (10.528 ms) : 10493, 10564
.   : milestone, 10528,
section candidate
noprobe (293.18 µs) : 260, 327
.   : milestone, 293,
basic (298.334 µs) : 291, 306
.   : milestone, 298,
loop (10.526 ms) : 10499, 10553
.   : milestone, 10526,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 291.609 µs [268.074 µs, 315.144 µs]
basic 301.055 µs [293.881 µs, 308.23 µs]
loop 10.528 ms [10.493 ms, 10.564 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 293.18 µs [259.645 µs, 326.716 µs]
basic 298.334 µs [290.522 µs, 306.146 µs]
loop 10.526 ms [10.499 ms, 10.553 ms]

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/log-probestatussink-full-q
git_commit_date 1725526572 1725529626
git_commit_sha 7497a93 36afbf0
release_version 1.40.0-SNAPSHOT~7497a93de3 1.40.0-SNAPSHOT~36afbf0e63
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725531905 1725531905
ci_job_id 628438736 628438736
ci_pipeline_id 43598748 43598748
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~36afbf0e63, baseline=1.40.0-SNAPSHOT~7497a93de3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052433
Total [baseline] (10.339 s) : 0, 10339041
Agent [candidate] (1.049 s) : 0, 1048508
Total [candidate] (10.415 s) : 0, 10415236
section appsec
Agent [baseline] (1.185 s) : 0, 1185410
Total [baseline] (10.579 s) : 0, 10578855
Agent [candidate] (1.185 s) : 0, 1184975
Total [candidate] (10.599 s) : 0, 10598844
section iast
Agent [baseline] (1.182 s) : 0, 1181565
Total [baseline] (10.875 s) : 0, 10874636
Agent [candidate] (1.175 s) : 0, 1174510
Total [candidate] (10.813 s) : 0, 10812566
section profiling
Agent [baseline] (1.246 s) : 0, 1246445
Total [baseline] (10.559 s) : 0, 10559059
Agent [candidate] (1.247 s) : 0, 1247494
Total [candidate] (10.557 s) : 0, 10556506
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.185 s 132.976 ms (12.6%)
Agent iast 1.182 s 129.132 ms (12.3%)
Agent profiling 1.246 s 194.012 ms (18.4%)
Total tracing 10.339 s -
Total appsec 10.579 s 239.814 ms (2.3%)
Total iast 10.875 s 535.595 ms (5.2%)
Total profiling 10.559 s 220.018 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.185 s 136.468 ms (13.0%)
Agent iast 1.175 s 126.002 ms (12.0%)
Agent profiling 1.247 s 198.987 ms (19.0%)
Total tracing 10.415 s -
Total appsec 10.599 s 183.608 ms (1.8%)
Total iast 10.813 s 397.33 ms (3.8%)
Total profiling 10.557 s 141.27 ms (1.4%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~36afbf0e63, baseline=1.40.0-SNAPSHOT~7497a93de3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.494 ms) : 0, 671494
BytebuddyAgent [candidate] (668.873 ms) : 0, 668873
GlobalTracer [baseline] (307.798 ms) : 0, 307798
GlobalTracer [candidate] (306.424 ms) : 0, 306424
AppSec [baseline] (51.383 ms) : 0, 51383
AppSec [candidate] (51.474 ms) : 0, 51474
Remote Config [baseline] (668.466 µs) : 0, 668
Remote Config [candidate] (668.387 µs) : 0, 668
Telemetry [baseline] (7.48 ms) : 0, 7480
Telemetry [candidate] (7.482 ms) : 0, 7482
section appsec
BytebuddyAgent [baseline] (691.877 ms) : 0, 691877
BytebuddyAgent [candidate] (691.15 ms) : 0, 691150
GlobalTracer [baseline] (301.078 ms) : 0, 301078
GlobalTracer [candidate] (301.004 ms) : 0, 301004
AppSec [baseline] (158.646 ms) : 0, 158646
AppSec [candidate] (159.752 ms) : 0, 159752
Remote Config [baseline] (625.494 µs) : 0, 625
Remote Config [candidate] (615.12 µs) : 0, 615
Telemetry [baseline] (8.887 ms) : 0, 8887
Telemetry [candidate] (8.566 ms) : 0, 8566
IAST [baseline] (21.315 ms) : 0, 21315
IAST [candidate] (20.578 ms) : 0, 20578
section iast
BytebuddyAgent [baseline] (785.7 ms) : 0, 785700
BytebuddyAgent [candidate] (780.809 ms) : 0, 780809
GlobalTracer [baseline] (298.029 ms) : 0, 298029
GlobalTracer [candidate] (296.334 ms) : 0, 296334
AppSec [baseline] (53.5 ms) : 0, 53500
AppSec [candidate] (51.615 ms) : 0, 51615
Remote Config [baseline] (595.184 µs) : 0, 595
Remote Config [candidate] (587.581 µs) : 0, 588
Telemetry [baseline] (8.784 ms) : 0, 8784
Telemetry [candidate] (8.058 ms) : 0, 8058
IAST [baseline] (21.28 ms) : 0, 21280
IAST [candidate] (23.48 ms) : 0, 23480
section profiling
ProfilingAgent [baseline] (95.437 ms) : 0, 95437
ProfilingAgent [candidate] (95.736 ms) : 0, 95736
BytebuddyAgent [baseline] (664.135 ms) : 0, 664135
BytebuddyAgent [candidate] (664.948 ms) : 0, 664948
GlobalTracer [baseline] (389.147 ms) : 0, 389147
GlobalTracer [candidate] (388.963 ms) : 0, 388963
AppSec [baseline] (51.874 ms) : 0, 51874
AppSec [candidate] (51.964 ms) : 0, 51964
Remote Config [baseline] (681.449 µs) : 0, 681
Remote Config [candidate] (685.549 µs) : 0, 686
Telemetry [baseline] (7.349 ms) : 0, 7349
Telemetry [candidate] (7.374 ms) : 0, 7374
Profiling [baseline] (95.461 ms) : 0, 95461
Profiling [candidate] (95.759 ms) : 0, 95759
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~36afbf0e63, baseline=1.40.0-SNAPSHOT~7497a93de3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050437
Total [baseline] (8.514 s) : 0, 8514085
Agent [candidate] (1.049 s) : 0, 1049067
Total [candidate] (8.502 s) : 0, 8501858
section iast
Agent [baseline] (1.174 s) : 0, 1174275
Total [baseline] (8.976 s) : 0, 8976372
Agent [candidate] (1.172 s) : 0, 1172156
Total [candidate] (8.957 s) : 0, 8957284
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1183558
Total [baseline] (9.022 s) : 0, 9022204
Agent [candidate] (1.181 s) : 0, 1181286
Total [candidate] (8.945 s) : 0, 8944823
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172651
Total [baseline] (8.969 s) : 0, 8969176
Agent [candidate] (1.168 s) : 0, 1168450
Total [candidate] (8.982 s) : 0, 8981710
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent iast 1.174 s 123.837 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 133.121 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.173 s 122.214 ms (11.6%)
Total tracing 8.514 s -
Total iast 8.976 s 462.287 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.022 s 508.118 ms (6.0%)
Total iast_TELEMETRY_OFF 8.969 s 455.091 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.172 s 123.089 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 132.219 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.168 s 119.383 ms (11.4%)
Total tracing 8.502 s -
Total iast 8.957 s 455.427 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.945 s 442.965 ms (5.2%)
Total iast_TELEMETRY_OFF 8.982 s 479.852 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~36afbf0e63, baseline=1.40.0-SNAPSHOT~7497a93de3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.181 ms) : 0, 670181
BytebuddyAgent [candidate] (669.279 ms) : 0, 669279
GlobalTracer [baseline] (307.058 ms) : 0, 307058
GlobalTracer [candidate] (306.838 ms) : 0, 306838
AppSec [baseline] (51.413 ms) : 0, 51413
AppSec [candidate] (51.227 ms) : 0, 51227
Remote Config [baseline] (673.162 µs) : 0, 673
Remote Config [candidate] (670.646 µs) : 0, 671
Telemetry [baseline] (7.496 ms) : 0, 7496
Telemetry [candidate] (7.456 ms) : 0, 7456
section iast
BytebuddyAgent [baseline] (781.203 ms) : 0, 781203
BytebuddyAgent [candidate] (779.207 ms) : 0, 779207
GlobalTracer [baseline] (296.037 ms) : 0, 296037
GlobalTracer [candidate] (296.08 ms) : 0, 296080
AppSec [baseline] (53.311 ms) : 0, 53311
AppSec [candidate] (51.283 ms) : 0, 51283
IAST [baseline] (21.382 ms) : 0, 21382
IAST [candidate] (22.606 ms) : 0, 22606
Remote Config [baseline] (600.014 µs) : 0, 600
Remote Config [candidate] (585.382 µs) : 0, 585
Telemetry [baseline] (8.104 ms) : 0, 8104
Telemetry [candidate] (8.765 ms) : 0, 8765
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (787.288 ms) : 0, 787288
BytebuddyAgent [candidate] (785.294 ms) : 0, 785294
GlobalTracer [baseline] (298.038 ms) : 0, 298038
GlobalTracer [candidate] (297.665 ms) : 0, 297665
AppSec [baseline] (55.008 ms) : 0, 55008
AppSec [candidate] (52.97 ms) : 0, 52970
IAST [baseline] (20.593 ms) : 0, 20593
IAST [candidate] (22.132 ms) : 0, 22132
Remote Config [baseline] (622.142 µs) : 0, 622
Remote Config [candidate] (597.876 µs) : 0, 598
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (8.901 ms) : 0, 8901
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.767 ms) : 0, 779767
BytebuddyAgent [candidate] (775.967 ms) : 0, 775967
GlobalTracer [baseline] (296.434 ms) : 0, 296434
GlobalTracer [candidate] (295.462 ms) : 0, 295462
AppSec [baseline] (52.47 ms) : 0, 52470
AppSec [candidate] (51.653 ms) : 0, 51653
IAST [baseline] (21.728 ms) : 0, 21728
IAST [candidate] (23.935 ms) : 0, 23935
Remote Config [baseline] (569.762 µs) : 0, 570
Remote Config [candidate] (582.573 µs) : 0, 583
Telemetry [baseline] (8.001 ms) : 0, 8001
Telemetry [candidate] (7.229 ms) : 0, 7229
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-05T09:55:49 2024-09-05T10:02:38
git_branch master jpbempel/log-probestatussink-full-q
git_commit_date 1725526572 1725529626
git_commit_sha 7497a93 36afbf0
release_version 1.40.0-SNAPSHOT~7497a93de3 1.40.0-SNAPSHOT~36afbf0e63
start_time 2024-09-05T09:55:36 2024-09-05T10:02:25
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725530902 1725530902
ci_job_id 628438738 628438738
ci_pipeline_id 43598748 43598748
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~36afbf0e63, baseline=1.40.0-SNAPSHOT~7497a93de3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.36 ms) : 1339, 1380
.   : milestone, 1360,
appsec (1.729 ms) : 1704, 1754
.   : milestone, 1729,
appsec_no_iast (1.711 ms) : 1687, 1736
.   : milestone, 1711,
iast (1.481 ms) : 1458, 1503
.   : milestone, 1481,
profiling (1.461 ms) : 1437, 1486
.   : milestone, 1461,
tracing (1.458 ms) : 1433, 1483
.   : milestone, 1458,
section candidate
no_agent (1.347 ms) : 1327, 1366
.   : milestone, 1347,
appsec (1.735 ms) : 1711, 1760
.   : milestone, 1735,
appsec_no_iast (1.738 ms) : 1715, 1762
.   : milestone, 1738,
iast (1.464 ms) : 1442, 1487
.   : milestone, 1464,
profiling (1.478 ms) : 1455, 1501
.   : milestone, 1478,
tracing (1.453 ms) : 1429, 1478
.   : milestone, 1453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.339 ms, 1.38 ms] -
appsec 1.729 ms [1.704 ms, 1.754 ms] 369.667 µs (27.2%)
appsec_no_iast 1.711 ms [1.687 ms, 1.736 ms] 351.743 µs (25.9%)
iast 1.481 ms [1.458 ms, 1.503 ms] 120.962 µs (8.9%)
profiling 1.461 ms [1.437 ms, 1.486 ms] 101.767 µs (7.5%)
tracing 1.458 ms [1.433 ms, 1.483 ms] 98.154 µs (7.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.366 ms] -
appsec 1.735 ms [1.711 ms, 1.76 ms] 388.701 µs (28.9%)
appsec_no_iast 1.738 ms [1.715 ms, 1.762 ms] 391.793 µs (29.1%)
iast 1.464 ms [1.442 ms, 1.487 ms] 117.781 µs (8.7%)
profiling 1.478 ms [1.455 ms, 1.501 ms] 131.02 µs (9.7%)
tracing 1.453 ms [1.429 ms, 1.478 ms] 106.589 µs (7.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~36afbf0e63, baseline=1.40.0-SNAPSHOT~7497a93de3
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.972 µs) : 357, 397
.   : milestone, 377,
iast (485.135 µs) : 463, 507
.   : milestone, 485,
iast_FULL (552.713 µs) : 531, 574
.   : milestone, 553,
iast_GLOBAL (506.661 µs) : 485, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (482.865 µs) : 461, 505
.   : milestone, 483,
iast_INACTIVE (445.305 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (472.484 µs) : 450, 495
.   : milestone, 472,
tracing (435.866 µs) : 415, 456
.   : milestone, 436,
section candidate
no_agent (366.305 µs) : 347, 386
.   : milestone, 366,
iast (478.009 µs) : 454, 502
.   : milestone, 478,
iast_FULL (551.228 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (503.544 µs) : 482, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (488.399 µs) : 467, 510
.   : milestone, 488,
iast_INACTIVE (441.593 µs) : 421, 462
.   : milestone, 442,
iast_TELEMETRY_OFF (474.505 µs) : 451, 498
.   : milestone, 475,
tracing (442.531 µs) : 422, 463
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.972 µs [357.374 µs, 396.57 µs] -
iast 485.135 µs [463.03 µs, 507.24 µs] 108.164 µs (28.7%)
iast_FULL 552.713 µs [531.48 µs, 573.946 µs] 175.741 µs (46.6%)
iast_GLOBAL 506.661 µs [485.122 µs, 528.2 µs] 129.69 µs (34.4%)
iast_HARDCODED_SECRET_DISABLED 482.865 µs [461.022 µs, 504.707 µs] 105.893 µs (28.1%)
iast_INACTIVE 445.305 µs [424.545 µs, 466.065 µs] 68.334 µs (18.1%)
iast_TELEMETRY_OFF 472.484 µs [449.821 µs, 495.146 µs] 95.512 µs (25.3%)
tracing 435.866 µs [415.308 µs, 456.424 µs] 58.895 µs (15.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.305 µs [347.045 µs, 385.565 µs] -
iast 478.009 µs [454.38 µs, 501.638 µs] 111.704 µs (30.5%)
iast_FULL 551.228 µs [530.121 µs, 572.336 µs] 184.924 µs (50.5%)
iast_GLOBAL 503.544 µs [482.248 µs, 524.84 µs] 137.24 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 488.399 µs [466.518 µs, 510.28 µs] 122.095 µs (33.3%)
iast_INACTIVE 441.593 µs [420.992 µs, 462.195 µs] 75.289 µs (20.6%)
iast_TELEMETRY_OFF 474.505 µs [451.385 µs, 497.625 µs] 108.2 µs (29.5%)
tracing 442.531 µs [422.007 µs, 463.055 µs] 76.226 µs (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/log-probestatussink-full-q
git_commit_date 1725526572 1725529626
git_commit_sha 7497a93 36afbf0
release_version 1.40.0-SNAPSHOT~7497a93de3 1.40.0-SNAPSHOT~36afbf0e63
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725531529 1725531529
ci_job_id 628438739 628438739
ci_pipeline_id 43598748 43598748
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~36afbf0e63, baseline=1.40.0-SNAPSHOT~7497a93de3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.236 ms) : 2201, 2272
.   : milestone, 2236,
iast (1.969 ms) : 1927, 2011
.   : milestone, 1969,
iast_GLOBAL (2.021 ms) : 1977, 2065
.   : milestone, 2021,
profiling (1.856 ms) : 1822, 1890
.   : milestone, 1856,
tracing (1.846 ms) : 1812, 1879
.   : milestone, 1846,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.228 ms) : 2193, 2263
.   : milestone, 2228,
iast (1.979 ms) : 1936, 2022
.   : milestone, 1979,
iast_GLOBAL (2.025 ms) : 1982, 2069
.   : milestone, 2025,
profiling (1.87 ms) : 1836, 1903
.   : milestone, 1870,
tracing (1.843 ms) : 1810, 1876
.   : milestone, 1843,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.236 ms [2.201 ms, 2.272 ms] 776.502 µs (53.2%)
iast 1.969 ms [1.927 ms, 2.011 ms] 509.139 µs (34.9%)
iast_GLOBAL 2.021 ms [1.977 ms, 2.065 ms] 561.215 µs (38.4%)
profiling 1.856 ms [1.822 ms, 1.89 ms] 396.259 µs (27.1%)
tracing 1.846 ms [1.812 ms, 1.879 ms] 386.028 µs (26.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.228 ms [2.193 ms, 2.263 ms] 766.696 µs (52.5%)
iast 1.979 ms [1.936 ms, 2.022 ms] 517.306 µs (35.4%)
iast_GLOBAL 2.025 ms [1.982 ms, 2.069 ms] 563.406 µs (38.5%)
profiling 1.87 ms [1.836 ms, 1.903 ms] 407.919 µs (27.9%)
tracing 1.843 ms [1.81 ms, 1.876 ms] 381.036 µs (26.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~36afbf0e63, baseline=1.40.0-SNAPSHOT~7497a93de3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
appsec (15.223 s) : 15223000, 15223000
.   : milestone, 15223000,
iast (18.654 s) : 18654000, 18654000
.   : milestone, 18654000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
.   : milestone, 17995000,
profiling (15.202 s) : 15202000, 15202000
.   : milestone, 15202000,
tracing (15.17 s) : 15170000, 15170000
.   : milestone, 15170000,
section candidate
no_agent (15.368 s) : 15368000, 15368000
.   : milestone, 15368000,
appsec (15.198 s) : 15198000, 15198000
.   : milestone, 15198000,
iast (18.835 s) : 18835000, 18835000
.   : milestone, 18835000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
.   : milestone, 17878000,
profiling (15.333 s) : 15333000, 15333000
.   : milestone, 15333000,
tracing (14.849 s) : 14849000, 14849000
.   : milestone, 14849000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.049 s [15.049 s, 15.049 s] -
appsec 15.223 s [15.223 s, 15.223 s] 174.0 ms (1.2%)
iast 18.654 s [18.654 s, 18.654 s] 3.605 s (24.0%)
iast_GLOBAL 17.995 s [17.995 s, 17.995 s] 2.946 s (19.6%)
profiling 15.202 s [15.202 s, 15.202 s] 153.0 ms (1.0%)
tracing 15.17 s [15.17 s, 15.17 s] 121.0 ms (0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.368 s [15.368 s, 15.368 s] -
appsec 15.198 s [15.198 s, 15.198 s] -170.0 ms (-1.1%)
iast 18.835 s [18.835 s, 18.835 s] 3.467 s (22.6%)
iast_GLOBAL 17.878 s [17.878 s, 17.878 s] 2.51 s (16.3%)
profiling 15.333 s [15.333 s, 15.333 s] -35.0 ms (-0.2%)
tracing 14.849 s [14.849 s, 14.849 s] -519.0 ms (-3.4%)

@jpbempel
Send telemetry log when Probe status queue is full
36afbf0 
Use a rate limited logger to warn the queue for probe status is full
and send it explicitly to telemetry
@jpbempel jpbempel force-pushed the jpbempel/log-probestatussink-full-q branch from ae739bf to 36afbf0 Compare September 5, 2024 09:47
@jpbempel jpbempel merged commit 3eb330d into master Sep 10, 2024
99 checks passed
@jpbempel jpbempel deleted the jpbempel/log-probestatussink-full-q branch September 10, 2024 05:32
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi