-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable profiling startForceFirst silently for native image builds #7555
Conversation
Is this even for long running processes? IIRC, the profiler should be started eventually, if the app has been running for a long time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please, add the possibility to enable the profiler delay via this flag to the profiler troubleshooting guide, just in case.
I don't believe so- the ProfilerInstaller explicitly says that the Profiler is to start first. As far as I know, the run never gets called again, so we never get to the code that sets a delayed startup |
Oh, ok. Hm, should we have a warning if a user overrides the flag when running the native image as well? |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~a293df12f3, baseline=1.40.0-SNAPSHOT~6e276bef3e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054811
Total [baseline] (10.402 s) : 0, 10401538
Agent [candidate] (1.053 s) : 0, 1053189
Total [candidate] (10.418 s) : 0, 10417838
section appsec
Agent [baseline] (1.185 s) : 0, 1185023
Total [baseline] (10.668 s) : 0, 10668479
Agent [candidate] (1.184 s) : 0, 1183670
Total [candidate] (10.585 s) : 0, 10584837
section iast
Agent [baseline] (1.177 s) : 0, 1176538
Total [baseline] (10.79 s) : 0, 10789847
Agent [candidate] (1.175 s) : 0, 1175218
Total [candidate] (10.862 s) : 0, 10862066
section profiling
Agent [baseline] (1.26 s) : 0, 1259539
Total [baseline] (10.613 s) : 0, 10613317
Agent [candidate] (1.25 s) : 0, 1250387
Total [candidate] (10.62 s) : 0, 10620215
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~a293df12f3, baseline=1.40.0-SNAPSHOT~6e276bef3e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.943 ms) : 0, 672943
BytebuddyAgent [candidate] (671.728 ms) : 0, 671728
GlobalTracer [baseline] (308.331 ms) : 0, 308331
GlobalTracer [candidate] (307.751 ms) : 0, 307751
AppSec [baseline] (51.634 ms) : 0, 51634
AppSec [candidate] (51.731 ms) : 0, 51731
Remote Config [baseline] (677.84 µs) : 0, 678
Remote Config [candidate] (683.001 µs) : 0, 683
Telemetry [baseline] (7.494 ms) : 0, 7494
Telemetry [candidate] (7.595 ms) : 0, 7595
section appsec
BytebuddyAgent [baseline] (691.401 ms) : 0, 691401
BytebuddyAgent [candidate] (689.408 ms) : 0, 689408
GlobalTracer [baseline] (301.221 ms) : 0, 301221
GlobalTracer [candidate] (301.107 ms) : 0, 301107
AppSec [baseline] (159.551 ms) : 0, 159551
AppSec [candidate] (159.756 ms) : 0, 159756
IAST [baseline] (19.949 ms) : 0, 19949
IAST [candidate] (19.043 ms) : 0, 19043
Remote Config [baseline] (619.047 µs) : 0, 619
Remote Config [candidate] (618.172 µs) : 0, 618
Telemetry [baseline] (8.627 ms) : 0, 8627
Telemetry [candidate] (9.63 ms) : 0, 9630
section iast
BytebuddyAgent [baseline] (782.229 ms) : 0, 782229
BytebuddyAgent [candidate] (781.243 ms) : 0, 781243
GlobalTracer [baseline] (296.54 ms) : 0, 296540
GlobalTracer [candidate] (296.297 ms) : 0, 296297
AppSec [baseline] (51.873 ms) : 0, 51873
AppSec [candidate] (55.216 ms) : 0, 55216
IAST [baseline] (23.534 ms) : 0, 23534
IAST [candidate] (20.971 ms) : 0, 20971
Remote Config [baseline] (589.074 µs) : 0, 589
Remote Config [candidate] (578.199 µs) : 0, 578
Telemetry [baseline] (8.111 ms) : 0, 8111
Telemetry [candidate] (7.276 ms) : 0, 7276
section profiling
BytebuddyAgent [baseline] (671.006 ms) : 0, 671006
BytebuddyAgent [candidate] (665.907 ms) : 0, 665907
GlobalTracer [baseline] (393.105 ms) : 0, 393105
GlobalTracer [candidate] (390.665 ms) : 0, 390665
AppSec [baseline] (52.359 ms) : 0, 52359
AppSec [candidate] (52.134 ms) : 0, 52134
Remote Config [baseline] (693.312 µs) : 0, 693
Remote Config [candidate] (682.014 µs) : 0, 682
Telemetry [baseline] (7.422 ms) : 0, 7422
Telemetry [candidate] (7.343 ms) : 0, 7343
ProfilingAgent [baseline] (96.682 ms) : 0, 96682
ProfilingAgent [candidate] (95.572 ms) : 0, 95572
Profiling [baseline] (96.705 ms) : 0, 96705
Profiling [candidate] (95.596 ms) : 0, 95596
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~a293df12f3, baseline=1.40.0-SNAPSHOT~6e276bef3e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053939
Total [baseline] (8.511 s) : 0, 8510657
Agent [candidate] (1.052 s) : 0, 1051844
Total [candidate] (8.5 s) : 0, 8499914
section iast
Agent [baseline] (1.191 s) : 0, 1190807
Total [baseline] (8.997 s) : 0, 8997404
Agent [candidate] (1.193 s) : 0, 1193497
Total [candidate] (9.04 s) : 0, 9040165
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1178043
Total [baseline] (8.954 s) : 0, 8954083
Agent [candidate] (1.175 s) : 0, 1174988
Total [candidate] (8.963 s) : 0, 8962908
section iast_TELEMETRY_OFF
Agent [baseline] (1.191 s) : 0, 1191219
Total [baseline] (9.042 s) : 0, 9042060
Agent [candidate] (1.18 s) : 0, 1179551
Total [candidate] (9.008 s) : 0, 9008488
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~a293df12f3, baseline=1.40.0-SNAPSHOT~6e276bef3e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.601 ms) : 0, 672601
BytebuddyAgent [candidate] (670.814 ms) : 0, 670814
GlobalTracer [baseline] (307.581 ms) : 0, 307581
GlobalTracer [candidate] (307.528 ms) : 0, 307528
AppSec [baseline] (51.782 ms) : 0, 51782
AppSec [candidate] (51.647 ms) : 0, 51647
Remote Config [baseline] (679.487 µs) : 0, 679
Remote Config [candidate] (685.684 µs) : 0, 686
Telemetry [baseline] (7.584 ms) : 0, 7584
Telemetry [candidate] (7.481 ms) : 0, 7481
section iast
BytebuddyAgent [baseline] (792.344 ms) : 0, 792344
BytebuddyAgent [candidate] (794.203 ms) : 0, 794203
GlobalTracer [baseline] (300.138 ms) : 0, 300138
GlobalTracer [candidate] (301.201 ms) : 0, 301201
AppSec [baseline] (52.383 ms) : 0, 52383
AppSec [candidate] (55.127 ms) : 0, 55127
IAST [baseline] (23.512 ms) : 0, 23512
IAST [candidate] (21.18 ms) : 0, 21180
Remote Config [baseline] (579.314 µs) : 0, 579
Remote Config [candidate] (586.86 µs) : 0, 587
Telemetry [baseline] (8.026 ms) : 0, 8026
Telemetry [candidate] (7.322 ms) : 0, 7322
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.116 ms) : 0, 783116
BytebuddyAgent [candidate] (781.239 ms) : 0, 781239
GlobalTracer [baseline] (297.216 ms) : 0, 297216
GlobalTracer [candidate] (296.883 ms) : 0, 296883
AppSec [baseline] (51.866 ms) : 0, 51866
AppSec [candidate] (51.734 ms) : 0, 51734
IAST [baseline] (24.282 ms) : 0, 24282
IAST [candidate] (23.505 ms) : 0, 23505
Remote Config [baseline] (570.216 µs) : 0, 570
Remote Config [candidate] (591.72 µs) : 0, 592
Telemetry [baseline] (7.291 ms) : 0, 7291
Telemetry [candidate] (7.34 ms) : 0, 7340
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.05 ms) : 0, 791050
BytebuddyAgent [candidate] (781.858 ms) : 0, 781858
GlobalTracer [baseline] (301.736 ms) : 0, 301736
GlobalTracer [candidate] (299.658 ms) : 0, 299658
AppSec [baseline] (53.072 ms) : 0, 53072
AppSec [candidate] (49.251 ms) : 0, 49251
IAST [baseline] (21.172 ms) : 0, 21172
IAST [candidate] (26.315 ms) : 0, 26315
Remote Config [baseline] (599.089 µs) : 0, 599
Remote Config [candidate] (598.21 µs) : 0, 598
Telemetry [baseline] (9.715 ms) : 0, 9715
Telemetry [candidate] (8.094 ms) : 0, 8094
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~a293df12f3, baseline=1.40.0-SNAPSHOT~6e276bef3e
dateFormat X
axisFormat %s
section baseline
no_agent (1.335 ms) : 1315, 1354
. : milestone, 1335,
appsec (1.732 ms) : 1709, 1755
. : milestone, 1732,
appsec_no_iast (1.727 ms) : 1703, 1751
. : milestone, 1727,
iast (1.471 ms) : 1449, 1494
. : milestone, 1471,
profiling (1.509 ms) : 1484, 1533
. : milestone, 1509,
tracing (1.487 ms) : 1463, 1511
. : milestone, 1487,
section candidate
no_agent (1.329 ms) : 1310, 1348
. : milestone, 1329,
appsec (1.724 ms) : 1700, 1749
. : milestone, 1724,
appsec_no_iast (1.725 ms) : 1701, 1749
. : milestone, 1725,
iast (1.489 ms) : 1466, 1511
. : milestone, 1489,
profiling (1.468 ms) : 1445, 1492
. : milestone, 1468,
tracing (1.478 ms) : 1454, 1502
. : milestone, 1478,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~a293df12f3, baseline=1.40.0-SNAPSHOT~6e276bef3e
dateFormat X
axisFormat %s
section baseline
no_agent (364.706 µs) : 345, 384
. : milestone, 365,
iast (482.078 µs) : 460, 504
. : milestone, 482,
iast_FULL (549.272 µs) : 528, 570
. : milestone, 549,
iast_GLOBAL (504.322 µs) : 483, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (481.763 µs) : 460, 503
. : milestone, 482,
iast_INACTIVE (444.182 µs) : 423, 465
. : milestone, 444,
iast_TELEMETRY_OFF (470.227 µs) : 448, 493
. : milestone, 470,
tracing (436.134 µs) : 416, 456
. : milestone, 436,
section candidate
no_agent (366.487 µs) : 346, 387
. : milestone, 366,
iast (487.338 µs) : 465, 509
. : milestone, 487,
iast_FULL (549.955 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (510.206 µs) : 487, 533
. : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (479.016 µs) : 457, 501
. : milestone, 479,
iast_INACTIVE (439.358 µs) : 419, 460
. : milestone, 439,
iast_TELEMETRY_OFF (469.715 µs) : 447, 492
. : milestone, 470,
tracing (440.819 µs) : 420, 462
. : milestone, 441,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~a293df12f3, baseline=1.40.0-SNAPSHOT~6e276bef3e
dateFormat X
axisFormat %s
section baseline
no_agent (1.457 ms) : 1445, 1469
. : milestone, 1457,
appsec (2.227 ms) : 2191, 2262
. : milestone, 2227,
iast (1.996 ms) : 1952, 2040
. : milestone, 1996,
iast_GLOBAL (2.024 ms) : 1980, 2068
. : milestone, 2024,
profiling (1.866 ms) : 1831, 1900
. : milestone, 1866,
tracing (1.83 ms) : 1798, 1863
. : milestone, 1830,
section candidate
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.217 ms) : 2182, 2253
. : milestone, 2217,
iast (1.986 ms) : 1942, 2031
. : milestone, 1986,
iast_GLOBAL (2.03 ms) : 1986, 2074
. : milestone, 2030,
profiling (1.847 ms) : 1812, 1882
. : milestone, 1847,
tracing (1.834 ms) : 1801, 1867
. : milestone, 1834,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~a293df12f3, baseline=1.40.0-SNAPSHOT~6e276bef3e
dateFormat X
axisFormat %s
section baseline
no_agent (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
appsec (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
iast (18.797 s) : 18797000, 18797000
. : milestone, 18797000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
profiling (15.827 s) : 15827000, 15827000
. : milestone, 15827000,
tracing (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
section candidate
no_agent (15.475 s) : 15475000, 15475000
. : milestone, 15475000,
appsec (15.281 s) : 15281000, 15281000
. : milestone, 15281000,
iast (18.628 s) : 18628000, 18628000
. : milestone, 18628000,
iast_GLOBAL (17.955 s) : 17955000, 17955000
. : milestone, 17955000,
profiling (15.378 s) : 15378000, 15378000
. : milestone, 15378000,
tracing (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
|
What Does This Do
This turns on the
dd.profiling.start_force_first
config setting silently when the profiler is baked into a Graal native image.Motivation
Without this flag specified, the profiling integration will fail silently. The flag itself is relevant to older, non-Graal JVMs (for historical reasons). Docs do not mention this requirement at the moment.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROF-10457]