Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XSS support for Freemarker post 2.3.24-incubating #7532

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Add XSS support for Freemarker post 2.3.24-incubating #7532

merged 6 commits into from
Sep 3, 2024

Conversation

Mariovido
Copy link
Contributor

@Mariovido Mariovido commented Aug 30, 2024 •
edited
Loading

What Does This Do

Adds support to the detection of XSS in the Freemarker library from the 2.3.24-incubating version

Motivation

Being able to detect XSS in the library of Freemarker

Additional Notes

The PR that adds support to oldest versions is this one --> #7497

Contributor Checklist

Jira ticket: APPSEC-11285

@pr-commenter
Copy link

pr-commenter bot commented Aug 30, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/xss_freemarker_newer_versions
git_commit_date 1725348747 1725351949
git_commit_sha 7f8886b bdb2f47
release_version 1.40.0-SNAPSHOT~7f8886bbc2 1.39.0-SNAPSHOT~bdb2f47318
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725354256 1725354256
ci_job_id 625086054 625086054
ci_pipeline_id 43388719 43388719
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~bdb2f47318, baseline=1.40.0-SNAPSHOT~7f8886bbc2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046927
Total [baseline] (8.512 s) : 0, 8512310
Agent [candidate] (1.049 s) : 0, 1049183
Total [candidate] (8.483 s) : 0, 8483020
section iast
Agent [baseline] (1.179 s) : 0, 1179368
Total [baseline] (8.978 s) : 0, 8978294
Agent [candidate] (1.171 s) : 0, 1171325
Total [candidate] (8.956 s) : 0, 8955956
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1173083
Total [baseline] (8.93 s) : 0, 8930196
Agent [candidate] (1.181 s) : 0, 1180815
Total [candidate] (8.975 s) : 0, 8975146
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1171223
Total [baseline] (8.979 s) : 0, 8978892
Agent [candidate] (1.179 s) : 0, 1179282
Total [candidate] (9.0 s) : 0, 8999825
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.179 s 132.442 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.173 s 126.156 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.171 s 124.296 ms (11.9%)
Total tracing 8.512 s -
Total iast 8.978 s 465.984 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.93 s 417.886 ms (4.9%)
Total iast_TELEMETRY_OFF 8.979 s 466.582 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.171 s 122.142 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 131.633 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.179 s 130.099 ms (12.4%)
Total tracing 8.483 s -
Total iast 8.956 s 472.936 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.975 s 492.127 ms (5.8%)
Total iast_TELEMETRY_OFF 9.0 s 516.805 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~bdb2f47318, baseline=1.40.0-SNAPSHOT~7f8886bbc2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.963 ms) : 0, 667963
BytebuddyAgent [candidate] (669.379 ms) : 0, 669379
GlobalTracer [baseline] (306.002 ms) : 0, 306002
GlobalTracer [candidate] (306.671 ms) : 0, 306671
AppSec [baseline] (51.369 ms) : 0, 51369
AppSec [candidate] (51.408 ms) : 0, 51408
Remote Config [baseline] (662.42 µs) : 0, 662
Remote Config [candidate] (667.248 µs) : 0, 667
Telemetry [baseline] (7.373 ms) : 0, 7373
Telemetry [candidate] (7.451 ms) : 0, 7451
section iast
BytebuddyAgent [baseline] (784.935 ms) : 0, 784935
BytebuddyAgent [candidate] (778.874 ms) : 0, 778874
GlobalTracer [baseline] (296.401 ms) : 0, 296401
GlobalTracer [candidate] (295.65 ms) : 0, 295650
AppSec [baseline] (52.944 ms) : 0, 52944
AppSec [candidate] (52.478 ms) : 0, 52478
IAST [baseline] (21.985 ms) : 0, 21985
IAST [candidate] (22.882 ms) : 0, 22882
Remote Config [baseline] (586.222 µs) : 0, 586
Remote Config [candidate] (580.371 µs) : 0, 580
Telemetry [baseline] (8.818 ms) : 0, 8818
Telemetry [candidate] (7.303 ms) : 0, 7303
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.402 ms) : 0, 779402
BytebuddyAgent [candidate] (785.152 ms) : 0, 785152
GlobalTracer [baseline] (295.858 ms) : 0, 295858
GlobalTracer [candidate] (297.611 ms) : 0, 297611
AppSec [baseline] (51.214 ms) : 0, 51214
AppSec [candidate] (51.173 ms) : 0, 51173
IAST [baseline] (24.22 ms) : 0, 24220
IAST [candidate] (24.391 ms) : 0, 24391
Remote Config [baseline] (584.411 µs) : 0, 584
Remote Config [candidate] (593.282 µs) : 0, 593
Telemetry [baseline] (8.165 ms) : 0, 8165
Telemetry [candidate] (8.192 ms) : 0, 8192
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.709 ms) : 0, 777709
BytebuddyAgent [candidate] (783.387 ms) : 0, 783387
GlobalTracer [baseline] (296.05 ms) : 0, 296050
GlobalTracer [candidate] (298.26 ms) : 0, 298260
AppSec [baseline] (52.198 ms) : 0, 52198
AppSec [candidate] (50.542 ms) : 0, 50542
IAST [baseline] (23.044 ms) : 0, 23044
IAST [candidate] (25.509 ms) : 0, 25509
Remote Config [baseline] (583.083 µs) : 0, 583
Remote Config [candidate] (584.001 µs) : 0, 584
Telemetry [baseline] (7.982 ms) : 0, 7982
Telemetry [candidate] (7.283 ms) : 0, 7283
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~bdb2f47318, baseline=1.40.0-SNAPSHOT~7f8886bbc2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060193
Total [baseline] (10.46 s) : 0, 10460352
Agent [candidate] (1.054 s) : 0, 1053759
Total [candidate] (10.395 s) : 0, 10394548
section appsec
Agent [baseline] (1.183 s) : 0, 1182858
Total [baseline] (10.59 s) : 0, 10589637
Agent [candidate] (1.183 s) : 0, 1182674
Total [candidate] (10.551 s) : 0, 10551282
section iast
Agent [baseline] (1.173 s) : 0, 1172959
Total [baseline] (10.814 s) : 0, 10813813
Agent [candidate] (1.18 s) : 0, 1180288
Total [candidate] (10.851 s) : 0, 10850511
section profiling
Agent [baseline] (1.249 s) : 0, 1248942
Total [baseline] (10.626 s) : 0, 10626247
Agent [candidate] (1.245 s) : 0, 1244648
Total [candidate] (10.55 s) : 0, 10550306
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.183 s 122.666 ms (11.6%)
Agent iast 1.173 s 112.766 ms (10.6%)
Agent profiling 1.249 s 188.75 ms (17.8%)
Total tracing 10.46 s -
Total appsec 10.59 s 129.284 ms (1.2%)
Total iast 10.814 s 353.461 ms (3.4%)
Total profiling 10.626 s 165.894 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.183 s 128.914 ms (12.2%)
Agent iast 1.18 s 126.528 ms (12.0%)
Agent profiling 1.245 s 190.888 ms (18.1%)
Total tracing 10.395 s -
Total appsec 10.551 s 156.735 ms (1.5%)
Total iast 10.851 s 455.963 ms (4.4%)
Total profiling 10.55 s 155.758 ms (1.5%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~bdb2f47318, baseline=1.40.0-SNAPSHOT~7f8886bbc2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (677.835 ms) : 0, 677835
BytebuddyAgent [candidate] (672.069 ms) : 0, 672069
GlobalTracer [baseline] (308.628 ms) : 0, 308628
GlobalTracer [candidate] (308.213 ms) : 0, 308213
AppSec [baseline] (51.762 ms) : 0, 51762
AppSec [candidate] (51.612 ms) : 0, 51612
Remote Config [baseline] (672.685 µs) : 0, 673
Remote Config [candidate] (674.737 µs) : 0, 675
Telemetry [baseline] (7.545 ms) : 0, 7545
Telemetry [candidate] (7.566 ms) : 0, 7566
section appsec
BytebuddyAgent [baseline] (689.272 ms) : 0, 689272
BytebuddyAgent [candidate] (689.846 ms) : 0, 689846
GlobalTracer [baseline] (300.687 ms) : 0, 300687
GlobalTracer [candidate] (301.097 ms) : 0, 301097
AppSec [baseline] (159.327 ms) : 0, 159327
AppSec [candidate] (159.157 ms) : 0, 159157
Remote Config [baseline] (605.083 µs) : 0, 605
Remote Config [candidate] (621.861 µs) : 0, 622
Telemetry [baseline] (8.213 ms) : 0, 8213
Telemetry [candidate] (8.179 ms) : 0, 8179
IAST [baseline] (22.36 ms) : 0, 22360
IAST [candidate] (20.376 ms) : 0, 20376
section iast
BytebuddyAgent [baseline] (779.236 ms) : 0, 779236
BytebuddyAgent [candidate] (784.809 ms) : 0, 784809
GlobalTracer [baseline] (295.643 ms) : 0, 295643
GlobalTracer [candidate] (297.681 ms) : 0, 297681
AppSec [baseline] (52.224 ms) : 0, 52224
AppSec [candidate] (54.304 ms) : 0, 54304
Remote Config [baseline] (599.357 µs) : 0, 599
Remote Config [candidate] (579.49 µs) : 0, 579
Telemetry [baseline] (8.773 ms) : 0, 8773
Telemetry [candidate] (8.061 ms) : 0, 8061
IAST [baseline] (22.909 ms) : 0, 22909
IAST [candidate] (21.164 ms) : 0, 21164
section profiling
ProfilingAgent [baseline] (96.437 ms) : 0, 96437
ProfilingAgent [candidate] (95.989 ms) : 0, 95989
BytebuddyAgent [baseline] (664.98 ms) : 0, 664980
BytebuddyAgent [candidate] (662.724 ms) : 0, 662724
GlobalTracer [baseline] (389.474 ms) : 0, 389474
GlobalTracer [candidate] (388.278 ms) : 0, 388278
AppSec [baseline] (52.054 ms) : 0, 52054
AppSec [candidate] (51.986 ms) : 0, 51986
Remote Config [baseline] (691.457 µs) : 0, 691
Remote Config [candidate] (682.114 µs) : 0, 682
Telemetry [baseline] (7.411 ms) : 0, 7411
Telemetry [candidate] (7.321 ms) : 0, 7321
Profiling [baseline] (96.461 ms) : 0, 96461
Profiling [candidate] (96.013 ms) : 0, 96013
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-03T08:34:54 2024-09-03T08:41:41
git_branch master mario.vidal/xss_freemarker_newer_versions
git_commit_date 1725348747 1725351949
git_commit_sha 7f8886b bdb2f47
release_version 1.40.0-SNAPSHOT~7f8886bbc2 1.39.0-SNAPSHOT~bdb2f47318
start_time 2024-09-03T08:34:41 2024-09-03T08:41:28
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725353245 1725353245
ci_job_id 625086055 625086055
ci_pipeline_id 43388719 43388719
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~bdb2f47318, baseline=1.40.0-SNAPSHOT~7f8886bbc2
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.179 µs) : 348, 387
.   : milestone, 367,
iast (476.872 µs) : 455, 498
.   : milestone, 477,
iast_FULL (546.188 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (501.645 µs) : 480, 523
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (475.776 µs) : 454, 498
.   : milestone, 476,
iast_INACTIVE (441.007 µs) : 420, 462
.   : milestone, 441,
iast_TELEMETRY_OFF (474.472 µs) : 451, 498
.   : milestone, 474,
tracing (433.974 µs) : 414, 454
.   : milestone, 434,
section candidate
no_agent (364.428 µs) : 345, 384
.   : milestone, 364,
iast (480.574 µs) : 459, 502
.   : milestone, 481,
iast_FULL (545.77 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (508.194 µs) : 486, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (487.54 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (441.349 µs) : 421, 462
.   : milestone, 441,
iast_TELEMETRY_OFF (477.271 µs) : 454, 500
.   : milestone, 477,
tracing (433.701 µs) : 413, 454
.   : milestone, 434,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.179 µs [347.737 µs, 386.62 µs] -
iast 476.872 µs [455.498 µs, 498.247 µs] 109.694 µs (29.9%)
iast_FULL 546.188 µs [524.94 µs, 567.436 µs] 179.009 µs (48.8%)
iast_GLOBAL 501.645 µs [480.105 µs, 523.185 µs] 134.466 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED 475.776 µs [453.66 µs, 497.892 µs] 108.597 µs (29.6%)
iast_INACTIVE 441.007 µs [419.616 µs, 462.399 µs] 73.829 µs (20.1%)
iast_TELEMETRY_OFF 474.472 µs [451.426 µs, 497.518 µs] 107.294 µs (29.2%)
tracing 433.974 µs [413.569 µs, 454.379 µs] 66.796 µs (18.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.428 µs [344.75 µs, 384.107 µs] -
iast 480.574 µs [458.884 µs, 502.265 µs] 116.146 µs (31.9%)
iast_FULL 545.77 µs [524.746 µs, 566.793 µs] 181.341 µs (49.8%)
iast_GLOBAL 508.194 µs [486.206 µs, 530.183 µs] 143.766 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 487.54 µs [466.317 µs, 508.763 µs] 123.112 µs (33.8%)
iast_INACTIVE 441.349 µs [420.751 µs, 461.947 µs] 76.921 µs (21.1%)
iast_TELEMETRY_OFF 477.271 µs [454.351 µs, 500.19 µs] 112.842 µs (31.0%)
tracing 433.701 µs [413.363 µs, 454.039 µs] 69.272 µs (19.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~bdb2f47318, baseline=1.40.0-SNAPSHOT~7f8886bbc2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.721 ms) : 1697, 1745
.   : milestone, 1721,
appsec_no_iast (1.715 ms) : 1690, 1740
.   : milestone, 1715,
iast (1.478 ms) : 1455, 1500
.   : milestone, 1478,
profiling (1.488 ms) : 1466, 1510
.   : milestone, 1488,
tracing (1.454 ms) : 1429, 1480
.   : milestone, 1454,
section candidate
no_agent (1.334 ms) : 1315, 1353
.   : milestone, 1334,
appsec (1.731 ms) : 1707, 1754
.   : milestone, 1731,
appsec_no_iast (1.736 ms) : 1712, 1759
.   : milestone, 1736,
iast (1.464 ms) : 1442, 1486
.   : milestone, 1464,
profiling (1.46 ms) : 1437, 1483
.   : milestone, 1460,
tracing (1.459 ms) : 1435, 1483
.   : milestone, 1459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.721 ms [1.697 ms, 1.745 ms] 358.688 µs (26.3%)
appsec_no_iast 1.715 ms [1.69 ms, 1.74 ms] 353.037 µs (25.9%)
iast 1.478 ms [1.455 ms, 1.5 ms] 115.651 µs (8.5%)
profiling 1.488 ms [1.466 ms, 1.51 ms] 125.627 µs (9.2%)
tracing 1.454 ms [1.429 ms, 1.48 ms] 92.359 µs (6.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.353 ms] -
appsec 1.731 ms [1.707 ms, 1.754 ms] 396.857 µs (29.8%)
appsec_no_iast 1.736 ms [1.712 ms, 1.759 ms] 401.811 µs (30.1%)
iast 1.464 ms [1.442 ms, 1.486 ms] 130.403 µs (9.8%)
profiling 1.46 ms [1.437 ms, 1.483 ms] 126.119 µs (9.5%)
tracing 1.459 ms [1.435 ms, 1.483 ms] 125.497 µs (9.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/xss_freemarker_newer_versions
git_commit_date 1725348747 1725351949
git_commit_sha 7f8886b bdb2f47
release_version 1.40.0-SNAPSHOT~7f8886bbc2 1.39.0-SNAPSHOT~bdb2f47318
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725353898 1725353898
ci_job_id 625086056 625086056
ci_pipeline_id 43388719 43388719
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~bdb2f47318, baseline=1.40.0-SNAPSHOT~7f8886bbc2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1469
.   : milestone, 1458,
appsec (2.216 ms) : 2181, 2251
.   : milestone, 2216,
iast (1.956 ms) : 1914, 1999
.   : milestone, 1956,
iast_GLOBAL (2.003 ms) : 1959, 2046
.   : milestone, 2003,
profiling (1.858 ms) : 1823, 1892
.   : milestone, 1858,
tracing (1.836 ms) : 1804, 1869
.   : milestone, 1836,
section candidate
no_agent (1.456 ms) : 1444, 1467
.   : milestone, 1456,
appsec (2.219 ms) : 2184, 2254
.   : milestone, 2219,
iast (1.962 ms) : 1919, 2004
.   : milestone, 1962,
iast_GLOBAL (2.022 ms) : 1978, 2066
.   : milestone, 2022,
profiling (2.342 ms) : 2154, 2529
.   : milestone, 2342,
tracing (1.829 ms) : 1796, 1862
.   : milestone, 1829,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.469 ms] -
appsec 2.216 ms [2.181 ms, 2.251 ms] 758.098 µs (52.0%)
iast 1.956 ms [1.914 ms, 1.999 ms] 498.282 µs (34.2%)
iast_GLOBAL 2.003 ms [1.959 ms, 2.046 ms] 544.692 µs (37.4%)
profiling 1.858 ms [1.823 ms, 1.892 ms] 399.596 µs (27.4%)
tracing 1.836 ms [1.804 ms, 1.869 ms] 378.476 µs (26.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.444 ms, 1.467 ms] -
appsec 2.219 ms [2.184 ms, 2.254 ms] 763.644 µs (52.5%)
iast 1.962 ms [1.919 ms, 2.004 ms] 505.8 µs (34.7%)
iast_GLOBAL 2.022 ms [1.978 ms, 2.066 ms] 566.163 µs (38.9%)
profiling 2.342 ms [2.154 ms, 2.529 ms] 885.967 µs (60.9%)
tracing 1.829 ms [1.796 ms, 1.862 ms] 373.155 µs (25.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~bdb2f47318, baseline=1.40.0-SNAPSHOT~7f8886bbc2
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.863 s) : 14863000, 14863000
.   : milestone, 14863000,
appsec (15.154 s) : 15154000, 15154000
.   : milestone, 15154000,
iast (18.678 s) : 18678000, 18678000
.   : milestone, 18678000,
iast_GLOBAL (17.92 s) : 17920000, 17920000
.   : milestone, 17920000,
profiling (15.714 s) : 15714000, 15714000
.   : milestone, 15714000,
tracing (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,
section candidate
no_agent (14.978 s) : 14978000, 14978000
.   : milestone, 14978000,
appsec (15.463 s) : 15463000, 15463000
.   : milestone, 15463000,
iast (18.395 s) : 18395000, 18395000
.   : milestone, 18395000,
iast_GLOBAL (17.867 s) : 17867000, 17867000
.   : milestone, 17867000,
profiling (15.197 s) : 15197000, 15197000
.   : milestone, 15197000,
tracing (15.082 s) : 15082000, 15082000
.   : milestone, 15082000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.863 s [14.863 s, 14.863 s] -
appsec 15.154 s [15.154 s, 15.154 s] 291.0 ms (2.0%)
iast 18.678 s [18.678 s, 18.678 s] 3.815 s (25.7%)
iast_GLOBAL 17.92 s [17.92 s, 17.92 s] 3.057 s (20.6%)
profiling 15.714 s [15.714 s, 15.714 s] 851.0 ms (5.7%)
tracing 15.125 s [15.125 s, 15.125 s] 262.0 ms (1.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.978 s [14.978 s, 14.978 s] -
appsec 15.463 s [15.463 s, 15.463 s] 485.0 ms (3.2%)
iast 18.395 s [18.395 s, 18.395 s] 3.417 s (22.8%)
iast_GLOBAL 17.867 s [17.867 s, 17.867 s] 2.889 s (19.3%)
profiling 15.197 s [15.197 s, 15.197 s] 219.0 ms (1.5%)
tracing 15.082 s [15.082 s, 15.082 s] 104.0 ms (0.7%)

@Mariovido Mariovido added the comp: asm iast Application Security Management (IAST) label Aug 30, 2024
@Mariovido Mariovido mentioned this pull request Aug 30, 2024
Merged
5 tasks
@Mariovido Mariovido marked this pull request as ready for review August 30, 2024 12:46
@Mariovido Mariovido requested review from a team as code owners August 30, 2024 12:46
manuel-alvarez-alvarez
manuel-alvarez-alvarez approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@Mariovido Mariovido merged commit ff8dcc7 into master Sep 3, 2024
98 checks passed
@Mariovido Mariovido deleted the mario.vidal/xss_freemarker_newer_versions branch September 3, 2024 09:53
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST)
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mariovido @manuel-alvarez-alvarez