-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves info around smap parsing success/failure #7461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~a8196cb4ab, baseline=1.40.0-SNAPSHOT~6055e41f1f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070574
Total [baseline] (8.539 s) : 0, 8539053
Agent [candidate] (1.067 s) : 0, 1066934
Total [candidate] (8.541 s) : 0, 8540790
section iast
Agent [baseline] (1.195 s) : 0, 1194674
Total [baseline] (8.989 s) : 0, 8988697
Agent [candidate] (1.195 s) : 0, 1195046
Total [candidate] (8.989 s) : 0, 8989046
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.203 s) : 0, 1202749
Total [baseline] (9.006 s) : 0, 9005722
Agent [candidate] (1.193 s) : 0, 1192854
Total [candidate] (8.977 s) : 0, 8977009
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1188381
Total [baseline] (8.983 s) : 0, 8983486
Agent [candidate] (1.2 s) : 0, 1200124
Total [candidate] (9.005 s) : 0, 9005324
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~a8196cb4ab, baseline=1.40.0-SNAPSHOT~6055e41f1f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.127 ms) : 0, 684127
BytebuddyAgent [candidate] (681.587 ms) : 0, 681587
GlobalTracer [baseline] (311.94 ms) : 0, 311940
GlobalTracer [candidate] (311.159 ms) : 0, 311159
AppSec [baseline] (52.298 ms) : 0, 52298
AppSec [candidate] (52.032 ms) : 0, 52032
Remote Config [baseline] (725.387 µs) : 0, 725
Remote Config [candidate] (738.213 µs) : 0, 738
Telemetry [baseline] (7.683 ms) : 0, 7683
Telemetry [candidate] (7.638 ms) : 0, 7638
section iast
BytebuddyAgent [baseline] (795.372 ms) : 0, 795372
BytebuddyAgent [candidate] (794.348 ms) : 0, 794348
GlobalTracer [baseline] (300.492 ms) : 0, 300492
GlobalTracer [candidate] (301.363 ms) : 0, 301363
AppSec [baseline] (53.918 ms) : 0, 53918
AppSec [candidate] (50.938 ms) : 0, 50938
Remote Config [baseline] (636.645 µs) : 0, 637
Remote Config [candidate] (613.777 µs) : 0, 614
Telemetry [baseline] (7.443 ms) : 0, 7443
Telemetry [candidate] (7.379 ms) : 0, 7379
IAST [baseline] (22.99 ms) : 0, 22990
IAST [candidate] (26.577 ms) : 0, 26577
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.073 ms) : 0, 803073
BytebuddyAgent [candidate] (793.711 ms) : 0, 793711
GlobalTracer [baseline] (300.373 ms) : 0, 300373
GlobalTracer [candidate] (299.704 ms) : 0, 299704
AppSec [baseline] (52.713 ms) : 0, 52713
AppSec [candidate] (54.494 ms) : 0, 54494
Remote Config [baseline] (610.215 µs) : 0, 610
Remote Config [candidate] (618.221 µs) : 0, 618
Telemetry [baseline] (8.975 ms) : 0, 8975
Telemetry [candidate] (7.436 ms) : 0, 7436
IAST [baseline] (23.01 ms) : 0, 23010
IAST [candidate] (23.084 ms) : 0, 23084
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.149 ms) : 0, 790149
BytebuddyAgent [candidate] (798.173 ms) : 0, 798173
GlobalTracer [baseline] (299.801 ms) : 0, 299801
GlobalTracer [candidate] (302.742 ms) : 0, 302742
AppSec [baseline] (53.368 ms) : 0, 53368
AppSec [candidate] (53.124 ms) : 0, 53124
Remote Config [baseline] (598.191 µs) : 0, 598
Remote Config [candidate] (599.501 µs) : 0, 600
Telemetry [baseline] (8.136 ms) : 0, 8136
Telemetry [candidate] (7.328 ms) : 0, 7328
IAST [baseline] (22.508 ms) : 0, 22508
IAST [candidate] (24.224 ms) : 0, 24224
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~a8196cb4ab, baseline=1.40.0-SNAPSHOT~6055e41f1f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069222
Total [baseline] (10.499 s) : 0, 10498802
Agent [candidate] (1.085 s) : 0, 1085320
Total [candidate] (10.469 s) : 0, 10469149
section appsec
Agent [baseline] (1.202 s) : 0, 1201577
Total [baseline] (10.646 s) : 0, 10645806
Agent [candidate] (1.203 s) : 0, 1202688
Total [candidate] (10.628 s) : 0, 10627543
section iast
Agent [baseline] (1.194 s) : 0, 1194446
Total [baseline] (10.853 s) : 0, 10852536
Agent [candidate] (1.203 s) : 0, 1202817
Total [candidate] (10.886 s) : 0, 10885550
section profiling
Agent [baseline] (1.269 s) : 0, 1268506
Total [baseline] (10.574 s) : 0, 10573929
Agent [candidate] (1.269 s) : 0, 1268586
Total [candidate] (10.557 s) : 0, 10557420
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~a8196cb4ab, baseline=1.40.0-SNAPSHOT~6055e41f1f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.932 ms) : 0, 682932
BytebuddyAgent [candidate] (692.78 ms) : 0, 692780
GlobalTracer [baseline] (312.168 ms) : 0, 312168
GlobalTracer [candidate] (316.958 ms) : 0, 316958
AppSec [baseline] (52.012 ms) : 0, 52012
AppSec [candidate] (53.086 ms) : 0, 53086
Remote Config [baseline] (736.029 µs) : 0, 736
Remote Config [candidate] (747.133 µs) : 0, 747
Telemetry [baseline] (7.599 ms) : 0, 7599
Telemetry [candidate] (7.803 ms) : 0, 7803
section appsec
BytebuddyAgent [baseline] (703.03 ms) : 0, 703030
BytebuddyAgent [candidate] (703.033 ms) : 0, 703033
GlobalTracer [baseline] (304.318 ms) : 0, 304318
GlobalTracer [candidate] (305.037 ms) : 0, 305037
AppSec [baseline] (162.516 ms) : 0, 162516
AppSec [candidate] (160.669 ms) : 0, 160669
Remote Config [baseline] (654.681 µs) : 0, 655
Remote Config [candidate] (652.701 µs) : 0, 653
Telemetry [baseline] (8.046 ms) : 0, 8046
Telemetry [candidate] (9.074 ms) : 0, 9074
IAST [baseline] (18.446 ms) : 0, 18446
IAST [candidate] (20.892 ms) : 0, 20892
section iast
BytebuddyAgent [baseline] (795.075 ms) : 0, 795075
BytebuddyAgent [candidate] (800.556 ms) : 0, 800556
GlobalTracer [baseline] (301.253 ms) : 0, 301253
GlobalTracer [candidate] (302.745 ms) : 0, 302745
AppSec [baseline] (52.687 ms) : 0, 52687
AppSec [candidate] (53.036 ms) : 0, 53036
Remote Config [baseline] (657.072 µs) : 0, 657
Remote Config [candidate] (617.604 µs) : 0, 618
Telemetry [baseline] (7.367 ms) : 0, 7367
Telemetry [candidate] (8.148 ms) : 0, 8148
IAST [baseline] (23.627 ms) : 0, 23627
IAST [candidate] (23.849 ms) : 0, 23849
section profiling
BytebuddyAgent [baseline] (676.657 ms) : 0, 676657
BytebuddyAgent [candidate] (676.37 ms) : 0, 676370
GlobalTracer [baseline] (395.44 ms) : 0, 395440
GlobalTracer [candidate] (395.74 ms) : 0, 395740
AppSec [baseline] (52.841 ms) : 0, 52841
AppSec [candidate] (52.699 ms) : 0, 52699
Remote Config [baseline] (722.569 µs) : 0, 723
Remote Config [candidate] (714.895 µs) : 0, 715
Telemetry [baseline] (7.495 ms) : 0, 7495
Telemetry [candidate] (7.51 ms) : 0, 7510
ProfilingAgent [baseline] (96.992 ms) : 0, 96992
ProfilingAgent [candidate] (97.127 ms) : 0, 97127
Profiling [baseline] (97.015 ms) : 0, 97015
Profiling [candidate] (97.152 ms) : 0, 97152
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~a8196cb4ab, baseline=1.40.0-SNAPSHOT~6055e41f1f
dateFormat X
axisFormat %s
section baseline
no_agent (1.34 ms) : 1321, 1360
. : milestone, 1340,
appsec (1.729 ms) : 1706, 1753
. : milestone, 1729,
appsec_no_iast (1.733 ms) : 1709, 1757
. : milestone, 1733,
iast (1.474 ms) : 1451, 1497
. : milestone, 1474,
profiling (1.538 ms) : 1514, 1562
. : milestone, 1538,
tracing (1.484 ms) : 1459, 1508
. : milestone, 1484,
section candidate
no_agent (1.352 ms) : 1332, 1372
. : milestone, 1352,
appsec (1.742 ms) : 1717, 1766
. : milestone, 1742,
appsec_no_iast (1.738 ms) : 1714, 1762
. : milestone, 1738,
iast (1.481 ms) : 1458, 1503
. : milestone, 1481,
profiling (1.477 ms) : 1453, 1500
. : milestone, 1477,
tracing (1.473 ms) : 1448, 1498
. : milestone, 1473,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~a8196cb4ab, baseline=1.40.0-SNAPSHOT~6055e41f1f
dateFormat X
axisFormat %s
section baseline
no_agent (376.034 µs) : 356, 396
. : milestone, 376,
iast (491.403 µs) : 470, 513
. : milestone, 491,
iast_FULL (555.03 µs) : 534, 576
. : milestone, 555,
iast_GLOBAL (522.643 µs) : 499, 546
. : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (498.521 µs) : 476, 521
. : milestone, 499,
iast_INACTIVE (454.878 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (480.952 µs) : 458, 504
. : milestone, 481,
tracing (443.647 µs) : 424, 464
. : milestone, 444,
section candidate
no_agent (375.809 µs) : 356, 396
. : milestone, 376,
iast (499.348 µs) : 478, 521
. : milestone, 499,
iast_FULL (558.793 µs) : 538, 580
. : milestone, 559,
iast_GLOBAL (509.403 µs) : 488, 531
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (486.836 µs) : 465, 509
. : milestone, 487,
iast_INACTIVE (450.164 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (484.54 µs) : 462, 507
. : milestone, 485,
tracing (448.76 µs) : 428, 469
. : milestone, 449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~a8196cb4ab, baseline=1.40.0-SNAPSHOT~6055e41f1f
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.295 ms) : 2254, 2336
. : milestone, 2295,
iast (2.055 ms) : 2006, 2104
. : milestone, 2055,
iast_GLOBAL (2.089 ms) : 2040, 2139
. : milestone, 2089,
profiling (1.927 ms) : 1887, 1966
. : milestone, 1927,
tracing (1.901 ms) : 1863, 1940
. : milestone, 1901,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.281 ms) : 2241, 2321
. : milestone, 2281,
iast (2.045 ms) : 1996, 2094
. : milestone, 2045,
iast_GLOBAL (2.103 ms) : 2052, 2153
. : milestone, 2103,
profiling (1.927 ms) : 1887, 1967
. : milestone, 1927,
tracing (1.901 ms) : 1863, 1940
. : milestone, 1901,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~a8196cb4ab, baseline=1.40.0-SNAPSHOT~6055e41f1f
dateFormat X
axisFormat %s
section baseline
no_agent (15.113 s) : 15113000, 15113000
. : milestone, 15113000,
appsec (15.354 s) : 15354000, 15354000
. : milestone, 15354000,
iast (19.005 s) : 19005000, 19005000
. : milestone, 19005000,
iast_GLOBAL (18.097 s) : 18097000, 18097000
. : milestone, 18097000,
profiling (15.699 s) : 15699000, 15699000
. : milestone, 15699000,
tracing (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
section candidate
no_agent (15.163 s) : 15163000, 15163000
. : milestone, 15163000,
appsec (15.297 s) : 15297000, 15297000
. : milestone, 15297000,
iast (19.039 s) : 19039000, 19039000
. : milestone, 19039000,
iast_GLOBAL (18.013 s) : 18013000, 18013000
. : milestone, 18013000,
profiling (15.376 s) : 15376000, 15376000
. : milestone, 15376000,
tracing (15.123 s) : 15123000, 15123000
. : milestone, 15123000,
|
jbachorik
reviewed
Sep 4, 2024
...-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/events/SmapEntryFactory.java
Outdated
Show resolved
Hide resolved
…/main/java/com/datadog/profiling/controller/openjdk/events/SmapEntryFactory.java Co-authored-by: Jaroslav Bachorik <[email protected]>
jbachorik
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This makes some small changes to the logging and data produced by the
SmapEntryFactory
to enable clearly identifying the root cause of a failure to annotate or produce memory map info,type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-10270