reduce number of scope activations in gRPC client instrumentation #5470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
#4646 and #4680 changed the way context propagation worked in the gRPC instrumentation: rather than context being captured by
SerializingExecutor.schedule
(which simply executes theSerializingExecutor
itself as aRunnable
)and activated by
SerializingExecutor.run
(which drains a queue ofRunnable
tasks and runs each one) the context was now captured by each task submitted toSerializingExecutor.execute
and activated when each task would run. This prevents the context active whenSerializingExecutor.schedule
was called being active when each task runs. However, a singleSerializingExecutor
only ever executes tasks for the same request, so allowingSerializingExecutor.run
to activate the scope once drastically reduces the number of scope activations (they are all the same scopes), thus reducing tracing overhead. This change essentially reverts #4646 and #4680 and letsSerializingExecutor.run
capture and activate the same scope for all the tasks it executes.Motivation
Reduce overhead
Additional Notes