Support dynamic configuration of trace sampling rate #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
mcculls
force-pushed
the
mcculls/dynamic-sampling-rate
branch
5 times, most recently
from
1486083
to
3761f64
Compare
mcculls
changed the title
This meant reworking the check to decide when to override response tags; we now base it on whether the original static config has been replaced.
Refactor priority sampling to inside PendingTrace
mcculls
force-pushed
the
mcculls/dynamic-sampling-rate
branch
from
3761f64
to
5b9a8bb
Compare
mcculls
force-pushed
the
mcculls/dynamic-sampling-rate
branch
from
5b9a8bb
to
30754de
Compare
…(less to test) feels wrong to try to address the missing (unrelated) coverage in this PR, so temporarily excluding CoreTracer instead
mcculls
force-pushed
the
mcculls/dynamic-sampling-rate
branch
from
30754de
to
823386d
Compare
PerfectSlayer
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.