Add support for double values for metric probes #5457
Conversation
for gauge and histogram metric types
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
| private void convertIfRequired(Type currentType, Type expectedType, InsnList insnList) { | ||
| if (expectedType == Type.LONG_TYPE && currentType == Type.INT_TYPE) { | ||
| private Type convertIfRequired(Type currentType, InsnList insnList) { | ||
| if (currentType == Type.INT_TYPE) { |
There was a problem hiding this comment.
nit, if someone define a byte variable - does the byte code store those as int? I wonder if byte type are supported by default.
There was a problem hiding this comment.
That's relevant question. The thing is, the JVM on the operand stack treats byte short & char as int, see https://docs.oracle.com/javase/specs/jvms/se20/html/jvms-2.html#jvms-2.11.1
Note that most instructions in Table 2.11.1-A do not have forms for the integral types byte, char, and short. None have forms for the boolean type. A compiler encodes loads of literal values of types byte and short using Java Virtual Machine instructions that sign-extend those values to values of type int at compile-time or run-time. Loads of literal values of types boolean and char are encoded using instructions that zero-extend the literal to a value of type int at compile-time or run-time. Likewise, loads from arrays of values of type boolean, byte, short, and char are encoded using Java Virtual Machine instructions that sign-extend or zero-extend the values to values of type int. Thus, most operations on values of actual types boolean, byte, char, and short are correctly performed by instructions operating on values of computational type int.
There was a problem hiding this comment.
Though, will add in a next PR some unit tests with those type because the internal representation with EL may not match this.
for gauge and histogram metric types
What Does This Do
Motivation
Additional Notes