Add special support for enum values #5441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
Enum in java are in fact regular classes with a special treatment by the java compiler. from the POV of the JVM there is no difference. From user perspective however it would be nice to have constant name as enum values. We are serializing then the enum constant name in the snapshot instead of handling enum as regular complex class
jpbempel
force-pushed
the
jpbempel/handle-enums
branch
from
71be16f
to
b6de77a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
We are serializing then the enum constant name in the snapshot instead of handling enum as regular complex class
Motivation
Enum in java are in fact regular classes with a special treatment by the java compiler. from the POV of the JVM there is no difference. From user perspective however it would be nice to have constant name as enum values.
Additional Notes