implement queue timing using Datadog profiler, remove JFR implementation #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
richardstartin
force-pushed
the
rgs/ddprof-queuetime
branch
2 times, most recently
from
4488838
to
a610ac9
Compare
richardstartin
force-pushed
the
rgs/ddprof-queuetime
branch
from
a610ac9
to
9976840
Compare
jbachorik
reviewed
Jun 22, 2023
...oller-ddprof/src/main/java/com/datadog/profiling/controller/ddprof/DatadogProfilerTimer.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public void close() { | ||
| long endMillis = System.currentTimeMillis(); |
There was a problem hiding this comment.
We are ok with System.currentTimeMillis() not being strictly monotonic?
There was a problem hiding this comment.
We're looking for >= 50ms time spent in the queue, and while this isn't monotonic, it has the same origin wherever you call it.
...t-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/DatadogProfiler.java
Show resolved
Hide resolved
jbachorik
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes