Allow trace flush interval to be configurable #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
bantonsson
reviewed
Jun 21, 2023
| @@ -35,7 +35,7 @@ public static class DDAgentWriterBuilder { | |||
| long timeoutMillis = TimeUnit.SECONDS.toMillis(DEFAULT_AGENT_TIMEOUT); | |||
| int traceBufferSize = BUFFER_SIZE; | |||
| HealthMetrics healthMetrics = HealthMetrics.NO_OP; | |||
| int flushFrequencySeconds = 1; | |||
| int flushIntervalMilliseconds = 1000; | |||
There was a problem hiding this comment.
Why not TimeUnit.SECONDS.toMillis(DEFAULT_TRACE_FLUSH_INTERVAL);?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds the ability to configure the flush interval used to flush traces to the backend.
Motivation
Logs injection smoke tests take too long with dynamic config enabled.
Additional Notes
The unit for frequency would be flushes/per second . "Interval" is the correct when talking about durations. I updated where applicable.
Almost all of the configurations for intervals use seconds without specifying "seconds" in the config name. I followed that pattern. Internally, milliseconds is used because passing the timeunit through all of those layers would be annoying.
Lots of tests and smoke tests can be sped up by configuring a shorter flush interval. I did not make any of those changes in this PR.