Bump default max remote config payload size limit to 5Mb #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ASM_DATA` to block IPs has increased our expectations for remote config payload sizes. While there might be upcoming changes to have lighter payloads, bumping the RC payload size limit to 5Mb should be enough to keep up with the limits that are currently tested for all tracers. Note that RC esponses are cached, so payloads this big should not be seen at every polling interval.
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
bantonsson
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Bump the default maximum remote config payload size to 5Mb.
Motivation
ASM_DATAto block IPs has increased our expectations for remote config payload sizes. While there might be upcoming changes to have lighter payloads, bumping the RC payload size limit to 5Mb should be enough to keep up with the limits that are currently tested for all tracers.Note that RC esponses are cached, so payloads this big should not be seen at every polling interval.
Additional Notes