Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto-configuration for code-coverage in Gradle #5399

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jun 15, 2023

What Does This Do

Adds automatic configuration of per-test code coverage for Gradle projects.
If dd.civisibility.jacoco.plugin.version property is provided when running a Gradle build with the tracer attached, the tracer will automatically configure Jacoco plugin of the given version to be used with the build.

Motivation

In order for the tracer's per-test code coverage feature to work, Jacoco needs to be used in the project.
The usual way of enabling Jacoco would be to update a Gradle build file, registering Jacoco plugin and adding a Jacoco task.
The clients often have troubles doing this, and are in general reluctant to modify their build files.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Jun 15, 2023
@nikita-tkachenko-datadog nikita-tkachenko-datadog changed the title WIP: Nikita tkachenko/per test code coverage auto config gradle Implement auto-configuration for code-coverage in Maven Jun 16, 2023
@nikita-tkachenko-datadog nikita-tkachenko-datadog changed the title Implement auto-configuration for code-coverage in Maven Implement auto-configuration for code-coverage in Gradle Jun 19, 2023
@nikita-tkachenko-datadog nikita-tkachenko-datadog force-pushed the nikita-tkachenko/per-test-code-coverage-auto-config-maven branch from df7babb to 8c0dcd2 Compare June 19, 2023 16:54
@nikita-tkachenko-datadog nikita-tkachenko-datadog force-pushed the nikita-tkachenko/per-test-code-coverage-auto-config-gradle branch from 70585d6 to 0dc5098 Compare June 19, 2023 16:56
@pr-commenter
Copy link

pr-commenter bot commented Jun 19, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.17.0-SNAPSHOT~2e03d43a32 1.17.0-SNAPSHOT~3dc786ba11
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review June 19, 2023 19:23
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner June 19, 2023 19:23
Base automatically changed from nikita-tkachenko/per-test-code-coverage-auto-config-maven to master June 20, 2023 12:41
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner June 20, 2023 12:41
@nikita-tkachenko-datadog nikita-tkachenko-datadog force-pushed the nikita-tkachenko/per-test-code-coverage-auto-config-gradle branch from 0dc5098 to 3dc786b Compare June 20, 2023 12:42
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am not the one with the most background with this domain so another pair of eyes is welcome.

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 257827e into master Jun 22, 2023
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/per-test-code-coverage-auto-config-gradle branch June 22, 2023 15:11
@github-actions github-actions bot added this to the 1.17.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants