expose cassandra contact points and use for peer.service #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
force-pushed
the
andrea.marziali/cassandra-contact-points
branch
2 times, most recently
from
9d86db4
to
b8468ff
Compare
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
amarziali
force-pushed
the
andrea.marziali/cassandra-contact-points
branch
from
b8468ff
to
564ab81
Compare
| } | ||
| return inetSocketAddress.getHostString(); | ||
| }) | ||
| .collect(Collectors.joining(",")); |
There was a problem hiding this comment.
Are they implicitly distinct?
...dra-4/src/main/java/datadog/trace/instrumentation/datastax/cassandra4/ContactPointsUtil.java
Show resolved
Hide resolved
PerfectSlayer
requested changes
Jun 21, 2023
oups I have to clean it up (I used locally and forgot) thanks! |
amarziali
force-pushed
the
andrea.marziali/cassandra-contact-points
branch
from
564ab81
to
d0da813
Compare
amarziali
force-pushed
the
andrea.marziali/cassandra-contact-points
branch
from
d0da813
to
de87c2c
Compare
PerfectSlayer
approved these changes
Jun 21, 2023
amarziali
force-pushed
the
andrea.marziali/cassandra-contact-points
branch
from
de87c2c
to
02b467c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Surface cassandra contact points on a tag
db.cassandra.contact.pointsand use it as a privileged precursor for cassandra peer.serviceMotivation
Additional Notes