Avoid need to inject BeanDefinitionRepairer everywhere as a helper #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
inst: others
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
amarziali
approved these changes
Jun 16, 2023
Instead we record the bean classes of the initial definitions as they are registered, so we can repair them as necessary later on. This also means we can remove the extra call to 'setBeanClassName' which was overwriting the resolved class in the definition (they share a single field) and was actually making the original issue more likely. This approach works better in OSGi where otherwise we might end up injecting multiple BeanDefinitionRepairer helpers, which increases the risk of a type being registered in a repairer class that's different to the one actually used to repair definitions.
mcculls
force-pushed
the
mcculls/cleanup-bean-repairer-injection
branch
from
f4ee88c
to
05a952a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we record the bean classes of the initial definitions as they are registered, so we can repair them as necessary later on. This also means we can remove the extra call to 'setBeanClassName' which was overwriting the resolved class in the definition (they share a single field) and was actually making the original issue more likely.
This approach works better in OSGi where otherwise we might end up injecting multiple BeanDefinitionRepairer helpers, which increases the risk of a type being registered in a repairer class that's different to the one actually used to repair definitions.