Per test code coverage in CI Visibility #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 21 cases.
|
nikita-tkachenko-datadog
added
the
comp: ci visibility
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/per-test-code-coverage
branch
2 times, most recently
from
dd9e287
to
fad217b
Compare
nikita-tkachenko-datadog
changed the title
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/per-test-code-coverage
branch
3 times, most recently
from
cdfa5f9
to
b5d7d55
Compare
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/per-test-code-coverage
branch
from
b5d7d55
to
1371a67
Compare
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/per-test-code-coverage
branch
from
1371a67
to
7330034
Compare
smola
reviewed
Jun 19, 2023
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { |
There was a problem hiding this comment.
Is this equals implementation really needed?
There was a problem hiding this comment.
Good catch, that was a leftover from some experiments, removed
smola
approved these changes
Jun 19, 2023
Co-authored-by: Santiago M. Mola <[email protected]>
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/per-test-code-coverage
branch
from
ff4a9dc
to
2300346
Compare
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/per-test-code-coverage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds per-test code coverage support for CI Visibility product: code coverage info is collected separately for every test case.
Motivation
Per-test code coverage data is needed to support CI Visibility Intelligent Test Runner.
Additional Notes
Code coverage is implemented on top of Jacoco, by instrumenting Jacoco classes and injecting bytecode that inserts additional test probes.