Unify hostname detection in config and telemetry #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
force-pushed
the
smola/unify-hostname-detection
branch
2 times, most recently
from
d01ad98
to
3aa334b
Compare
mcculls
reviewed
Dec 1, 2022
mcculls
approved these changes
Dec 1, 2022
* In telemetry, used the hostname discovered in Config initialization. * In Config, try `/proc/sys/kernel/hostname` and `/etc/hostname` before the `hostname` command.
smola
force-pushed
the
smola/unify-hostname-detection
branch
from
3aa334b
to
b43facf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
/proc/sys/kernel/hostnameand/etc/hostnamebefore thehostnamecommand.Motivation
We detected hostname twice, and in slightly different ways (Telemetry wouldn't use environment variables, Config wouldn't use hostname files).
Additional Notes
Initially discovered while monitoring the execution of external process, which was triggered Config's execution of
hostname