Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSM] Don't send null tags with data streams checkpoint #4349

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

hokitam
Copy link
Contributor

@hokitam hokitam commented Nov 29, 2022

What Does This Do

This PR will remove any null tags that we try to send along in a data streams checkpoint.

Motivation

Null tags cause deserialization issues in the Data Streams backend, causing checkpoints to be dropped.

Additional Notes

@hokitam hokitam marked this pull request as ready for review November 29, 2022 20:15
@hokitam hokitam requested a review from a team as a code owner November 29, 2022 20:15
Copy link
Contributor

@nayeem-kamal nayeem-kamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hokitam hokitam merged commit 914cfcf into master Nov 29, 2022
@hokitam hokitam deleted the hokitam/nullfix branch November 29, 2022 22:54
@github-actions github-actions bot added this to the 1.2.0 milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants