Reduce the amount of full-type parsing needed for instrumentation #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
force-pushed
the
mcculls/reduceFullTypeParsing
branch
2 times, most recently
from
7e5fc08
to
6cbfb8e
Compare
…r we're matching or transforming
mcculls
force-pushed
the
mcculls/reduceFullTypeParsing
branch
from
6cbfb8e
to
db9c5cb
Compare
PerfectSlayer
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
For certain metadata (class modifiers, the names of interfaces and any super-class) we only need the outline of the declaring type, regardless whether we're matching or transforming. This PR temporarily switches the type-factory to always create outlines when looking up this kind of metadata.
The delegate check in
LazyTypehas also been adjusted to allow re-use of full-types even when we only want outlines.Motivation
Outline type parsing is faster and uses less memory than full-type parsing.
Additional notes
For a small apps like petclinic this reduces the amount of full-types parsed from ~1200 to less than 300