Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced evaluateAt attribute in probe configs #4313

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

jpbempel
Copy link
Member

What Does This Do

Introduced evaluateAt attribute in probe configs
Refactored probe config builders

Motivation

Additional Notes

attribute is not used right now, but will be wired in a next PR

Refactored probe config builders
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Nov 24, 2022
@jpbempel jpbempel requested a review from a team as a code owner November 24, 2022 16:44
@jpbempel jpbempel requested review from shatzi and removed request for a team November 24, 2022 16:44
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jpbempel jpbempel merged commit 5118bde into master Nov 25, 2022
@jpbempel jpbempel deleted the jpbempel/evaluate-at branch November 25, 2022 07:50
@github-actions github-actions bot added this to the 1.2.0 milestone Nov 25, 2022
@bantonsson bantonsson modified the milestones: 1.1.2, 1.2.0-NEW Nov 25, 2022
@bantonsson bantonsson modified the milestones: 1.2.0, 1.2.0-NEW Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants