Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay generation of costly config elements #4302

Merged
merged 12 commits into from
Nov 24, 2022
Merged

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Nov 23, 2022

What Does This Do

  • Introduce lazy holders to delay computing the (random) runtime-id and hostname until they are needed
  • this avoids pulling in various types early, such as ThreadPoolExecutor, meaning fewer weak-context-stores
  • Further decoupling of instrumentation related config from the main config to help with native-image

Motivation

When we indirectly pull in types before installing the byte-buddy agent, in this case ThreadPoolExecutor, we lose the chance to add context fields to them. We then have to resort to weak-context-stores which are not as efficient.

@mcculls mcculls added tag: performance Performance related changes type: refactoring labels Nov 23, 2022
@mcculls mcculls merged commit 50a78b0 into master Nov 24, 2022
@mcculls mcculls deleted the mcculls/delay-costly-config branch November 24, 2022 10:15
@github-actions github-actions bot added this to the 1.2.0 milestone Nov 24, 2022
@bantonsson bantonsson modified the milestones: 1.2.0, 1.2.0-NEW, 1.1.2 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: performance Performance related changes type: refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants