Appsec: create top span for process executions #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataphract
force-pushed
the
glopes/appsec-proceses
branch
2 times, most recently
from
dd98672
to
f5881b0
Compare
smola
reviewed
Oct 3, 2022
...roovy/datadog/trace/instrumentation/java/lang/ProcessImplInstrumentationSpecification.groovy
Show resolved
Hide resolved
...java-lang/src/main/java8/datadog/trace/instrumentation/java/lang/ProcessImplStartAdvice.java
Outdated
Show resolved
Hide resolved
...java-lang/src/main/java8/datadog/trace/instrumentation/java/lang/ProcessImplStartAdvice.java
Outdated
Show resolved
Hide resolved
cataphract
force-pushed
the
glopes/appsec-proceses
branch
from
f5881b0
to
0694c11
Compare
smola
approved these changes
Oct 4, 2022
bantonsson
reviewed
Oct 6, 2022
There was a problem hiding this comment.
This looks good to me, and I think that the instrumentation doesn't need to be confined to AppSec. I'm not sure if it can be enabled by default until there is some sort of redaction implemented though.
Since this is instrumenting a class inside the bootstrap class loader, I think that the helpers need to be moved like they were for the shut down instrumentation #3913
cataphract
force-pushed
the
glopes/appsec-proceses
branch
3 times, most recently
from
d3410f2
to
9d457e2
Compare
smola
reviewed
Oct 31, 2022
dd-java-agent/appsec/src/main/java/com/datadog/appsec/AppSecSystem.java
Outdated
Show resolved
Hide resolved
cataphract
force-pushed
the
glopes/appsec-proceses
branch
from
9d457e2
to
43293fe
Compare
cataphract
force-pushed
the
glopes/appsec-proceses
branch
from
43293fe
to
08778b8
Compare
smola
reviewed
Nov 10, 2022
cataphract
force-pushed
the
glopes/appsec-proceses
branch
10 times, most recently
from
678ebe0
to
36f2456
Compare
cataphract
force-pushed
the
glopes/appsec-proceses
branch
from
36f2456
to
308f4fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds a span for process executions. See the doc "Shell Execution Integration" for the spec. Redactions are not implemented.