Make SafeRequestBuilderTest check that header values don't leak #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
added
tag: no release notes
PerfectSlayer
approved these changes
Sep 26, 2022
mcculls
approved these changes
Sep 26, 2022
bantonsson
force-pushed
the
ban/safe=request-builder-test
branch
from
069de95 to
2c8f817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds checks for the exception message content for the
SafeRequestBuilderto make sure that sensitive header values don't leak.Motivation
Show that the mitigations for header value leaking in OkHttp3 SNYK-JAVA-COMSQUAREUPOKHTTP3-2958044 added in #3682 is effective.
Additional Notes