Kafka Streams: remove span/scope from task #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When finishing the span, remove it to allow it to be GC'd and not linger. Don't think it's causing any problems... just more sanitary.
tylerbenson
added
the
tag: no release notes
(Sorting the spans by start time doesn't fix later invocations of `trace()`, so the indexes don't line up correctly with the prior assertions.)
bantonsson
approved these changes
Aug 20, 2021
dougqh
reviewed
Aug 20, 2021
...rc/main/java/datadog/trace/instrumentation/kafka_streams/KafkaStreamTaskInstrumentation.java
Show resolved
Hide resolved
mcculls
approved these changes
Aug 20, 2021
charliegracie
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When finishing the span, remove it to allow it to be GC'd and not linger. Don't think it's causing any problems... just more sanitary.
Also fix a flake in the test.