[Breaking change for dd-trace-api] Deprecate scope finishOnClose and continuation close #1424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: These deprecated methods will be removed in the following release.
The
finishOnClose
functionality will remain in the OpenTracing compatibility layer, but behavior may change if utilizing on continuations.Migrating usage can impact the way span duration is calculated. For example given the following code:
Historically, the Java Tracer prevented the top level span from finishing until the child work finished, resulting in a trace like this:
After this change, it will produce a trace more like this, which more accurately depicts the duration of the method execution.
Since trace duration is based on the parent/top level span, this change can impact the trace duration calculation.