Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: add interchangeable writer to logTraceWriter #939
ddtrace/tracer: add interchangeable writer to logTraceWriter #939
Changes from 12 commits
4197940
42555fe
1fb9558
cff5ac3
2a4e28c
486ffbf
cb236a0
e9478d1
315dda6
867992a
8e31e1c
90f4ac6
b5fb84a
0f2709b
52e9c53
d207894
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this func is only needed in tests right? If so, does it make sense to move it into a test file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered it, but since
var logWriter
is declared and used here, I thought the function for manipulating it should be co-located so the intention/usage is apparent for whoever next looks atvar logWriter
.Let me know if you feel strongly that it should be moved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's test code (unused elsewhere), so it belongs in a test. But likewise, if you feel strongly, leave it :)