Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/contrib: fix TestTelemetryEnabled flakiness on Windows #3051

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Dec 19, 2024

What does this PR do?

Allows other path separators to prevent flaking on Windows OS.

Motivation

Test was flaking in CI due to different results from Windows vs other OS's.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 19, 2024

Datadog Report

Branch report: hannahkm/fix-telemetry-enabled
Commit report: e3136dc
Test service: dd-trace-go

✅ 0 Failed, 4066 Passed, 64 Skipped, 2m 45.92s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2024-12-19 17:14:48

Comparing candidate commit 529bfdd in PR branch hannahkm/fix-telemetry-enabled with baseline commit cec8baa in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

@hannahkm hannahkm marked this pull request as ready for review December 19, 2024 16:51
@hannahkm hannahkm requested review from a team as code owners December 19, 2024 16:51
@hannahkm hannahkm merged commit a36a57f into v2-dev Dec 19, 2024
152 checks passed
@hannahkm hannahkm deleted the hannahkm/fix-telemetry-enabled branch December 19, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants