-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo: mandatory issue templates (AIDM-425) #3046
base: main
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5116 Passed, 70 Skipped, 2m 34.43s Total Time |
BenchmarksBenchmark execution time: 2024-12-20 00:56:32 Comparing candidate commit 3e3b7d9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
3aa516e
to
19234d0
Compare
- type: input | ||
attributes: | ||
label: Operating System | ||
description: "Provide your operating system and version (e.g. `uname -a`)" | ||
placeholder: Darwin Kernel Version 23.6.0 | ||
validations: | ||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it would make more sense to ask for the output of go env
instead of only asking for the operating system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agreed. OS only isn't very useful for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made this change
What does this PR do?
Motivation
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!