Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: mandatory issue templates (AIDM-425) #3046

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tlhunter
Copy link
Member

What does this PR do?

  • repurposes the freeform issue templates to versions with UI elements
  • makes issue templates mandatory
  • links to helpdesk pages

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@tlhunter tlhunter added enhancement quick change/addition that does not need full team approval docs no-changelog changelog/no-changelog labels Dec 18, 2024
@tlhunter tlhunter requested review from a team as code owners December 18, 2024 00:15
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 18, 2024

Datadog Report

Branch report: tlhunter/create-issue-standard
Commit report: 585488a
Test service: dd-trace-go

✅ 0 Failed, 5116 Passed, 70 Skipped, 2m 34.43s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2024

Benchmarks

Benchmark execution time: 2024-12-20 00:56:32

Comparing candidate commit 3e3b7d9 in PR branch tlhunter/create-issue-standard with baseline commit d15e61a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@tlhunter tlhunter force-pushed the tlhunter/create-issue-standard branch from 3aa516e to 19234d0 Compare December 18, 2024 22:50
Comment on lines 43 to 49
- type: input
attributes:
label: Operating System
description: "Provide your operating system and version (e.g. `uname -a`)"
placeholder: Darwin Kernel Version 23.6.0
validations:
required: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would make more sense to ask for the output of go env instead of only asking for the operating system

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agreed. OS only isn't very useful for us.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made this change

@tlhunter tlhunter enabled auto-merge (squash) December 19, 2024 22:00
@eliottness eliottness requested review from eliottness and removed request for eliottness December 20, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog docs enhancement quick change/addition that does not need full team approval no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants