go.mod: module go.opentelemetry.io/collector/pdata@latest found (v1.21.0), but does not contain package go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental

[eliottness]

What does this PR do?

This PR exist because of errors in the CI like this one

To sum things up, 1 OTel dependency has a breaking change and an other OTel dependency is breaking because of it. And on top of that, for some reason, go get -u upgrades only one of them and not the other which ends up breaking go mod tidy.

The dependency with the faulty go.mod should be github.com/DataDog/datadog-agent/pkg/trace.

To counter all of that, we should be able to simply transform the dependency breaking into a non-transitive dependency do take complete control over it and supersede the minimum version declared in the faulty go.mod

Reviewer's Checklist

• Changed code has unit tests for its functionality at or near 100% coverage.
• System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
• There is a benchmark for any new code, or changes to existing code.
• If this interacts with the agent in a new way, a system test has been added.
• Add an appropriate team label so this PR gets put in the right place for the release notes.
• Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
• For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

[datadog-datadog-prod-us1]

Datadog Report

Branch report: eliottness/fix-go-get-v1
Commit report: b19dd9f
Test service: dd-trace-go

✅ 0 Failed, 5112 Passed, 70 Skipped, 2m 54.23s Total Time

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-12-17 11:21:37

Comparing candidate commit 2a9aa50 in PR branch eliottness/fix-go-get-v1 with baseline commit 5a8a82c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

[darccio]

@RomainMuller I'd recommend to cherry-pick this into v1.71.0 release branch cc @eliottness

[rosti-il]

Hi. Could you release 1.70.2 with this fix as well?

[darccio]

@rosti-il We are close to release v1.71.0 but I leave the decision to this month's release manager @RomainMuller

PS: you can fix it locally by applying the same "blank import" pattern we did in our tracer.

[RomainMuller]

I confirm this will be rolled into v1.71.x