-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report datadog.tracer.abandoned_spans health metric #3032
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5121 Passed, 70 Skipped, 2m 54.52s Total Time |
BenchmarksBenchmark execution time: 2024-12-23 16:30:12 Comparing candidate commit 286ed77 in PR branch Found 3 performance improvements and 1 performance regressions! Performance is the same for 55 metrics, 0 unstable metrics. scenario:BenchmarkSetTagMetric-24
scenario:BenchmarkSetTagString-24
scenario:BenchmarkSetTagStringer-24
scenario:BenchmarkTracerAddSpans-24
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a non-blocking question
if v, ok := s.Meta[ext.Component]; ok { | ||
integration = v | ||
} else { | ||
integration = "manual" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the main concern is that leaving it blank might give the impression of being misconfigured/missing information. If we manually set it to manual here, it'll give a little more clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly what Hannah said.
From being on the troubleshooting side, an explicit value (e.g. "manual") is a good way to differentiate from an unset/missing value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then
What does this PR do?
Report the count of unfinished spans as a metric, along with tags about the span name and span integration.
This PR also makes the following small changes:
Motivation
Abandoned spans info is already available in tracer logs, but making the information visible as a metric that we can track alongside other data points in the Datadog platform will make debugging easier for customer and support.
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!