appsec: Service Extension callout #2965
Open
+396
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
e-n-0
force-pushed
the
flavien/service-extensions-part2
branch
from
a87535b to
0044a8f
Compare
e-n-0
force-pushed
the
flavien/service-extensions-part2
branch
2 times, most recently
from
6c165d2 to
0607577
Compare
BenchmarksBenchmark execution time: 2024-12-19 18:03:04 Comparing candidate commit e3cc085 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
e-n-0
force-pushed
the
flavien/service-extensions-part2
branch
from
0607577 to
867a55b
Compare
6 tasks
e-n-0
changed the title
e-n-0
force-pushed
the
flavien/service-extensions-part2
branch
2 times, most recently
from
34f396f to
7d3e562
Compare
e-n-0
force-pushed
the
flavien/service-extensions
branch
from
2eeb6b1 to
402f7d0
Compare
e-n-0
force-pushed
the
flavien/service-extensions-part2
branch
from
7d3e562 to
ca1de07
Compare
e-n-0
force-pushed
the
flavien/service-extensions-part2
branch
from
0614501 to
2b06ea5
Compare
eliottness
requested changes
Nov 7, 2024
eliottness
force-pushed
the
flavien/service-extensions
branch
from
1f2b791 to
9630788
Compare
eliottness
force-pushed
the
flavien/service-extensions
branch
2 times, most recently
from
0929de5 to
e3bb1e5
Compare
e-n-0
force-pushed
the
flavien/service-extensions
branch
from
c7063d8 to
b0844b8
Compare
e-n-0
force-pushed
the
flavien/service-extensions-part2
branch
12 times, most recently
from
8ee70e2 to
42d9365
Compare
e-n-0
force-pushed
the
flavien/service-extensions-part2
branch
from
42d9365 to
673ec27
Compare
rarguelloF
reviewed
Dec 18, 2024
contrib/envoyproxy/go-control-plane/cmd/serviceextensions/main.go
Outdated
Show resolved
Hide resolved
contrib/envoyproxy/go-control-plane/cmd/serviceextensions/main.go
Outdated
Show resolved
Hide resolved
rarguelloF
reviewed
Dec 19, 2024
contrib/envoyproxy/go-control-plane/cmd/serviceextensions/main.go
Outdated
Show resolved
Hide resolved
contrib/envoyproxy/go-control-plane/cmd/serviceextensions/main.go
Outdated
Show resolved
Hide resolved
contrib/envoyproxy/go-control-plane/cmd/serviceextensions/main.go
Outdated
Show resolved
Hide resolved
| }) | ||
|
|
||
| if err := g.Wait(); err != nil { | ||
| log.Error("service_extension: %v\n", err) |
There was a problem hiding this comment.
You might want to os.Exit(1) in this case to signal the process exit with an error.
However if you do this, please note any defer you might have won't run. If you want to use os.Exit and defer, the best approach would be to move the logic from lines 81-95 to a separate function func startService(cfg serviceExtensionConfig) error, and have these defer's in there.
There was a problem hiding this comment.
Thanks for the comment, I applied the changes in e3cc085 😄
(I also added a Flush to the logs before exiting.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the part 2 PR to support Envoy's External Processing. This part is creating a package to be used for the GCP Services Extensions product.
You can find all related document for this implementation in Confluence ASM - GCP Services Extensions.
You can find the part 1 of this PR.
What does this PR do?
This PR creates a new binary project that implements a gRPC server using the Envoy External Processor protocol of Envoy and an HTTP server for the health check. The gRPC server use the gRPC Interceptor (
StreamServerInterceptor) implemented from the part 1.Release
The PR includes a new GitHub action to publish new docker images to the repo at each new release.
These images are push under the name
ghcr.io/datadog/dd-trace-go/service-extensions-calloutand exists with the following tags:v1.69.1)You can find the package released in the GitHub repo registry.
Tests
System tests
System tests have been implemented on this PR. A new
external-processingscenario with the docker image given to customers and envoy infrastructure has been added in thegolangstage.APM and ASM test has been imported to be sure that all spans and tags are correctly set to validate the integrity of the created traces.
Macro Benchmarks
Benchmarks of the the whole extension is available on this benchmarking platform branch.
More information with dashboard can be found here.
Reviewer's Checklist
Unsure? Have a question? Request a review!