contrib/go-chi: Apply DD_TRACE_HTTP_SERVER_ERROR_STATUSES #2960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
isServerError
function from go-chi and go-chi.v5 integrations. In the case that the contribs have not been initialized with a custom error checker viaWithStatusError
, they will rely on the error checker from httptrace.This allows go-chi and go-chi.v5 integrations to be impacted by DD_TRACE_HTTP_SERVER_ERROR_STATUSES.
Motivation
Noticed the
Test_Config_HttpServerErrorStatuses_FeatureFlagCustom
system test was failing for go-chi (link)Reviewer's Checklist
Unsure? Have a question? Request a review!