fix and cleanup the Content-Length handling in transport

[paulcacheux]

What does this PR do?

This PR cleans up the Content-Length header in the request made to the agent. In the case of civisibility the request is made with a *bytes.Buffer and as indicated in the documentation the content length is computed automatically here (cf doc).

In the case of the default/regular trace transport, the Content-Length was set manually through the header. My investigation from the agent side is that we receive a fair amount of traces from dd-trace-go without Content-Length, so this PR moves the content length back to the actual request field, as suggested in the documentation.

Here is a playground example showing how setting the header manually is not working as expected https://go.dev/play/p/AGdBGGZ7IgY

Motivation

Reviewer's Checklist

• Changed code has unit tests for its functionality at or near 100% coverage.
• System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
• There is a benchmark for any new code, or changes to existing code.
• If this interacts with the agent in a new way, a system test has been added.
• Add an appropriate team label so this PR gets put in the right place for the release notes.
• Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-10-30 12:38:57

Comparing candidate commit be5f2ea in PR branch paulcacheux/content-length-cleanup with baseline commit fab2f13 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

[paulcacheux]

/merge

[dd-devflow]

❌ MergeQueue

You are not allowed to use the merge queue towards main. User is not part of the authorized users or teams.
The authorized teams are: apm-ecosystems, apm-go, asm-go, profiling-go.
The authorized users are: dbenamydd.

If you need support, contact us on Slack #devflow with those details!

[paulcacheux]

@darccio thanks for the review, please feel free to merge this (I don't have the rights)

[darccio]

@paulcacheux Sure, give me a moment.