Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[godfathering] contrib/dimfeld/httptreemux.v5: failing tests for path variable replacement #2938

Merged
merged 2 commits into from
Oct 22, 2024
Merged

[godfathering] contrib/dimfeld/httptreemux.v5: failing tests for path variable replacement #2938

merged 2 commits into from
Oct 22, 2024

Conversation

darccio
Copy link
Member

@darccio darccio commented Oct 22, 2024 •
edited
Loading

What does this PR do?

Replicates and closes #2881 #2812

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners October 22, 2024 08:09
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 22, 2024
@darccio darccio merged commit e104e1e into main Oct 22, 2024
146 of 147 checks passed
@darccio darccio deleted the dario.castane/godfathering-pr-2881 branch October 22, 2024 08:28
darccio added a commit that referenced this pull request Oct 23, 2024
@darccio @MNThomson
[godfathering] contrib/dimfeld/httptreemux.v5: failing tests for path…
e103210 
… variable replacement (#2938)

Co-authored-by: Max Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darccio @MNThomson