Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: support reading statsd port from tracer #2931

Merged
merged 17 commits into from
Nov 8, 2024

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Oct 16, 2024

What does this PR do?

  • Adds an internal ignore to the agent to be used during testing user set statsd ports
  • Adapts expected format of statsd port

Motivation

The issue was reported by #1802 . This PR follows up on the work on #1803 .

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2024

Benchmarks

Benchmark execution time: 2024-11-05 19:15:00

Comparing candidate commit 0eea826 in PR branch hannah/fix-statsd-port with baseline commit 2d679b9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@hannahkm hannahkm marked this pull request as ready for review November 1, 2024 18:27
@hannahkm hannahkm requested a review from a team as a code owner November 1, 2024 18:27
ddtrace/tracer/log_test.go Outdated Show resolved Hide resolved
ddtrace/tracer/option.go Show resolved Hide resolved
@darccio darccio merged commit 2320b43 into main Nov 8, 2024
149 of 150 checks passed
@darccio darccio deleted the hannah/fix-statsd-port branch November 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants