Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/appsec: fix derivatives serdes on simple types #2905

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

eliottness
Copy link
Contributor

What does this PR do?

This PR fixes fingerprinting derivatives received from the WAF that were serialized in json as string, hence adding another set of quotes to the values

Motivation

Support for Attacker Fingerprinting

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness requested a review from a team as a code owner October 2, 2024 14:55
@eliottness eliottness force-pushed the eliott.bouhana/fix-derivatives-serdes branch from 169d234 to 8759ab0 Compare October 2, 2024 15:18
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness merged commit ef90025 into main Oct 2, 2024
165 of 166 checks passed
@eliottness eliottness deleted the eliott.bouhana/fix-derivatives-serdes branch October 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants